From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 993CEC61DA4 for ; Thu, 9 Feb 2023 11:07:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0C5B36B0071; Thu, 9 Feb 2023 06:07:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 076EF6B0072; Thu, 9 Feb 2023 06:07:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EA7316B0074; Thu, 9 Feb 2023 06:07:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id DBB706B0071 for ; Thu, 9 Feb 2023 06:07:09 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 9C639160C4B for ; Thu, 9 Feb 2023 11:07:09 +0000 (UTC) X-FDA: 80447476578.09.D51B3C3 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf06.hostedemail.com (Postfix) with ESMTP id A70AE180014 for ; Thu, 9 Feb 2023 11:07:07 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675940827; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TRAvu4Z0OOIvgpDTIWMkfJW/Jms3PbcyBWP63Hd0cug=; b=5tBxm50T3DGx2mtWQ7Xi7Umoagar1cU0lqqOtRTczayKeQp190gJIAiWr9RI6Gk8pUnSYp UzsZQinnpJJwy4QqbrzjPhy1LqCAzoaaprUDoHaS/q3ZprMVWYSCKv7NTz3wdSg/O0lFOQ oB9IzcFdJoFvfsslXDqc5lVAJ+7to9g= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf06.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675940827; a=rsa-sha256; cv=none; b=rx9GMFRrerXq3xtIjiJvdBXWn2apIY5L1LYabnSJUSiosPt/3Y/gTLUBN3Kl4KAeCSs4Mc 4FXozv8v32JcPFxSaUEU9JYNNh0mX8HeAuiPRnsC6z7d2E93zw5vjyLzQ3eB2E3q0Mq7Yx knyiEzbmKpMSwdzaoXgDp1G0Hh41T2I= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.206]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PCDV60WmMz6J7kQ; Thu, 9 Feb 2023 19:02:38 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 9 Feb 2023 11:07:04 +0000 Date: Thu, 9 Feb 2023 11:07:04 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH 07/18] cxl/region: Move region-position validation to a helper Message-ID: <20230209110704.000072c6@Huawei.com> In-Reply-To: <63e475f2a5fd_36c729455@dwillia2-xfh.jf.intel.com.notmuch> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564538779.847146.8356062886811511706.stgit@dwillia2-xfh.jf.intel.com> <20230208123031.00006990@Huawei.com> <63e475f2a5fd_36c729455@dwillia2-xfh.jf.intel.com.notmuch> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500002.china.huawei.com (7.191.160.78) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A70AE180014 X-Stat-Signature: wqf9xp63w6d9ywrsb17q1bfu5hiwor76 X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675940827-116977 X-HE-Meta: U2FsdGVkX198EtkOS+1l3VBZ5pjDA76ufv6N7W29nYsEQ6OFMgDiZQ9H3aCzFnq3rkUs2xnuVhnGq5wjX/cVMpEOm9EtROdHdp5GY2jNukcFULTRPp5tfyPLT5xBAJbVNhdys8eiI0HynJ1XxVWJvXXbPyv535EggVccyXZHshnv6EPEp/dfXPE9p9nSWuJpeiNAiIs7pE73DxOuCQHunF6i4VXNm/HZnc0efo/oBePflbA/7WoPw7xKu05SBxjP/icQfXiFfrBjfTHr7zSOh96QaQU9BQOQQTVpZ5MwfmKS3V7cSYmxvcrew+ZhB92f+1RiNWMPyvMx+zmcUFGCzC+DkiiMnQnvreDmia4nDfjS2TV+gl8Mf/kkfPOMPRnQPAmvdvEUmx/RFcIoxYC1rH1lLhP00rcA6BrFeL6/gvFOrsq357yKvTqzJ7nSvcbZWPU49xtU7xvmx7qkaV6Rv+/T8abhtda0tRma9w1SFtBUEXzHTC3XnMXuCCtf+ipgWaSeXWWj9D1LCIrFtqXIK2Hrc4buYJSL+aMViiwBjIRLDYttM2OTkPgwDOH//s4QA7lM56SIlrQsAv9QaIa+Le+BeRFKiMKEb/hvbs6An8S9drVF0RGfXT+h/Ern6sMe2qxfvi9ZnJxLBDMF+maJmcHESP73b1l30fYaUx7hPGXx6atYMLxHnhnQ+TS15k4S2WZzkPUZmDwQJmODdwZHxte9LhX1pudISxd+7gX81ccwMtyeMaK19slZVA1w+eYoleJoi+zUMeq4hwe+wo6TTFrhlBcU8OVWRjbuk1PVdqghup7IwiuagjSluDnozg1NnW3lBGVPIuYk439TozcUXtN8gVZQRX8bnWFIuFcTRKjxfMx0LPBfUWKXf8vLD7Q8us/si+NfnWX242e70TCOfVyWsClGnVf+upZLdkwq23abitDJMI0AUs8WSpHxpbbpxss4WOZjZe6IRnEoZXV W2fDXt4l sIjvdiqPDGky0Gjt55N8e1eawCZcWQ7RX9q1F0es75lLq4Gxm3ZBs+d6jiHQwrL72qvT9npYqRAtpuwh3gSNhlxeaYNM+OGHRGFXUSAq5QvZpTDJQTmJjtKzTdMDcg3N6ZRuFpr8bExoSY4SzzOtCWiFEXFGKWb4ZuJ59Ty6meQlrrLLkxVMzq/PD4Q6XbLg4c7Rdtf3e/cF9FuvhYhzlqjB1fHWUtPr/eUxsonS/h1cFBxg63/3UQJ/rPg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000322, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Feb 2023 20:26:26 -0800 Dan Williams wrote: > Jonathan Cameron wrote: > [..] > > > @@ -1284,13 +1327,6 @@ static int cxl_region_attach(struct cxl_region *cxlr, > > > return -ENXIO; > > > } > > > > > > - if (cxlrd->calc_hb(cxlrd, pos) != dport) { > > > - dev_dbg(&cxlr->dev, "%s:%s invalid target position for %s\n", > > > - dev_name(&cxlmd->dev), dev_name(&cxled->cxld.dev), > > > - dev_name(&cxlrd->cxlsd.cxld.dev)); > > > - return -ENXIO; > > > - } > > > - > > > > In an ideal world, this would have been nice as two patches. > > One that reorders the various checks so that they are in the order > > after you have factored things out (easy to review for correctness) > > then one that factored it out. > > I played with this a bit and the only way I could see to make the diff > come out significantly nicer would be to use a forward declaration to > move the new helpers below cxl_region_attach(). Don't bother then! Unless you've already done it. In the ideal world diff would magically present everything in the most human readable form :) What are all these AI folk working on that we don't already have this! Jonathan