From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4C38CC636CC for ; Thu, 9 Feb 2023 02:44:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C02C36B0072; Wed, 8 Feb 2023 21:44:57 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id BB3AB6B0074; Wed, 8 Feb 2023 21:44:57 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A7BAE6B0075; Wed, 8 Feb 2023 21:44:57 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 995DC6B0072 for ; Wed, 8 Feb 2023 21:44:57 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 623F24049C for ; Thu, 9 Feb 2023 02:44:57 +0000 (UTC) X-FDA: 80446211034.17.C90C240 Received: from out-152.mta0.migadu.com (out-152.mta0.migadu.com [91.218.175.152]) by imf25.hostedemail.com (Postfix) with ESMTP id 8B31EA000B for ; Thu, 9 Feb 2023 02:44:55 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=YxT2MBU6; spf=pass (imf25.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.152 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675910695; a=rsa-sha256; cv=none; b=yVZcPZnDHBuXZ8rcykeQY9OkodLC9ca2es70Dlzd07lGE8hYQpPiefXvtVKK7EPIjLkM6K iAoqvW4Dq2LaAm3hsC6ruu+TpSNDgR7Gs1lZRkSiGZHRmAu1yFODM8RlOEpbL76WR5vhzE oeAwfEm33GzY6fPHdWl0E91TBkft3p0= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=YxT2MBU6; spf=pass (imf25.hostedemail.com: domain of yajun.deng@linux.dev designates 91.218.175.152 as permitted sender) smtp.mailfrom=yajun.deng@linux.dev; dmarc=pass (policy=none) header.from=linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675910695; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references:dkim-signature; bh=6j791U1wIUFSOI7G5OFn8eDWYHiEod5wKDWuChvQKYw=; b=rF8yXF3d13zkJrE6ONrPXFz3iQbIXILrrHN3uotBAmykXQuJPiXrbIfsy892DWcgZpLqmM v5qCMoGw4oJ0RPiFfpKkdK1NdmQ9PAhsLLulR+0kZmkrd4YWIC1fo0Hao7r4yqKoZqUMA5 dZNJfaK+G21hj9HhgTkYt9RUAfT650g= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675910693; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=6j791U1wIUFSOI7G5OFn8eDWYHiEod5wKDWuChvQKYw=; b=YxT2MBU6ERJfONrIkOap8zG+cxkJFGKQtMQMMqerZX2JyQAMZFxUDz8IrRZnONqOUFWPrS MGCYEkvg0+xid3z3ybjMcByY3Z4pmwpk5E3q5l0ZGTMS5VdXUPrZvwGrBSiF6r7xtE0D0B WGMhQb3Qe+2Aus6swE/JXS+/qAghOns= From: Yajun Deng To: akpm@linux-foundation.org Cc: ziy@nvidia.com, mgorman@techsingularity.net, david@redhat.com, vbabka@suse.cz, rppt@linux.ibm.com, osalvador@suse.de, rppt@kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Yajun Deng Subject: [PATCH] mm/page_alloc: optimize the loop in find_suitable_fallback() Date: Thu, 9 Feb 2023 10:44:35 +0800 Message-Id: <20230209024435.3392916-1-yajun.deng@linux.dev> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Queue-Id: 8B31EA000B X-Rspamd-Server: rspam01 X-Stat-Signature: jzgaoinyqmgf1p8fy9kp8q8jeb5r4tti X-HE-Tag: 1675910695-427335 X-HE-Meta: U2FsdGVkX1/jgXbv9ysZ3XDLrSzpK+vGalpn1a9J/t7IUqJOed1G8LhcMWm8PN7hW/Pmfr05dnv1JHizF+f2KS4wP8EIzf7Z+EcQMKNlTqYEmUNiFUmZiolxDV2QmCYgcmYBaUobK3S3DegDxs5JOXjHgriDQjWe5aLk5lCc5nepx2kOZnuSx3jZze+OzWgdA3Xp88I+mb/9oQfJT/3lr9kzO+qebZ52l0VyeW6Bo3eM7RpivBCjOK8Tw57IvaG5j5PByFeRr5SweWOOlCeDjt6FAvh1T4+aTbjB2/+MUBVSKZpH+QiNCEhQWgAACEXMjDmvVJWrorEc9BSddVWS51GRVOgB3WS8Dw2LUm5X3Ifm5aUjakuM/8V8xhc2Jyd4SD7f+F4kc6ecBzXTAwMhr7ElOlwBlbfO1XbPLU7R3a3H66NwKnzArLAw8JMAVt3cRjOKBTA5FsVfCgYULP1Uf4G7V+SLaHJtmcORHlwieYkQX6dWRAECFjT87AKAey9ee3GojMKXmhTiyS16jTKdsZfBdd9vToAcp0BRKVzNbUlRXzyAJTDf43xUKsxuM9N9JFhIQNlEPNUDQub8OEnGMnj6CUdXoNbkSL6VgVb3L70UdtI1IzfmqY7UHtLxUVLiKeek5qppVtkhv9uPOkzcCZczfHGzZSYQ9oyLHCMdxGb1dde6hQBR0F6hfnuTZZy8AQUI1ENlaHge/dzK3/VB98Mcysb228SX4uacO4QvC3zrZL2J8r2vsX7FhLCACPwPzQJ1HkBM5VtDhO8O25Mw4n8Yp3wpVD76d6/3tOPsGG2xpe+DwhUtipB5M3nZRw8cqJtqYHs+1XM3iuME1rhjJ2zbvCTChNQAPdndz5Tv95Iq13EiL9DnnVgOaaMVn/QYVCnuxCzx57qbus2Ax9WSWgaeDmEM1iDmu3e7lBQsVubvh9o7XbI6ic1W9CXH+/3iGBtQGJqPCDFNFkEjTkr /LJkAj0x 7NHJ2jgU8cabwmKorEisTuvtAJ7Ez8c7ps4RAa3BwmEebUbiD7YBDN3ryVVYhYwKcXQG7wau71wqheSL9TPVc4QTzsh1ZdIieOFFgJs+JwtaNXTzQLGbhYcXjjaNEFKkujO35 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000085, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There is no need to execute the next loop if it not return in the first loop. So add a break at the end of the loop. There are only three rows in fallbacks, so reduce the first index size from MIGRATE_TYPES to MIGRATE_PCPTYPES. Signed-off-by: Yajun Deng --- mm/page_alloc.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/mm/page_alloc.c b/mm/page_alloc.c index 1113483fa6c5..536e8d838fb5 100644 --- a/mm/page_alloc.c +++ b/mm/page_alloc.c @@ -2603,7 +2603,7 @@ struct page *__rmqueue_smallest(struct zone *zone, unsigned int order, * * The other migratetypes do not have fallbacks. */ -static int fallbacks[MIGRATE_TYPES][MIGRATE_PCPTYPES - 1] = { +static int fallbacks[MIGRATE_PCPTYPES][MIGRATE_PCPTYPES - 1] = { [MIGRATE_UNMOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_MOVABLE }, [MIGRATE_MOVABLE] = { MIGRATE_RECLAIMABLE, MIGRATE_UNMOVABLE }, [MIGRATE_RECLAIMABLE] = { MIGRATE_UNMOVABLE, MIGRATE_MOVABLE }, @@ -2861,7 +2861,7 @@ int find_suitable_fallback(struct free_area *area, unsigned int order, int i; int fallback_mt; - if (area->nr_free == 0) + if (area->nr_free == 0 || !migratetype_is_mergeable(migratetype)) return -1; *can_steal = false; @@ -2873,11 +2873,10 @@ int find_suitable_fallback(struct free_area *area, unsigned int order, if (can_steal_fallback(order, migratetype)) *can_steal = true; - if (!only_stealable) - return fallback_mt; - - if (*can_steal) + if (!only_stealable || *can_steal) return fallback_mt; + else + break; } return -1; -- 2.25.1