From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75988C05027 for ; Thu, 9 Feb 2023 02:33:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A10226B0071; Wed, 8 Feb 2023 21:33:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 99A1B6B0072; Wed, 8 Feb 2023 21:33:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 813976B0074; Wed, 8 Feb 2023 21:33:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6FDC46B0071 for ; Wed, 8 Feb 2023 21:33:52 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 3D2C8A07D8 for ; Thu, 9 Feb 2023 02:33:52 +0000 (UTC) X-FDA: 80446183104.16.2964269 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf16.hostedemail.com (Postfix) with ESMTP id 87D9A180009 for ; Thu, 9 Feb 2023 02:33:50 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of "SRS0=M4Zj=6F=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=M4Zj=6F=goodmis.org=rostedt@kernel.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675910030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DLtMGZF0v0Hn4ierY4ofrpO5WY4G4CjQOXLtOUO6Qws=; b=ZX9hytOhyisAlAWnTesbAyMFRQ00OPENeDPL2kUq42BA5LQlVtIJpLZsspM5mIy8XzVmhz 5+ENvpFMiHx/z1HgvXCk5rdwSljUnTTBNQd1FkuJyIibCADcN/6ENOWBjpSYX9HjOtMNRI BgzAB2a7DfnbnQEssMb5XefmT8QJg0U= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf16.hostedemail.com: domain of "SRS0=M4Zj=6F=goodmis.org=rostedt@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=M4Zj=6F=goodmis.org=rostedt@kernel.org" ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675910030; a=rsa-sha256; cv=none; b=QzdATtXsFFDZXpylFwZAq3VZtq8hFMoPCc3tXndKcwS4qnR92jruS1D30Hv3bfGCO5QWjJ TikMxUion0RcXIhWPrKj/OOiDKrOpSFDCEex5uHwhyFK1rwJ2wvqHXsEJ+zioCXPSzZkRG DDs4VSl8PvFfxW6DnULRvBzNV9SuSqE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5E96661838; Thu, 9 Feb 2023 02:33:49 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CDBC0C433EF; Thu, 9 Feb 2023 02:33:45 +0000 (UTC) Date: Wed, 8 Feb 2023 21:33:43 -0500 From: Steven Rostedt To: John Stultz Cc: Alexei Starovoitov , Yafang Shao , Andrew Morton , Network Development , bpf , "linux-perf-use." , Linux-Fsdevel , linux-mm , LKML , kernel test robot , kbuild test robot , Andrii Nakryiko , David Hildenbrand , Mathieu Desnoyers , Arnaldo Carvalho de Melo , Andrii Nakryiko , Michal Miroslaw , Peter Zijlstra , Matthew Wilcox , Al Viro , Kees Cook , Petr Mladek , Kajetan Puchalski , Lukasz Luba , Qais Yousef , Daniele Di Proietto , Linus Torvalds Subject: Re: [PATCH v2 7/7] tools/testing/selftests/bpf: replace open-coded 16 with TASK_COMM_LEN Message-ID: <20230208213343.40ee15a5@gandalf.local.home> In-Reply-To: <20230208212858.477cd05e@gandalf.local.home> References: <20211120112738.45980-1-laoar.shao@gmail.com> <20211120112738.45980-8-laoar.shao@gmail.com> <20230208212858.477cd05e@gandalf.local.home> X-Mailer: Claws Mail 3.17.8 (GTK+ 2.24.33; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 87D9A180009 X-Stat-Signature: t3enwr193fm9ao6k9mo8xbmhdocd8d6k X-HE-Tag: 1675910030-588904 X-HE-Meta: U2FsdGVkX18tPvVx3RJ528hwXsztcjQ6CbQerSoDChFWFeMCQ30AG9azOdAvUULamNHkISeTYCzfJZrDWhxNnoWQ5OYmsaklKQyzoanLk9KfVeFokHBwaDBclBXn+6YnnERars5ayhd1tJOxqPmtGxR4D2VKzZ05LT4X21Mn0P1qiRXhnhPI2+FDA9tIU3EuHZaf5y/FG7Sx+ChSyC9kc4v05EYYyVR5wFik1pBU3Li5tKS2PvrSs6wXR8kpqt6yhH/ul7IINpOATnHr1NWFMKSb9cdc8F1dPpIFUVDGS7gSqtsim4pr/XiwNvQ6DruWAi9TJ4F82pdXEjA7YFeZLGl02Rcwl9opgo0F8bctXg6SHetRbW5e9I11XhHhM8wOOb0Iyc2n7yhduRNeKbzwgLhHzmNb/h69kK8X4xtvoh0HrUUQdFzPj0fmiA0XlCHqATeVKvFkVToKlHgkyxx2oAks6CiNa/sHWOjeiBBZGigCYKq/Nz8PgzcV6oHy+44c7XxJppGGYZLr0e7Dx7AtSY0quaNVgPPuoK3qtlIZaVdqabrwrCv3pIb9SK++fMAK/H73bmpLe92T9yUYJ3CZ+Luzf26VXbdp3jxPpq98RQLF8gxyGZyczQyJHPGvJWlfVCvM6lVf8NoOSjzPMsyTPvOie1YlfUCPnp2cz5gXFOxHuX18GiHcaNFYD521vnobDbKrYFQhrPbcIvoV+3gACAGRLuyoD38CTS8pFX0qp1PBlv2CckvpCp4EWnCZapAimpubeyD85CMGbhIxu0Hcwtdr2HGteV6e0vPA+oUT1NcKoJC3PkvwrGUkNpTmaLQEMYaz4SiJdTU3QGPnynWXb8fzbRnHSPmSBYBqusz3H353T3oM/3nj5L5E5VLPK59AlQcVmXDHTNVc8bEgmzXydgAPFocL/UhmkrPiWETQeT8q8RUBDG8gQgsW40vh4qGUzrvCzBPaFluLqFSZL6S G6Fjez43 tyW6NSjLvq86UfIKa/t9FMxwdcu3xYYEF73iCxr0B/SmfnJsx1+eSN7GO9c1Ke05kIW78Wt4zq1txcwJ+3Gbes+mh748LXPGtWrqvs6S8MqJ6wnHPynEH60+PqhqteXjPdceruKKs99di5HlY7j5vsXMUSOEfqfywXbt4HT7GJ3q0/eiZhVqEaWtCpSoO5QMUpOygqCEKunvInL7FXJTESJUf9FcLQOZFHWqeZ7WofwJcm2/6mIyOYpd++hMci4CUNxNr/eiye4ZSFQlz9QoI85TWNXNM6bLqWGYBQqFABT+46h6WXEiSy073BSsG8l38+JMQT4TnqpO1Qcp7YBS//jQ98CX6oSWanWW/AAWgh8jwi6M5dmUvOPLtfQ8kFNeIBpl9KZs9/+3SOoRmBTw/br3IwbqK0bnniPTQVsgw1prQbiRFYF1M4PrceDDpEJbXjfzoJHW/lJ1+NHGlnQMSxMS5q9SWQbbsduufv3+lIpBc/jYT3Pu0ogN3tmxEAjw+Wh4F5BpA3Sgrz+so5aS5laJdmTXtXop9GlVL X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 8 Feb 2023 21:28:58 -0500 Steven Rostedt wrote: > And this breaks much more than android. It will break trace-cmd, rasdaemon > and perf (if it's not using BTF). This change very much "Breaks userspace!" > And requires a kernel workaround, not a user space one. OK, so it doesn't break perf, trace-cmd and rasdaemon, because the enum is only needed in the print_fmt part. It can handle it in the field portion. That is: system: sched name: sched_switch ID: 285 format: field:unsigned short common_type; offset:0; size:2; signed:0; field:unsigned char common_flags; offset:2; size:1; signed:0; field:unsigned char common_preempt_count; offset:3; size:1; signed:0; field:int common_pid; offset:4; size:4; signed:1; field:char prev_comm[TASK_COMM_LEN]; offset:8; size:16; signed:0; ^^^^^^^^^^^^^^ ^^ is ignored is used field:pid_t prev_pid; offset:24; size:4; signed:1; field:int prev_prio; offset:28; size:4; signed:1; field:long prev_state; offset:32; size:8; signed:1; field:char next_comm[TASK_COMM_LEN]; offset:40; size:16; signed:0; field:pid_t next_pid; offset:56; size:4; signed:1; field:int next_prio; offset:60; size:4; signed:1; print fmt: "prev_comm=%s prev_pid=%d prev_prio=%d prev_state=%s%s ==> next_comm=%s next_pid=%d next_prio=%d", REC->prev_comm, REC->prev_pid, REC->prev_prio, (REC->prev_state & ((((0x00000000 | 0x00000001 | 0x00000002 | 0x00000004 | 0x00000008 | 0x00000010 | 0x00000020 | 0x00000040) + 1) << 1) - 1)) ? __print_flags(REC->prev_state & ((((0x00000000 | 0x00000001 | 0x00000002 | 0x00000004 | 0x00000008 | 0x00000010 | 0x00000020 | 0x00000040) + 1) << 1) - 1), "|", { 0x00000001, "S" }, { 0x00000002, "D" }, { 0x00000004, "T" }, { 0x00000008, "t" }, { 0x00000010, "X" }, { 0x00000020, "Z" }, { 0x00000040, "P" }, { 0x00000080, "I" }) : "R", REC->prev_state & (((0x00000000 | 0x00000001 | 0x00000002 | 0x00000004 | 0x00000008 | 0x00000010 | 0x00000020 | 0x00000040) + 1) << 1) ? "+" : "", REC->next_comm, REC->next_pid, REC->next_prio ^^^^^^^ Is what requires the conversions. So I take that back. It only breaks perfetto, and that's because it writes its own parser and doesn't use libtraceevent. -- Steve