From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A6B0C636D3 for ; Wed, 8 Feb 2023 17:33:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D2DF86B0078; Wed, 8 Feb 2023 12:33:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CB6DD6B007B; Wed, 8 Feb 2023 12:33:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B58066B007D; Wed, 8 Feb 2023 12:33:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 9D7506B0078 for ; Wed, 8 Feb 2023 12:33:09 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 73560160FD1 for ; Wed, 8 Feb 2023 17:33:09 +0000 (UTC) X-FDA: 80444820498.04.81318A1 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf10.hostedemail.com (Postfix) with ESMTP id 7C7F8C001F for ; Wed, 8 Feb 2023 17:33:06 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675877587; a=rsa-sha256; cv=none; b=CruNXzui52d4yfjphJ8x8sI4J/NJrMdQEJXurCPudw2YUu6rt4Z2nNLicJ/NuXzQTKr0Uz cTt3g2wwAad9NY0kFf1hZnYvC7NSLnsq5R/ebMERumQ9THuNgtnQf0SPLtIsRT7esB/wmV PEXNYje/kg9yJgqtAekjns9JZFq/NPY= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675877587; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=a8O3yFRiB0D0KenXHe7Ma7aI7oJnR/mvQnx6UgWL1Ys=; b=cyuRSZ8lH3FBvLZ5cVxQ00J5sh9yzKgJGPEgHQE3NhoTrxkHfGrmTZSzpvYkoO3B6Hs7/t U95KhtYPqwr7qcMqeGa5/EHGZej2Ya8tCPY3GnadEWFF9bYyKXtrm4jSS9hCq6vkBY6EYu UwU9wmXEii8vJKFO2JhS2lVg5PjsLiA= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PBn5y3YWyz6J7Wr; Thu, 9 Feb 2023 01:28:38 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 8 Feb 2023 17:33:04 +0000 Date: Wed, 8 Feb 2023 17:33:03 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH 14/18] dax/hmem: Drop unnecessary dax_hmem_remove() Message-ID: <20230208173303.00007b2c@Huawei.com> In-Reply-To: <167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564542679.847146.17174404738816053065.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspam-User: X-Rspamd-Queue-Id: 7C7F8C001F X-Rspamd-Server: rspam01 X-Stat-Signature: g9tk9a7d9efiu3rryhzcejxeeqiu7nwr X-HE-Tag: 1675877586-658560 X-HE-Meta: U2FsdGVkX1/ynvENsu5tuKjho/o7+aoJiGpxn78ef3GUNxDwGYbbNV4K8NoqDEy6W46OlhGrSOgnT30+xly4MwTODok9hv4L2A5MuXhcRcozUwE50ezURprUPJ4XYyyMGp1LrjbeVPCrDGU1BuRLSkz6CENzlFyGBZwP5wymAFBapNOWl7jcwT+5TtnkC2FXjV8TnvYgsVbsu26Irp23mTtC+GNZaVwT4MahCE5F3d0n1yUcVDiuF+nx6iWFPflrtuTS8lo4c4rrSWMCKOsNwpv1t6QkAWCu9RfQLRmIzYTFL29DLPIWTy+mAQ3W+bi7Jwm1kCbzB+nMOUGuLjMfX8xKs5LRIbK2OWBnQm0fSSmGEilDqOVknSNOX8T9YJIAHeNwF7aPfdgi54cN+LMOW9627G6z+TybdpdMQyaOEdyF9hGmjH4nE/kneXfzG6Cj8bxYDqZ7+BecFwfV6/PTFTZiGpfFC6xE9r/AsR3Iv2jdyQ8mkRZ5Bgdm0cHBNZFBhAF3JBZUVW0jSEv+LefgIzDF07ItZgyzoVqHO9YpTlWY2s84bIRyrNzY17wmELq9+d8AbTg9l2oiFBCnIt4uruPGGT6/w/ljuU18Yg95KHB7t+0w6dqPrz1ZtSSVHrYYT9AYM474Jxr4MwfqifuaSCG0OjOzCBkRWTFcEIM0SBheFSzP2WPeFg6FnbTdIPb0gykaPD7ZsmBnchml9jLPyVAMEEMtEeqomGIvFCL1c/0QQ6jNKtbnUrlfoWkPGfAFCm2pSYyXHc7u7PyklcJw2BPCh4mPTHr740zXNqCYuT7NWpjRpgTknFoOxkl+2UjrPlsKIptizd3FDW0kUm6D38Zkgts2Ys7XVAL25PLqdYPxV3rg45QDEKWzdj1YOSu0mz37N1UrAfdyFmIc4+P62WnUYeGpxBh9e2k/mBuL8016vs5yQvGywzsf3lBflAO1UmPTTYTVuN3GndlQyoI 0yUQi+WE LHyulqyaDCF2oxPiIbtKv5ESJQbN4RJmd0CPwJ+ZHA67tQSFH3rFGrdw6lqSBi9Uo4zlm/T9UuOFtHYKVwUNUI1zn8lx4rfXPP2qJs6UAbPCYC0FNdvHkThZxjios0j04TvHHMGiuEXLUKWjbNCKk6ailwpVRAPf3SMu6sjeGHDE+YZsGgj3qKlPJfZN/M4+k8Nk2ucv7LsHCXGIEfldhoFWLBQhg94U8AjX+sD8zT0ZxwuXoEDaVE38G3RL1tbTnOpCFiqbwcfwup0RyZOPDtPjaAalrjBnN278+pTmgYgIo5peGniwl1RIH6w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 05 Feb 2023 17:03:46 -0800 Dan Williams wrote: > Empty driver remove callbacks can just be elided. > > Signed-off-by: Dan Williams Reviewed-by: Jonathan Cameron > --- > drivers/dax/hmem/hmem.c | 7 ------- > 1 file changed, 7 deletions(-) > > diff --git a/drivers/dax/hmem/hmem.c b/drivers/dax/hmem/hmem.c > index 1bf040dbc834..c7351e0dc8ff 100644 > --- a/drivers/dax/hmem/hmem.c > +++ b/drivers/dax/hmem/hmem.c > @@ -44,15 +44,8 @@ static int dax_hmem_probe(struct platform_device *pdev) > return 0; > } > > -static int dax_hmem_remove(struct platform_device *pdev) > -{ > - /* devm handles teardown */ > - return 0; > -} > - > static struct platform_driver dax_hmem_driver = { > .probe = dax_hmem_probe, > - .remove = dax_hmem_remove, > .driver = { > .name = "hmem", > }, >