From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6DB4C636CC for ; Wed, 8 Feb 2023 17:32:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4552B6B0078; Wed, 8 Feb 2023 12:32:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 410286B007B; Wed, 8 Feb 2023 12:32:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2F4616B007D; Wed, 8 Feb 2023 12:32:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 219586B0078 for ; Wed, 8 Feb 2023 12:32:00 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id D662440FC0 for ; Wed, 8 Feb 2023 17:31:59 +0000 (UTC) X-FDA: 80444817558.08.D0F86F4 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf27.hostedemail.com (Postfix) with ESMTP id BDB8240002 for ; Wed, 8 Feb 2023 17:31:56 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675877517; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=o9J2lVGBWijb/0CmHdQI+wPB8gyArOzKtakqsOszkB4=; b=PKPbsh1y5hhQAsHmHgi+njX/AiF+wNb60CLO58TpkljgzYRSwIcij1pglAz9DB7AaoWJLS xU8DzpIh0jd55qz1iMbI30OECNMmftcM/7EmWZ4FAGqd0FMpkObfDx4kfSeXVR8T11YmDh d7Yw3gGCn20THdopcekIJ0VwROtzwc8= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf27.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675877517; a=rsa-sha256; cv=none; b=2XZgW67A3kW8igpi/bFKkfQao/6nGuh4AExbA4BKG0eFxP8yfjED0EZqsAxNfC1iw13+3g g3zS8DZZ052lx5mU/0VlaXvxm+22jFATeMmW4aXTjd/OZ+ezWMzT4sOV5bkeoj62NOPcAO yvOJ7pk+9ytefNA0TPm+tUZJiBYP9tk= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.226]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PBn4z2DpZz6J64s; Thu, 9 Feb 2023 01:27:47 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 8 Feb 2023 17:31:50 +0000 Date: Wed, 8 Feb 2023 17:31:49 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH 12/18] tools/testing/cxl: Define a fixed volatile configuration to parse Message-ID: <20230208173149.000043a2@Huawei.com> In-Reply-To: <167564541523.847146.12199636368812381475.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564541523.847146.12199636368812381475.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500006.china.huawei.com (7.191.161.198) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: BDB8240002 X-Stat-Signature: hihx5wbypqp18pgtqxqrizzkzw1fo5mw X-Rspam-User: X-Rspamd-Server: rspam08 X-HE-Tag: 1675877516-251945 X-HE-Meta: U2FsdGVkX1/tIZK1b45UZdt56HecFz5/EtBmlrqX1vR+d+VitfB9IrZ1aiQSTpGRsN5HaWrBMtury5SBKtqPtaJv59JHGeI4YIsG9a0f5kPZTkfniQK5xPCxQilWZZZ1GVuYCW71+PvUxAiF8z6GZ3YiY39Kk9YAZ8tdzw9iO50MF2LAlJrAl0PJPevTnJaSHqVfWNfeTUCbHjZGEGTytqxO1rml82ZTBuhhDqBhklugFspWaopy+GLDbBfpywnrDp+wZZHOTHw5Wy+x9mjIhGfboKBoy+tXWngQKd689mnzPhnyFahEj6P5MIYT8iNhAd3JCL7ocpd4xYSoN+sVcBDuSY4DjbEMy5xLHKaJlhMXeTgqWPSwAup6arTv7xDBJhMWPm5De/zDH8KSXIPLWgfOK7sT4JjI62fIoSJIR9KlfCs2I3cbtgrH9ejZ718vK0f84ZPuqo5R8K9ZnGkq7SoItt8DvAhoop9MaNSJx3kGNnbKistUkYch8N2d/wesESdAUijzP2ZEF+5QCdJiN4iR1MotwxQbCTa14D+x21rf0YPebnr4XOiO5Dmk/AtS1zfqLUj+OEuVdxMxqdkzZghRPgNVD50EPvnkA566TgOusDyS0iVSBbu3CiOomVhRkKv3UMKH8e5D4kldDittKjsjH5G2vNGgweQarfiyeU4/N407k/ImLn+LkuMtTVaE5S4ylcHGcKXozuguwXCB8nEYf3dEpN7FIQDWI0R0MNSdS7sW+36Va5H1P+V8pgvLqH8KMqZ7k2CJvRyRfEUnfpgM0nov6R1TJwJd+SGo2PnVkndjNV4Dc3JU7mf1j20LZ4Og5J0AFJ5K0dpeygHde8ClLuvo6RvsIVOkwxcONnoeNyYH1ll4AHSUGQXk2GAz08Vya4b07eJQcenZtBg9rQH1LZ7K59AUBZOAWF/Mr/tvVc2osHLIzQDF/TPFet4VvzM0d9QKogcBUGH2AwD lnyE3l4I /pSDJ2TTTB9bwr+OPoma2IzKo4vVaBCc39mi6uoEjSIHlxOQsbpz/KC525bOkca4J56bBZGIGw4whIb6IFIs2E+aff7Wp/YARkzFpt0TgdqDSl/JUIKVrSF0Tr+ILA3V4V5Uvo8sCWie4j9Pm32z8C54D431WxYdoR7lWuwRuxGYD1qmj/rSMxH3lgIdbwqA91NYdFm34NGZRaK87mOZKz72m2aTpr9LJEqipFrrXZ5Ei/E1Rqxlxxjtv6Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 05 Feb 2023 17:03:35 -0800 Dan Williams wrote: > Take two endpoints attached to the first switch on the first host-bridge > in the cxl_test topology and define a pre-initialized region. This is a > x2 interleave underneath a x1 CXL Window. > > $ modprobe cxl_test > $ # cxl list -Ru > { > "region":"region3", > "resource":"0xf010000000", > "size":"512.00 MiB (536.87 MB)", > "interleave_ways":2, > "interleave_granularity":4096, > "decode_state":"commit" > } > > Signed-off-by: Dan Williams > --- > drivers/cxl/core/core.h | 3 - > drivers/cxl/core/hdm.c | 3 + > drivers/cxl/core/port.c | 4 + > drivers/cxl/cxl.h | 4 + > drivers/cxl/cxlmem.h | 3 + > tools/testing/cxl/test/cxl.c | 146 +++++++++++++++++++++++++++++++++++++++--- > 6 files changed, 148 insertions(+), 15 deletions(-) > > diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c > index 8130430ffbcf..8d0895cbae93 100644 > --- a/drivers/cxl/core/port.c > +++ b/drivers/cxl/core/port.c > @@ -458,6 +458,7 @@ bool is_switch_decoder(struct device *dev) > { > return is_root_decoder(dev) || dev->type == &cxl_decoder_switch_type; > } > +EXPORT_SYMBOL_NS_GPL(is_switch_decoder, CXL); > > struct cxl_decoder *to_cxl_decoder(struct device *dev) > { > @@ -485,6 +486,7 @@ struct cxl_switch_decoder *to_cxl_switch_decoder(struct device *dev) > return NULL; > return container_of(dev, struct cxl_switch_decoder, cxld.dev); > } > +EXPORT_SYMBOL_NS_GPL(to_cxl_switch_decoder, CXL); > > static void cxl_ep_release(struct cxl_ep *ep) > { > @@ -528,7 +530,7 @@ static const struct device_type cxl_port_type = { > > bool is_cxl_port(struct device *dev) > { > - return dev->type == &cxl_port_type; > + return dev && dev->type == &cxl_port_type; Adding that protection just for mocking seems a bit nasty. Could you push the sanity check out to the caller or am I missing something? Perhaps worth calling out the reason we'd call this on a NULL dev with a comment or similar. > } > EXPORT_SYMBOL_NS_GPL(is_cxl_port, CXL); > > diff --git a/drivers/cxl/cxl.h b/drivers/cxl/cxl.h > index 9b3765c5c81a..4c6ee6c96f23 100644 > --- a/drivers/cxl/cxl.h > +++ b/drivers/cxl/cxl.h > @@ -452,6 +452,7 @@ struct cxl_region_params { > * struct cxl_region - CXL region > * @dev: This region's device > * @id: This region's id. Id is globally unique across all regions > + * @fixed: At least one decoder in this region was locked down at init > * @mode: Endpoint decoder allocation / access mode > * @type: Endpoint decoder target type > * @cxl_nvb: nvdimm bridge for coordinating @cxlr_pmem setup / shutdown > @@ -462,6 +463,7 @@ struct cxl_region_params { > struct cxl_region { > struct device dev; > int id; > + bool fixed; I was wondering why a mocking patch was changing the region state structure... It isn't - this isn't used that I can find. > enum cxl_decoder_mode mode; > enum cxl_decoder_type type; > struct cxl_nvdimm_bridge *cxl_nvb;