From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id AC2E2C636CC for ; Wed, 8 Feb 2023 12:36:24 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 24F106B0073; Wed, 8 Feb 2023 07:36:24 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1D7416B0074; Wed, 8 Feb 2023 07:36:24 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0785F6B0075; Wed, 8 Feb 2023 07:36:24 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EADCE6B0073 for ; Wed, 8 Feb 2023 07:36:23 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id A50F4160130 for ; Wed, 8 Feb 2023 12:36:23 +0000 (UTC) X-FDA: 80444072646.27.9CC7B00 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf23.hostedemail.com (Postfix) with ESMTP id A935E140008 for ; Wed, 8 Feb 2023 12:36:21 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675859781; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/RA45rv04amez17IBB8GMWFSgkfpFO3dmM1e5m7elBg=; b=I6ppbnczCuBWaYqtqWnIiopHYrGVuoAXk7k3oOm2prnKxiNZ4FNoAOWs+T7cy0cNiy47uc Z95A2YFUiPfswR2vOBNoWDhnbgk4v1NrbP3mLtaRssI8vYsqyopHqe2d2N+ZnYflSPIzlQ WJ4Lu9ZbCaKcLYArZjxIwt/zJbu5IdE= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=none; dmarc=pass (policy=quarantine) header.from=huawei.com; spf=pass (imf23.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675859781; a=rsa-sha256; cv=none; b=efwQtf4fvqe6BKloLZZWvGYa/1T9ECvZ/en1/pCR5fprnZCd2APkBm4Nb8ppcwofhW/8jq YiGyEUrUSnamqk2pDI7EKK8mtPSgeQtzf8bPK5204IWUJAAUZPo6BO081qs10c+Clkaoyz zVPGLxDmKxDpn2xO1HwbphRLx2KwzoU= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PBfWY5FbPz6J7Ln; Wed, 8 Feb 2023 20:31:53 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 8 Feb 2023 12:36:19 +0000 Date: Wed, 8 Feb 2023 12:36:18 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH 09/18] cxl/region: Enable CONFIG_CXL_REGION to be toggled Message-ID: <20230208123618.00007460@Huawei.com> In-Reply-To: <167564539875.847146.16213498614174558767.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564539875.847146.16213498614174558767.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500001.china.huawei.com (7.191.163.213) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Rspamd-Queue-Id: A935E140008 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: hryndrm3bsz8o9yrowyuqdjgogectjgy X-HE-Tag: 1675859781-925851 X-HE-Meta: U2FsdGVkX1+ppyUDnhKQmbPuLWdQyzCylqbrpgbJgpjmomDqbWxFCY0eMe3RIAqyRDA58qB33aBUHok3N+Iuaf1StsJo9f9Zfp1aQzIy0Y/0c8Vz4I3pR2U6X0YCVGka/WYa2RDkl0dq/yFCP1J9cOhspfdxeTNcOoDAN4s11kVLbB1Od/Ftec7nKPPJipt1kTQDnfMgwfiwrckmFyWgyDbzFxSZni6dpG5Z7TWWGK7VEMBaAJDYXIHNb8PKQazL+gduXfnuskLZktgkmachomb+WH6WLCkx4NuXqoqp43kVk8kMkpRLJZD4DUWFju2SQ4nrWAsFXjpCESXBc1cc6YDnTgpVOVPfpJVoieHjEOOI6MTRi7Xx3H5Nj4X5ZuxUUUma2raq3DcnuRoaYVt541YJBCp1bwcO4+8nNtiTcNrl4lgfV2QNUJKNvQT3jaM+xJUj8Jt/Y+Q6d/ZbZTXaMAmZtkbtF/Qq+TvFGYC4IOnbadPF5jyhBSp3IVCNwArly4Yz+Kwra8ZTIok9LH0eFdLkBAKlIeydWeyKOrh/U0Lflp0xj03vNXhKd4tajN/gYe7rYHBPKGQ1vEymkQojp4jwo4er3UN6WuCr9nou4gMsQtktVWF/3YMtPiSrEaZstf9tprJ7NtTCosuZtTc+59UMsXjukSUo5aoC972IzYd6tFv30CsGqR3bpgmYxEocUSGWH2axpzvZZutQ01UgYPV3xsHuPtLyJnSUlfkAnMSyWd1/3wBjqzMkU8jxD91T7s9atycOrMQxPi5c2QbycMZf7PUsCLAqiXVKnCbBwEW7n9jCzKqewE0wWuYiIrlvkFXFtEih4RKrxoMgylu6V2tcA1fMVXLoSAQsPSYXvVmqfY93iEUguaN3bKC10KJjP9s1LwULSGNAbzntfMRA9pGhu8czUN8z7NTunVn2rvXcRMEs6HY/dmgpTBX03QQmYBlJQaLFfObjbpAA93U q9TnzUnB 5BiNmL7C0ewRcriixdAOyBwAtthQWw4cE+HD+XmVJ9kMlDsOOWTWmlPbprr4hpA4rQYBeHuEIK1jl9VnLbM34fu6klbC4++PoQRVC5wA6xoL5fdixSL01BEMoIjlVW6xsnSX9zyu8W+aQJTedFvawbgX1bqROfkNPSKTLthGkYMZM2qxUQFBddNj95jZRPmun+9vqm4JHMyRZDY6pIjbQ0b7TBS2+523V7gZA3+4vuDVvDH6SmGXuqs37iU5ZXsvRCCZvt4h/oBNG+FFtbQ766/yzHUkf+TeG2jndRcsERmFIW4e91kTfubC5rw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 05 Feb 2023 17:03:18 -0800 Dan Williams wrote: > Add help text and a label so the CXL_REGION config option can be > toggled. This is mainly to enable compile testing without region > support. Hmm. Possibly pull the reasoning up here for why this might want to be configurable at all. I'm not sure I fully follow your reasoning as enumerating existing regions 'should' be harmless gathering of information, not something that could do any damage - so who would turn this off? Reviewed-by: Jonathan Cameron > > Signed-off-by: Dan Williams > --- > drivers/cxl/Kconfig | 12 +++++++++++- > 1 file changed, 11 insertions(+), 1 deletion(-) > > diff --git a/drivers/cxl/Kconfig b/drivers/cxl/Kconfig > index 0ac53c422c31..163c094e67ae 100644 > --- a/drivers/cxl/Kconfig > +++ b/drivers/cxl/Kconfig > @@ -104,12 +104,22 @@ config CXL_SUSPEND > depends on SUSPEND && CXL_MEM > > config CXL_REGION > - bool > + bool "CXL: Region Support" > default CXL_BUS > # For MAX_PHYSMEM_BITS > depends on SPARSEMEM > select MEMREGION > select GET_FREE_REGION > + help > + Enable the CXL core to enumerate and provision CXL regions. A CXL > + region is defined by one or more CXL expanders that decode a given > + system-physical address range. For CXL regions established by > + platform-firmware this option enables memory error handling to > + identify the devices participating in a given interleaved memory > + range. Otherwise, platform-firmware managed CXL is enabled by being > + placed in the system address map and does not need a driver. > + > + If unsure say 'y' > > config CXL_REGION_INVALIDATION_TEST > bool "CXL: Region Cache Management Bypass (TEST)" > >