From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57E52C636CC for ; Wed, 8 Feb 2023 12:32:27 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CFF176B0073; Wed, 8 Feb 2023 07:32:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id CAF956B0074; Wed, 8 Feb 2023 07:32:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B9E256B0075; Wed, 8 Feb 2023 07:32:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A967F6B0073 for ; Wed, 8 Feb 2023 07:32:26 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 6E5D6AB357 for ; Wed, 8 Feb 2023 12:32:26 +0000 (UTC) X-FDA: 80444062692.28.6F36C09 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf08.hostedemail.com (Postfix) with ESMTP id 613B0160004 for ; Wed, 8 Feb 2023 12:32:24 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675859544; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=PNCUaJYmKUAORj+VISCsCnX64YumD27QvDppenu/L/A=; b=RNGAdl7rkquwl4pms2N1Ka/sKjIy6IscX+L0DIngf1nVqCXhPH4cxCgOwhlEtHuvGHWAXo 1nC+nBvqkP9LTeGQuQxv7Cqx+YvpLB2qX/Yup3BdvWHDCFItgDBOLPL3rgGx8FWrU94azx nbtx2iDPXVVbyoqFUgh0sYoAspm0uxc= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=none; spf=pass (imf08.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675859544; a=rsa-sha256; cv=none; b=Hs4hlzy5/LS+YZVbMOgkiAtie7y+eFmiIrcDCn9+lg3ptCeY2YuSGAs3xv3VwXex6Q5PT9 hVX6yPA4J3dke3q7yHi9VPH0Zekx/0J+QBrSmJfM8mfAIUqX9JGNnlSJj4/lJQyTmCs2fZ +wvMhpPz3q1smvuhNYJBidBY2N4GJMk= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.207]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4PBfRR3RSvz67y6K; Wed, 8 Feb 2023 20:28:19 +0800 (CST) Received: from localhost (10.202.227.76) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Wed, 8 Feb 2023 12:32:22 +0000 Date: Wed, 8 Feb 2023 12:32:21 +0000 From: Jonathan Cameron To: Dan Williams CC: , Kees Cook , , , Subject: Re: [PATCH 08/18] kernel/range: Uplevel the cxl subsystem's range_contains() helper Message-ID: <20230208123221.0000516c@Huawei.com> In-Reply-To: <167564539327.847146.788601375229324484.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564539327.847146.788601375229324484.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.202.227.76] X-ClientProxiedBy: lhrpeml500004.china.huawei.com (7.191.163.9) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Stat-Signature: pkt4sagkbygno5nmiz7k6qg6hechu6iy X-Rspam-User: X-Rspamd-Queue-Id: 613B0160004 X-Rspamd-Server: rspam06 X-HE-Tag: 1675859544-5559 X-HE-Meta: U2FsdGVkX18h9JNpVVFnC25mGbjSJpx49sZkAnGVOnYyRq2b/XiR1C0Erk9lU4Gmn6JkFIH62ANKu6Y5iRm7QJ5NwDOiptk5IaYwhCHTaVOdusJEtnldmxqgQjuEZ0UjoPjTPgNSlRVaV/6e0QGCBoM3+Kz9uA9IX/Cf12k4q6k0SnTjJSm7f8L1TNQIJ7mbeiH5d21DAYQroVRJSFofI5Ys9o+iMR45Rba+aL0tieULasjPYOfzcDMjDF5E7fSjUdsIEAXt6YeXFIg85O8KyR9ROFM+jJUge0d5cgd/Uw6eCO6X6HHuAQ/H2GAZk/NUUr4fuTde6ew7L9o1tr7vv+1uf7sr0y1/4kscHLYIMJhrABYnAhvWS8SvjtDywBzcTxtqrwxawQO2/WFIHJAbMDrSECm0E4GCWJ0ta5KjDI7rX2AP2qUicj+/bzpQpyctO9NaAyLE1UJDvJY9n9nPnntK6/tsKGMjxrRH84CeH2MH475vSarjkAWIFmqaoONL/s1jlUHlSJaTN4sLj37/M3k3HM6YSdnTKkrmko0GcPgxZ9IVN5HuCIc8na9nPNA0XDuIKaThioAIH+rrWrtycYqhrcHpHN+CyptqqvNjAQSy/9QgajYKLnYDwtlyGiOi/Y9c4ny5Gp0Z65Dvj8O6zzSlDxzsl0TlPYQkSARRFqSUbgREZdgcyq1qcs9+Qwq4C7KLf0b4+pSQu/ju1RM0jAq/eUQBEZj8i2W3O/NMoo/TdYZLtiHiM+8amz43VprZVdK0FVxlga9H2RLwNMAN42qvXSc0osMX2ciVLq/WYK2SpXbc1GAec09F9kCUNj9VHzShnjO4vliLUE+plofC1c/oqI/ufVy7qn/Ju2BRWbOcl9oOqiBEdMfK7dInB62oYbtZwgVEICBA3X4ZML9x6b5hkCSKy/V2LmOyvTZm+BdEqBhufQzgAMQgwr2BoTiwAV/eMK1C537rowBogRF nvSBB5RF 3PmIgccprywOVqBgz0IuLJx61cr5bQR7dOylgiDzIUghda20aOhC0PwUvvzatHkeae1XPkfPVS3C7Lq0N52zJljEHqI5pNSkKBZ+G7tv5ldukz11Ak/6MnCQst+2p49fkfxxEFkmUvcyB4cs2zPdu2ySKEPVe/We3l1gC/scfu9eMiXoyMdG46KeKNKSMn4Y0Aiuv2V5iZoNNcRrCO/av7p+OcIC0VoKyt7eMeDWAB9R3tL83RqGpF7tDfMB0MwNfGtViYrZvQJmjsF/Yyxv035SL/IHspNdjzULuQZHSLfzXxbxQ9CtpWW2Ugu/d2LabnNq5OPBNDR1+BY/RmPmAbliU9OSjZCvabsBnN1I3+DPR/205JM9neqlIvQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 05 Feb 2023 17:03:13 -0800 Dan Williams wrote: > In support of the CXL subsystem's use of 'struct range' to track decode > address ranges, add a common range_contains() implementation with > identical semantics as resource_contains(); > > The existing 'range_contains()' in lib/stackinit_kunit.c is namespaced > with a 'stackinit_' prefix. > > Cc: Kees Cook > Signed-off-by: Dan Williams Seems reasonable. Reviewed-by: Jonathan Cameron > --- > drivers/cxl/core/pci.c | 5 ----- > include/linux/range.h | 5 +++++ > lib/stackinit_kunit.c | 6 +++--- > 3 files changed, 8 insertions(+), 8 deletions(-) > > diff --git a/drivers/cxl/core/pci.c b/drivers/cxl/core/pci.c > index 1d1492440287..9ed2120dbf8a 100644 > --- a/drivers/cxl/core/pci.c > +++ b/drivers/cxl/core/pci.c > @@ -214,11 +214,6 @@ static int devm_cxl_enable_mem(struct device *host, struct cxl_dev_state *cxlds) > return devm_add_action_or_reset(host, clear_mem_enable, cxlds); > } > > -static bool range_contains(struct range *r1, struct range *r2) > -{ > - return r1->start <= r2->start && r1->end >= r2->end; > -} > - > /* require dvsec ranges to be covered by a locked platform window */ > static int dvsec_range_allowed(struct device *dev, void *arg) > { > diff --git a/include/linux/range.h b/include/linux/range.h > index 274681cc3154..7efb6a9b069b 100644 > --- a/include/linux/range.h > +++ b/include/linux/range.h > @@ -13,6 +13,11 @@ static inline u64 range_len(const struct range *range) > return range->end - range->start + 1; > } > > +static inline bool range_contains(struct range *r1, struct range *r2) > +{ > + return r1->start <= r2->start && r1->end >= r2->end; > +} > + > int add_range(struct range *range, int az, int nr_range, > u64 start, u64 end); > > diff --git a/lib/stackinit_kunit.c b/lib/stackinit_kunit.c > index 4591d6cf5e01..05947a2feb93 100644 > --- a/lib/stackinit_kunit.c > +++ b/lib/stackinit_kunit.c > @@ -31,8 +31,8 @@ static volatile u8 forced_mask = 0xff; > static void *fill_start, *target_start; > static size_t fill_size, target_size; > > -static bool range_contains(char *haystack_start, size_t haystack_size, > - char *needle_start, size_t needle_size) > +static bool stackinit_range_contains(char *haystack_start, size_t haystack_size, > + char *needle_start, size_t needle_size) > { > if (needle_start >= haystack_start && > needle_start + needle_size <= haystack_start + haystack_size) > @@ -175,7 +175,7 @@ static noinline void test_ ## name (struct kunit *test) \ > \ > /* Validate that compiler lined up fill and target. */ \ > KUNIT_ASSERT_TRUE_MSG(test, \ > - range_contains(fill_start, fill_size, \ > + stackinit_range_contains(fill_start, fill_size, \ > target_start, target_size), \ > "stack fill missed target!? " \ > "(fill %zu wide, target offset by %d)\n", \ >