From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8332FC636CC for ; Wed, 8 Feb 2023 08:39:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 856176B0071; Wed, 8 Feb 2023 03:38:59 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 805E36B0072; Wed, 8 Feb 2023 03:38:59 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6CEA56B0073; Wed, 8 Feb 2023 03:38:59 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 5BD8E6B0071 for ; Wed, 8 Feb 2023 03:38:59 -0500 (EST) Received: from smtpin28.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 0AD70120D5B for ; Wed, 8 Feb 2023 08:38:59 +0000 (UTC) X-FDA: 80443474398.28.5C29F8C Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by imf17.hostedemail.com (Postfix) with ESMTP id CE27640014 for ; Wed, 8 Feb 2023 08:38:55 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="c9RjlUO/"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=PBruLdRW; spf=pass (imf17.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675845535; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Cp7jqh5hHbo9wb0Q0a89sIw2vEoYBd810R/yRio0ylg=; b=JAVN+oxQc650dVWlsAlhdvFYiA6QJd4wMGMu9FTw2yc4FjwmBXu+wyd9CvERjAt6DFofyL iL6itDLUCqwHFiDvSkOdsVqjq8cg/cWdB4nDI8BnVHFINPwEEm7JX0o1ZuFD/ek6gwGupH riul5bKTwQoGdU2BmF/MbnMXU/tDbYg= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b="c9RjlUO/"; dkim=pass header.d=messagingengine.com header.s=fm1 header.b=PBruLdRW; spf=pass (imf17.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.28 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675845535; a=rsa-sha256; cv=none; b=EMgfBZHekd8h6ddDNgW8wscsiWWhdDgqcbHoPsYaPUOdsDNeUJDiZwMlnaROV4Rk/+T0+f +ap0/IbNrJcFkKuA9EYN/ZGbPUWvM+QDO3n8M98ZZQDQw1O0GiHdCFlVQSCw5If67OOgfZ H9yTfvbbpWUWL3yhJbj8JZ/f4XWQnfA= Received: from compute6.internal (compute6.nyi.internal [10.202.2.47]) by mailout.nyi.internal (Postfix) with ESMTP id A97705C0107; Wed, 8 Feb 2023 03:38:53 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute6.internal (MEProxy); Wed, 08 Feb 2023 03:38:53 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1675845533; x=1675931933; bh=Cp 7jqh5hHbo9wb0Q0a89sIw2vEoYBd810R/yRio0ylg=; b=c9RjlUO/82BbTsK8+P cgV4Wfyt9nrKO6AFrQXec6KXZjmebFFJ0B3XsxgEQ8m4Ks8WP6W6SSJcElmSdqPz 76kH3VA1iR8znTPRgGPGmg/aYIMVuyLn9cnnj6+19Dkh+uriH4192KDgEH3i9b6G 6JKFYxTZKq8bqumo9erPXort4Gwl3d7vfJIMa8ejUeXM5EyuCRrEkx5YapJ1ROUR v5xIrOcMPj6FBR22ssbCt7sgbR2Viw/47UHQde8QAROwoGmFfyB30ryvH6LTrGVC cNqpKx90tUsbqJ7dKJ3QY3tt76rQURmXL6evTGG12gfFZ7AII1FRkbZgCuDYEOog v99Q== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm1; t=1675845533; x=1675931933; bh=Cp7jqh5hHbo9wb0Q0a89sIw2vEoY Bd810R/yRio0ylg=; b=PBruLdRWcFccTtRyACRdPbMTWVlux0Rud/VxlneYDyKB QCjYTE3J6Z+CyMXvUakh6zUpD8QrHlVMSJMzoKUjBoFNjFzZ+nOhOyJHSY/yL0ZN MJ+cgNpzUDIgSXltRcQ4mmvaxZ0MGa+OWUgENg9wzVy9Ss7/0JRerGh0WLTfUyJy QqrIIRLNK63w/73Pstrp7jEVutDowr/nrOaS/ZF/paKiiAzkVbmeiggDeWJrTagD M0Rx8vJPU7Rr79XEtdE9i7BnPTDL6J8gTl1BRs4T6cNyYwu81tzjDxxiuTQSf/5K LyRg6laxedwY4L/8eoHpRbqklrtYcqRKtgSb5Gze8w== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegledguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpeffhffvvefukfhfgggtuggjsehttddttddttddvnecuhfhrohhmpedfmfhi rhhilhhlucetrdcuufhhuhhtvghmohhvfdcuoehkihhrihhllhesshhhuhhtvghmohhvrd hnrghmvgeqnecuggftrfgrthhtvghrnhephfeigefhtdefhedtfedthefghedutddvueeh tedttdehjeeukeejgeeuiedvkedtnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrg hmpehmrghilhhfrhhomhepkhhirhhilhhlsehshhhuthgvmhhovhdrnhgrmhgv X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 8 Feb 2023 03:38:53 -0500 (EST) Received: by box.shutemov.name (Postfix, from userid 1000) id 0914D109D51; Wed, 8 Feb 2023 11:38:49 +0300 (+03) Date: Wed, 8 Feb 2023 11:38:48 +0300 From: "Kirill A. Shutemov" To: "Matthew Wilcox (Oracle)" Cc: Yin Fengwei , linux-mm@kvack.org, david@redhat.com, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [PATCH v5 2/5] mm: Add generic set_ptes() Message-ID: <20230208083848.craqlaft2xtmchwf@box.shutemov.name> References: <20230207194937.122543-1-willy@infradead.org> <20230207194937.122543-3-willy@infradead.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230207194937.122543-3-willy@infradead.org> X-Rspam-User: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CE27640014 X-Stat-Signature: c6kyggyfx1dwdpbh1fkhg71gq5yubfdr X-HE-Tag: 1675845535-818866 X-HE-Meta: U2FsdGVkX18/2NqmV70ZD3rtFwiztPzSz3RGvVKbpXdQs5Bi+b6SJjckHZ0KF8R4duIZD6G1yh030n6OTa0sUbeAl17CGZMb+9Py33eNG442yiYixeQ5+muOtJOE2IVBQHIjQSW8SJBr9B3DiDKjKeBrCNTIKv/14PaNUKMFquzLhotu+ljSjt/iiAgxCOyMkGPBXue4NlIU80u7Fx4Bvqe43S4eb1+q7qjls+kG9btlU5O5Vx+6wWODp75FWM2wgfQG4uZQ/P4G6aEKB1zJQtusN9+3lSDErlZMzcOFU5n/1IgNxvs5/c3LMtR+oZYyyQCzchwEGtVVZZrCyDp/IZDyzWQlZOfmchYNfk9HVUFzfb+caYAtc/Usxg/E6jdq7u2mrWIi7/rTz8ND9ciJgncPtZQ4q4JLoaLPTIEHMaTm6QGxid/O/f2puBs9QBxXaWRjbomlnHW/UFzNfs8iqwc/P2IsSA+vvZ1KlknTr+s536VyQEhnEB538Hjx3t7Qa82RC03N6vX9/rwuTDT9UYW+IZIOX+wXmYQ3psxWlSzNKeYAHs313m4vTEpRLHefJM6kdIJ8a/6bQ/W/fIMFqKcLhP0aW/2WlBqD87TXFOX0DmP9ruZ/pbOr7gZMTdI34aVHwRVBZFtkfYmSrIkkWENvsAgxzBDGpYfeVDfhRJlSY0maYpndnqu1LBJAKwPHLYB3p8n1HcOw3vHtsXl8L/YHKqOxdIUFFtFt6gWAuJgOyOBBoJDiRxitYjG7iao7x/RO+7aO7xi/TYVHzSnpHPFOT6iEReCYI4XD4eH3GuWb7V43GFKERXUJnJAO/xrltEYk+79eWHH0UeqJtrSv2nN0TErZFkjvCvUiE6OHgpQGsVgRSLqDByWpgDWVgbRNc/XisuZC4qaqZ1gVaYmM5sYRlrcl7wFnqMZvY4G7AUznEISaeilvNkAEaJkyhjj1VLPtyxyrHksZR9qdwOf vLRUQlvi 9RxtyYQU3bRnA5tJj90mwXfE8g7xThRkn156TXMDBxxkLHJKLy8um3N546QGwD/KV0fs8txo40MdW3QSzUCbkzE4SyLD8RyGkk5fOani6+YpFi4dvAwST1jaR0CpErDzMboGMhsz3HhVjUBePZalkO5/Q+7nPf8LVdQeNTkAa4WAxpNLkQxJnCCyczHp05s3G/LEasVN+YV0e8vYx6R/FtTHUQyMMGligfZEO3a75S017x1dRBILVFmhA+JfPABQkeSycDRVZy7IVL9uOgnTmzXoebNlkIGKuKQzquDTIHZekiuQD++vq9ZxXgpldF+Nh8otfZ0iLzcRs8eItoWA4eKYZSYQQk99YuutQ/cEOLyHFyYHHFJsDqFtylY2ldzqiTOzAm1ZQ4zJsvYrSwlMF0zvLiFWZ2J6Px1Kc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, Feb 07, 2023 at 07:49:32PM +0000, Matthew Wilcox (Oracle) wrote: > This set_ptes should work for most architectures. Those that need to > set a special bit in their PTEs or have their PFNs located at a different > offset from PAGE_SHIFT will need to override it. > > Signed-off-by: Matthew Wilcox (Oracle) > --- > include/linux/pgtable.h | 27 +++++++++++++++++++++++++++ > 1 file changed, 27 insertions(+) > > diff --git a/include/linux/pgtable.h b/include/linux/pgtable.h > index c63cd44777ec..e1804d23e7c4 100644 > --- a/include/linux/pgtable.h > +++ b/include/linux/pgtable.h > @@ -1439,6 +1439,33 @@ static inline int pmd_protnone(pmd_t pmd) > > #endif /* CONFIG_MMU */ > > +#ifndef set_ptes > +/** > + * set_ptes - Map consecutive pages to a contiguous range of addresses. > + * @mm: Address space to map the pages into. > + * @addr: Address to map the first page at. > + * @ptep: Page table pointer for the first entry. > + * @pte: Page table entry for the first page. > + * @nr: Number of pages to map. > + * > + * Context: The caller holds the page table lock. The PTEs all lie > + * within a single PMD (and VMA, and folio). > + */ > +static inline void set_ptes(struct mm_struct *mm, unsigned long addr, > + pte_t *ptep, pte_t pte, unsigned int nr) > +{ > + for (;;) { > + set_pte_at(mm, addr, ptep, pte); > + if (--nr == 0) > + break; Maybe do { ... } while (--nr); instead of the for()? > + ptep++; > + addr += PAGE_SIZE; > + /* This works for x86. Check how PTEs are encoded */ > + pte = __pte(pte_val(pte) + PAGE_SIZE); Looks like it deserves own helper. Something like pte = pte_next(pte); > + } > +} > +#endif > + > #ifdef CONFIG_HAVE_ARCH_HUGE_VMAP > > #ifndef __PAGETABLE_P4D_FOLDED > -- > 2.35.1 > > -- Kiryl Shutsemau / Kirill A. Shutemov