From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4BBBC636CD for ; Tue, 7 Feb 2023 22:38:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 314BB6B0092; Tue, 7 Feb 2023 17:38:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 275A06B0093; Tue, 7 Feb 2023 17:38:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1186C6B0095; Tue, 7 Feb 2023 17:38:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id F29CC6B0092 for ; Tue, 7 Feb 2023 17:38:47 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B8F6DC04FB for ; Tue, 7 Feb 2023 22:38:47 +0000 (UTC) X-FDA: 80441961894.10.46CDC0B Received: from out-232.mta0.migadu.com (out-232.mta0.migadu.com [91.218.175.232]) by imf09.hostedemail.com (Postfix) with ESMTP id E9C0A140008 for ; Tue, 7 Feb 2023 22:38:45 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vcbhtsKT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.232 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675809526; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vwuRw1o2exT5ngAZcWIKwa411GMUiDhgomSfWzZ0N9w=; b=dqO3a9Lu3t0EV9xtesKzUzKa0sEyLWNLwbT5eqHOtQHPcu6fF/s+UWqkuUc4vntkiiOsGh MELt4JBn9fD6RTP3gwlKAkHdtmAOHYogVZFI0fqsMR+WaCSNCeeaVBknLFSAPw7h0uWfqn 5vqyDaIQGOQAk6IYBJbxuG/d05Za3oA= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux.dev header.s=key1 header.b=vcbhtsKT; dmarc=pass (policy=none) header.from=linux.dev; spf=pass (imf09.hostedemail.com: domain of naoya.horiguchi@linux.dev designates 91.218.175.232 as permitted sender) smtp.mailfrom=naoya.horiguchi@linux.dev ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675809526; a=rsa-sha256; cv=none; b=EdVfRxy9LQ6l5qZhzAYegysbi/Xpq1vqoLZG7S8oI2iP7ubTjGH4eZmNVrYaPlZsBn2ZzY nXisVCwNV0IGLLMUjUHn7CkRq59BN4a7aY5QncvC9sadrUO4tT+Ydv8R+vBYu2am/GKqOm ZDYjHE5yoEdfKvanSS3uEIk6Gx0j/1c= Date: Wed, 8 Feb 2023 07:38:35 +0900 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1675809524; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=vwuRw1o2exT5ngAZcWIKwa411GMUiDhgomSfWzZ0N9w=; b=vcbhtsKTlCb8oofvqjxO4zBOt903cmfLMqyGuFOoV4/ZuEa/KfTb8zJgdn0u+gEozLEEW4 Yihp5XMCgUcQUFOvMQXCrip9RR9ArJ/xxv7+5daX0Tk3x/orzIvMAGozbI8JXBlm9F2fDZ Edhag0P5MR8g9M3ntViXe0GkZwDHTQE= X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. From: Naoya Horiguchi To: Kefeng Wang Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com, linux-mm@kvack.org, linmiaohe@huawei.com, tony.luck@intel.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v4] mm: hwposion: support recovery from ksm_might_need_to_copy() Message-ID: <20230207223835.GA1039769@u2004> References: <20230201074433.96641-1-wangkefeng.wang@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20230201074433.96641-1-wangkefeng.wang@huawei.com> X-Migadu-Flow: FLOW_OUT X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: E9C0A140008 X-Stat-Signature: xenrf9hwu6dnx7iqkjcop4ppfrwt6jxb X-HE-Tag: 1675809525-370361 X-HE-Meta: U2FsdGVkX19mQ/pbPTYJ3nTxoTNKWxlMfeVytxz0ZD256ajy0jAlSRhlm/hRK3i8pD59pRYNUL3/qMKNYXoVRk9CLXg4a/IEHnW1S3pKaRkBDRpDmujaTLz1dI9j2XGw0YyaGCKl9Juq+rNuuLS/kfuzUiojRdSFNRlkWpgA3ew3LQJowEAZwJnTIqKiiKZe2FtwcIuw0Nus4kgSAmYOPXzJHzbJ+NmOsrOwqT5kXhjMz0LzXSz1IYO3zFHlo6DGbqzZ9WoMwI0Sn0keo5JjCHJGnK+6+1TR+c0XFM83ificioW55SsBUGyJ2oRbBRgmgOEOVUcHSqDrpi4Q6y1gp7O265DJfc/jMdts0l7UCIl2Nvz8Hv0h3bFHMojRpl+PAqhjJ8wQZzoafFgbaC8mBPsru+dsSTP3MW3ySrkocUPyIunTrpzrGh+Xojk1W4aD8Zq5cHywFOS0YlC/rHG5FLujE9S5SvST66Sp5g9b7omeeyql0lCCoo3dD7CUWRiC2QDD1yr3+V7Yu6voLtopvLC0fqH/1NqVOEytykXOl/3iZVrSMiYouih8xbJPwW5T/s2l/UgJ/rjlN5gms01FxJijbMxYbC0XDNOPFOaNvCR+Xm8kta9X8bKDBVhHDL1x5R2kqZAh5iZgbz3eB67w4FxSDVBMwYLXuasjROE9kSsAL7tydplZayfpsUlvtpuFVtVCMc9i5UoNJStUhwhpUfO89nJa4F/tL842DVFE6YsP4kG7mVdEj8obFAGz9nlF3R+y5cAW2LfF+svEcfAao/rnJhBL+Q7LjNy5ZB/lWu2bcLnl+RtBhxfZcH64O6mJtRf0OQLQt0kxV1NT2q+mNukoB465uGFt8BiG5hfaCvA6isVkYmWzfxJmlMqMhX/4Em+IEaENGqS9t0vLNC6B7HLjj0DbBpVY3L/jXreB5qaDdRpUceDFYcaU/HBLjjCtRVJHJYZ01IjSRuJUI8I JWulj6MA xn8loPbza9whX9h+O4mALQLOiDK0x7iKyZ96+aKl3s+rIGHKhpGXigEm3oZrWDMqfkru7S9MHmETvqxs54dsadxZE3yQLf81poQ+rKRnQu4jOOdOV6BA81IDcruv61QX/TtSO/eYJ5nJLfVtsAnerWiy3f/MRi68sK0SBw8VHlAOHND7IuRYD63n0QQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Feb 01, 2023 at 03:44:33PM +0800, Kefeng Wang wrote: > When the kernel copy a page from ksm_might_need_to_copy(), but runs > into an uncorrectable error, it will crash since poisoned page is > consumed by kernel, this is similar to the issue recently fixed by > Copy-on-write poison recovery. > > When an error is detected during the page copy, return VM_FAULT_HWPOISON > in do_swap_page(), and install a hwpoison entry in unuse_pte() when > swapoff, which help us to avoid system crash. Note, memory failure on > a KSM page will be skipped, but still call memory_failure_queue() to > be consistent with general memory failure process, and we could support > KSM page recovery in the feature. > > Signed-off-by: Kefeng Wang Looks good to me, thank you. Reviewed-by: Naoya Horiguchi