From: Naoya Horiguchi <naoya.horiguchi@linux.dev>
To: Kefeng Wang <wangkefeng.wang@huawei.com>
Cc: akpm@linux-foundation.org, naoya.horiguchi@nec.com,
linux-mm@kvack.org, linmiaohe@huawei.com, tony.luck@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4] mm: hwposion: support recovery from ksm_might_need_to_copy()
Date: Wed, 8 Feb 2023 07:38:35 +0900 [thread overview]
Message-ID: <20230207223835.GA1039769@u2004> (raw)
In-Reply-To: <20230201074433.96641-1-wangkefeng.wang@huawei.com>
On Wed, Feb 01, 2023 at 03:44:33PM +0800, Kefeng Wang wrote:
> When the kernel copy a page from ksm_might_need_to_copy(), but runs
> into an uncorrectable error, it will crash since poisoned page is
> consumed by kernel, this is similar to the issue recently fixed by
> Copy-on-write poison recovery.
>
> When an error is detected during the page copy, return VM_FAULT_HWPOISON
> in do_swap_page(), and install a hwpoison entry in unuse_pte() when
> swapoff, which help us to avoid system crash. Note, memory failure on
> a KSM page will be skipped, but still call memory_failure_queue() to
> be consistent with general memory failure process, and we could support
> KSM page recovery in the feature.
>
> Signed-off-by: Kefeng Wang <wangkefeng.wang@huawei.com>
Looks good to me, thank you.
Reviewed-by: Naoya Horiguchi <naoya.horiguchi@nec.com>
prev parent reply other threads:[~2023-02-07 22:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-01 7:44 Kefeng Wang
2023-02-04 1:46 ` Andrew Morton
2023-02-07 22:38 ` Naoya Horiguchi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230207223835.GA1039769@u2004 \
--to=naoya.horiguchi@linux.dev \
--cc=akpm@linux-foundation.org \
--cc=linmiaohe@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=naoya.horiguchi@nec.com \
--cc=tony.luck@intel.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox