From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30DE8C636CC for ; Tue, 7 Feb 2023 12:22:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B71D76B00BD; Tue, 7 Feb 2023 07:22:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B21E96B00BF; Tue, 7 Feb 2023 07:22:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A10B56B00C0; Tue, 7 Feb 2023 07:22:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 8F5A46B00BD for ; Tue, 7 Feb 2023 07:22:15 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 614601601CE for ; Tue, 7 Feb 2023 12:22:15 +0000 (UTC) X-FDA: 80440408230.09.8559CDD Received: from mail3-164.sinamail.sina.com.cn (mail3-164.sinamail.sina.com.cn [202.108.3.164]) by imf01.hostedemail.com (Postfix) with ESMTP id 86A774001A for ; Tue, 7 Feb 2023 12:22:09 +0000 (UTC) Authentication-Results: imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.164 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675772533; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=mVk1JwMmvwi1GxgG0hECc0KA5TQIfB2e72h/MA4aCIQ=; b=pEcbLP0ZRn76J2zViBKHqh1l/Pf+QWafNZH6nclHo/rxw0v8Hm3wPvxft1kIKzJs0t3Xot 2C9g4YrB6mS5ELVNtNo9YKQ90Tdp3oI99eQ6rS5gQRcS+J7zPhDsjv3fBYJx6tP98kFjxe pqMu7PiMNQYkzngIAYX7culFM/M9AVU= ARC-Authentication-Results: i=1; imf01.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf01.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.164 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675772533; a=rsa-sha256; cv=none; b=WXGhWsP4qTs0I1JZdvFK70R5AOYf1qu/amJdNos9K0LlQ/iTvdx0P6cW2BQ7KMtvi0VLDT na3wktRvhCfQvdiRZ3Mz4ZSa8RYi3zGntfJLrKLgb/dxJteF72nNwP/LxwOA2XuTNcmUnD PXHAarmKdTRTivKjGb0okzH9W1WUoYc= Received: from unknown (HELO localhost.localdomain)([114.249.61.130]) by sina.com (172.16.97.35) with ESMTP id 63E24181000092B7; Tue, 7 Feb 2023 20:18:11 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 98019415073429 From: Hillf Danton To: syzbot Cc: David Howells , akpm@linux-foundation.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] WARNING in is_valid_gup_args Date: Tue, 7 Feb 2023 20:21:53 +0800 Message-Id: <20230207122153.1514-1-hdanton@sina.com> In-Reply-To: <0000000000004b0d5205f41631be@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 86A774001A X-Stat-Signature: 9eh5ids3334ppw8hyghsu3usdhs7998p X-HE-Tag: 1675772529-546081 X-HE-Meta: U2FsdGVkX1+kCaZ9LnlORHohCQ31iRQfEAJunPMXPz1MiY0hJSL4odyB4frCqfpvd0KeNjLcmdum6k1plEefk2+v9hlr9JCK9xeoCS6N6Pa7tfvP4T79bKHd+pV8gmw/3l+IRB545c+RsyZOcCF3UQQjn9x3Cx/Zp61HANAhFPUD+naL2/Qle69T3pK2BvISPUcHbrL0P6/3MbK666kv/WTjsqhmom8+gzT7hu4DASmA5xSaF/BgE6zZHYVWpUZc5TZaUZG21fhhEzTLRSGEoyYDUlttZeCLb4HHQVau7GbxDmeYeqckcVyZmtGyAKn7RXlifpAn7HmyeZvhWDEAzXI5EfKP0JGcI7Ek3wj3oYRXQgr++mIu3FGpl5IcBDuAhVvqBCpkVNo3dYhTz9rAgLaBXJZyrDXTIEyIdE1GbEGzNxiJMGxlyBpjDApOf3WhIk2+ngvwJe24FQEqJ0m6D2C4axG4iLfdKiGkm30jFGyF9BryNdip73n7X2fTw6RsLUqK+HzYyaztyRUnhguHADHJ7LTeKQtpv+YUKBgBm0ikfRZVB0SnwiaNbt/ZM/5xb7p0mJLjqudKLg9SwSefvR6auHLGNwL5kwSCWOE74iGuCpsZx0AsdyzXH6f83il4iXj+QfB3NLfIESCw9yQpg0PRnalp1yubSWFrWtJgqokhq2ZVvmkBz7wWg1Jc0uYvUjZ7eapCP8DmoT/J4FkXHvTKTfOiheydPMi9enGyBRDj+1EnVkkcf9HDsPOLmbVsiTmFDaflqI+cxSl08qdIjza+oNcDzYwO059VQkWkPzt0Q/TGsKOwng/SHn03/hWNjpgCHF++jN38PshvbTAKkK9woMVKbhCc/i5FcIKd1QVukjuXUHPwPRxRfNgcw6aM2ltUvk3JfRC0SgKxQeQDeehUt23Um5RFFPS5l+uM7/ZNVHwTLCfAicL2hSRTaynaPxoXt+X3Oz/R/qDnOaD p/vn976F Ag/l4E64wxBvgwzNiOlF5/z97b6A7U7S5xSyHu4BgVTAZ/Hav63jRZRVw6Rbt41rR8WGUzbR1NjbJVkDN7cJj0+JrhrJQ66oCoTLVdNBp33doRvgLT2QLCxltGK8ZGo+6SXTptik0BKPBppQwPdTL0lmGsBkWL6i8DQHX0ERgKb++1X6Hwq73jtLjT0uIpiHP7RB4FEs4BYta/3CvBxlP3gtMiS5Ov2Kk9dHETWS8s8nfa/wmxzr1Xk14NI6MBK3sw/6L+8tGqnz7idNFUhfuWeb1JOVDs2qgyy/CXYsfCtnq32b7h+DqNmwNfP95eVGbsMPUvdSSnP+M+18etzvx+8Cz2UTBDtcOc0hmzULPYVVs9KowZo2JRFF7p807tU5Tgdfv+uOgtDmBHJ39H3JdmrDd8Mm9aovJkCjwpHV5Wn71jdYR5mvsBd4kkSDVVtk+eRDSwi3efmVQGZnDgbuW9wcsr/Twa+y/0DvUt4ARPqXZ5NtfAMKEgppzrPJjlAe4G2qEQjlKLhG6e1CT3KU7ex9MphM8AF3pEO7Zx/QOnirVifLTO64VQaTu0qW4vAomkBdcKuPkqgcra7xsuSdJayiNhNSr8K+RcUfaxEACvQ5gjoxQn/MNXFMAAHLT0xoCqDkdXWufgNT92BHUWO4XwgMc7HobHbIHqwmxpJhUUh0Ml68= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mate: Mon, 06 Feb 2023 22:23:56 -0800 > Hello, > > syzbot found the following issue on: > > HEAD commit: 49a8133221c7 Add linux-next specific files for 20230207 > git tree: linux-next > console output: https://syzkaller.appspot.com/x/log.txt?x=15016013480000 > kernel config: https://syzkaller.appspot.com/x/.config?x=3691b32dd4410e01 > dashboard link: https://syzkaller.appspot.com/bug?extid=1f0c9407f4d20f7488b9 > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/6277c699d71e/disk-49a81332.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/cbef27c2f238/vmlinux-49a81332.xz > kernel image: https://storage.googleapis.com/syzbot-assets/7c0c68d93ac8/bzImage-49a81332.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+1f0c9407f4d20f7488b9@syzkaller.appspotmail.com > > ------------[ cut here ]------------ > WARNING: CPU: 1 PID: 11452 at mm/gup.c:2121 is_valid_gup_args+0x1d8/0x230 mm/gup.c:2121 > Modules linked in: > CPU: 1 PID: 11452 Comm: syz-executor.0 Not tainted 6.2.0-rc7-next-20230207-syzkaller #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023 > RIP: 0010:is_valid_gup_args+0x1d8/0x230 mm/gup.c:2121 > Code: c7 ff 48 83 3c 24 00 0f 85 7a ff ff ff e8 10 3a c7 ff 0f 0b 45 31 e4 eb cd e8 04 3a c7 ff 0f 0b 45 31 e4 eb c1 e8 f8 39 c7 ff <0f> 0b 45 31 e4 eb b5 e8 ec 39 c7 ff 0f 0b 45 31 e4 eb a9 e8 e0 39 > RSP: 0018:ffffc900091f72c0 EFLAGS: 00010212 > RAX: 000000000000165e RBX: 0000000000040000 RCX: ffffc90003dc1000 > RDX: 0000000000040000 RSI: ffffffff81bd3248 RDI: 0000000000000005 > RBP: ffffc900091f7320 R08: 0000000000000005 R09: 0000000000000000 > R10: 0000000000040000 R11: 0000000000000000 R12: 0000000000000000 > R13: 0000000000000000 R14: 0000000000040000 R15: 0000000000040000 > FS: 00007f31c3ca4700(0000) GS:ffff8880b9900000(0000) knlGS:0000000000000000 > CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 > CR2: 0000001b31624000 CR3: 0000000027a30000 CR4: 00000000003506e0 > DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 > DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400 > Call Trace: > > pin_user_pages_fast+0x83/0x100 mm/gup.c:3089 > iov_iter_extract_user_pages lib/iov_iter.c:2160 [inline] > iov_iter_extract_pages+0x2b9/0x1e20 lib/iov_iter.c:2229 > __bio_iov_iter_get_pages block/bio.c:1267 [inline] > bio_iov_iter_get_pages block/bio.c:1340 [inline] > bio_iov_iter_get_pages+0x354/0x1580 block/bio.c:1327 > iomap_dio_bio_iter+0x830/0x1440 fs/iomap/direct-io.c:323 > iomap_dio_iter fs/iomap/direct-io.c:436 [inline] > __iomap_dio_rw+0xd81/0x1d80 fs/iomap/direct-io.c:594 > iomap_dio_rw+0x40/0xa0 fs/iomap/direct-io.c:682 > ext4_dio_write_iter fs/ext4/file.c:587 [inline] > ext4_file_write_iter+0x1053/0x1710 fs/ext4/file.c:698 > call_write_iter include/linux/fs.h:1851 [inline] > do_iter_readv_writev+0x20b/0x3b0 fs/read_write.c:735 > do_iter_write+0x182/0x700 fs/read_write.c:861 > vfs_writev+0x1aa/0x670 fs/read_write.c:934 > do_pwritev+0x1b6/0x270 fs/read_write.c:1031 > __do_sys_pwritev2 fs/read_write.c:1090 [inline] > __se_sys_pwritev2 fs/read_write.c:1081 [inline] > __x64_sys_pwritev2+0xef/0x150 fs/read_write.c:1081 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd Quick fix like the diff below can be test when a reproducer is available. --- x/lib/iov_iter.c +++ y/lib/iov_iter.c @@ -2140,7 +2140,7 @@ static ssize_t iov_iter_extract_user_pag size_t *offset0) { unsigned long addr; - unsigned int gup_flags = FOLL_PIN; + unsigned int gup_flags = 0; size_t offset; int res;