From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67BBEC64EC4 for ; Tue, 7 Feb 2023 03:54:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EEC166B0073; Mon, 6 Feb 2023 22:54:03 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E743C6B0078; Mon, 6 Feb 2023 22:54:03 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CC6C16B007D; Mon, 6 Feb 2023 22:54:03 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id B8DAF6B0073 for ; Mon, 6 Feb 2023 22:54:03 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 8C53DAAF44 for ; Tue, 7 Feb 2023 03:54:03 +0000 (UTC) X-FDA: 80439127566.08.9154EB7 Received: from mail-pj1-f48.google.com (mail-pj1-f48.google.com [209.85.216.48]) by imf23.hostedemail.com (Postfix) with ESMTP id 9F123140008 for ; Tue, 7 Feb 2023 03:54:01 +0000 (UTC) Authentication-Results: imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e9tBbGrV; spf=pass (imf23.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675742041; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=radrNJcEj52EO1Vyn1//3vwMeqorrUn+XF43zRmwQLM=; b=In3wZUALsENFeZlGfCnn40T/mHrcu7SQmG2DehV3FDf6fc3QeNrVSbnThSfGFq85gOXiXz usOWXiLedTaW7gxv6geK13PgIu7qsP1YKaDD7dYULPUQY8TX5JgspYhEvOs5i+6x4DTDTV ln9FGjs60osAf/mK6vo+3YUVMdhNC4Q= ARC-Authentication-Results: i=1; imf23.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=e9tBbGrV; spf=pass (imf23.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.216.48 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675742041; a=rsa-sha256; cv=none; b=ZuDGXik8LhgYmQwYHG8p7/06WSS5wZdrRfsoHGkYwiYeSN2pvrx/0rLOL48TA6VzoEvtbB OF661wZzjxXUooOR5pDRD32mpVin9q3ir/j8VaGL9KDVuLy/ApZ+UwlSM9gSpw6QEvC0+u pzS5WQE/Ta87Djy/x4usrD9nEiXtqZg= Received: by mail-pj1-f48.google.com with SMTP id bx22so10791581pjb.3 for ; Mon, 06 Feb 2023 19:54:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=radrNJcEj52EO1Vyn1//3vwMeqorrUn+XF43zRmwQLM=; b=e9tBbGrVc6KrCXLirUIwtUWWZ5pScVYwhGOAX85/DTr5qa96neTYfNiaW0Zb/8meJQ 1pqo78jPkCl06fIq603NmiH73ykIdE4tNysE7jWe+cqbGQoi9HRy5GXSizPwBDnptLs/ VdPLJ2wnPfV6r6WEDIrm8HmD229QpmDjX+wZ0dIu0qcmHVGfNGsYodK0wfi2wWI5G+SG Fm3K4UDmTwirbtiNNPUbhT/BLmCWI8dVf3lP7LNwLlC9pYszNYTHzELutRWlrZWhnAtV 9JbufIvqryccaNGycUo23FTX14QEl0JPhIjUdPVkkLIlKOzmjCljWGg/3U79rB9jCxhI mobw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=radrNJcEj52EO1Vyn1//3vwMeqorrUn+XF43zRmwQLM=; b=yrZ7aFFcAtqcO+iMGywT8kYResHU3z6PLoyG+pwmZ4rG5lLJZqzq52ermKheApi0l/ BnmZSwZaG7W9oBxgh9RK12Iod8haTPweaMNLZbVslmyFgJqJB+AdOk/zbMVG+MxewbSP JfzIdhflfy2/l3fNN3RN7dQl3sZgl4DwE44V/RgtGHnfuiSu7fm1XFh9eyYBXb9FszNp fEBDqW15ZqCw4+IrNrlZhu+PqIyacz2wKFVGhd1DtDlzZJWTV+Ac6f0HO90q2qgmWLlB wVVQkgVhoy54DXvCD0lHh12wGN8fq6ESvEGqMm6Q0Jr0zocvt7B5v0RdanCU+08bzVGe lSOQ== X-Gm-Message-State: AO0yUKVRh059hGfAdR6ln1TSQxa4GVEwo27Wf//aYxnOmjhcfmYv4/QC eZ736KmN5VV24bv9dyoOhF0= X-Google-Smtp-Source: AK7set/ZfBJEIGUrpJL8s7VUE/4LvMWeWo6c88SMYAKDr4tnwSgq7/tvhA0ZTlIbSkN1+Fz2FrhpsQ== X-Received: by 2002:a17:902:e2c2:b0:199:1219:1568 with SMTP id l2-20020a170902e2c200b0019912191568mr1103226plc.4.1675742040504; Mon, 06 Feb 2023 19:54:00 -0800 (PST) Received: from strix-laptop.hitronhub.home ([123.110.9.95]) by smtp.googlemail.com with ESMTPSA id q4-20020a170902b10400b0019682e27995sm7647655plr.223.2023.02.06.19.53.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 19:53:59 -0800 (PST) From: Chih-En Lin To: Andrew Morton , Qi Zheng , David Hildenbrand , "Matthew Wilcox (Oracle)" , Christophe Leroy , John Hubbard , Nadav Amit , Barry Song Cc: Steven Rostedt , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Yang Shi , Peter Xu , Vlastimil Babka , "Zach O'Keefe" , Yun Zhou , Hugh Dickins , Suren Baghdasaryan , Pasha Tatashin , Yu Zhao , Juergen Gross , Tong Tiangen , Liu Shixin , Anshuman Khandual , Li kunyu , Minchan Kim , Miaohe Lin , Gautam Menghani , Catalin Marinas , Mark Brown , Will Deacon , Vincenzo Frascino , Thomas Gleixner , "Eric W. Biederman" , Andy Lutomirski , Sebastian Andrzej Siewior , "Liam R. Howlett" , Fenghua Yu , Andrei Vagin , Barret Rhoden , Michal Hocko , "Jason A. Donenfeld" , Alexey Gladkov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Dinglan Peng , Pedro Fonseca , Jim Huang , Huichun Feng , Chih-En Lin Subject: [PATCH v4 07/14] mm/madvise: Handle COW-ed PTE with madvise() Date: Tue, 7 Feb 2023 11:51:32 +0800 Message-Id: <20230207035139.272707-8-shiyn.lin@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207035139.272707-1-shiyn.lin@gmail.com> References: <20230207035139.272707-1-shiyn.lin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 9F123140008 X-Stat-Signature: 7u4rr93khadgfco81mzjzm8kw5ygwom3 X-Rspam-User: X-HE-Tag: 1675742041-233447 X-HE-Meta: U2FsdGVkX1/GfP+kWNx1GB3kBlLe3DLpbsMoQ3pUQGfA/t2Aqc0g4LbSyp14RzXAmKMLn4DBLaPIQuXxg+dqf9Zr0uK/ACewMV25hwK+JzpWmFoU7Ddmxy57hjYf+9aqIFdLKQjNEKC6coliiSVhKiaOveLRBL2ql42IoCjCAxeG6gmeQxbyS5h4v/ozBTsX0+u7Sx0eqXzfg6DFlwUukdBhxfjn8lvvwjIJc2NMoFQN6iPTqq0PJkgpdhBLATcFIO19llo5CbO5R9/2e17qsVO8hlzvcTGuG6xCHsm7XZPLfbufFxGnNO1v1d/Dz8d4qDf4OxtZg6aTHAZwciWCRiWHgBHdbSEClBQ0MDgqCVXVtJxKt2wnmk94iAL/1785RxuSz1q36qRUutds6JikfXP/f7HdkWvsPv1DG1NMKn+oaOSL7du05lqGUunrxUSsRisfGLUJvlsuPu6RZOehP+pGkXlO8f0QlFNMWnRCku9IptYbr5ISw21bsAKI9UI3takH7kuic9Q5O0UOWfbXHUkfrO4ZaHuKA9qQvpCcQDjhbLoxHi9lCtZipeKhKEF7QqLjYD/A7UB3dP6yazQNrqt6gaJq7sntgHFURugtfnlyUNqpZLpKhNLil6N/eoXD/uT2H+Dxom7SWxTwMfw3E8+1Ll7ln3/Tfs3xYUd0+W0wS4G2wyQdYciLY+wLJ/X/ZCqAQZS5HK1mvjnUahkk+MZSlhNBIqurRLnjhkuED5LjtcZiirqNCiijKkFnBhrMK9g9Xo1bNMcgSeBTo4wScQCLR30zXUg4j8p1rM/yTqziV4WFkv5FaSaQzQTkUN3ch2umLbP0oo8Z9R2yTaS5O4D02ponMBNIjrYvhtI54OW4lSGCK0iSygKn9WeVCLzOV0YcQ5410snOsl48nLgHxKvPUHLMe4sRmztnmvFs51GsSAbLmzWd2MCkRzVGqSVj9iiTMsOvXKGd2Fr0yG0 5fF4Z/Qd tt0KS1XQLsItM1SVXYzPzLeRiFU3HWapfgBUmig8EwX2epKT7TrtczvHuRp+8kEwXV4t6e6OP4MDWkTk1YaEjZZowck/NmhgMufXvaUWOFBbHrdQGcI/WcoBgC1MLeR7w9slVEm+QOmhtg4Vc+6tDtjSBIyM6inI0mB0e8roDo3WXoj8Cq3GCCKq3FBpxHXAXXAT4rmXRZgPAlb2N65+LliEPNZQyJUwcBIMuY5whrII1CQKDZssw4+2mmp47sNHHSYZTOK2E55EWo5xay5ow2Ja7BEXGLN9miHXUo4pV3oZJP2CXNfWL+GFbb9BsVypJ+g2EtJ1jK94eyXMCs1n7+13uOmrtbgdvmzEnIUlSFZWXN6CnkMD7BjieQH75vqf9F0Ybesxilh9S39mEctaOt1OHk3fTiNzV5ouDZ0NLP2uKJwiQbifSSJ4VUzInBUr3kvXlKEGy9S4b2ouyrXtF5mDYs8jA7MFyLOoC2/n65tyynr0MYD8CgmokehOopumkTW+sFxX72evQNi5l7DUzTChFzCY+yPa16x9ywM4zonY7WkfXC7holz6lqQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Break COW PTE if madvise() modify the pte entry of COW-ed PTE. Following are the list of flags which need to break COW PTE. However, like MADV_HUGEPAGE and MADV_MERGEABLE, we should handle it respectively. - MADV_DONTNEED: It calls to zap_page_range() which already be handled. - MADV_FREE: It uses walk_page_range() with madvise_free_pte_range() to free the page by itself, so add break_cow_pte(). - MADV_REMOVE: Same as MADV_FREE, it remove the page by itself, so add break_cow_pte_range(). - MADV_COLD: Similar to MAD_FREE, break COW PTE before pageout. - MADV_POPULATE: Let GUP deal with it. Signed-off-by: Chih-En Lin --- mm/madvise.c | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/mm/madvise.c b/mm/madvise.c index b6ea204d4e23..8b815942f286 100644 --- a/mm/madvise.c +++ b/mm/madvise.c @@ -428,6 +428,9 @@ static int madvise_cold_or_pageout_pte_range(pmd_t *pmd, if (pmd_trans_unstable(pmd)) return 0; #endif + if (break_cow_pte(vma, pmd, addr)) + return 0; + tlb_change_page_size(tlb, PAGE_SIZE); orig_pte = pte = pte_offset_map_lock(vma->vm_mm, pmd, addr, &ptl); flush_tlb_batched_pending(mm); @@ -629,6 +632,10 @@ static int madvise_free_pte_range(pmd_t *pmd, unsigned long addr, if (pmd_trans_unstable(pmd)) return 0; + /* We should only allocate PTE. */ + if (break_cow_pte(vma, pmd, addr)) + goto next; + tlb_change_page_size(tlb, PAGE_SIZE); orig_pte = pte = pte_offset_map_lock(mm, pmd, addr, &ptl); flush_tlb_batched_pending(mm); @@ -989,6 +996,12 @@ static long madvise_remove(struct vm_area_struct *vma, if ((vma->vm_flags & (VM_SHARED|VM_WRITE)) != (VM_SHARED|VM_WRITE)) return -EACCES; + error = break_cow_pte_range(vma, start, end); + if (error < 0) + return error; + else if (error > 0) + return -ENOMEM; + offset = (loff_t)(start - vma->vm_start) + ((loff_t)vma->vm_pgoff << PAGE_SHIFT); -- 2.34.1