From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5856C636CD for ; Tue, 7 Feb 2023 03:53:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 74B456B007B; Mon, 6 Feb 2023 22:53:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D6316B007D; Mon, 6 Feb 2023 22:53:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 527456B007E; Mon, 6 Feb 2023 22:53:26 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C1A56B007B for ; Mon, 6 Feb 2023 22:53:26 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 1013CA7F7B for ; Tue, 7 Feb 2023 03:53:26 +0000 (UTC) X-FDA: 80439126012.07.B19DC40 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) by imf12.hostedemail.com (Postfix) with ESMTP id 33C414000D for ; Tue, 7 Feb 2023 03:53:24 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hCRrp5kp; spf=pass (imf12.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675742004; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ESippIZ/CnSB38WrMj5JjilizAGyOvY6jTA6jEVsXQY=; b=rUoYgX4l48uxb1jAOL6k2r39shUM0rZBnJWeLeS0qemgYsEW4UbCqGyYbnDPvYNtEYNI9o 0aJvdjR9Up6qaB3NU6G6mGOq9YQXEP2zDj3M/YqqExUI6RjvovaYqAJoDGAsLJeOm5tDqb 37r448tAA3wjWuz+k08PoQUCm28kRuI= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=hCRrp5kp; spf=pass (imf12.hostedemail.com: domain of shiyn.lin@gmail.com designates 209.85.214.169 as permitted sender) smtp.mailfrom=shiyn.lin@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675742004; a=rsa-sha256; cv=none; b=K9S3fTG5H0/wLB1Anp28Fy27GUS+M1r2+khHr9B1XDQ9RGtNBiLDPZ0E021G6wjQnQzC+t 2m3YUPb2oJIPqaxJ6/AMgK9SLcOmf2Ol9GSHRYIbhEV91p3UuDhIH/Hy7byGuIaB7cHqCJ KdEIuX7W/lkAtui1iTPJoyeKVI3uK1g= Received: by mail-pl1-f169.google.com with SMTP id g13so9576696ple.10 for ; Mon, 06 Feb 2023 19:53:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=ESippIZ/CnSB38WrMj5JjilizAGyOvY6jTA6jEVsXQY=; b=hCRrp5kpGX6QjdARktYunOshhGk1+EWKFT5Inj47ph8UgEaPUwrDd08achgmwp3+yh X2XxKEgIJtkgLu7diHgDiBGzH0J0BsocTB0tHay6IQqubsICj4ahady75+p1pVmQ8hmv REsKqot4Cf2GZHbfsUo2MbxsDaWeFF3d2o5dwAPUToyCuvp5zwyr5SD9uH5rEsgqfVHY ZTNUoPVRCVRlIsFb+wrwo4fjETdVaEMb6/wHALYAOJ8lWPfF/ePBMb3BHCpJbWQiS8tA FypkGbVdOQkNs6tW5XpQtNablH6CqIhBzSTyPoFExmbx9SOovtew9FUYuUyPZkNYuYub Ph9w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ESippIZ/CnSB38WrMj5JjilizAGyOvY6jTA6jEVsXQY=; b=4i3rEJmSm2232aJNjehr16HX7QvCNHi+r5z8/BVKfoa2NdHpjeFfy719ifw9ebSKlF wvHHhvqT40vCq35mkSrFJeaU8gQwq2ZNmdm8q9/0u582TrrN3Vstyj8KIep7CqXtkvua cWlBtYdhXEKp9bx7CBzA4kb2VTju0tzadJjUFURJ+SFXRHCZyYDhD1mqS7wD121R0cb9 SXp8P4pZ6l+HN/s6+Atd2KkFedqndKpeViwhT+l5hL5Q6o5M9awfiXGQDLfRV5V+lmA+ TJMMYKLe3+0gSQjlne1Z0fardWHPml7ITAjLThU5lRCenrRyLpRa3l8vDRz48X5TzoOX GNNg== X-Gm-Message-State: AO0yUKUjBudC4tuDj4wiHSyfYfGp9xI5HTZZ6ng62l5iCkdbgHxaQWRd nT3PnR/kJ00/hTqr9rvm680= X-Google-Smtp-Source: AK7set+i4QEI6ncNS3F1kMiQrABLK/ayhTEQ52mLQfi5RcF2b9D1IkmgPWJcep3JctJB4hPN+Y3yPQ== X-Received: by 2002:a17:902:f24c:b0:198:e584:5823 with SMTP id j12-20020a170902f24c00b00198e5845823mr1054495plc.34.1675742003150; Mon, 06 Feb 2023 19:53:23 -0800 (PST) Received: from strix-laptop.hitronhub.home ([123.110.9.95]) by smtp.googlemail.com with ESMTPSA id q4-20020a170902b10400b0019682e27995sm7647655plr.223.2023.02.06.19.53.10 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 06 Feb 2023 19:53:22 -0800 (PST) From: Chih-En Lin To: Andrew Morton , Qi Zheng , David Hildenbrand , "Matthew Wilcox (Oracle)" , Christophe Leroy , John Hubbard , Nadav Amit , Barry Song Cc: Steven Rostedt , Masami Hiramatsu , Peter Zijlstra , Ingo Molnar , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Yang Shi , Peter Xu , Vlastimil Babka , "Zach O'Keefe" , Yun Zhou , Hugh Dickins , Suren Baghdasaryan , Pasha Tatashin , Yu Zhao , Juergen Gross , Tong Tiangen , Liu Shixin , Anshuman Khandual , Li kunyu , Minchan Kim , Miaohe Lin , Gautam Menghani , Catalin Marinas , Mark Brown , Will Deacon , Vincenzo Frascino , Thomas Gleixner , "Eric W. Biederman" , Andy Lutomirski , Sebastian Andrzej Siewior , "Liam R. Howlett" , Fenghua Yu , Andrei Vagin , Barret Rhoden , Michal Hocko , "Jason A. Donenfeld" , Alexey Gladkov , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-trace-kernel@vger.kernel.org, linux-perf-users@vger.kernel.org, Dinglan Peng , Pedro Fonseca , Jim Huang , Huichun Feng , Chih-En Lin Subject: [PATCH v4 04/14] mm/rmap: Break COW PTE in rmap walking Date: Tue, 7 Feb 2023 11:51:29 +0800 Message-Id: <20230207035139.272707-5-shiyn.lin@gmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230207035139.272707-1-shiyn.lin@gmail.com> References: <20230207035139.272707-1-shiyn.lin@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: s4pck7xzrydxxys3cgwbw84pr5s4c7dz X-Rspamd-Queue-Id: 33C414000D X-HE-Tag: 1675742004-209890 X-HE-Meta: U2FsdGVkX1+SHVNmzagjCCTi0R+cg3Bd3Mx/nywmTcX/cYpR8chqEWhRjq6VrV6e6nLYs6jyCgZYfOK38MsjzOP5U7+6WQfRNvSy3bYYnCosTCqqb43WzhfibbODt0qb8+zke/xKdbwyYcYGti5ejDmmXzwzQKna8w+fRKvNbYdOYczV6C+LFm+fW0MTu9Kn1zVMOgx6EMIcUdogqlDqsSvMEsttJ9gzQMPEjMqOHfOwRb4u6+U/bul7j7uTXvBttG7WREPbK6Q54FALk9SrHlGo4dcw55JWrSx6ZAX5lHOX3GpbaGhrKUmX6vrAzRgirLfXb71alrHyUHRHQMI+FcBuFrsyr1y6Rd0AWvSXToZdPeF1VyI2IgHraf/I1Aqv3Yut5TdsdTDw+qjivRfPxeJHLiIH7sEgfVaAWqL8uVnscnQ4/UOeVezsfX9wpRPoy+KWhKL+xw9x1CyNKYH2XQPbVEcexsfuz9sS+zl+CM2FxIiQEy0D7e6JHtJ6oS90CNwhpY5+4U4wITG/jKTr3OaZpWaV2Qd2u2OSpKMh7imJY8Dq8nRLhVUJYHiJPi639bUD6RDni/DOivoBdFvry5XbqrQs8HJoGvdyrshY8cmximAp8543m8IXbjt4paQgUNLRFYTm2zdcrxrdlqQ0YBTXqzj/+3VKlPB/g002uEVAA/FQBXI65MRLNb8p6mfSDKEhRwJKX8VMa8FUh6iighZ1M0gRnDAuqyvaIROiV9Kn8nd3XP1+WVXBjkZ1ou3DyLiINH1qTlcdkN6cv3HvXXUcbS2PardrCGs7Ne/BLo417Oq7AiFdrpS7BIGxQh72OibYwwT+Y4IuOPw+gOdUiLvxOiK4fxp71+Wy/YGqUZl16nTcCeQS/7e/OgWT55kWtljgr9DtGOzq67OMY0RSu3nxhHzx+RjhUAOrwOe/i5AsJhNs62KlHbGKt+OEUEM2MJhesGyhtNJ9dRDWFdM ytwiIAiK aN8OWmyTTExE+756uy3vNz7u+OTZS0+fL5OkYWSjWtOKoLCKnCvUojtZFx8XZaBCowj5+YEofqFWbsjQ7zcWVAYIrtDQabQFvQHjI1QuRot+f1K0l/32DAL9JmLjy+eywQSczDY8WSp+aLPRG4Zjtkqas/wxiDW2TlM6ge5FpMpt5ilVZ+GnAIBVQrAndaYUXUxCVSdp/Ehpa2qeHGB6BY/zE+loNTr+EZ9i9BIehzNcBQ6SzMb14PgOPnu7aCxjlLNwKXmaYfhjNkNW5dB3In8rwOkLpDy/XKYp3Hstl+hdrglKA3A0XeZ3NVQkFP+LK8LdIycKZ62DZCLBmXuhLJn3RaPxqnxxztf1VW+hevTtPfpO7IDEvmcWpS4anQZJq5mkfsjj3YYtzSSGC1g1Z2wtT2lV+hNphZWhPJHGPr/Nj7cVdNOL0flFBj+pAdXvU+kmeEXi0c2ZJ39s4Rr2KnU4qd8KHsu75XPfLXGJJkgCtdgXXpfWQCZGhIo/M9z0hT28rJYB+4hyrVspQGj3Fu09FldWvO0UxnEg6jSu7zKV735PRb/VP0Sd4SA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Some of the features (unmap, migrate, device exclusive, mkclean, etc) might modify the pte entry via rmap. Add a new page vma mapped walk flag, PVMW_BREAK_COW_PTE, to indicate the rmap walking to break COW PTE. Signed-off-by: Chih-En Lin --- include/linux/rmap.h | 2 ++ mm/migrate.c | 3 ++- mm/page_vma_mapped.c | 4 ++++ mm/rmap.c | 9 +++++---- mm/vmscan.c | 3 ++- 5 files changed, 15 insertions(+), 6 deletions(-) diff --git a/include/linux/rmap.h b/include/linux/rmap.h index bd3504d11b15..d0f07e551973 100644 --- a/include/linux/rmap.h +++ b/include/linux/rmap.h @@ -368,6 +368,8 @@ int make_device_exclusive_range(struct mm_struct *mm, unsigned long start, #define PVMW_SYNC (1 << 0) /* Look for migration entries rather than present PTEs */ #define PVMW_MIGRATION (1 << 1) +/* Break COW-ed PTE during walking */ +#define PVMW_BREAK_COW_PTE (1 << 2) struct page_vma_mapped_walk { unsigned long pfn; diff --git a/mm/migrate.c b/mm/migrate.c index a4d3fc65085f..04376ce05aa8 100644 --- a/mm/migrate.c +++ b/mm/migrate.c @@ -183,7 +183,8 @@ void putback_movable_pages(struct list_head *l) static bool remove_migration_pte(struct folio *folio, struct vm_area_struct *vma, unsigned long addr, void *old) { - DEFINE_FOLIO_VMA_WALK(pvmw, old, vma, addr, PVMW_SYNC | PVMW_MIGRATION); + DEFINE_FOLIO_VMA_WALK(pvmw, old, vma, addr, + PVMW_SYNC | PVMW_MIGRATION | PVMW_BREAK_COW_PTE); while (page_vma_mapped_walk(&pvmw)) { rmap_t rmap_flags = RMAP_NONE; diff --git a/mm/page_vma_mapped.c b/mm/page_vma_mapped.c index 93e13fc17d3c..7b35e85b9964 100644 --- a/mm/page_vma_mapped.c +++ b/mm/page_vma_mapped.c @@ -251,6 +251,10 @@ bool page_vma_mapped_walk(struct page_vma_mapped_walk *pvmw) step_forward(pvmw, PMD_SIZE); continue; } + if (pvmw->flags & PVMW_BREAK_COW_PTE) { + if (break_cow_pte(vma, pvmw->pmd, pvmw->address)) + return not_found(pvmw); + } if (!map_pte(pvmw)) goto next_pte; this_pte: diff --git a/mm/rmap.c b/mm/rmap.c index b616870a09be..bce97496b1f6 100644 --- a/mm/rmap.c +++ b/mm/rmap.c @@ -1012,7 +1012,8 @@ static int page_vma_mkclean_one(struct page_vma_mapped_walk *pvmw) static bool page_mkclean_one(struct folio *folio, struct vm_area_struct *vma, unsigned long address, void *arg) { - DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, PVMW_SYNC); + DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, + PVMW_SYNC | PVMW_BREAK_COW_PTE); int *cleaned = arg; *cleaned += page_vma_mkclean_one(&pvmw); @@ -1463,7 +1464,7 @@ static bool try_to_unmap_one(struct folio *folio, struct vm_area_struct *vma, unsigned long address, void *arg) { struct mm_struct *mm = vma->vm_mm; - DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, 0); + DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, PVMW_BREAK_COW_PTE); pte_t pteval; struct page *subpage; bool anon_exclusive, ret = true; @@ -1834,7 +1835,7 @@ static bool try_to_migrate_one(struct folio *folio, struct vm_area_struct *vma, unsigned long address, void *arg) { struct mm_struct *mm = vma->vm_mm; - DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, 0); + DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, PVMW_BREAK_COW_PTE); pte_t pteval; struct page *subpage; bool anon_exclusive, ret = true; @@ -2187,7 +2188,7 @@ static bool page_make_device_exclusive_one(struct folio *folio, struct vm_area_struct *vma, unsigned long address, void *priv) { struct mm_struct *mm = vma->vm_mm; - DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, 0); + DEFINE_FOLIO_VMA_WALK(pvmw, folio, vma, address, PVMW_BREAK_COW_PTE); struct make_exclusive_args *args = priv; pte_t pteval; struct page *subpage; diff --git a/mm/vmscan.c b/mm/vmscan.c index bf3eedf0209c..15eda32146fd 100644 --- a/mm/vmscan.c +++ b/mm/vmscan.c @@ -1882,7 +1882,8 @@ static unsigned int shrink_folio_list(struct list_head *folio_list, /* * The folio is mapped into the page tables of one or more - * processes. Try to unmap it here. + * processes. Try to unmap it here. Also, since it will write + * to the page tables, break COW PTE if they are. */ if (folio_mapped(folio)) { enum ttu_flags flags = TTU_BATCH_FLUSH; -- 2.34.1