From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 56F1EC05027 for ; Mon, 6 Feb 2023 17:45:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CDE0C6B0073; Mon, 6 Feb 2023 12:45:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C8E666B0074; Mon, 6 Feb 2023 12:45:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B0AB16B0075; Mon, 6 Feb 2023 12:45:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A14616B0073 for ; Mon, 6 Feb 2023 12:45:48 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 77ECC14014B for ; Mon, 6 Feb 2023 17:45:48 +0000 (UTC) X-FDA: 80437594776.13.CDC3FB7 Received: from toucan.tulip.relay.mailchannels.net (toucan.tulip.relay.mailchannels.net [23.83.218.254]) by imf17.hostedemail.com (Postfix) with ESMTP id EBC484001F for ; Mon, 6 Feb 2023 17:45:44 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=lkeL1n+O; dmarc=none; spf=pass (imf17.hostedemail.com: domain of dave@stgolabs.net designates 23.83.218.254 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675705546; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3RUNAXgDE0f/nNzbflUV5Av58uCfCjLXusvt31cTdrs=; b=2u/PqbH1qmhYbdC6pY07Gmv7vYBDqcF503qxB/aOHMAvbvrfAN0gFob7G1Hym/5Xde/OK1 pDupCrJfeGbaLbKKwc22uU6AREMYaLrMh0+K2f2d8aK8V8rA8imubWN//ygYZvnnBSH8PC BcGAYbKV6UBWNRjnRidvZpkMsdGMX+U= ARC-Authentication-Results: i=2; imf17.hostedemail.com; dkim=pass header.d=stgolabs.net header.s=dreamhost header.b=lkeL1n+O; dmarc=none; spf=pass (imf17.hostedemail.com: domain of dave@stgolabs.net designates 23.83.218.254 as permitted sender) smtp.mailfrom=dave@stgolabs.net; arc=pass ("mailchannels.net:s=arc-2022:i=1") ARC-Seal: i=2; s=arc-20220608; d=hostedemail.com; t=1675705546; a=rsa-sha256; cv=pass; b=0SMEKW354MR/fjvOfMUmmDYqQK7Ur5KpohqHddg3azVe+a7ub1oRoFox/csL4wXryr0nl5 7dB3hDwJ0TU91Snp4RhOhk0N36wKPNnEOH/H0OPB1JwxKsgBiUdu0o7t7LW8Vph6f6F+7w oKJHJu6afrca8VLZwR+/FJ1T4ctM9WI= X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net Received: from relay.mailchannels.net (localhost [127.0.0.1]) by relay.mailchannels.net (Postfix) with ESMTP id 8C10C7E153D; Mon, 6 Feb 2023 17:45:40 +0000 (UTC) Received: from pdx1-sub0-mail-a221.dreamhost.com (unknown [127.0.0.6]) (Authenticated sender: dreamhost) by relay.mailchannels.net (Postfix) with ESMTPA id 0B9807E1BEB; Mon, 6 Feb 2023 17:45:40 +0000 (UTC) ARC-Seal: i=1; s=arc-2022; d=mailchannels.net; t=1675705540; a=rsa-sha256; cv=none; b=AHtYt9eUWyhODzXYwuV3PQOLHr1s+09m1S3W9O97t1j25yxzpX4YTpKmQEEbzBxITidfir Jg8M0fSGCiumRNk8QhciK3LrTZsOL4mx+7VTGMFcKL/NeQ8QYdkNLtXSEpTE/lUFU2xSV+ hJKn81nfLKOhyNbxKZeGrBDuyQ5+l9vdnnEila/B+JNJKwFb/SdpqB4Wl+hRqfmSV7ZYAS yHU13jKHDUAjB9e5WD0IPiP34IFhA5R3OoAnBEdEMC4Ik3QO0al5gI+DF6zfw+HfA/BFmE bB/mpKkrd9MU+CfoXn7NWguMhcfdabE1OYzxVXYBCZPQVUp1sb23SxCQdCdseA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=mailchannels.net; s=arc-2022; t=1675705540; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3RUNAXgDE0f/nNzbflUV5Av58uCfCjLXusvt31cTdrs=; b=lR2UwC/NwDHiWiJZnwKH2XopLuyRfnXiB74NKLhkLtgEWwSs4J6HM50fzt0Maf9sXvPNTE abwEWAj99wF/2m83UuAeCFxGxIPiZZaio0xNHclH17Wu1lt3EeXBk5jYkCJKQ7zpMmFmyE qIMufLSUdd1uDejOWivyVNyHSYbzcqZH80HaXvbcC/idOUU9zRZYX49uslVc0HUnZ2em8J x4W4PiNsWdr11qsCfRSlLT/Q7rfrNoPMW+AHAvamZv/BoPUlPqgkTXFGucNwog998QHr5o 4NlY9xvqt8pqXspE8jMEYNMP/rqiyc+xqp70uimbkTJ5XyyVmEXyUg5JKyflIA== ARC-Authentication-Results: i=1; rspamd-5fb8f68d88-vqvfk; auth=pass smtp.auth=dreamhost smtp.mailfrom=dave@stgolabs.net X-Sender-Id: dreamhost|x-authsender|dave@stgolabs.net X-MC-Relay: Neutral X-MailChannels-SenderId: dreamhost|x-authsender|dave@stgolabs.net X-MailChannels-Auth-Id: dreamhost X-Left-Stretch: 637568a91d17b01c_1675705540379_1488037364 X-MC-Loop-Signature: 1675705540379:3862434003 X-MC-Ingress-Time: 1675705540379 Received: from pdx1-sub0-mail-a221.dreamhost.com (pop.dreamhost.com [64.90.62.162]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384) by 100.99.229.28 (trex/6.7.1); Mon, 06 Feb 2023 17:45:40 +0000 Received: from offworld (ip72-199-50-187.sd.sd.cox.net [72.199.50.187]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) (Authenticated sender: dave@stgolabs.net) by pdx1-sub0-mail-a221.dreamhost.com (Postfix) with ESMTPSA id 4P9YZV6pWKz9t; Mon, 6 Feb 2023 09:45:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=stgolabs.net; s=dreamhost; t=1675705539; bh=3RUNAXgDE0f/nNzbflUV5Av58uCfCjLXusvt31cTdrs=; h=Date:From:To:Cc:Subject:Content-Type; b=lkeL1n+OXLg2qI5yCtNhW4g+KfM4mm1JAbQ0etfFeY3E3oWAgamWc8cZA3AjTIZ5f i7yA3/x50s4lZSQWRUO2+KpD+/colHn4EhgkdknTVbTprtlOZJa84nVYB+2u6caBh4 83esFO8jaNgIx3+bgKudk1SVjSWMO5hDRAa+6XOqplhILzmIguikBo4Q2CiobYtcbM fH3eQ9YpGWt2KQPk4p51VhotmWhYzBfUB6DxoziUdhGGwTErF0SCULEt4R9PCL7pyK XcHXdh5wBDYAf7FIWO5yjKQhZXEmsbnpItdISXIrI+ZwxiuyPQmYSr6cYbdjV7Cmnz +meMv/DFpL+Mw== Date: Mon, 6 Feb 2023 09:18:12 -0800 From: Davidlohr Bueso To: Dan Williams Cc: Gregory Price , linux-cxl@vger.kernel.org, David Hildenbrand , Kees Cook , stable@vger.kernel.org, Dave Hansen , Michal Hocko , linux-mm@kvack.org, linux-acpi@vger.kernel.org Subject: Re: [PATCH 00/18] CXL RAM and the 'Soft Reserved' => 'System RAM' default Message-ID: <20230206171812.2kra5mqrqk26f6mf@offworld> Mail-Followup-To: Dan Williams , Gregory Price , linux-cxl@vger.kernel.org, David Hildenbrand , Kees Cook , stable@vger.kernel.org, Dave Hansen , Michal Hocko , linux-mm@kvack.org, linux-acpi@vger.kernel.org References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <63e13907cffb9_ea22229458@dwillia2-xfh.jf.intel.com.notmuch> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <63e13907cffb9_ea22229458@dwillia2-xfh.jf.intel.com.notmuch> User-Agent: NeoMutt/20220429 X-Rspamd-Queue-Id: EBC484001F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: m7ketxefouggfcsnf4owxdmtbhsuikks X-HE-Tag: 1675705544-473183 X-HE-Meta: U2FsdGVkX1/irkivzBOwlbm0buXoqYmLrFmrLgiHi3u/4Hum7HqooaoPOr5xrvfR6IdShT633+CTQ1+Nmnmgy8Nx2JcQsy8SByMOEFCDxXML2jDuF2eSCgK8vsKI6z0dsLevA5OgwsbEPQwYgAbWaCRXwl5SyEv59Ny3uu4/ktQnU2TVyTVHZ335mTSO6lT3II+SdTDiEGZUKRVnEeZP42nZPEvAQ1R2ThExQcF8wOQN0pD+u//xwW5kJjbalYAya7SH3/uW+28zJ+7qcgETw6yOE9QMJqGy3l3s59gca5WlkPmA3v7E+IARzwpz/jjpV2lNEyhijMcZofvEJ+jve7M9Dak/i8e99eJ501tCwIMUT/mE2cjaw1Q+dPWLGDacRL76CNzE9pWg6AHUlcAIfH7WdGnfZHUf/X1Puv4hganhapcC41WHcLIHaGCN36xhlzjjW0vkZcgWJMNioDOfX+k/5JzxVfNpHZ4GqPRL2Ph15U3GGZHY6JsXTo7D3bhaH9grnFaa9eY8fv0tKgHw5fQD9kq0sS2Ot8SGmCKZxeC8qhvb+Hn3jzQ1ZuO+FWrfQr0DFuaUECC4AlBRSBdUOggphokLNoRRDBT8WZMIZwjoNTQvLvNLn+Zpbw2DqTKtNymy/feBTgfojWop089czKGrylY53PHdXYqcgumTaJrzXWsOLdqSEWzScd9sAA/j7nNpsiKfilUJM+Jjxcw8JYvb6akc9i0ZuqMF+I6E8n8oF+y5aHhiDDub5FVdIct1jpCErWAQc+OjZdBbq5KeRsQcwGFG2COImlEwhhZKQinE6m73RYB4LmzTudR8/DzmMm6uZagkluMp9wQAypyYsxM52uC3Y8swZRdeiCcGckt4Xw8jBW3z/GloUGIwZ4v9kvrwG2gnYbP2iRLnyBM5aa8ZlaNokfAjeqnTVmZCVSrUJJX/ygaOnZ3sEYY89EGGZEHRFN+YpWmru3mSm9T KiWKMJ8G ixgDxyPhCw91LqpMOM5qlMD+QZvUZ37/QOeyXxfKpvemF01RrhOFN57yjq7Z57ZESef8Q/DfF3+tiVZu22iYZXZ+kXJcWlV5D00d5CFgRKQOm5LMP9cFdd5x9XRB7JLk/FzAnHbdNSSFRyWnuThAGh8WI0w9k/UVJApI9Yvvsxmod0a9s7JImet3aXbuwavn3Z+VBtMAicIgcMIRco26b9Tf+kbzAPC46SiwKcOO2yUcT/yo68soCec6PApvxBu40ceUgET8FJoxRHTaL4YxCyGAdINRcuHknniDVe4b1tZ0+Q6nXBq3bhM08rQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 06 Feb 2023, Dan Williams wrote: >Gregory Price wrote: >[..] >> Leverage the same QEMU branch, machine, and configuration as my prior >> tests, i'm now experiencing a kernel panic on boot. Will debug a bit >> in the morning, but here is the stack trace i'm seeing >> >> Saw this in both 1 and 2 root port configurations >> >> (note: I also have the region reset issue previously discussed on top of >> your branch). >> >> QEMU configuration: >> >> sudo /opt/qemu-cxl/bin/qemu-system-x86_64 \ >> -drive file=/var/lib/libvirt/images/cxl.qcow2,format=qcow2,index=0,media=disk,id=hd \ >> -m 2G,slots=4,maxmem=4G \ >> -smp 4 \ >> -machine type=q35,accel=kvm,cxl=on \ >> -enable-kvm \ >> -nographic \ >> -device pxb-cxl,id=cxl.0,bus=pcie.0,bus_nr=52 \ >> -device cxl-rp,id=rp0,bus=cxl.0,chassis=0,port=0,slot=0 \ >> -object memory-backend-file,id=mem0,mem-path=/tmp/mem0,size=1G,share=true \ >> -device cxl-type3,bus=rp0,volatile-memdev=mem0,id=cxl-mem0 \ >> -M cxl-fmw.0.targets.0=cxl.0,cxl-fmw.0.size=1G >> >[..] >> [ 15.162837] RIP: 0010:bus_add_device+0x5b/0x150 > >I suspect cxl_bus_type is not intialized yet. I think this should >address it: Yep, thanks. > >diff --git a/drivers/cxl/core/port.c b/drivers/cxl/core/port.c >index 0faeb1ffc212..6fe00702327f 100644 >--- a/drivers/cxl/core/port.c >+++ b/drivers/cxl/core/port.c >@@ -2011,6 +2011,6 @@ static void cxl_core_exit(void) > debugfs_remove_recursive(cxl_debugfs); > } > >-module_init(cxl_core_init); >+subsys_initcall(cxl_core_init); > module_exit(cxl_core_exit); > MODULE_LICENSE("GPL v2");