From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3AF03C05027 for ; Mon, 6 Feb 2023 16:18:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AFECB6B0074; Mon, 6 Feb 2023 11:18:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id AAEEC6B0075; Mon, 6 Feb 2023 11:18:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 976A96B0078; Mon, 6 Feb 2023 11:18:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 888326B0074 for ; Mon, 6 Feb 2023 11:18:48 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 452471C6041 for ; Mon, 6 Feb 2023 16:18:48 +0000 (UTC) X-FDA: 80437375536.05.8CD891C Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf02.hostedemail.com (Postfix) with ESMTP id 401B880017 for ; Mon, 6 Feb 2023 16:18:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="hQO7lfu/"; spf=pass (imf02.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675700326; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=rDZV3mvNGQ6bQlUZNt+pm2+TOpLBe+J478jwvr5iYPs=; b=aNHUYqjorinNTL789K2/1LGzumg7uGfkur1lW07krwqLwnpgaNPcLGpp/e5hxVqj2rH84D GUUB4q0E9MAYqv6gEnhYLr0SOHl1kXxoQuS7AtoUB1xcXAxyXu4tZ9nymRy6FsLJCExvcU qJ+WDCkIVVsyrW6sitT1trzYmifzOUg= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b="hQO7lfu/"; spf=pass (imf02.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com; dmarc=pass (policy=quarantine) header.from=suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675700326; a=rsa-sha256; cv=none; b=VUH38i8jPQsviuv4yVYBSnCPoemCC/uw56ezmzPjzIafNc+7L8UCcxsHH1/1iAe1pTWOp6 xHTHq2NWgB0X3q4Lcuzgf3JCsjb/5H5XohImCkwrsp6kRJCA9Rtk+gHUhY/xZJwoPiZtJ7 acuCt+Q38q+JVllzryzhAvDpzW80zqo= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id D0F3E1FDC4; Mon, 6 Feb 2023 16:18:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675700324; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=rDZV3mvNGQ6bQlUZNt+pm2+TOpLBe+J478jwvr5iYPs=; b=hQO7lfu/O7FHy0nrH+ZhkVayWc951N8vQUFqsqBQVt4PbLGzLrGPHE0FDkfgw6DtmqrQPF qa2n3gEEry2sT6DZB/Rg+HdMe6NO7pTxDB6Xavt7nlAC7Uxskyt7xQPfC/06rlzBMBlBxC 3x3/WqSPCBN2XPQ1ctlHBSeoxXMyGEg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 93FF5138E7; Mon, 6 Feb 2023 16:18:44 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id ubUoI2Qo4WP5BwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 16:18:44 +0000 Date: Mon, 6 Feb 2023 17:18:43 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Yosry Ahmed Cc: Johannes Weiner , Michal Hocko , Shakeel Butt , Roman Gushchin , Tejun Heo , linux-mm@kvack.org, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, Christian Brauner Subject: Re: [RFC PATCH] mm: memcontrol: don't account swap failures not due to cgroup limits Message-ID: <20230206161843.GD21332@blackbody.suse.cz> References: <20230202155626.1829121-1-hannes@cmpxchg.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="+KJYzRxRHjYqLGl5" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 401B880017 X-Rspam-User: X-Stat-Signature: 935kp1xc8xmiw8qu8m5d3rzo5ru54s3g X-HE-Tag: 1675700325-598305 X-HE-Meta: U2FsdGVkX19ENvvSiv8630a0BQM2jaW38Mj6BVrzTxAbUhne3cKXtw8QuregGippzAl1PgO9w2Z8FXQhGB9ZzMrSnG0yU69Vx6D9VD6GrrBFl0fcxK5ISJtjaR3hqIQ/nx5GIRsQK2hMo8T+3j4rJGOZ823TT46Mp+xhs/DCTQqajoFwwR+y1wiAch7QZKn3e+f8MV8MyLxf9apKnVyGP45UPvTfrItGySuYjIasvMHjWoydtlxLQnUcGUHHyIBTngZLS3z8RrQ/TWft82nRXh+VvYJorjeQlrNvqHeekorM/SPhdPrnfobFK69Wwg/U4RA/mF9+C2/f2fnNFiyJBRPtI29Ze/EkEXIioHOrpxzqdsw3L8FZlpePweLiy+wkw0ipxGPVU9ZZBS+by4DyWiu2j+WmvrV9uYPpGB7owxnUuh4WdBP3E3e7NQ6/RL1IJemAZgitC/M7ZvLueFJgvTTWZm7ljsRJv00H+xaS3AxA6Qv7XSHFqNbsNAbmKLTBuC668PUUaoDDX+m1jOrWH8BgWNMeSpri0UzkBmafo9qn7YfAWTJtAz/wcbuCg5vJL1hZWyHkDbw9fahhvttnDBhGwNQ2F0zN8Kz7Y1M7wAJBwvvzleUsojqXNSVIc8ZKR3dL9BiW6t/tyQl2jJdqP6hXbZMU2cVQJCK1BZWsbEwfLTCHtwZK9iQ7ND4LTPkSLZRHY9MXYwPqsyDS94mXw5XE7xSc290Wg+P+/a6KkPLdaNr3r9N92AnTpVni/lGWs/uf/z4YuwyhJK2+CTnMP/Sy2w1RZCtUAkd3gWFUEqTEa4j/pkMG0+PbpCzgQbD0205V+PC/8MeBmbv0EQb8XJX+4GysM0iEBrtxGE3zch6AXSmZXlSrIEyjSME16rMdm5Apyycp7wd8gufj9ddYAyd0hV+l8VjQhCvUnHw8lwY+8VlafseS7gP01T8T6Nhick0iLawIQD7j5oWJ2fM a8IDt+sx gtdizAScXDXfGdc0OjtcuAX/Cr1OYK1H79r6vV5KztRMmCLFjrLiwdYV3FiJT7h4Qxcb3wIfeKY0WW62LhZhFH/lbKDg6R9EEfUPnrb4iVdQP6VJLK8eRj1dbLCkL49BVoguCl/IiGs8neZDwLQnhSin84CNiRwIOsVFix++v0KMGrotWltBtSH0emlfTpuO8us6rIHBjVj9HevdjapuvuGFhH2Sm9408lMWdo8CoBLs5N5Tk5xoHKMi/ex3fQWii88t2UblivttQcTAGcXenHakK3F/GsFDveo96WMORBgdnGMJNLJCrINehGG3T/0S0ysxc X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --+KJYzRxRHjYqLGl5 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Thu, Feb 02, 2023 at 10:30:40AM -0800, Yosry Ahmed wrote: > > b) Only count cgroup swap events when they are actually due to a > > cgroup's own limit. Exclude failures that are due to physical swap > > shortage or other system-level conditions (like !THP_SWAP). Also > > count them at the level where the limit is configured, which may be > > above the local cgroup that holds the page-to-be-swapped. > > > > This is in line with how memory.swap.high, memory.high and > > memory.max events are counted. > > > > However, it's a change in documented behavior. >=20 > This option makes sense to me, but I can't speak to the change of > documented behavior. However, looking at the code, it seems like if we do= this > the "max" & "fail" counters become effectively the same. "fail" would > not provide much value then. >=20 > I wonder if it makes sense to have both, and clarify that "fail" - > "max" would be non-limit based failures (e.g. ran out of swap space), > or would this cause confusion as to whether those non-limit failures > were transient (THP fallback) or eventual? I somewhat second this. Perhaps, could the patch (and arguments) be split in two: 1) count .max events on respective limit's level (other limits consistency), 2) redefine (remove?) memory.swap.fail events? Michal --+KJYzRxRHjYqLGl5 Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY+EoYQAKCRAkDQmsBEOq uXuJAQCRA9+UXkEzfVoUWjltXKLdc9vqvH0D5zne/GZdvubZBwEAoxc1UQlw1YcL 8fUMQsShXoCJhwMdfV5kVkrsg1du8ww= =agtq -----END PGP SIGNATURE----- --+KJYzRxRHjYqLGl5--