From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 25987C636D3 for ; Mon, 6 Feb 2023 16:02:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id AE4B56B0072; Mon, 6 Feb 2023 11:02:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A942F6B0078; Mon, 6 Feb 2023 11:02:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 983996B007D; Mon, 6 Feb 2023 11:02:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 88D556B0072 for ; Mon, 6 Feb 2023 11:02:32 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 29229C07F2 for ; Mon, 6 Feb 2023 16:02:32 +0000 (UTC) X-FDA: 80437334544.01.E1088E1 Received: from frasgout.his.huawei.com (frasgout.his.huawei.com [185.176.79.56]) by imf21.hostedemail.com (Postfix) with ESMTP id E40531C002A for ; Mon, 6 Feb 2023 16:02:27 +0000 (UTC) Authentication-Results: imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675699350; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WATbOO+Zy3R0thy6g5GNH3nauMDiHtFmsyuudwvDCtI=; b=WEcIZODZfod3NuEM6JyV7SM+e2RALfd/1Mm0ZmclnkaouPWqJ4JyMdsDimC5mnX50th//O Bb2vIRFV2BfsyrBIMGjr0R94myQ4IJivW1rKu918/6urvGRxZ+LOr/vzYpwPW0R9jiA3I9 kzDiQdowTQDxp6TyToDZXtAqaG1kBdU= ARC-Authentication-Results: i=1; imf21.hostedemail.com; dkim=none; spf=pass (imf21.hostedemail.com: domain of jonathan.cameron@huawei.com designates 185.176.79.56 as permitted sender) smtp.mailfrom=jonathan.cameron@huawei.com; dmarc=pass (policy=quarantine) header.from=huawei.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675699350; a=rsa-sha256; cv=none; b=fRgHkdejnPo/hcLlhFq7QBT/PulUz+3BQ8+NIvNA42UEHPOQnujvhP6pbnjL8TW/bRI3vm x46j/4FEUGs/HbuUv77ic9v0u8RNi4Thj+fIy3vZHJeuP4hPxzu3CJkgtb3ez7Ywyqougi fkYLnmlU5AwT0k/QUXHQDuv+rIwnEXo= Received: from lhrpeml500005.china.huawei.com (unknown [172.18.147.201]) by frasgout.his.huawei.com (SkyGuard) with ESMTP id 4P9WFt4kBrz6J9yS; Tue, 7 Feb 2023 00:01:06 +0800 (CST) Received: from localhost (10.81.207.58) by lhrpeml500005.china.huawei.com (7.191.163.240) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Mon, 6 Feb 2023 16:02:23 +0000 Date: Mon, 6 Feb 2023 16:02:21 +0000 From: Jonathan Cameron To: Dan Williams CC: , , , Subject: Re: [PATCH 04/18] cxl/region: Validate region mode vs decoder mode Message-ID: <20230206160221.000045ea@Huawei.com> In-Reply-To: <167564537131.847146.9020072654741860107.stgit@dwillia2-xfh.jf.intel.com> References: <167564534874.847146.5222419648551436750.stgit@dwillia2-xfh.jf.intel.com> <167564537131.847146.9020072654741860107.stgit@dwillia2-xfh.jf.intel.com> Organization: Huawei Technologies Research and Development (UK) Ltd. X-Mailer: Claws Mail 4.1.0 (GTK 3.24.33; x86_64-w64-mingw32) MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.81.207.58] X-ClientProxiedBy: lhrpeml500005.china.huawei.com (7.191.163.240) To lhrpeml500005.china.huawei.com (7.191.163.240) X-CFilter-Loop: Reflected X-Stat-Signature: xrh1o7riginuizhe6r45ziume6ut3y67 X-Rspam-User: X-Rspamd-Queue-Id: E40531C002A X-Rspamd-Server: rspam06 X-HE-Tag: 1675699347-664580 X-HE-Meta: U2FsdGVkX19XIyYHTrh9JAeKBZZt9guFV0+/NUf0qTsgqOruQy8ZdE63FtEhm3GxpU9Mj3fMmFIttDxuq+SUBOOkgdam6G+J6mHHywI6NADkac1lyJOCeQqAXEaxDKwVQMTTMT1YVzZjD048WQ82MWvkX2IWZkAvwZwZuH0TgxOgQWfPcgLqXqDgTzd7zCIGG/wU5zRtB/nRScHXY5nliDpRzDB9yuS4AgxiAT0J6IHB516Y/pkioowieFsSpymm4I+bkAGWm1XEtGSHE/X1MN1Rl5WvOsKeubrAGqFZS1uNb6orWRG3XsOKbL8zZUrdzsQToGGNwEUi+2P9XOIvtsZudskzk+GUn+cFedvl2RYtEcir6BepnIBTKi9u30BWqIvtSD78UHONxGEXWWMmq1sDDoE5t38yqa1F6H8KiWCZad5qx2fWogm3to2eJz8sPQcQWzikbrbN4CqK3KsBbbEfpCHaDVlU+UnzCEWyFlKIxIexIUuhd5qeGpDV+hoy9FjFggolN4QiAZOGk4xwfMeNyeOTI83ULrT0v9px83IdBPEWlBPH01psBoG2L6BV2UGDBuZFBOhRUCizYD8GvqWPqluwDuUjz5/BH9mVvQEaGumUYdS5Ynj74W1c05WxyXPxXC+zGwEUwWxFSzFrCoDQUYZSG/z/Ws1M39+ORClL7/+/jzGxIGeeikGNfSNuoHAX/+UdYlCrcGBo6JZPR7zE5LvUok70+9LRefMbwa8qXCSdKFMt+ObkFvdTrjDxZBL5h0uUhaF26n+xUXdtUZLP1tIqfjc4B1zJrQeGMMBJud5Gh0ye3P+edP1GOGnx3JkZd4JBBuEaTmN0KZWQ9magPHzee4L2b0p2XDWekIyMsGasP2ofBtvzzfeGFSlOpsfm/g6aNnRmmxTxRYJUZ6cjRcZu8f+AFbFgEJ9+EoO64W3ggTVwTBZ9BDkFqppUUJrRkQMlEzFi3RpYxNF EfnB/wXp 8anhI3bTtIjqmXZMKzaYQRnQqGFTE8Fo+oJurnsNzovlmI+F8Jphqb4YfH/8OGKcJ7KdK55WZtf8VcuwKh61lkIrX3nxqtCoz793xyXIShd++m4EpV3mTmdAkXQgHkII4cVBnf5RfuV60mIOwZktf1o2jZy4Ikxq9+R2rNL8dstxrf4dS9Q6F2mU+R+W1MDhmHwI7m8TvnI5H6qp6Pe4LViPTJeaYJtEXB5j37qfd6WE+GWadIROHSLcQ/skHqpn1fwrxa0DmF9xeO6Y= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 05 Feb 2023 17:02:51 -0800 Dan Williams wrote: > In preparation for a new region mode, do not, for example, allow > 'ram' decoders to be assigned to 'pmem' regions and vice versa. > > Signed-off-by: Dan Williams I guess we aren't support mixed endpoint decoders for now (and maybe never..) If we did I'd expect this to have to allow mixed with either RAM or PMEM. Reviewed-by: Jonathan Cameron > --- > drivers/cxl/core/region.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/drivers/cxl/core/region.c b/drivers/cxl/core/region.c > index c9e7f05caa0f..53d6dbe4de6d 100644 > --- a/drivers/cxl/core/region.c > +++ b/drivers/cxl/core/region.c > @@ -1217,6 +1217,12 @@ static int cxl_region_attach(struct cxl_region *cxlr, > struct cxl_dport *dport; > int i, rc = -ENXIO; > > + if (cxled->mode != cxlr->mode) { > + dev_dbg(&cxlr->dev, "%s region mode: %d mismatch: %d\n", > + dev_name(&cxled->cxld.dev), cxlr->mode, cxled->mode); > + return -EINVAL; > + } > + > if (cxled->mode == CXL_DECODER_DEAD) { > dev_dbg(&cxlr->dev, "%s dead\n", dev_name(&cxled->cxld.dev)); > return -ENODEV; >