From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D6863C63797 for ; Mon, 6 Feb 2023 15:51:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5E4456B007D; Mon, 6 Feb 2023 10:51:14 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 593AE6B007E; Mon, 6 Feb 2023 10:51:14 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4364E6B0080; Mon, 6 Feb 2023 10:51:14 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 344306B007D for ; Mon, 6 Feb 2023 10:51:14 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 039364096F for ; Mon, 6 Feb 2023 15:51:13 +0000 (UTC) X-FDA: 80437306068.04.4D13EE8 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf18.hostedemail.com (Postfix) with ESMTP id 1B4131C0019 for ; Mon, 6 Feb 2023 15:51:11 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=hasfkwf5; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf18.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675698672; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=7fhVqQ68veOG9L/p1SZuHOGXVu/+YnsgNDr8L++Nf6Y=; b=Wkl6OjlhDpV3shW3pFLUWVNV9s8EXQ8WKNBaXQ1hoyIqMAbe+B5g+QqVM9+d/j/ppVA5bS +yJYeTya7mV8aOloXRho/wCSWMZFE6hnyq2/rjZR1P6Yw5++xZj/aOJVygMFXkSmhmoPB5 +ovAtNco5eZD3vm8YYBF9KL8bhW1V4g= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=suse.com header.s=susede1 header.b=hasfkwf5; dmarc=pass (policy=quarantine) header.from=suse.com; spf=pass (imf18.hostedemail.com: domain of mkoutny@suse.com designates 195.135.220.29 as permitted sender) smtp.mailfrom=mkoutny@suse.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675698672; a=rsa-sha256; cv=none; b=HQ7O2yYkk5r5hoZomvlIarU9rEB/NJopFTObR6zrqV20HRuZJf1BHxJC9KnKyXZnaYt+TK s78RfyKVWt9PYu5P8m9+1l6xhZlC0IbR7/CdQGUw2EYW7JrfX+fn3xYFWqlMfY0c92rZk2 Q+vsyxHmPOFIEHx+emncZS9hW4UEbAg= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id CFA826061D; Mon, 6 Feb 2023 15:51:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.com; s=susede1; t=1675698670; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=7fhVqQ68veOG9L/p1SZuHOGXVu/+YnsgNDr8L++Nf6Y=; b=hasfkwf5qLMSjdjBN6tNl9erNVm4U6hoHsFNNv8OenccPiydH09u+yHslUPouNtKnn2j4N IRgHQtzLbkOt8iKWYtUOv6bo1JcUIFxWHwPmp2gSgcxRDuF2Ctx5P6pQwAe+dzYWZqeVsp 54yNNtbDWOGQDl97k5EHhRinkwPr6Gw= Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 8D1F7138E7; Mon, 6 Feb 2023 15:51:10 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id R8GOIe4h4WPrdwAAMHmgww (envelope-from ); Mon, 06 Feb 2023 15:51:10 +0000 Date: Mon, 6 Feb 2023 16:51:09 +0100 From: Michal =?iso-8859-1?Q?Koutn=FD?= To: Frederic Weisbecker Cc: LKML , Roman Gushchin , Michal Hocko , Marcelo Tosatti , Leonardo , Johannes Weiner , Shakeel Butt , Muchun Song , Andrew Morton , Peter Zijlstra , Thomas Gleixner , cgroups@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 1/2] sched/isolation: Merge individual nohz_full features into a common housekeeping flag Message-ID: <20230206155107.GA31453@blackbody.suse.cz> References: <20230203232409.163847-1-frederic@kernel.org> <20230203232409.163847-2-frederic@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="EVF5PPMfhYS0aIcm" Content-Disposition: inline In-Reply-To: <20230203232409.163847-2-frederic@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 1B4131C0019 X-Stat-Signature: px5u8hpnjxi455th364bytko7icasx5k X-HE-Tag: 1675698671-863048 X-HE-Meta: U2FsdGVkX18W7fIYAPZl0EQoqZNXBjXrEedT6gNrYtWkqi1a7h/9pkE1Ejym1pOpLH1s3BBRl5+ZT17SWXLMR7C1TWTGMq9zB8divOupzCktRAIj8L5JV/90wCmjYi7a3U5XUzMBCxhNQ4KJgbSv/EGKJCR70x1F1m4/eCmyul2Sk078CxqF7nfGwJ5jWluTFX0QC2b+dqWoRv7T5GJrJVYAp88mPpjzmMj2QM7hFtt5aJS72DOAzjRq3PTC8HmJhtG5+s0lENIGvVK9jtPxhF1ajGjappme52kyeemQI+WNChRnDkCAHsVtDxt0FkM1F9cs818C9krLzksSTxVRjbM8xhOw7aH4lFa/2KF2HBo/5d+JI14B7Wd2d3Pqa3LJRcJtq3hSnjXmGtIuPyxBNDctZJ3WYYKFG812wS1xXYZKNsLxbmUivD1QMP/JWo+7+FqYTdZkp706n6mldhNP/fNW2I33yp/V5Emm3UsUzzzSFHdkJ3XI3T1/jNeLnIYy5pyKXUJWkA7LRgr51wuzjh6TERxd4m0b4RYGLDNF77OZS+x/4SCENpj8AKbY/oZu2NPNn5YELW89GQjudM0NCds9K41ePW+2U0qOON2oQKhctwq7SMHiXBX96aH3OEbeVJi2CvYU14cKhJU0bpHAyL8/YcAR83DSogLfW/BYNf2oVmXr84h1BpRW5tbC5kCUAhHGtSQ6jMXpWQgKkFbHz10IcfPw7k0Nb1gvrFrw1RF371D1zVadAOooXgokK7YV79dt/KRht33TEIb2qrpkct5dMli0tEHLH/TLQxisCEwqgCUUjY7KyUxpgpqjfclZ2V7v7LOasb9gVDAOI93DCWODVMTb704IO/lVXzsqlyIXWs7yg7JiZdkfb6DRfvE9JtOTXJrWtzNPzjl+tv4jVJ3O+QZPgJreO0+RHZhDXagU5hYZ2+CvO7dm7GRLWZnWygTSeRxldnRWL5xmExp NxojfeRo hGkyU3pyp9tTG+vARL21HL8aYsJ3L3PWs+a0//AGK3ukxN/qN3rc6mTyWgWLAJOOR9TVo7SQaRh7hBUHuDbqW2zA4qdgKNz75BCpBL5aV8UicBAnqerWxJJgYa7OAY3Tt8ejq7BrmoF7sOPItyOLU7aojDTxBErxCmFPBnFYRoLrdBysTwYAfq+jsz3NbpJNn2UcgfkspIVMF55M0ay8auzwPulsXS54XGUHwevNCf0P2lFdio76oo9/40SZ7twxTq1TdRKoWhr5BscfNLYowTjgm+w0Pu25ZAMYiC4fep+rSNRaOC06oaD9sXXYQmi2+SV+0U2hIbccm/4/RRh4u9B4aN2KZh/XJ6g7QFMvt2Zq4ePj37oPX43RfSzCTrNDNSYs4OUdLt/Qkedc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: --EVF5PPMfhYS0aIcm Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello Frederic. On Sat, Feb 04, 2023 at 12:24:08AM +0100, Frederic Weisbecker wrote: > The individual isolation features turned on by nohz_full were initially > split in order for each of them to be tunable through cpusets. However > plans have changed in favour of an interface (be it cpusets or sysctl) > grouping all these features to be turned on/off altogether. > Then should the need ever arise, the interface can still be expanded > to handle the individual isolation features. >=20 > Therefore the current isolation split between tick/timer/workqueue/rcu/ > kthreads/misc doesn't make sense anymore. Why it doesn't make sense? I think it's a useful annotation of respective operations wrt CPU isolation. The grouping you did into HK_TYPE_KERNEL_NOISE (or even coarser) should IMO be done at the place where it'll be exposed into the favored interface (like it's with nohz_full=3D). Thanks, Michal --EVF5PPMfhYS0aIcm Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQTrXXag4J0QvXXBmkMkDQmsBEOquQUCY+Eh4QAKCRAkDQmsBEOq uY4SAQCzuyUGyy1DTu07dJpsvqnTWqj22goDeqZvTqIu0AP03gEAyBFBBPOZ8x2z 1AxH3gDttpfyCcnalCsgb2sHDcUf+gA= =pZsI -----END PGP SIGNATURE----- --EVF5PPMfhYS0aIcm--