From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 380EAC636CD for ; Sun, 5 Feb 2023 19:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3E7E36B0072; Sun, 5 Feb 2023 14:01:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 36FDB6B0073; Sun, 5 Feb 2023 14:01:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 2105F6B0074; Sun, 5 Feb 2023 14:01:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0A7B46B0072 for ; Sun, 5 Feb 2023 14:01:17 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id C8B8AA0598 for ; Sun, 5 Feb 2023 19:01:16 +0000 (UTC) X-FDA: 80434156152.11.8E1AFA6 Received: from lgeamrelo11.lge.com (lgeamrelo13.lge.com [156.147.23.53]) by imf30.hostedemail.com (Postfix) with ESMTP id 5839E80021 for ; Sun, 5 Feb 2023 19:01:12 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of taejoon.song@lge.com designates 156.147.23.53 as permitted sender) smtp.mailfrom=taejoon.song@lge.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675623675; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:references; bh=9lAInHjt+dnLpD1VxlpAAvbr86BgXwVvbzeN/2J9YpI=; b=oRNc1GBZkwSg1+d9yRiYP0RXYVQuBY/WMpJlygqma+c8kcXibEmjyU05o4zNBxzRcdQzR3 jCYLnUeDBdwpUcIEfZrK1GqoZLxbtk/ZdQKJqfmm7riAfDpU+zTZxRFMR7cezQjqfsNd1Q ZegkFZj5g3NMvU/Qgjs63/C9LJsSX+E= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of taejoon.song@lge.com designates 156.147.23.53 as permitted sender) smtp.mailfrom=taejoon.song@lge.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675623675; a=rsa-sha256; cv=none; b=dMcc3eWlICa9maubwGPU6pFLtyQT8gu2OvmBiRi/kCTMCdJXl8P1+G84FnHMPfym/owxgG my9cwGhGvGDyv58qY4ZzXB5a2pGr1eoAQ6w2OZfB6QdOTpXDxx5tEpdVD9crcY/2dDq/Vk +WuU1NO7YKyKlDM/3Qf3NB/kaMjkncs= Received: from unknown (HELO lgeamrelo01.lge.com) (156.147.1.125) by 156.147.23.53 with ESMTP; 6 Feb 2023 04:01:10 +0900 X-Original-SENDERIP: 156.147.1.125 X-Original-MAILFROM: taejoon.song@lge.com Received: from unknown (HELO localhost.localdomain) (10.177.244.77) by 156.147.1.125 with ESMTP; 6 Feb 2023 04:01:10 +0900 X-Original-SENDERIP: 10.177.244.77 X-Original-MAILFROM: taejoon.song@lge.com From: Taejoon Song To: sjenning@redhat.com, ddstreet@ieee.org, vitaly.wool@konsulko.com, akpm@linux-foundation.org Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, yjay.kim@lge.com, Taejoon Song Subject: [PATCH] mm/zswap: try to avoid worst-case scenario on same element pages Date: Mon, 6 Feb 2023 04:00:36 +0900 Message-Id: <20230205190036.1730134-1-taejoon.song@lge.com> X-Mailer: git-send-email 2.34.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5839E80021 X-Rspam-User: X-Stat-Signature: yapaspsy3yydt91gcw4zwniokwuequp1 X-HE-Tag: 1675623672-688546 X-HE-Meta: U2FsdGVkX1+WKp3RB1EM/INMGow0H5tvHwiHjsB8fKnEkOnFP5E6LIIgclnjw+6fUuLxphp7YqHXw1VHTYUDiXXFWxSv0ASlzA6LtmiMAwQY0kJolLtcaqvwcVsP7cS+9W1PZ2EKup/PBPvn9fPXk4FSU5Oc+aO1TRQOrGruldEGQ0j/Jdr7hx85crvUBNumRk31pSP5zaH/PTX4Grv0RhlKjGQs1CX5jW9L2gEFwRrdXxxuHntzGow+SNIhmav3VdpTpWjKTAw2NIWWcPxI3xfW3AGFrTbz1Uf21e1OcpmSfF3g8eMDv268SsVb+Q7qCM9qhMVAjJpwTNFGdi8XGo1jTVNXA71wVB+sOSkX8n5SjFLHuPGGlV10hMMCAg4eBbprHpYmsbLSz5u7AnJLTWfCpVG1Taxe8NWsiFhLQ/dON9lyXIO6DzleEm3aM69QiCQH6u8tpCRLWPROJhtnY+/Fs0D3KeJEBajb5MbW4hALmvgJoRdIpemWPeRAtxWUbFij+j5BfjlbDYq2jwuiN6gXoqYVFc5QlsMITP+vM2ZBNQnIwz654GFjoYW41AxmBGiRN5QM6UGdZQIcpU3IwXoNKzkjxW3hKcryXxjvrjORQGb2GYm2bwJgXUsZ8E9oBmp37sZU1A33AmA4fTSK4SxCX40t+2sj3mcl8lxfvPzTVBie87ybRQnO1v8yr3hhr4SigiQ11oFfRQbcieqnRkhwaovcHxjpj2huznKBbm001SqQ02Y8BowgJHQ1V45WqocWOvjzMa0awnVaTXIihxpD0qR01dWc9T8CP+BzQ1gLke2UjdFbv6A9T6WrOXfkdVBo89Ay0C3RsULpjs+YeXE31GHNsAZ1WD43RRY79+J24j3028BLAq0fOda/Y/rbPudi3d3Ibsr+nhV9d+RV/O5GRHUA/8i4R50r3P6jptDDE/Dsf3KxxzCYFvWe/qVxuIdWNSqgCDAHrOSXSy+ pkAnIUok ZLuLwahvdRY7PVTCr75fOoikpn+bv7xvOCMTCKVEFjiaVZiZmfv3taJEP/tIIBa2wt/uXPUPXMJqY3LgZ71cikQGVwRLxUtHqH0WODc3erX+PBzfOCPez0Oxmw1MAxQSUk4IYKWG6T2tCB1bYIUwxy/SKpr4bsq2O8FpDtS+x/NmQ41w= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: The worst-case scenario on finding same element pages is that almost all elements are same at the first glance but only last few elements are different. Since the same element tends to be grouped from the beginning of the pages, if we check the first element with the last element before looping through all elements, we might have some chances to quickly detect non-same element pages. 1. Test is done under LG webOS TV (64-bit arch) 2. Dump the swap-out pages (~819200 pages) 3. Analyze the pages with simple test script which counts the iteration number and measures the speed at off-line Under 64-bit arch, the worst iteration count is PAGE_SIZE / 8 bytes = 512. The speed is based on the time to consume page_same_filled() function only. The result, on average, is listed as below: Num of Iter Speed(MB/s) Looping-Forward (Orig) 38 99265 Looping-Backward 36 102725 Last-element-check (This Patch) 33 125072 The result shows that the average iteration count decreases by 13% and the speed increases by 25% with this patch. This patch does not increase the overall time complexity, though. I also ran simpler version which uses backward loop. Just looping backward also makes some improvement, but less than this patch. This patch was already applied to zram on mainline v5.6-rc1: https://lkml.org/lkml/2019/12/3/1422 Signed-off-by: Taejoon Song --- mm/zswap.c | 16 ++++++++++++---- 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/mm/zswap.c b/mm/zswap.c index f6c89049cf70..2f0ebd8bc620 100644 --- a/mm/zswap.c +++ b/mm/zswap.c @@ -1073,15 +1073,23 @@ static int zswap_writeback_entry(struct zpool *pool, unsigned long handle) static int zswap_is_page_same_filled(void *ptr, unsigned long *value) { - unsigned int pos; unsigned long *page; + unsigned long val; + unsigned int pos, last_pos = PAGE_SIZE / sizeof(*page) - 1; page = (unsigned long *)ptr; - for (pos = 1; pos < PAGE_SIZE / sizeof(*page); pos++) { - if (page[pos] != page[0]) + val = page[0]; + + if (val != page[last_pos]) + return 0; + + for (pos = 1; pos < last_pos; pos++) { + if (val != page[pos]) return 0; } - *value = page[0]; + + *value = val; + return 1; } -- 2.34.1