From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71869C636CD for ; Sat, 4 Feb 2023 06:19:06 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A0F316B0072; Sat, 4 Feb 2023 01:19:05 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BE646B0073; Sat, 4 Feb 2023 01:19:05 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8D3FD6B0074; Sat, 4 Feb 2023 01:19:05 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 7F1A06B0072 for ; Sat, 4 Feb 2023 01:19:05 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 4A10A1A035C for ; Sat, 4 Feb 2023 06:19:05 +0000 (UTC) X-FDA: 80428606650.24.3C782E2 Received: from mxct.zte.com.cn (mxct.zte.com.cn [183.62.165.209]) by imf25.hostedemail.com (Postfix) with ESMTP id 32BA4A0006 for ; Sat, 4 Feb 2023 06:19:01 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of yang.yang29@zte.com.cn designates 183.62.165.209 as permitted sender) smtp.mailfrom=yang.yang29@zte.com.cn; dmarc=pass (policy=none) header.from=zte.com.cn ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675491543; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=DeKHfn2gOVzknIChz0xgqUFlUnPnz4fzYXLaepE1CIM=; b=ayoyx0CIyZHASJ7pV7ZBk3fWpQ/s3wuV6bsgS4t4lrzdGLPqpsdm/bNtLhQdg1+xsOgdB2 Lgwxh7Yg0WZ44+Tl/MYWcbP6LT4UbShDcIvK0X0khgenMfE9Zd+qpjNGe3RPUVHl6B0xFj m5xJ1Bk1fHQbz+OhxWeVYbxo7OqxJ6c= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of yang.yang29@zte.com.cn designates 183.62.165.209 as permitted sender) smtp.mailfrom=yang.yang29@zte.com.cn; dmarc=pass (policy=none) header.from=zte.com.cn ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675491543; a=rsa-sha256; cv=none; b=GlEX9gTrKO2Sa21cJkpV+3yu6WpU1V/Hce75EM7Ro40hKZnJDlTF2/bmcdXmWTWZDeWHCk XVouMFcXD6MgKKk/Mr7QV6PAC3SgafXccauiae42CIbS3juv3GlB0wKcfL0zREz6zygcYC qTZser1zkZnWLYjuSgyRxv9tEbZcPe8= Received: from mse-fl1.zte.com.cn (unknown [10.5.228.132]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mxct.zte.com.cn (FangMail) with ESMTPS id 4P82R54Ksxz4y3Zn; Sat, 4 Feb 2023 14:18:57 +0800 (CST) Received: from szxlzmapp06.zte.com.cn ([10.5.230.252]) by mse-fl1.zte.com.cn with SMTP id 3145WsHw015648; Sat, 4 Feb 2023 14:18:33 +0800 (+08) (envelope-from yang.yang29@zte.com.cn) Received: from mapi (szxlzmapp01[null]) by mapi (Zmail) with MAPI id mid14; Sat, 4 Feb 2023 14:18:35 +0800 (CST) Date: Sat, 4 Feb 2023 14:18:35 +0800 (CST) X-Zmail-TransId: 2b0363ddf8bbffffffffaca1c72a X-Mailer: Zmail v1.0 Message-ID: <202302041418359766772@zte.com.cn> In-Reply-To: <60125c55-9ab7-7531-e124-cb676943fea6@redhat.com> References: 202212300913573751808@zte.com.cn,60125c55-9ab7-7531-e124-cb676943fea6@redhat.com Mime-Version: 1.0 From: To: Cc: , , , , , , , Subject: =?UTF-8?B?UmU6IFtQQVRDSCB2NSAyLzZdIGtzbTogc3VwcG9ydCB1bnNoYXJpbmcgemVybyBwYWdlcyBwbGFjZWQgYnkgS1NN?= Content-Type: text/plain; charset="UTF-8" X-MAIL:mse-fl1.zte.com.cn 3145WsHw015648 X-Fangmail-Gw-Spam-Type: 0 X-Fangmail-Anti-Spam-Filtered: true X-Fangmail-MID-QID: 63DDF8D1.000/4P82R54Ksxz4y3Zn X-Stat-Signature: z1ekdodqpa7eu8z6rf9m59fu9a818ehs X-Rspam-User: X-Rspamd-Queue-Id: 32BA4A0006 X-Rspamd-Server: rspam06 X-HE-Tag: 1675491541-55856 X-HE-Meta: U2FsdGVkX1/XB3GC7HFSU1/AXQhj4cvmQOeussngN/dBkviWbS21urFAmd5UJYO79RrKHYLiKB9M9Jsm9miLSoJAwdMciNOIKL4JtrTFCh9HP+SXDcOG0B+3KDwhSF8jijUdbie2rpG+CY0+cPd3UfY+nsv84eRoOt/fo7ZcDJ6ux2yYduupPKfcs5xHN0Oovx5RjFpjNeyBKr+IM8EUdFe5XCM82ZiDK0NusEQV5jhBM65x/OJ18nOvNg3Q7jT/XNz4aFmHue7Aoe6QHPM+OICbv0piUrpIpcS1ZM2x64Di4hLxPEYJSWdQSRii8KpyawWN4aIJVoQi3he52lHWfNDBXR4VpBS8cpJQynNKufjrk9G0vNDNMRoAIl0PrdBmEJYB9KRpLqD3abC0o2EprhkD9qzlUpNRlUdoi1z8ZeUm/2ji6wT+zRwbbEydP9AyUnghA1rMWZtKIummDuO5CRGWeGHSHdnCgXER0pm3Azt8HB13nNprXMVVjn0ZMS+u5IUeo0EQoW6JkXM85XpZiTXfTrPzcUjQqbYY9h6thabpHgcDsVGJW7pFFLwP8mQfhHkB9CB31AewRb/Mzw8fNVCJ7kuVIQL3kwThDkoYmXPqcAXehs0cQcfRUPn8E6LOLzeTCim6CaxzzeX62oX5pyoz4t9fsjHXwZsSArtIiP/BcnadB2ENqcfeA4s3bNlVKuBX36vkT3m0DW4mO/cd5ugLU7J/u3UKBWrbN3P1cwXy5jop/ax22KxbnGb2Lqdfm7Ae6zc+ySL1MXG5rovHDNaHwfu0kCSr1v8lXZmQal0drUkw4c3bTXfg2AOMhltiWaUxMCbPj0UBJkr8uzlBjfjrdn2HD3HdBHQKjZfZvOWwp9cU87ErL+7gppGfjN4jXC2uYtGod+R5gSUD9hYBJcES0o01inLBDwJ7NdUtnF7yuFtw9kldO4NBQ7oCYXNQkrX2hcuQ2sH5JbxNS7w n23J88EM 87iDll2pUbOI60sL+J4TTc43Grfh6pQj4l/ponxONp5YOtrJwJtxCX74QOOwLvkdFgncbhBVA0L+aINLDRxUaBWmxOByQyi4R9QpnFUKfJM3RFRRZbGaQyyTfGayfeiqqZwNJOzPkPv6vRHjafDfvuCpOKUB7smJrzLlFMYeEibQ8FZnYbVqapRpnoZ27NgB13QSe865p9iyQPYNCFZanV/Ok5czPeH4RRagJgyqZJaoppV2R8U9ZIYYyElvWpBlW00oaEsO2bA+e9SMBBdoxmcGtyyqaADkrEZowkGnni77KP5vR1xwH8kg3bScinmXtH54a0HXJMySe+OBqFCNETU11Gw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: > Why use flags if they both conditions are mutually exclusive? Just to make the return value of break_ksm_pmd_entry() more expressive and understandable. because break_ksm_pmd_entry have three types of returned values (0, 1, 2). > MADV_UNMERGEABLE -> unmerge_ksm_pages() will never unshare the shared > zeropage? I thought the patch description mentions that that is one of > the goals? No, MADV_UNMERGEABLE will trigger KSM to unshare the shared zeropages in the context of "get_next_rmap_item() -> unshare_zero_pages(), but not directly in the context of " madvise()-> unmerge_ksm_pages() ". The reason for this is to avoid increasing long delays of madvise() calling on unsharing zero pages.