From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 65E1AC61DA4 for ; Fri, 3 Feb 2023 14:17:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BAB226B0072; Fri, 3 Feb 2023 09:17:36 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B65F76B0073; Fri, 3 Feb 2023 09:17:36 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FBAE6B0074; Fri, 3 Feb 2023 09:17:36 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 8DD1C6B0072 for ; Fri, 3 Feb 2023 09:17:36 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 3FAD81A0201 for ; Fri, 3 Feb 2023 14:17:36 +0000 (UTC) X-FDA: 80426183712.24.119FCEB Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by imf11.hostedemail.com (Postfix) with ESMTP id 236E240006 for ; Fri, 3 Feb 2023 14:17:33 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b=JNZb6P36; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=hKEIfQfe; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.25 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675433854; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c/4NwnfyZ/yTFhItgM0rIBtdtMRRDh+qfg+UrASpJuY=; b=wjhMDGIat/E84d6pgEZbVh0wE7ro8tp3oVnSpZywH/ytGrK0g1znPc+4F9CC3CT388S4K0 apXD0aX0BB+A1UPL2vO7DphpiHC8i1TknR5dDBELQbkOg6d3hKazlBD/HinSf5NB4QyjD2 bffm2FcBb9CC01Y3614ylss9mZ9qI44= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=shutemov.name header.s=fm2 header.b=JNZb6P36; dkim=pass header.d=messagingengine.com header.s=fm3 header.b=hKEIfQfe; spf=pass (imf11.hostedemail.com: domain of kirill@shutemov.name designates 66.111.4.25 as permitted sender) smtp.mailfrom=kirill@shutemov.name; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675433854; a=rsa-sha256; cv=none; b=UeCuGaD1ntqc5ED/tZ8a0TvGZdG0S+rRiG1S8ND5GB6qzStk++eFgKIaex15vr2b8lqCuJ 9HB10/6kd6JomOguSU7f7pU7me4hUBgPPQm+XAJbFrC1y60IebsVOeXW1RUhrfo1aa42fM jVZJmwpm3a3nKoJoDpMipZdUX+n8Vy4= Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailout.nyi.internal (Postfix) with ESMTP id 8FC425C010E; Fri, 3 Feb 2023 09:17:33 -0500 (EST) Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Fri, 03 Feb 2023 09:17:33 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=shutemov.name; h=cc:cc:content-type:date:date:from:from:in-reply-to :in-reply-to:message-id:mime-version:references:reply-to:sender :subject:subject:to:to; s=fm2; t=1675433853; x=1675520253; bh=c/ 4NwnfyZ/yTFhItgM0rIBtdtMRRDh+qfg+UrASpJuY=; b=JNZb6P36CSEG4Hmr0Z fEc3VkdcSbRIqddNF0IvcSINyrdZY1zLO51zJwnzm6imRMbyGchIzVu78gjOWO88 ORRxTWAFXhThhCUia5NUm7GT2pPe/iIljLzKYf6z7MwUsSNM1T6PgHcDOsEyLutY p2HNw6QBnZ4JV9YFnqoFDVszaDZ1QjHDXUUzfPtaK8g/0aOMGtSzU7tIL8liE/R3 jGHJUdrH/JFQ3egVHNPNRjS59BQdmBNnPGeSSisOQexgoZt2vpj5ZMCMZz3wNvjB Pzhs9+cpPZXRXjFv1d2ipAAs4y+3yCYPTVp0UhTztCI6YV2sGUARd98Pg7UfJTD2 UvFQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-type:date:date:feedback-id :feedback-id:from:from:in-reply-to:in-reply-to:message-id :mime-version:references:reply-to:sender:subject:subject:to:to :x-me-proxy:x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s= fm3; t=1675433853; x=1675520253; bh=c/4NwnfyZ/yTFhItgM0rIBtdtMRR Dh+qfg+UrASpJuY=; b=hKEIfQfeAJRfwCHcipyW8dmyo6WgxcLX2SrrG1e3uHlX tdo1PZgDKaJKbvrkmBXbsd1GBWZzaBsEquSv6mx9o8setD2OOpXl/ymrOGRUYky2 D1nIbjraUjJriI/bgJh3Sij8ul2F6Asw4C3MrNq+GK+gUTRxKvmezn4ZLM/UfhJb E7MUFa2WcZYrR12N0z1cvG3JtNTpc8zsh4KGsOMgUtlrbQm3eiG0AfmB9mCrZz6f vBlGf/FxznLwCQg0rTppkoxiq0oXh7ePah197NjchF4oVhlV4E7rV3LAfrXa18uo 2zZC6zSlu5ix/Xo1lDtWrtQ2PPfUCEottW7gP1QMkQ== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrudegtddgheelucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvfevuffkfhggtggujgesthdttddttddtvdenucfhrhhomhepfdfmihhr ihhllhcutedrucfuhhhuthgvmhhovhdfuceokhhirhhilhhlsehshhhuthgvmhhovhdrnh grmhgvqeenucggtffrrghtthgvrhhnpefhieeghfdtfeehtdeftdehgfehuddtvdeuheet tddtheejueekjeegueeivdektdenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmh epmhgrihhlfhhrohhmpehkihhrihhllhesshhhuhhtvghmohhvrdhnrghmvg X-ME-Proxy: Feedback-ID: ie3994620:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 3 Feb 2023 09:17:32 -0500 (EST) Received: by box.shutemov.name (Postfix, from userid 1000) id 0635410DFD6; Fri, 3 Feb 2023 17:17:30 +0300 (+03) Date: Fri, 3 Feb 2023 17:17:29 +0300 From: "Kirill A. Shutemov" To: Yin Fengwei Cc: willy@infradead.org, david@redhat.com, linux-mm@kvack.org, dave.hansen@intel.com, tim.c.chen@intel.com, ying.huang@intel.com Subject: Re: [RFC PATCH v3 1/4] filemap: add function filemap_map_folio_range() Message-ID: <20230203141729.o3l4ry2rkoo3snhz@box.shutemov.name> References: <20230203131636.1648662-1-fengwei.yin@intel.com> <20230203131636.1648662-2-fengwei.yin@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230203131636.1648662-2-fengwei.yin@intel.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 236E240006 X-Stat-Signature: jo3s5qyzoowq8y444w66oafkzkqxuan8 X-Rspam-User: X-HE-Tag: 1675433853-462085 X-HE-Meta: U2FsdGVkX18xG0gHd4eGDf1LT5RqFJuoCS453QNEDPLLDLF6TFGFrj3gO6KrlDDF4gXBfRmexVqQQC7lPCDd6uwoxZuTp3T4UntEQUyEJdksdIT8YLxvD4WKiIxrzlncXYsHlPX+ZakqMky5lJWmZAhmUUtLEG4hfYiDAYVeSazeWh3qTyn/0N69bYySdcNlh920UDVRdWo9t4YPg3x4UunW+cKu4H4W6y68W7jZFFHo1CCfekFVwGyyIPkwYOFTqDoG+C0K8tWzPgK/MRrVS+bVIDveuV1NEzs80qTC4RDh8QEk+Gj6W41t4iGX4rFUXL5JhPEoHRNw/5GXIUsJoj1RsGHpXJJgGv4x4S0Yugk3iHk7KCPYYrI0xo5rsWOovnL3G7RoypYLGLjmPlyzOpDds5J9o0YGNFjHxc3iW4GjY8IIbzdjCSexiqLvP38GO9Gai7bAURa1eSdwyMJJvwHWS48uUYdY/0XxSZTX4AfZzVA2Lig5k/DMnOJkPyshTnkdueUbczmQEeC7pOeJ+/703xDID8rLxaDlFTJOYKxHP/BMCwC3OHtJ2140RvCSoZA1ONAI+a6lu/JI9L8orG5FjOzxi+N4MDdv/iHAKd10dJDb2B4GsoBs9vh/mmDOoKn2/ijLGHklQh/u3PViHXgGgdb9rRmy1KbzokXsEFiqW3+H8Ug/Ud1prmczipIbr3dRQcfk/oxd+TvtwEOOT5WPxiWKGUviRXFylYvTsBreFaB25624jGQ/VSfto2o6eGN8gobauqnRaYsWiQc3Q83Balv+XzQwc3f8vRwyMw3rSKBpyjWHV6gJSrYZ+EEDinWXL7pZNQjbrsQxTmeShzwgUym9ofXDbEn6kwGhNt5th4FDIOQoYJXS8/no9CWTEkLjzR6wsKN6un1dJlBLq7Am9toNZlAaipbId3u2UhWbxXzKZDv+q9TdYgyxPhbbhCWNpFFV21q2CV+sgzy vIm+y9G5 40Fm3AJ/iY4MGsVDr4PvSEFaazAYYKrBZzWiRq3PUxqTjDhDZmgSOWsK51f8dMbFVfasl8Hbt2u4mBlyAIivsmpklNnVsG+/FyXsIADLeZjyx07Reu0JP3LzklVSGdNPeLPYfQqv2l1ZLuZR9U1BBoxIMMnuncDEBiL0MSZOYT6TvvLsSSgqzVg9MjQd5yoeTfeeJ7F1j3V6tuwZnarMjPplkkQH8apr1BZHspLPEKHDVf12dsiPXO05PP+GySm5I/8qNSE24NaQrvupnKAWaQL9c9tQAyqkhQQ+0w+kMX35QZSizAFxyXSsskn2OywhejEZgAtuaSdcMYpqVAudBLljmQazlGZ5fCOTd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Fri, Feb 03, 2023 at 09:16:33PM +0800, Yin Fengwei wrote: > @@ -3378,45 +3425,18 @@ vm_fault_t filemap_map_pages(struct vm_fault *vmf, > addr = vma->vm_start + ((start_pgoff - vma->vm_pgoff) << PAGE_SHIFT); > vmf->pte = pte_offset_map_lock(vma->vm_mm, vmf->pmd, addr, &vmf->ptl); > do { > -again: > - page = folio_file_page(folio, xas.xa_index); > - if (PageHWPoison(page)) > - goto unlock; > - > - if (mmap_miss > 0) > - mmap_miss--; > + unsigned long end; > > addr += (xas.xa_index - last_pgoff) << PAGE_SHIFT; > vmf->pte += xas.xa_index - last_pgoff; > last_pgoff = xas.xa_index; > + end = folio->index + folio_nr_pages(folio) - 1; > + nr_pages = min(end, end_pgoff) - xas.xa_index + 1; > > - /* > - * NOTE: If there're PTE markers, we'll leave them to be > - * handled in the specific fault path, and it'll prohibit the > - * fault-around logic. > - */ > - if (!pte_none(*vmf->pte)) > - goto unlock; > - > - /* We're about to handle the fault */ > - if (vmf->address == addr) > - ret = VM_FAULT_NOPAGE; > + ret |= filemap_map_folio_range(vmf, folio, > + xas.xa_index - folio->index, addr, nr_pages); > + xas.xa_index = end; IIRC, end here can be beyond end_pgoff. Can it cause an issue? I don't see it, but just in case. -- Kiryl Shutsemau / Kirill A. Shutemov