From: Longlong Xia <xialonglong1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<chenwandun@huawei.com>, <wangkefeng.wang@huawei.com>,
<sunnanyong@huawei.com>
Subject: [PATCH -next 0/3] cleanup of devtmpfs_*_node()
Date: Thu, 2 Feb 2023 03:10:43 +0000 [thread overview]
Message-ID: <20230202031046.1224338-1-xialonglong1@huawei.com> (raw)
In one test, when modprobe zram, no zram device was found in the /dev.
But don't see any errors printed in jouranls/dmesg. Later we found out
that the reason was that device_add() did not check its return value when
calling devtmpfs_create_node(). So we hope to turn devtmpfs_*_node() &
devtmpfs_submit_req() into a function with no return value, and add some
debug info in the handle() that actually processes the request to let the
user know why the creation was not successful.
Patch [1] devtmpfs: convert to pr_fmt.
Patch [2] devtmpfs: add debug info to handle().
Patch [3] devtmpfs: Remove return value of devtmpfs_*_node() &
devtmpfs_submit_req().
Longlong Xia (3):
devtmpfs: convert to pr_fmt
devtmpfs: add debug info to handle()
devtmpfs: remove return value of devtmpfs_*_node() &
devtmpfs_submit_req()
drivers/base/base.h | 8 +++----
drivers/base/devtmpfs.c | 48 +++++++++++++++++++++++------------------
2 files changed, 31 insertions(+), 25 deletions(-)
--
2.25.1
next reply other threads:[~2023-02-02 3:12 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-02-02 3:10 Longlong Xia [this message]
2023-02-02 3:10 ` [PATCH -next 1/3] devtmpfs: convert to pr_fmt Longlong Xia
2023-02-02 3:10 ` [PATCH -next 2/3] devtmpfs: add debug info to handle() Longlong Xia
2023-02-02 3:10 ` [PATCH -next 3/3] devtmpfs: remove return value of devtmpfs_*_node() & devtmpfs_submit_req() Longlong Xia
2023-02-02 4:47 ` Re:[PATCH -next] cleanup of devtmpfs_*_node() Longlong Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230202031046.1224338-1-xialonglong1@huawei.com \
--to=xialonglong1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=chenwandun@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=sunnanyong@huawei.com \
--cc=wangkefeng.wang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox