From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E7ECDC636CD for ; Thu, 2 Feb 2023 01:48:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 64FB06B0087; Wed, 1 Feb 2023 20:48:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5FF636B0089; Wed, 1 Feb 2023 20:48:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4EEB56B008A; Wed, 1 Feb 2023 20:48:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 3EEC16B0087 for ; Wed, 1 Feb 2023 20:48:31 -0500 (EST) Received: from smtpin12.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 1157840D4F for ; Thu, 2 Feb 2023 01:48:31 +0000 (UTC) X-FDA: 80420667222.12.726F05A Received: from r3-17.sinamail.sina.com.cn (r3-17.sinamail.sina.com.cn [202.108.3.17]) by imf25.hostedemail.com (Postfix) with ESMTP id C84DCA0011 for ; Thu, 2 Feb 2023 01:48:26 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.17 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675302509; a=rsa-sha256; cv=none; b=dT5/LedsJcuhs3XLAbhDoa1H0BOkbN2WlSwQ2DtPv1HH+lhIL0BWp4cpGyQAMh5yVLFwWB re7+I28XpxpslIQPxW0a8lQ52feYtAW2Lr1GSDVl6h1jIfUaIBezJrJYwpc3eCFz7cVmFe R3EitfmcLdy1KDX6UC53WDZNThbwf8Y= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=none; spf=pass (imf25.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.17 as permitted sender) smtp.mailfrom=hdanton@sina.com; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675302509; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=08wVFVKHU0g7WQx2dt7rYHiDZjEac/GnZOI/E+C5COk=; b=Tqllent//njLyYOub9L/2du8dwg8KVQ0J4ajC3eF53xok6TclZQnqeC6Xgp91OqpEyhk7N 5/CmrdJ+i+FHa0OEAUYJwPz0+LFdboQ7qkuyn8OhtMxqTNGHldSxoUb/scYwxKZKXOX5AW VulzY0BKqRUnpxDrERMqFutRtJFlASs= Received: from unknown (HELO localhost.localdomain)([114.249.61.130]) by sina.com (172.16.97.27) with ESMTP id 63DB15F400019249; Thu, 2 Feb 2023 09:46:30 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 26240149292577 From: Hillf Danton To: aloktiagi Cc: ebiederm@xmission.com, edumazet@google.com, netdev@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [RFC] net: add new socket option SO_SETNETNS Date: Thu, 2 Feb 2023 09:48:10 +0800 Message-Id: <20230202014810.744-1-hdanton@sina.com> In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: C84DCA0011 X-Rspamd-Server: rspam01 X-Stat-Signature: hehmq9u1hersoze6mgm5ghauhggoxzxw X-HE-Tag: 1675302506-482378 X-HE-Meta: U2FsdGVkX1/Xj2hofzWiXb30fJ7keFACgpkEvekzmpP7l25ZI0C7DaoMvpuXYxGpBqmJxZlDRhPSN6gZmY22ACe5L2RoJt/tl4Wwn4dZ6Che1atxsZczUuVzqa7lZD/C2BQ58O3ANeJZCl2CkXeFJZ/BTeue+YhFcPjzHFhNTMD1BNDhq2ERVb25sxxk8AQ2XLDu6ApOob/FICmlse2miyS7/VVJItiXRLuv5ydp3Aka8sLX0NEMhhDam4FaoWw20qgjhxuGsu2BobghO0AUMnB4dapkSLTl598kJ2Hr+JzImuyNo50TwCCg11YHmJrccmjRTOA21l30I+eoGjl9g1F986p4iQCjgnpiACTxNMniW+r/2gfTt5ZB/sgNdTpMPqTwFUecSRu0rOiVAzmR+Y6jnYTS9545ZcjSILECkn+HalO+kZEuSzGuTemxqLB94YnPZN1jmlokI4RSlphMTKQqkOyhfK5EHkk+eXX1izSq4vAijBvYCkcoGTi1O9VEsqwdBSJdRRbcjcLZ3uEyPZSg3wZ54PSmTzm1p+J5agwyXoM8F2T/Mr+dqlMcpbp2IhCamn2CFeRapfoheA8P2wWRt/lM1wMED0azh9Ib2lB5onqxAXA2nN5Ny0mgUBtrTiJdFZVsNHjaM/o5/y/ef2evNvD0fzL8MFcSBTGcCTerfJ1MXPv9H80JovPDP2b+3ueNfuJVmsqAKLkao4FJhPJmtLSufKZ4EvF4icCB4TsOX331daTJHWqpJS7iZgntQefNSVDKc5IS1NjAn2qtQHB6kCbxQ83gc/ypyW9B4iRgvcCTudFGyA61JvVFJLD4ej5PwlcjYSRLmZLHH/7QJxd0HJDR2L/wXUb0QwxamSY7yO6e2KRIsoPoswFrGR8RuoJ3apIJiTnHsNQMRpiXA0hoNkGhobSFp399OvupiBGk6ndIfL2+dj/33D77SIlu8+yeSQlzJNDawlIVHaV o+v9pgMF BN5zwgPXr0xPnuyGA3r3ZRccEgy0VqYEcRq/hEnt47QzJqM/6kyVkz/MdRBnE9ipJQKyJrpxVDxrp+Y9NJ35vomuOdSh5IVdhoYOj9qKzpMGfe8BCdJyVn1jt9cqVfl5e/+A3dbH1zbt/Gotm24XzHKMav0kVEE38MSlmvnubEFZ9cmA= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, 1 Feb 2023 19:22:57 +0000 aloktiagi > @@ -1535,6 +1535,52 @@ int sk_setsockopt(struct sock *sk, int level, int optname, > WRITE_ONCE(sk->sk_txrehash, (u8)val); > break; > > + case SO_SETNETNS: > + { > + struct net *other_ns, *my_ns; > + > + if (sk->sk_family != AF_INET && sk->sk_family != AF_INET6) { > + ret = -EOPNOTSUPP; > + break; > + } > + > + if (sk->sk_type != SOCK_STREAM && sk->sk_type != SOCK_DGRAM) { > + ret = -EOPNOTSUPP; > + break; > + } > + > + other_ns = get_net_ns_by_fd(val); > + if (IS_ERR(other_ns)) { > + ret = PTR_ERR(other_ns); > + break; > + } > + > + if (!ns_capable(other_ns->user_ns, CAP_NET_ADMIN)) { > + ret = -EPERM; > + goto out_err; > + } > + > + /* check that the socket has never been connected or recently disconnected */ > + if (sk->sk_state != TCP_CLOSE || sk->sk_shutdown & SHUTDOWN_MASK) { > + ret = -EOPNOTSUPP; > + goto out_err; > + } > + > + /* check that the socket is not bound to an interface*/ > + if (sk->sk_bound_dev_if != 0) { > + ret = -EOPNOTSUPP; > + goto out_err; > + } > + > + my_ns = sock_net(sk); > + sock_net_set(sk, other_ns); > + put_net(my_ns); > + break; cpu 0 cpu 2 --- --- ns = sock_net(sk); my_ns = sock_net(sk); sock_net_set(sk, other_ns); put_net(my_ns); ns is invalid ? > +out_err: > + put_net(other_ns); > + break; > + } > + > default: > ret = -ENOPROTOOPT; > break;