From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C06DAC38142 for ; Wed, 1 Feb 2023 07:05:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3A9F06B0072; Wed, 1 Feb 2023 02:05:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 359766B0074; Wed, 1 Feb 2023 02:05:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 248F76B0075; Wed, 1 Feb 2023 02:05:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 16EFC6B0072 for ; Wed, 1 Feb 2023 02:05:33 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E84241401AE for ; Wed, 1 Feb 2023 07:05:30 +0000 (UTC) X-FDA: 80417837220.25.C9596CD Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) by imf02.hostedemail.com (Postfix) with ESMTP id 0DB4280009 for ; Wed, 1 Feb 2023 07:05:27 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="f/j+v8er"; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675235129; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=vKxS4z6O4WGg6MpIeEk/2z3NLu/yFvVk/ob1xiLv/9U=; b=ZvP8sH49wwlIfEWX5cv2QM55FH8qYOnc+e0ADAlYF9GlCV+JXXB1XYQQlS/gyVLmlLstGA UKozutcZteLvmc36eJYIQHWAYitqzp6fwqYqtEMH8hKKP5a5i2dcbs7CgqlTRy8J7Izbyw LGVOT8+OBFXf6lCqV+3doecZ8DJnifc= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=intel.com header.s=Intel header.b="f/j+v8er"; spf=pass (imf02.hostedemail.com: domain of lkp@intel.com designates 192.55.52.120 as permitted sender) smtp.mailfrom=lkp@intel.com; dmarc=pass (policy=none) header.from=intel.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675235129; a=rsa-sha256; cv=none; b=FKiv7z+TSoCReWsv21cjeSKdzagi0s0VoWV39AFvBci/qjKJNEW6tGJxmktyWU+eQlewxb mQGiGm7uh+ws1vYUfIjmU1WVvOgwDj0OpTc5Vutc/TxM0JaxvlEUzyYj5p0Qo0pUomJ4oF e7vZ4YszNd2hPfH7OxcP2dlPrkm93u4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1675235128; x=1706771128; h=date:from:to:cc:subject:message-id:references: mime-version:in-reply-to; bh=z5PhnpmOAJuOc0Bq/L9mnpqUibI5L8+buBwNICS6zF8=; b=f/j+v8erKk1Vk7n8LI3A8cHLDKjbb6hMj9DvRF+84lAqx85od7d57XCz jacJT3l8AJdfa1AhIY+qwPczgYUqk9iX8YcsXg1+AwpS56FmDEXAjAmlN 6+vU/fKm3HX7qQl6DIk0nniq2BHIXk5/7Wq1s9kTFWQKItxxNVJ0N9Oxd co5uNJLSxyl4YTy880bU0QXfHIuaouPkyy3vvdYaBtRmXFkLdNABUF3F2 lDvMHU7I3ivgzl55+HR1dRvTEDOL57a4HG0EZH54PoyQ6tEBJDQ3xmTf5 wu8jzSDDwXuTn2OMACdJHUu3jQkoNJyQ7W+tFz+K5rHjfWXywacAI59Bs w==; X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="326724093" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="326724093" Received: from orsmga006.jf.intel.com ([10.7.209.51]) by fmsmga104.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 31 Jan 2023 23:05:23 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=McAfee;i="6500,9779,10607"; a="642303771" X-IronPort-AV: E=Sophos;i="5.97,263,1669104000"; d="scan'208";a="642303771" Received: from lkp-server01.sh.intel.com (HELO ffa7f14d1d0f) ([10.239.97.150]) by orsmga006.jf.intel.com with ESMTP; 31 Jan 2023 23:05:12 -0800 Received: from kbuild by ffa7f14d1d0f with local (Exim 4.96) (envelope-from ) id 1pN7B9-0005CK-2j; Wed, 01 Feb 2023 07:05:11 +0000 Date: Wed, 1 Feb 2023 15:04:58 +0800 From: kernel test robot To: Muhammad Usama Anjum , Peter Xu , David Hildenbrand , Andrew Morton , =?utf-8?B?TWljaGHFgiBNaXJvc8WCYXc=?= , Andrei Vagin , Danylo Mocherniuk , Paul Gofman , Cyrill Gorcunov Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev, Linux Memory Management List , Alexander Viro , Shuah Khan , Christian Brauner , Yang Shi , Vlastimil Babka , "Liam R . Howlett" , Yun Zhou , Suren Baghdasaryan , Alex Sierra , Muhammad Usama Anjum , Matthew Wilcox , Pasha Tatashin , Mike Rapoport , Nadav Amit , Axel Rasmussen , "Gustavo A . R . Silva" , Dan Williams , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kselftest@vger.kernel.org, Greg KH Subject: Re: [PATCH v9 2/3] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs Message-ID: <202302011447.7lSFpVO5-lkp@intel.com> References: <20230131083257.3302830-3-usama.anjum@collabora.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230131083257.3302830-3-usama.anjum@collabora.com> X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 0DB4280009 X-Stat-Signature: hk7fxp9yeqcktj957aaatjec9ff439c5 X-Rspam-User: X-HE-Tag: 1675235127-575318 X-HE-Meta: U2FsdGVkX1+NiYt+l0xosuMFK6SQ95BIfOzCfKO8nNE2LVPe04Q4suHkZCQfSsp3+J3+x5KQ/HxeymKfpuGQKUtXVKXU3vsRCTcceUxvS1dCf1GT4x7z4n4xnupJCPG79aDjB3NsmlwDOjTquVAq0yj2gxitbpgtelLRZghFI5rlcJptVJMj6cOaoax6/CfW9sShL0sbJVKgz91fQKSbXVn/0aLTL48O7vBzqrPpseBpdpjtvBT9en0DJAkOFGRi0X+DWCl+qI6bRYiCfxgpr2o3Auhh2AkRA2/nWB92MDVbsGVA7HgpeSuJ8GSlkTeisF+Mwv1/aBDLTKtX2o8XPIJXHpUb5eaJcUXsV9qQALxMIiFB4Wk9DiPS9DP5TDzlfyBRDzvLZQ17FfY9EEzR1HEvVpoG9gRI3jJ8GLJ7xbmEsH+FX0WluI1DeMfJa21ABx+aWJgKqHm1CkWDffF1g4jb4eYY8IcSOtS+teSXByj2AhGS6SGEa0GbK2avGn6rUGh/9BIfL0mYtLWXEAibyJ3/Dbm4ChGVC2YLnLSro3Zf8ctpbaGxvKCJqDoZGyKFOlrj/nMRM/4yY4XXMwlYH2RU58VutMBCB5Xap5Lw8zvZUNt76Vl9ACHOKT/QYpBm3NW1k9fYxTRw2rOflBOTemyBY8GupNb968BP/C7UhEufdgwccU3vrsBXq6oktUYV5tAsdp6i/lNuZQFwHRDnkeNyNzkRtXKiId+iheffy+5UV6JcpiioNfMSvh3Gy2SmkJC9GjvdOIYZt0pAUInIu5GY0/tlRwRWdv51mMaGn4+pb+vG6zGSQwzfZCTLGdWrjlQ3QdYX59Yuucf1e2jkd/Ds4c6XzsZ4et87TKyyP3aKubZSG6fGwY0Vh0l3w8+M2MQIYuTg9f+L8ZuZKM0xype+XJ7aK/cOVKXk681Hx3MFbAoHGdDVh+NKqDAdn54ft6P6+GDNi91DP7noaiV QtdRPRDO ClgO01D82JOAf8z/BXbEhqAAxw7TNIZ172N9m6N0lUQT8i8AquOUWQ9kyV6+N2+ffmHhPqEaaGVf4Qv869rlsNGZGn1vTq6OXqu4Ys50w2Za6pMRX9wlCaviuBJ5smmufVwB/yoRg80tANS681trfW2Dm6iJb7ddQLpY/UnqRKzOl4Rd2eExHAyLXMD2PvHjChoITpDFJHh9hQjq8lO3P4XZrSCugPwyXAIF0wwXrmiWCE2muVbTP5LggSX1Cae0m1F6bmi0LpKNtxHX1tYHd9OxLu5uESC9RCtdUQF39c39kVuWtC62quTkyJtPqQwNiNct9DYaY+3gkm6tBW6oIVJQWxXHugks2oiXi68OObUf40uS7i+OC+TcXPN0Dw9dcMFapbQ+SGUONM7IAhf5BuPwp2eEgD5du6/5RiI/Gj4UNusc92al9l0wh2tuTPL/QDJySsYtnTg36+2uOx1s50/33J2mtuCh3FDA+RwsATC6eMQg5G6LCiL6fxugdGQQaYDvyvVwLpzxODDU= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Muhammad, Thank you for the patch! Yet something to improve: [auto build test ERROR on shuah-kselftest/fixes] [also build test ERROR on linus/master v6.2-rc6] [cannot apply to shuah-kselftest/next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Muhammad-Usama-Anjum/userfaultfd-Add-UFFD-WP-Async-support/20230131-163537 base: https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git fixes patch link: https://lore.kernel.org/r/20230131083257.3302830-3-usama.anjum%40collabora.com patch subject: [PATCH v9 2/3] fs/proc/task_mmu: Implement IOCTL to get and/or the clear info about PTEs config: x86_64-rhel-8.3-rust (https://download.01.org/0day-ci/archive/20230201/202302011447.7lSFpVO5-lkp@intel.com/config) compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project f28c006a5895fc0e329fe15fead81e37457cb1d1) reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/11677b6b7fda958031115ea40aa219fc32c7dea4 git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Muhammad-Usama-Anjum/userfaultfd-Add-UFFD-WP-Async-support/20230131-163537 git checkout 11677b6b7fda958031115ea40aa219fc32c7dea4 # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=clang make.cross W=1 O=build_dir ARCH=x86_64 SHELL=/bin/bash fs/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> fs/proc/task_mmu.c:1907:5: error: implicit declaration of function 'uffd_wp_range' is invalid in C99 [-Werror,-Wimplicit-function-declaration] uffd_wp_range(walk->mm, vma, start, HPAGE_SIZE, true); ^ fs/proc/task_mmu.c:1927:3: error: implicit declaration of function 'uffd_wp_range' is invalid in C99 [-Werror,-Wimplicit-function-declaration] uffd_wp_range(walk->mm, vma, start, addr - start, true); ^ 2 errors generated. vim +/uffd_wp_range +1907 fs/proc/task_mmu.c 1874 1875 static inline int pagemap_scan_pmd_entry(pmd_t *pmd, unsigned long start, 1876 unsigned long end, struct mm_walk *walk) 1877 { 1878 struct pagemap_scan_private *p = walk->private; 1879 struct vm_area_struct *vma = walk->vma; 1880 unsigned long addr = end; 1881 spinlock_t *ptl; 1882 int ret = 0; 1883 pte_t *pte; 1884 1885 #ifdef CONFIG_TRANSPARENT_HUGEPAGE 1886 ptl = pmd_trans_huge_lock(pmd, vma); 1887 if (ptl) { 1888 bool pmd_wt; 1889 1890 pmd_wt = !is_pmd_uffd_wp(*pmd); 1891 /* 1892 * Break huge page into small pages if operation needs to be performed is 1893 * on a portion of the huge page. 1894 */ 1895 if (pmd_wt && IS_WP_ENGAGE_OP(p) && (end - start < HPAGE_SIZE)) { 1896 spin_unlock(ptl); 1897 split_huge_pmd(vma, pmd, start); 1898 goto process_smaller_pages; 1899 } 1900 if (IS_GET_OP(p)) 1901 ret = pagemap_scan_output(pmd_wt, vma->vm_file, pmd_present(*pmd), 1902 is_swap_pmd(*pmd), p, start, 1903 (end - start)/PAGE_SIZE); 1904 spin_unlock(ptl); 1905 if (!ret) { 1906 if (pmd_wt && IS_WP_ENGAGE_OP(p)) > 1907 uffd_wp_range(walk->mm, vma, start, HPAGE_SIZE, true); 1908 } 1909 return ret; 1910 } 1911 process_smaller_pages: 1912 if (pmd_trans_unstable(pmd)) 1913 return 0; 1914 #endif /* CONFIG_TRANSPARENT_HUGEPAGE */ 1915 1916 pte = pte_offset_map_lock(vma->vm_mm, pmd, start, &ptl); 1917 if (IS_GET_OP(p)) { 1918 for (addr = start; addr < end; pte++, addr += PAGE_SIZE) { 1919 ret = pagemap_scan_output(!is_pte_uffd_wp(*pte), vma->vm_file, 1920 pte_present(*pte), is_swap_pte(*pte), p, addr, 1); 1921 if (ret) 1922 break; 1923 } 1924 } 1925 pte_unmap_unlock(pte - 1, ptl); 1926 if ((!ret || ret == -ENOSPC) && IS_WP_ENGAGE_OP(p) && (addr - start)) 1927 uffd_wp_range(walk->mm, vma, start, addr - start, true); 1928 1929 cond_resched(); 1930 return ret; 1931 } 1932 -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests