From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1F785C636D3 for ; Wed, 1 Feb 2023 11:51:51 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8781D6B0074; Wed, 1 Feb 2023 06:51:50 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 827226B0075; Wed, 1 Feb 2023 06:51:50 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6EECA6B0078; Wed, 1 Feb 2023 06:51:50 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 5F1C16B0074 for ; Wed, 1 Feb 2023 06:51:50 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 267CF40963 for ; Wed, 1 Feb 2023 11:51:50 +0000 (UTC) X-FDA: 80418558780.19.EF1FEE7 Received: from mail-pf1-f179.google.com (mail-pf1-f179.google.com [209.85.210.179]) by imf29.hostedemail.com (Postfix) with ESMTP id 6A279120004 for ; Wed, 1 Feb 2023 11:51:48 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qcfksjVR; spf=pass (imf29.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675252308; a=rsa-sha256; cv=none; b=bzL+3dcRv+E1twWosw1KvFig2e7Lq4PjbnwAOP6IA01nmG6ihDC6sAMUQg32Nd+mPR4nkl umh0C+BZVmKg9MSoykrfhdDTxHU5bTWIBNXJOwM4ZLhQwmXpb9cZC0JSA5csTFBFhDeyPD OPd4HSTnRAzHtNnYuY5T0y1KlW54U6A= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=qcfksjVR; spf=pass (imf29.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.210.179 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675252308; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=SlGu/yguMdOnorRbAMGf2/LPCl7TfmrafuP3w+VjRZY=; b=Zhd7MaJElyaCpQFl4IRjLF85joSDhXSjoXTIV6xHhdziLrSrc2jnFHgmzSALKpNu+3d9sf Jxc8qGrcrOB32eqayDUzcVAuOfM5lTd1IwXYhson70YINVEbI3xYmVSWvqXpLCBT3I/pTs UtStdEsFP6VOsytHjux/ncBponZPSdA= Received: by mail-pf1-f179.google.com with SMTP id bd15so810553pfb.8 for ; Wed, 01 Feb 2023 03:51:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=SlGu/yguMdOnorRbAMGf2/LPCl7TfmrafuP3w+VjRZY=; b=qcfksjVRYHXXbFbWxhg4FV35oZcmFIR8xCcpzOz3Oc55PjYEki4RenvHgU1lxDZup/ FtNxEApg9HgN6naCG7UNBcU1qeSEtEeELMd9ToaJvHHeNHgaGET8Df8HxPZSbarzA/WZ BU2fIcI+iJt41Ordz+dBHmDPmw5t3FKrA6OeCL1RXyk5PZi6EPu6g3gcsPGewYK1wf8M L/QUzVXP/8341NgBlLQvXsGr07sFn3FlOYlFLo2Lq6/Ztbv6xsfB9J8M4YyMF7mm4fHL bb0HpXYy+fN0NCs6EGg/5ZuSnHSkOnIVxyYQdMWzIDbFMkm0BZM0tzsRYY/Obl1e5z2M QOOw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SlGu/yguMdOnorRbAMGf2/LPCl7TfmrafuP3w+VjRZY=; b=WqRTdPDLZ+eBRZRuu80zYppGb153cc3Iw5xC8CXZB9HPIheC3pQyla5zR/ypLnUZgF +lRJmi5+bNKHkAvJWwREdTgvvNwR9055OdBGqtFrg1fHkviMlsC3821t6CookIqeAFpm XsoOSvVoHHFkE6XBhHi8hveMpQ0T7KLymlOQ/v19v/+m9h5ByCu01H5+zeSReWRj7Ks9 G351Ev255FRbl1yRODnoX6sPYsKz96qnaKJGPmaVyU9nAHERFKR1OZO5KtzybD1/sD6u j/0GBQBgvnRF0ykgwVMO56N0qdOS40ngYI6586aQgKOboyhAwBlAnl3a1KcDc7DQ7Uyf GwXw== X-Gm-Message-State: AO0yUKWk6Ue/fBDP1nUGbCS+ZHNG9ogZd+ukFxR6UxnEp3UZM2YyWWVO METq3exPFk1UJlR2xwau09c= X-Google-Smtp-Source: AK7set+JXFrURQfeXo4giun6cXyoIz7ajUrc8QD9TTqDu7fnbzAcOFVVieNIVgiAB4AakpZU9C/hjQ== X-Received: by 2002:a62:1d4a:0:b0:58d:a981:b97c with SMTP id d71-20020a621d4a000000b0058da981b97cmr1701979pfd.34.1675252307320; Wed, 01 Feb 2023 03:51:47 -0800 (PST) Received: from min-iamroot ([210.91.70.133]) by smtp.gmail.com with ESMTPSA id g20-20020a056a001a1400b0058bc60dd98dsm4123488pfv.23.2023.02.01.03.51.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 03:51:46 -0800 (PST) Date: Wed, 1 Feb 2023 20:51:42 +0900 From: Hyunmin Lee To: Andrew Morton , Uladzislau Rezki , Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gwan-gyeong Mun , Jeungwoo Yoo , Sangyun Kim , Mike Rapoport , Christophe Leroy Subject: [PATCH v4] mm/vmalloc: replace BUG_ON to a simple if statement Message-ID: <20230201115142.GA7772@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Rspam-User: X-Rspamd-Queue-Id: 6A279120004 X-Rspamd-Server: rspam01 X-Stat-Signature: rfiteuopta8or6oxujco589bcbkr8opm X-HE-Tag: 1675252308-333059 X-HE-Meta: U2FsdGVkX19e9m8sEdE2GUmCBYm6rNZRpH15YEssbRfGFV9lDA1gU/o/BZSTJQ5YHpxupUOVHbfVAhUc/WjAOzqe7Tio0+G3MS1qNITv/2kKDfNE8Id3B6nWHujJzEFOGEtywyKz9mnCPa7YULj/wQmXmFhJHRAkg58QTSlOsQ3vveMZsskP3D6LcnHOgjj78+kJp+wFX/IDEqgODQwec0DD0UvMxkYPY/n7f87JvskeoeU54/mPefpXsbP1P7LCCRwKAMEd4hidES1CToWi/hTiQDzAYSqH3pD1ViOEKvjMb9/sTxDeoJUARAUmExUjVUXOoEyoJPvAoQwnKCSspVbGI71831K9tv1+VI69NQOHdg9EF4s9GeJ41SBmBU6JCKmk95ux6iDCAiFbyYMyJ//2/XMiy8b9qBHP6Wl9KexHnegFXsdhMtOOaq+SRMcPwupNSOx41RUaaJnoUKefShywFfkul1WSrafgwYKjc7KqdQ/BOFDEIxHbhBlLGNf+wNQ3VuKX8OETLyI1RKABKRc915sB/QEKKgpaxUUGPPeGbI4DbnQ5L08br/xyBhilzIap/8KSzTdL6xSmeB1UhkfJV5Zi79Kh49aO9aHUizPg6S8yoA6PGfTX65XotLIDoa/+vEHyeQIiflxF//jMKPpV8dChXXnW3Wa8HPNoz9mDHWDQ5iWrDluz09BkN/5XFoz+SGOkBFQfarXRLpkkOt+XeyK1CHU/1GmXVDrwufkOSryezfJU7kbY8JoNmAPiESN74RNQ9wQ6gRLg+cdxMZCvL/kITC/zogdBttdCgGPCJCFawJYe3HaUpLhpksxwmIXwgFhyJWAbo0E0tSCRME8Os47L+3uXlwZ7DaufAPSOpsf9UmhQSJefhM2hJNGvq6snT0CUSntMr7KUQw922mxc6MiDFSeBw8vsPRgfNSzzH5coUdVHW5ENLhcJbosvUyVbwnl6fkW9wb11tR1 pbi0I4mS oon1GvuThq/CVbfs96MzwJbLBQbuLfI0R9BRX4PGMNrO3OtGlGPJrE0y/OPWiskn29S7NPpomsQ9A8Qj8zZpg+pflulT+uLb+2KZPUetSK429i9tmnhKzFCPr3fIw1IcKBk7WXOB/MPlOdtCnmyGMRbNthRY8X6IKOHGAfEkdnw8EkUXi5Md7I7dZPugXEp9dsnh0s8iTWUeatLGaaL+Dxy+S+1wEI7yPNg2+Ux4C2582lWZPkgHgq9nim+ndtvaFfugQeMQhZaHD3mAT2MziKi6zboHek6j3kqbjC46GyGxJNhYRaj8CcpbIYwQgD0RCKJezdrq9tXcd0+OtDLl2/TKmF5MsGfhMR5nqvJl0NHitonxQED67xcSC8ll0MQRLyHcd9w4FwYBCoUf70jyutXS7lfdpogDGN5nYG8EkQs+2r5u+RqLdG/XHGLhtf3aQk3vNf30taxqnAdPvEXT4sJLSkHCTIFstdXG8UgdfnLfgGOmZOXwDeKjOj6V+DyIjGv9OE6zaOogzCbxq4FNyuMd4FVAdaoN2cIakCrYfs4vMR/qcnHyN6m5iabb2tRLo7ict X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As per the coding standards, in the event of an abnormal condition that should not occur under normal circumstances, the kernel should attempt recovery and proceed with execution, rather than halting the machine. Specifically, in the alloc_vmap_area() function, use a simple if() instead of using BUG_ON() halting the machine. Co-Developed-by: Gwan-gyeong Mun Co-Developed-by: Jeungwoo Yoo Co-Developed-by: Sangyun Kim Signed-off-by: Hyunmin Lee Signed-off-by: Gwan-gyeong Mun Signed-off-by: Jeungwoo Yoo Signed-off-by: Sangyun Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- v1->v2 : Add commit description v2->v3 : Change WARN_ON() to if() v3->v4 : Use only one if() for three conditions --- mm/vmalloc.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 74afa2208558..3b7e8856be35 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1587,9 +1587,8 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, int purged = 0; int ret; - BUG_ON(!size); - BUG_ON(offset_in_page(size)); - BUG_ON(!is_power_of_2(align)); + if (unlikely(!size || offset_in_page(size) || !is_power_of_2(align))) + return ERR_PTR(-EINVAL); if (unlikely(!vmap_initialized)) return ERR_PTR(-EBUSY); -- 2.25.1