From: kernel test robot <lkp@intel.com>
To: Byungchul Park <max.byungchul.park@gmail.com>,
linux-kernel@vger.kernel.org
Cc: oe-kbuild-all@lists.linux.dev, torvalds@linux-foundation.org,
damien.lemoal@opensource.wdc.com, linux-ide@vger.kernel.org,
adilger.kernel@dilger.ca, linux-ext4@vger.kernel.org,
mingo@redhat.com, peterz@infradead.org, will@kernel.org,
tglx@linutronix.de, rostedt@goodmis.org, joel@joelfernandes.org,
sashal@kernel.org, daniel.vetter@ffwll.ch, duyuyang@gmail.com,
johannes.berg@intel.com, tj@kernel.org, tytso@mit.edu,
willy@infradead.org, david@fromorbit.com, amir73il@gmail.com,
gregkh@linuxfoundation.org, kernel-team@lge.com,
linux-mm@kvack.org, akpm@linux-foundation.org, mhocko@kernel.org,
minchan@kernel.org, hannes@cmpxchg.org, vdavydov.dev@gmail.com,
sj@kernel.org
Subject: Re: [PATCH v9 07/25] dept: Apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete()
Date: Wed, 1 Feb 2023 11:19:55 +0800 [thread overview]
Message-ID: <202302011107.Qs35wciq-lkp@intel.com> (raw)
In-Reply-To: <1675154394-25598-8-git-send-email-max.byungchul.park@gmail.com>
Hi Byungchul,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on tip/locking/core]
[also build test WARNING on tip/sched/core drm-misc/drm-misc-next linus/master v6.2-rc6 next-20230131]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Byungchul-Park/llist-Move-llist_-head-node-definition-to-types-h/20230131-164632
patch link: https://lore.kernel.org/r/1675154394-25598-8-git-send-email-max.byungchul.park%40gmail.com
patch subject: [PATCH v9 07/25] dept: Apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete()
config: arc-allyesconfig (https://download.01.org/0day-ci/archive/20230201/202302011107.Qs35wciq-lkp@intel.com/config)
compiler: arceb-elf-gcc (GCC) 12.1.0
reproduce (this is a W=1 build):
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# https://github.com/intel-lab-lkp/linux/commit/4773cd9b4e467e974a08cfcd690019b170f2e123
git remote add linux-review https://github.com/intel-lab-lkp/linux
git fetch --no-tags linux-review Byungchul-Park/llist-Move-llist_-head-node-definition-to-types-h/20230131-164632
git checkout 4773cd9b4e467e974a08cfcd690019b170f2e123
# save the config file
mkdir build_dir && cp config build_dir/.config
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc olddefconfig
COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=arc SHELL=/bin/bash drivers/scsi/qla2xxx/
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
All warnings (new ones prefixed by >>):
drivers/scsi/qla2xxx/qla_dfs.c: In function 'qla2x00_dfs_tgt_port_database_show':
>> drivers/scsi/qla2xxx/qla_dfs.c:227:1: warning: the frame size of 1032 bytes is larger than 1024 bytes [-Wframe-larger-than=]
227 | }
| ^
vim +227 drivers/scsi/qla2xxx/qla_dfs.c
36c7845282eef0 Quinn Tran 2016-02-04 174
c423437e3ff41b Himanshu Madhani 2017-03-15 175 static int
c423437e3ff41b Himanshu Madhani 2017-03-15 176 qla2x00_dfs_tgt_port_database_show(struct seq_file *s, void *unused)
c423437e3ff41b Himanshu Madhani 2017-03-15 177 {
c423437e3ff41b Himanshu Madhani 2017-03-15 178 scsi_qla_host_t *vha = s->private;
c423437e3ff41b Himanshu Madhani 2017-03-15 179 struct qla_hw_data *ha = vha->hw;
4e5a05d1ecd92c Arun Easi 2020-09-03 180 struct gid_list_info *gid_list;
c423437e3ff41b Himanshu Madhani 2017-03-15 181 dma_addr_t gid_list_dma;
c423437e3ff41b Himanshu Madhani 2017-03-15 182 fc_port_t fc_port;
4e5a05d1ecd92c Arun Easi 2020-09-03 183 char *id_iter;
c423437e3ff41b Himanshu Madhani 2017-03-15 184 int rc, i;
c423437e3ff41b Himanshu Madhani 2017-03-15 185 uint16_t entries, loop_id;
c423437e3ff41b Himanshu Madhani 2017-03-15 186
c423437e3ff41b Himanshu Madhani 2017-03-15 187 seq_printf(s, "%s\n", vha->host_str);
c423437e3ff41b Himanshu Madhani 2017-03-15 188 gid_list = dma_alloc_coherent(&ha->pdev->dev,
c423437e3ff41b Himanshu Madhani 2017-03-15 189 qla2x00_gid_list_size(ha),
c423437e3ff41b Himanshu Madhani 2017-03-15 190 &gid_list_dma, GFP_KERNEL);
c423437e3ff41b Himanshu Madhani 2017-03-15 191 if (!gid_list) {
83548fe2fcbb78 Quinn Tran 2017-06-02 192 ql_dbg(ql_dbg_user, vha, 0x7018,
c423437e3ff41b Himanshu Madhani 2017-03-15 193 "DMA allocation failed for %u\n",
c423437e3ff41b Himanshu Madhani 2017-03-15 194 qla2x00_gid_list_size(ha));
c423437e3ff41b Himanshu Madhani 2017-03-15 195 return 0;
c423437e3ff41b Himanshu Madhani 2017-03-15 196 }
c423437e3ff41b Himanshu Madhani 2017-03-15 197
c423437e3ff41b Himanshu Madhani 2017-03-15 198 rc = qla24xx_gidlist_wait(vha, gid_list, gid_list_dma,
c423437e3ff41b Himanshu Madhani 2017-03-15 199 &entries);
c423437e3ff41b Himanshu Madhani 2017-03-15 200 if (rc != QLA_SUCCESS)
c423437e3ff41b Himanshu Madhani 2017-03-15 201 goto out_free_id_list;
c423437e3ff41b Himanshu Madhani 2017-03-15 202
4e5a05d1ecd92c Arun Easi 2020-09-03 203 id_iter = (char *)gid_list;
c423437e3ff41b Himanshu Madhani 2017-03-15 204
c423437e3ff41b Himanshu Madhani 2017-03-15 205 seq_puts(s, "Port Name Port ID Loop ID\n");
c423437e3ff41b Himanshu Madhani 2017-03-15 206
c423437e3ff41b Himanshu Madhani 2017-03-15 207 for (i = 0; i < entries; i++) {
4e5a05d1ecd92c Arun Easi 2020-09-03 208 struct gid_list_info *gid =
4e5a05d1ecd92c Arun Easi 2020-09-03 209 (struct gid_list_info *)id_iter;
c423437e3ff41b Himanshu Madhani 2017-03-15 210 loop_id = le16_to_cpu(gid->loop_id);
c423437e3ff41b Himanshu Madhani 2017-03-15 211 memset(&fc_port, 0, sizeof(fc_port_t));
c423437e3ff41b Himanshu Madhani 2017-03-15 212
c423437e3ff41b Himanshu Madhani 2017-03-15 213 fc_port.loop_id = loop_id;
c423437e3ff41b Himanshu Madhani 2017-03-15 214
c423437e3ff41b Himanshu Madhani 2017-03-15 215 rc = qla24xx_gpdb_wait(vha, &fc_port, 0);
c423437e3ff41b Himanshu Madhani 2017-03-15 216 seq_printf(s, "%8phC %02x%02x%02x %d\n",
c423437e3ff41b Himanshu Madhani 2017-03-15 217 fc_port.port_name, fc_port.d_id.b.domain,
c423437e3ff41b Himanshu Madhani 2017-03-15 218 fc_port.d_id.b.area, fc_port.d_id.b.al_pa,
c423437e3ff41b Himanshu Madhani 2017-03-15 219 fc_port.loop_id);
4e5a05d1ecd92c Arun Easi 2020-09-03 220 id_iter += ha->gid_list_info_size;
c423437e3ff41b Himanshu Madhani 2017-03-15 221 }
c423437e3ff41b Himanshu Madhani 2017-03-15 222 out_free_id_list:
c423437e3ff41b Himanshu Madhani 2017-03-15 223 dma_free_coherent(&ha->pdev->dev, qla2x00_gid_list_size(ha),
c423437e3ff41b Himanshu Madhani 2017-03-15 224 gid_list, gid_list_dma);
c423437e3ff41b Himanshu Madhani 2017-03-15 225
c423437e3ff41b Himanshu Madhani 2017-03-15 226 return 0;
c423437e3ff41b Himanshu Madhani 2017-03-15 @227 }
c423437e3ff41b Himanshu Madhani 2017-03-15 228
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-02-01 3:20 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-31 8:39 [PATCH v9 00/25] DEPT(Dependency Tracker) Byungchul Park
2023-01-31 8:39 ` [PATCH v9 01/25] llist: Move llist_{head,node} definition to types.h Byungchul Park
2023-01-31 8:39 ` [PATCH v9 02/25] dept: Implement Dept(Dependency Tracker) Byungchul Park
2023-01-31 8:39 ` [PATCH v9 03/25] dept: Add single event dependency tracker APIs Byungchul Park
2023-01-31 8:39 ` [PATCH v9 04/25] dept: Add lock " Byungchul Park
2023-01-31 8:39 ` [PATCH v9 05/25] dept: Tie to Lockdep and IRQ tracing Byungchul Park
2023-02-01 2:28 ` kernel test robot
2023-02-01 17:42 ` kernel test robot
2023-01-31 8:39 ` [PATCH v9 06/25] dept: Add proc knobs to show stats and dependency graph Byungchul Park
2023-01-31 8:39 ` [PATCH v9 07/25] dept: Apply sdt_might_sleep_{start,end}() to wait_for_completion()/complete() Byungchul Park
2023-02-01 3:19 ` kernel test robot [this message]
2023-01-31 8:39 ` [PATCH v9 08/25] dept: Apply sdt_might_sleep_{start,end}() to PG_{locked,writeback} wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 09/25] dept: Apply sdt_might_sleep_{start,end}() to swait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 10/25] dept: Apply sdt_might_sleep_{start,end}() to waitqueue wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 11/25] dept: Apply sdt_might_sleep_{start,end}() to hashed-waitqueue wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 12/25] dept: Distinguish each syscall context from another Byungchul Park
2023-01-31 8:39 ` [PATCH v9 13/25] dept: Distinguish each work " Byungchul Park
2023-01-31 8:39 ` [PATCH v9 14/25] dept: Add a mechanism to refill the internal memory pools on running out Byungchul Park
2023-01-31 8:39 ` [PATCH v9 15/25] locking/lockdep, cpu/hotplus: Use a weaker annotation in AP thread Byungchul Park
2023-01-31 8:39 ` [PATCH v9 16/25] dept: Apply sdt_might_sleep_{start,end}() to dma fence wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 17/25] dept: Track timeout waits separately with a new Kconfig Byungchul Park
2023-01-31 8:39 ` [PATCH v9 18/25] dept: Apply timeout consideration to wait_for_completion()/complete() Byungchul Park
2023-01-31 8:39 ` [PATCH v9 19/25] dept: Apply timeout consideration to swait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 20/25] dept: Apply timeout consideration to waitqueue wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 21/25] dept: Apply timeout consideration to hashed-waitqueue wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 22/25] dept: Apply timeout consideration to dma fence wait Byungchul Park
2023-01-31 8:39 ` [PATCH v9 23/25] dept: Record the latest one out of consecutive waits of the same class Byungchul Park
2023-01-31 8:39 ` [PATCH v9 24/25] dept: Make Dept able to work with an external wgen Byungchul Park
2023-01-31 8:39 ` [PATCH v9 25/25] dept: Track the potential waits of PG_{locked,writeback} Byungchul Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202302011107.Qs35wciq-lkp@intel.com \
--to=lkp@intel.com \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=amir73il@gmail.com \
--cc=damien.lemoal@opensource.wdc.com \
--cc=daniel.vetter@ffwll.ch \
--cc=david@fromorbit.com \
--cc=duyuyang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=joel@joelfernandes.org \
--cc=johannes.berg@intel.com \
--cc=kernel-team@lge.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=max.byungchul.park@gmail.com \
--cc=mhocko@kernel.org \
--cc=minchan@kernel.org \
--cc=mingo@redhat.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=sashal@kernel.org \
--cc=sj@kernel.org \
--cc=tglx@linutronix.de \
--cc=tj@kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
--cc=vdavydov.dev@gmail.com \
--cc=will@kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox