From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0E312C05027 for ; Wed, 1 Feb 2023 10:12:02 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9101D6B0071; Wed, 1 Feb 2023 05:12:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8C07E6B0072; Wed, 1 Feb 2023 05:12:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 787416B0074; Wed, 1 Feb 2023 05:12:01 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 66F706B0071 for ; Wed, 1 Feb 2023 05:12:01 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 06F178010D for ; Wed, 1 Feb 2023 10:12:01 +0000 (UTC) X-FDA: 80418307242.15.12C7198 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) by imf04.hostedemail.com (Postfix) with ESMTP id DEC0F4001F for ; Wed, 1 Feb 2023 10:11:58 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kYSkjbt3; spf=pass (imf04.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675246318; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding:in-reply-to: references:dkim-signature; bh=OYqzg/T0LaloBHYldjFBFyRxBuHKs2BASAL6cTqmqDQ=; b=1uzr+Rnd93XOehL6JjwzuOBzsJymSb6tZN2/XvGKXXOBrnwEc8z6gzTYkl0BqyU3XIMnu0 BH857Gqg91LdlDKXmHcfuREk573h0dn5ATqq88i2Z5jyQtYnZ6MpIhbxcerqzf1uNBgcNR CpaPSTV6T+2Oiy+Y4IgQtjuTfWWg4hk= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kYSkjbt3; spf=pass (imf04.hostedemail.com: domain of hn.min.lee@gmail.com designates 209.85.216.42 as permitted sender) smtp.mailfrom=hn.min.lee@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675246318; a=rsa-sha256; cv=none; b=EFWP5a70H4c97+JV5Qiln5qqH6zjcpsTbVE0C/pfcyAf4Cb6oIgSsICIYZozgP4Yh4cS03 +pZIAe7ErQXJD/62xpjh9RbJ+06NjnJMA//Va3gqLApzaEp86m4Fw6riJ7hNiQI8LYkN5f Mr4GwgtBHe/EJwRP4Mj8lijCyPxin/8= Received: by mail-pj1-f42.google.com with SMTP id n20-20020a17090aab9400b00229ca6a4636so1655463pjq.0 for ; Wed, 01 Feb 2023 02:11:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :from:to:cc:subject:date:message-id:reply-to; bh=OYqzg/T0LaloBHYldjFBFyRxBuHKs2BASAL6cTqmqDQ=; b=kYSkjbt3CoDGthjE1muYlphECzFd1NTCJGRUkVfEih4s35VlVL1HTaH0ENL2dd/v/y MDCRryUhOxagYtXjQawfsnLxB86PRAu7qiQVrHiJvh5fS+Kk2KAqmBqLsrel6yBc6xs1 7qZYg2oBnhZNRG9OCZNVuqCNuQrW741VSacLnkGxCeiTV+OKfX68fo9ZYEuoMjN84MYV Sgg0Cv40eYoNZFo5xuoMsWmaHj/9mbj6PSqZr8kayz1vRcyj1JOJeUhb0x+CEpgm5a1v m4qXJXGM3QRZIrquhuDuaqgvtrqnlyIoolwk9jLlhQa7PNHiA/DuYr2KGA5MbPP2K81J D2hQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-disposition:mime-version:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OYqzg/T0LaloBHYldjFBFyRxBuHKs2BASAL6cTqmqDQ=; b=dPNrd58GC4ICOm7z2sGzpYtqplx4HJLpTS/xa67ddXbvKNSCEn52AvUMxhBFQRSn8a zz3mjpKCVEgPsfsPy/PpURyEM0SwIAzHxkPU/rLUsRm1vVtjMWjM4zqdd5Px7hWV9d8D ygyWtrB6QrRFVrKRGuhmLFdsdiZ2udpOr8Zs+0xqGYUOgtHZAXb/sMEeKdaiAi5Egbpw wmXnIgt+j0ZZrEBxUOha0SMneTROnm0VCXuKRc2IQFTkWzRps7gt5d+IinJur3GPiv8A +eIa53rZDzA/CTS4MxJ3cvbE7uwCqq0PMbzgDGW+4Yqe2/JmIycheqM7oyWOFmwa83Rc j0Qw== X-Gm-Message-State: AO0yUKWDYeA6bks9cunQRpdQOtS9HwF6hqu4mIAKAxeY/HL/k3ts+dgE tabW2sQWkJ3/ruArsez6oY4= X-Google-Smtp-Source: AK7set9yNodUn2+Snq1aZuqL2V8nqcr56KT2NdQkF8cksyL8vJf600SDWYXtNiA+fTEausjp7bM3Vw== X-Received: by 2002:a05:6a21:99aa:b0:bc:ccea:a969 with SMTP id ve42-20020a056a2199aa00b000bccceaa969mr2451168pzb.26.1675246317753; Wed, 01 Feb 2023 02:11:57 -0800 (PST) Received: from min-iamroot ([210.91.70.133]) by smtp.gmail.com with ESMTPSA id f9-20020a639c09000000b004b4d4de54absm9167806pge.59.2023.02.01.02.11.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 01 Feb 2023 02:11:57 -0800 (PST) Date: Wed, 1 Feb 2023 19:11:52 +0900 From: Hyunmin Lee To: Andrew Morton , Uladzislau Rezki , Christoph Hellwig Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Gwan-gyeong Mun , Jeungwoo Yoo , Sangyun Kim , Mike Rapoport Subject: [PATCH v3] mm/vmalloc: replace BUG_ON to a simple if statement Message-ID: <20230201101152.GA5535@min-iamroot> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-Stat-Signature: n4d93oatcnenoubuyy7r1uqoejn9ozcn X-Rspam-User: X-Rspamd-Queue-Id: DEC0F4001F X-Rspamd-Server: rspam06 X-HE-Tag: 1675246318-64786 X-HE-Meta: U2FsdGVkX1/BMfZvEFkFebVpDmDnKPRNllB35l0oHONw2zH+ydft7zuMGkt0OUMNRjuSDw9iXwvkScj0IzgH05V73djc1RitpbcqO6+XghjVLU8v0ZAifEza97g2g7ZodWpuYCVNbZT7E7mv5t071nW8ZvXzr3gVw8Twj4/GF4IlBVlm9U1+P26za1VMJlAmHDuxMmSJfyauVdw75qsbLtYeUsL0Bxae577SMlR9TYvcCy8buhnV3War9HkKb9St3scdKvvYObpl68WFWDL+XbtmGsHllAMsfQWTeJYNLHiiXhYwaBG6B3CZHp3TNPeWnm7oXKNviqr0YeJTPsd2T/rRNmd5zTo6qLQPTcV+ALoM4Nyg2ajSmJdfctzVCXk39L/rtaa7NGrAq+SM8MEuqmfD/nTvRX0aovvGj+B9o5DS8U9sSOLCfyQwyyz6OhKR4yoRYhErdWqk9TKG67Oc5MU3AbTgVqKs8POG3H6jAeTYuXOgxV8+Nvtl2JZ2To4NvJPD1y8riB2NaBD1hTlmm0pdP+/0p7meuQhxo4I3jPr/LlHro9z1+4S5+Pb/bnFxTL0l5uVtJECmLZbeYAwOCi7mgMdaF2ljwh4JX1U9e+itwj4fZ165HySgmlMZFO7Et8uz06K+GLSfRLkKWwkRjn0zUF5KkJvNKTLgCyuoSWNVfJeyL9zs8kZFroiVNw3qVK9NFhW55IwhXGj+Neb0ITkr/7Z8K51AN9YoewPFNwXPxh4SKUh1+PdqmIG7ZCYA+k4guaMvBwexXtiZKY2NA9MLBXw5GjspF6WDK5M1PEdJsE98zQRKut6k1zzNGZiy8qwE+kyAJkYbdYbRuMBJQrg+sax3rDGOwk7SQMPyndLXSO9tTuZ8e/JQuc9fkJS9T+Oxw3+aZYmijAi4HPZRdcG+ePdaZJWoBKFRjG5ORkky3eEs5ZpLT0eDcjMQmacwyYIMhPOBc1Qt9tXCHbA 46n98vlJ xwvfenOO0nTHMMseyxwM6ln2gC4mBAOuT/SkNg7HWR1wAqztOPm10V7BRgRKdugBCt1m1fcQI/GmHaIPdyfORrJVEDLl9W88ZscB3QR/z3CVYXJlcP2dY2RSrJVRJuMaaWeNuGrIS4akBBMRTr7IpIdVLid/a3TKXQA4bxvleeUzHCYTvxIqSlLpLVep3JoW0qdliIQjOxojN61k9c3ymHkiA9/Fw6c7sZOFY/sA8iFflcXZxtcVjBQIDO1fyfmuvtqQD6+xzo3xeqvGcTmPwhoTmopBn2+H17t/JlF1zXtZHTdM6+36iJHtFGXA87lrxdA2jgvuHpXNdnGwIY+RmnPxdUof2s7Q9OwbvgtOu6ek8KjPiUOdWT4G3coi4OblgcOyQpcIanLe/4NPDGrwgVYPlpaEGdj1HDD6/Tt3j/xbEz4ka3puOzJOjVZQ24GrpiN6DIq3DOSYHOM99v+SLTfImYwHev0i5UAXNV+L29gttXGD7284ZlT3vyxvfJm1j0xkMHWbEmDqjXfw1lvsCGbOnr4EizhAbmo5mnNcILZnv01qHAjMPh+FXPkAliqbep/oS X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As per the coding standards, in the event of an abnormal condition that should not occur under normal circumstances, the kernel should attempt recovery and proceed with execution, rather than halting the machine. Specifically, in the alloc_vmap_area() function, use a simple if() instead of using BUG_ON() halting the machine. Co-Developed-by: Gwan-gyeong Mun Co-Developed-by: Jeungwoo Yoo Co-Developed-by: Sangyun Kim Signed-off-by: Hyunmin Lee Signed-off-by: Gwan-gyeong Mun Signed-off-by: Jeungwoo Yoo Signed-off-by: Sangyun Kim Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com> --- v1->v2 : Add commit description v2->v3 : Change WARN_ON() to if() --- mm/vmalloc.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/mm/vmalloc.c b/mm/vmalloc.c index 74afa2208558..52a346bc02a1 100644 --- a/mm/vmalloc.c +++ b/mm/vmalloc.c @@ -1587,9 +1587,14 @@ static struct vmap_area *alloc_vmap_area(unsigned long size, int purged = 0; int ret; - BUG_ON(!size); - BUG_ON(offset_in_page(size)); - BUG_ON(!is_power_of_2(align)); + if (unlikely(!size)) + return ERR_PTR(-EINVAL); + + if (unlikely(offset_in_page(size))) + return ERR_PTR(-EINVAL); + + if (unlikely(!is_power_of_2(align))) + return ERR_PTR(-EINVAL); if (unlikely(!vmap_initialized)) return ERR_PTR(-EBUSY); -- 2.25.1