From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19131C636D3 for ; Wed, 1 Feb 2023 00:32:11 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 73F6C6B0071; Tue, 31 Jan 2023 19:32:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6EFB46B0072; Tue, 31 Jan 2023 19:32:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5DE5A6B0074; Tue, 31 Jan 2023 19:32:10 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4EE786B0071 for ; Tue, 31 Jan 2023 19:32:10 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 1FFFF140D33 for ; Wed, 1 Feb 2023 00:32:10 +0000 (UTC) X-FDA: 80416846020.11.4706C4B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 6C29C1A001A for ; Wed, 1 Feb 2023 00:32:07 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eM7d9f3y; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675211527; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=e5+VjXurLTeLfRJk0xWyDESIoW0uGWg9MfXX+SMghbc=; b=MWft9cAX65+QloluIgqxDR1xSd6Rfn2ujF/mHZbI4d682MzbqTkbyY+CSn4raZcg+Yfq01 JCln0c5KlGQ1UJXcZ+3vGkqVf1u3QeKPjQwjO6JYSEnODhBUhFunTFGEHEvzLUe5fgxaA0 22REUfFimDHI8FV1jzy4WwRTIjLE6HQ= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=eM7d9f3y; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675211527; a=rsa-sha256; cv=none; b=WrpF8rCpH1Q6N9IeXNjHfD1Y1X92AQIadHtIUGdy8Dai/Gr+Sg57uzRLPhtnKjrf9gBK4t 4O330vJf6FW61fICXHn8mGS68GyUaWwKC+7vdROt2nevHwKP6f1C+njfSUZVkLE6R5gKWa dOOdEzHf+DM3soAg9Xea5XqemPr8JTI= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 5CE276174D; Wed, 1 Feb 2023 00:32:06 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8F431C433D2; Wed, 1 Feb 2023 00:32:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675211525; bh=PC5yQB77oK31WqmkfHnumQayq11crcBL2x05R3KZ/jo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=eM7d9f3yIifo5Vnn8aCiNI/6u7IUTKp3GPkBvFDqVGPAoz4cQWOtWZUTptCOxkzaE t/AVdKH6BRMb5H/svi/a1maEveOSR5ehDkOR4+YhySclWTbDJjvQx6/e03NCBhAh2V boev5JpeCML2iltM0x8FScbAAkhNAhBGRiKJKZ5c= Date: Tue, 31 Jan 2023 16:32:04 -0800 From: Andrew Morton To: Kefeng Wang Cc: , , , , , David Hildenbrand Subject: Re: [PATCH -next resend v3] mm: hwposion: support recovery from ksm_might_need_to_copy() Message-Id: <20230131163204.2c511663bfece90d56121cc6@linux-foundation.org> In-Reply-To: <20221213120523.141588-1-wangkefeng.wang@huawei.com> References: <20221213030557.143432-1-wangkefeng.wang@huawei.com> <20221213120523.141588-1-wangkefeng.wang@huawei.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 6C29C1A001A X-Rspam-User: X-Stat-Signature: 8qgiayh31d6fetrosb68137dwzec4c3d X-HE-Tag: 1675211527-431140 X-HE-Meta: U2FsdGVkX1+g4fxykltykyeHnb+qxTNGbWawHZuxfb83WemPqm4PRA2r15i3RZ1XwaoOER7VqgFT7l6MfaV2VYEpM5cqbLvS2b5Yl93aSbHa7eNxo+SfhxcperhJBCXw7izCx8OzOHV7uTi0YNTiwlH+QGUr0magPlbtwLhTPuo5QschYK1lVzAGfCiTFtvUQJuXhJBRgMWphpgMqgXwGxgnwlt2Ym2XK1Piy/Xu0zwCSHMJUxEYVcewAizPqiE+W0ESEFpPjOcIfZWH+EBhvM+vklJCFRaaKjvn+pw+MS0U8GQWtmY4xOAvHV5AUt/up2Wm9UmY+Ul4ppAzdTne3VYx8uwcZIPQpdFsgISHtoMscTmXPRAAnMZTJK5KxYF7BYzPF6XcfMfwbw6KNaKo4qpSmJcRFKygo07+zVkSJ6nKFInIm6elGKYSrZIQdhXk5SM7rg6e5XzX+kpfMwQGI5+nh7P8nbDvQmPsCRmLDASly4atheKlgCUevO/v1N+ZcDqMbifcQ7fVPkhQyUVPWoRV2oUmvZ/rRcEzKYcaKCGeSpYwaOWycD/99n88rIOpah3f/yrItwE0GC0bInH1CBKjdNYvC4wb1oF9Dl0loAhgxgnR4TIp/YOQ3tTQeucbtsR3YlHajlr0UswPjW1m6VFk3fCVFzFnAVm9xt7f59TlfnM8yPqBGBupAniPWQ64y5lEkFmVz1mGIZELZEc/qo58Os+WDTdUV9/J6f9+pOMROPRPWPzrcOpPiPHrcwlvIZEJwXeEIsGqEfha/Pgu6+ZaCP9J52Goohc9RsXvmbLcw88M30SxA3MHnuDsb+T6YwA7jv2UGQi72lZalf9ODI1gstzj2JV6M8a1I8DbcnfJJvG/yKnzrbBGTsJE0pUK9+cJsN0qVV+HEQj1WjANm/LT+rM5j6aMsD+gYn3f/OA3z1tbAgPFruKzfiQkP1GgXGEWCb/+rbkyXwo7d3F mQMAxnpm I9xC/DKT1EiOc7jG7998zuOQSNoaonqu8l/JtuRx3i3SG0oCuFqd2oycvxSQ3CTojiKjf6v3OcXr5uCuY2BoIo+d7UaPyQpB4hBLI/fZmMWDfmlFUClqSZWuxr23g9EBjUEVvSsQcpLSSdYp0ODrfD4fqmqGB2pP8yizTtMlLkGaQpnkbfwPCZooBgGwuTEf/Q8nx+bKNth2/cBnFvaUs7xDu+wVKWcesA39OUUpdw1HECvzrPG0IGzImDHCADI7UwoNZz7nL9S8aDj7dhGOdyxAiMW1hrRTm7Wqlbd8gjWXKOuCYF/cW2gDUeuOrgYONP+yvA5HlaCodIQRIoylltU5NGP/5KtgH/FvCaEwWO/OZnY6MUXPeKzpTe2UEIJ6l8Q5O3TwHbANAqT5jlekiXub8XHntMf3M7Ve6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 13 Dec 2022 20:05:23 +0800 Kefeng Wang wrote: > When the kernel copy a page from ksm_might_need_to_copy(), but runs > into an uncorrectable error, it will crash since poisoned page is > consumed by kernel, this is similar to Copy-on-write poison recovery, > When an error is detected during the page copy, return VM_FAULT_HWPOISON > in do_swap_page(), and install a hwpoison entry in unuse_pte() when > swapoff, which help us to avoid system crash. Note, memory failure on > a KSM page will be skipped, but still call memory_failure_queue() to > be consistent with general memory failure process. I believe we're awaiting a v4 of this? Did we consider a -stable backport? "kernel crash" sounds undesirable... Can we identify a Fixes: target for this? Thanks.