From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C64B7C636CC for ; Tue, 31 Jan 2023 15:08:00 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 650886B0074; Tue, 31 Jan 2023 10:08:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6010F6B0075; Tue, 31 Jan 2023 10:08:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4C9C36B0078; Tue, 31 Jan 2023 10:08:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 3C4406B0074 for ; Tue, 31 Jan 2023 10:08:00 -0500 (EST) Received: from smtpin22.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C56F9160227 for ; Tue, 31 Jan 2023 15:07:59 +0000 (UTC) X-FDA: 80415424278.22.ADEF803 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf27.hostedemail.com (Postfix) with ESMTP id E2E3440010 for ; Tue, 31 Jan 2023 15:07:57 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p40lVlSO; spf=pass (imf27.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675177678; a=rsa-sha256; cv=none; b=Rh5zcgxPoySsG9wd/uS3YA7FD4zrG5QzgEgvwBIxR9YChi7Oh25KZoiQsSDr9RS4jv+Ex3 9wGVjmdAFtQnTtB6t53GCA1tmQOUajVo0ZRm+PK+Wo/+Yij5iH9C5IkRKrQm1pFgxgR6gi 85TTbDwUB/d4LKF9TDAR+kRUnZkrhS4= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=p40lVlSO; spf=pass (imf27.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675177678; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=0o6jxy5cUYjH+z5RH9zjLKPC6ATFcHhwJmVi46wr0ww=; b=D9Tc6zxRkWz3t9ljNdS6gTpCNPdLfTRGFOgNlnpRR7jE2C+LDU9sjN/6NIhkVg6vGSlfNK xu5W42cZpwScY34utIZXjybr43QsGDjCV3AWPMEsrfHGdzm3S1C3kUDtK897lYdxQDkuzP Z3iN1vZKSI7qUmsOP4Er+NG5CaNa720= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 1880E61559; Tue, 31 Jan 2023 15:07:57 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D5FD0C433EF; Tue, 31 Jan 2023 15:07:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675177676; bh=ajutUaUEwqXpqNomITAth5hy9R3xXT8QLPlinoZAJIY=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=p40lVlSOCH+VjSQIdjkU8PO+fVfLNYRtIkNTKm11vCDwQUrUgrEH69Bdgymfh7bfn U68elFR1rMLRVoUxa7B6ooWVJfyyEV+xkXSEpBtEraVXMNKnAi30GXM6lGwwTUReCV FXBZnI0eDKQd3AoRlrbvAXTcxTyFkOCZHl1W2As1Fc8+WmKvGkRSSbIeifWPYYDJww DZjd4fT3zidmMlcBZ+ktC8kswxEt/xwq1wNGFFk59c7YJClGjnYPbvvwRiIGtrh2C8 YhtaH0xUGM+7l4gIQcIQXjAV5w879Czn0AT9PFLeJfx9N7l8UfBpHMoIY/MWOa/0DF rRKYb+puZAocQ== Date: Tue, 31 Jan 2023 15:07:51 +0000 From: Will Deacon To: Andrew Morton , ardb@kernel.org Cc: Liu Shixin , Catalin Marinas , Uladzislau Rezki , Christoph Hellwig , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set Message-ID: <20230131150750.GB2605@willie-the-truck> References: <20221227092634.445212-1-liushixin2@huawei.com> <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> <20230131150644.GA2605@willie-the-truck> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230131150644.GA2605@willie-the-truck> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspam-User: X-Rspamd-Queue-Id: E2E3440010 X-Rspamd-Server: rspam01 X-Stat-Signature: e3wpo59yhjm9ukqfr3rn9krrjyntiajr X-HE-Tag: 1675177677-365262 X-HE-Meta: U2FsdGVkX1/W39Iuf7EsVEaI4MUiA0cLsWUHTh4YRffjFNDF4bwH1jbO/Eij1bK+UDH9hEalWxvFOIEpd/tb7fiB89bElN4EnIV0xEOpMFAKPsHbvz8hBGB2d3XUdC/uBSS+JBVB8f1/1EZvWVC/Et5e0Z69/9VuBBx/N7pT+jGmax4PyXVhExyosga2YnG0Cnjc8aoFHxmRgw2P+wPNcTkOEeL8pmGjqIw1Z42JYUdfR08dQn+4wqGpZ+nrkse2vTEHYrGDjZUHOOVFK/MsQrTwqdB/2E4KFrsvYlHDXHsf3dWcGgOeAnCJDl1khv4UtnlCzgD447gEuaPiReMaWFvsluP+/HVZYJwpWEIxR62lKtyedv+MNS61WXPtoMXZcmm/XYtFUE0T0pBISI6QisFzxwv+otRjdMr+p1d48flgEP7B/wtlW6CMT9jVU/Hvkxb2816MyGCbmC0M/OFTWDeZxXVkc9C1yy/ng9vFZAakRETGtgZwia7FKBd93VPTikga8rTXvSck4xzjaw5LC/m1VvEzM9lFSaa0i7XTu0GnRUWSenw/sSidL5wEtly0DSkQ9OLnVsz9vXqwVpm7Xz0HKnvC2zzGHZ1arqtatabHBaizmPeSFg/m8wkWuG429Ilvg1ooctvZU4GbPxyLh+95NzeCkNWm9/DGbIivecLlIa2kUqDJoJJ5K4/uKXiENm+Kj33jwPzrN6LcjbTa/PunxWeKx6/AenpPqWpNqCOZO09Pz7WE/d+XXQM0UDsDv7vj772SkM7cADeYIFkRjBW3AmCte4x/RBNGThic462piMLtfjEi9IhPhrLXweVW0h2XyKkNTpHxureA+Cn5xPt/EVaASC9MjtBzA29VjyKCxeqhlUgy7oy6l4GouoFX9S4E0QFlhVpoxkNz+g1Xw9SobqQrd4Vwm9F5TKFVHgXd8ERLfqI8Ezfxna2eA3jCkOAjIQVonNy+C3RzYAG FkOZWXse 5f2gPAagezghUfiJxyJI9uhVgx/bAWb64F1g1TlNGlhyy8fKD5/N5TvldLt9iR9PgRnzhe6FwDtVgtX/Gw0RYkZT3Dm1ute5F475zvKagH4MJJom6aFRbySmZTP7iefQk6y6qSFTHkipBHqdGjIkQrSZySfFz03ObZahEh6PxyikWhu5bbbL86WLsZ4GlIfbNtFVsEHW1DlTzzdwqGbQnAXPcJU2arZ9OVnwc3IXjBOvokpHwgc4c7c9PnCiE+S9BoKp7GXR2AyozoKyF96Nn6zSzLW4o1ZD5FCVH5IUkBjmyNxxfisLAXVkNfyHyLNkKu8MRSPH5fUme9Zg5sVo0b/eEcCJZMRACCjvoE78dncVQDyCdBsda87B/8gzkRfRFD6AwBAgBREuD58WIjlNf5Xs+j8qKwcy7tkdaWsC9tp1s8iGjWofz2gToFb8F7j5B/Yg8ezWieh009RM+p6yYR5qwnV8Phdq0UOcEbjwbu7IA93tWgSzca3mD2jCGRRjQ2QhAJgY5iCdRUSOfHTo7zvq+n+y698zurcqvx4opL+wvB9hAHliC80o0+TR2Ruxscjzf X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Now really adding Ard... On Tue, Jan 31, 2023 at 03:06:44PM +0000, Will Deacon wrote: > +Ard -- full thread here: > > https://lore.kernel.org/all/20221227092634.445212-1-liushixin2@huawei.com/ > > On Sun, Jan 29, 2023 at 01:41:47PM -0800, Andrew Morton wrote: > > On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: > > > > > Hi, > > > > > > > > > This patch seems to have been lost in the corner. Recently I've meet this problem again > > > > > > on v6.1, so I would like to propose this patch again. > > > > > > > > > Thanks, > > > > > > > > > On 2022/12/27 17:26, Liu Shixin wrote: > > > > After I add a 10GB pmem device, I got the following error message when > > > > insert module: > > > > > > > > insmod: vmalloc error: size 16384, vm_struct allocation failed, > > > > mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 > > > > > > > > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the > > > > vmalloc region entirely. Although module_alloc() can fall back to a 2GB > > > > window if ARM64_MODULE_PLTS is set, the module region is still easily > > > > exhausted because the module region is located at bottom of vmalloc region > > > > and the vmalloc region is allocated from bottom to top. > > > > > > > > Skip module region if not calling from module_alloc(). > > > > > > > > I'll assume this is for the arm tree. > > > > Acked-by: Andrew Morton > > This looks like the same issue previously reported at: > > https://lore.kernel.org/all/e6a804de-a5f7-c551-ffba-e09d04e438fc@hisilicon.com/ > > where Ard had a few suggestions but, afaict, they didn't help. > > Will