From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5A891C636CC for ; Tue, 31 Jan 2023 15:06:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id CBA346B0071; Tue, 31 Jan 2023 10:06:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C43606B0072; Tue, 31 Jan 2023 10:06:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id AE3EC6B0074; Tue, 31 Jan 2023 10:06:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 9C52F6B0071 for ; Tue, 31 Jan 2023 10:06:55 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C701F120437 for ; Tue, 31 Jan 2023 15:06:54 +0000 (UTC) X-FDA: 80415421548.17.C9489AE Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf14.hostedemail.com (Postfix) with ESMTP id CB94510001F for ; Tue, 31 Jan 2023 15:06:51 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LIf+cf55; spf=pass (imf14.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675177611; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=u3Ddp1t9+l+2SlZKk6gxAIO0uOewUw2lZTobGHexyiQ=; b=V/K+VevFcCS66YgFC1ZsXVdv2LHMFX5Xn31j3C20c8O+188F++RddwoBflXiKMNMiomIEW 7FTSRfTHgi7bawC5rQLu4aV30wBfJ+KIfdRnJqF9lWPMXoFSw2HTH3jqY3NyBRpwZ6kcXR FQnVLieY1gYULgN0mmFs+GH1Lk/CFwY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=LIf+cf55; spf=pass (imf14.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=none) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675177611; a=rsa-sha256; cv=none; b=e6ufirtKei/xrfY+E6Z1SHplempHqgfsgQlqjMbQNLi7t5coC1vdwhbJomgnrW+U+Ez1hj y79nTIemCZsuP0sTM88BSChb57dbGqMbxh5KI+dnUi5aUBFCl1KkhThnwc9H8QomTW4/6l 5M8vn6Zs7pNs7EnpL37lPMLjj2Q3JpE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BE8206155B; Tue, 31 Jan 2023 15:06:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 12A15C4339C; Tue, 31 Jan 2023 15:06:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675177610; bh=R35cnbiI7703GH9oQ1vqbYJjiahLzQi/FCcJNYTNJeE=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=LIf+cf55yjz7LoJvlBEDfzMq0+pGRy/Qn63QvKHnM1ps8mFpq/0rZrzUW45gumAye 55QGiGsgYXnfh6HisPqmM2q/gttobg/d+KCN8qJDuXUAyTHrNsaT97VDxdzzvsq98M 5fAijsqYMUm5UazzmOxx17EfD6bb8xdmb6T0OrJ1gHugJ6Z8tTMlWX++FTE7MPoWsa GTCWfOr8Sw65YE57EvsqsdxM0zC5bg7RMSAc7iCeo+QzhtbuGmYYzvbYHQM4qAFCmD dIGvfWypxj5mvDUDVQPRJf5E8OKK/PU7BQB42MLNyCCVUCQMth80ScJNFJeKpzK5Ek eycfE2riHfCBw== Date: Tue, 31 Jan 2023 15:06:45 +0000 From: Will Deacon To: Andrew Morton Cc: Liu Shixin , Catalin Marinas , Uladzislau Rezki , Christoph Hellwig , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set Message-ID: <20230131150644.GA2605@willie-the-truck> References: <20221227092634.445212-1-liushixin2@huawei.com> <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: CB94510001F X-Rspam-User: X-Stat-Signature: yrke3a193agf3gwfzfzfrpcii9edkx8g X-HE-Tag: 1675177611-365206 X-HE-Meta: U2FsdGVkX1+Ksyymm4eO+XMIHAUI77D2QCBQ2Yhdsjv0YNA4B+lhX/E06uSrm3glGTQvHUCEm/rmf/DsM24rO3IVU1MDYQdt5K3el6bfyLo1NiYDy6utsdVQca/EU2uQrlQNUMhgRyrNSAg+7VEBktU474YID6GB5LhFKcTvsv3qFFNUMgCl8tlcwKlSPyj54hFBbV513DzQ8o5YQt16wGKnv7KTbnWQtZzww+TN//YbgPzA6frUw6ZtObgQe5Z0Zs8TO13Uj+pUzr2rVJ5IM51qlsFVXT/sI5qDaC4eW8HharXUlqYQwwMm7XmDxBSOcDDXuhxCPc+nDlkVNGam3IP/cDfcobqe0yZkRkNcsTTKF0+E2YoT02hAIz/UU43Vc54DWbqa8GkvlBe7zZ5JNfsG8L0HE+20wSSTucujkF0CAYcQg26K5Jyx5IO4Hk8blOdCUhByWgK1mLbIhswIOMXrXRCjcH7XcUsEem0IOVybbyh76va+Rb0EcD93JhRvLZ5u0FpzbjWQctAKVsCwqrT92VbgxqCnOxeaDyIR80lk/iIZd9Vy5ssm35MfHC0fO4fRTKYtKfBRYvv9A+4Tttz8ZPFxVAndABJiDx83oaTmj9t3ygf0Ko7TWkK+GHb3tFmMmNzpmDzLK2Is14XHEfUBzRFDy50RqIZ5fH60GcaJmHcGF52Nz6Izstqw3Koo3Tjh2s/AW4Syvbv3gNkXcSwFdWfVUZezGjwJJMw7KJ+Q5hlFuOTe4WL0E55zfvh79/KDyM8FCgkT8Eym+JUxrKrmSBZxdNZvsNhpYZjQS6Ejv4+KcM0HDXskMVrayGcQNQ7Kh6LDpYv0WvWugpJSb4CdN54fwsqwGyAa7oifxcLh3THwcBdIeHEQYOUm8ja+QdWHnnrbmALfaTxODFoP77ZJVJ6JU26nHwmlwkCOVizRXfVMZgJNsNhYzhNnq2XmcfJwEjnt284zcHn0bLH m1H1rk+U KltuJHWEJHx1BNqXuCFabX85ayQW49t+fp/CJUzTTW1C7MhPeRFn/QA8eg/met/J/p7kH/oCXS0SZkdMHWVqLgUvu+KsuweQ1Af77MnqDi0EyG3FwDhjflyFFlQyh+QJbXpPnH8Br2LW4kyG/0SbNV9EKOqQ4FyKwUuK7nN8EsoOHOjd1sUymUDFswgQcSO59peNKu4AGuy/DVqp9WbOWPPMqBXAiRE2Cv2ekIurPPJWGIG6ekaNEsq6YFPrUCeScq7sYOVQc1szbP8FtNMFm1tWYz178WGoBOzGYUi5wN4frOargxjWAwjoT8PinBUfUMaesOCIlZD0rsOgG4DJjGA6Eka2EHpaNFTs2yLJgaHLG4/7GaDi+ji3ckfeojyiV0+ZYYtGXrDBEtw1ENrWPkW6jKNwlhumdODhTXL+xqkY21y6aUhIkqsgHVp9pUMcw+EPh9+Q5BF/H89lPAfR3o5RMmY8M1sWsqT/pKxefW6nZPROzXy9Ovw3VQ/DwduNXrcJk94EK4ymlX+7p1QFsb7RoAgla9b7Z6UCCeXwmDywDb6EIbX8XXDFpyoJp+0HBFOCQ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: +Ard -- full thread here: https://lore.kernel.org/all/20221227092634.445212-1-liushixin2@huawei.com/ On Sun, Jan 29, 2023 at 01:41:47PM -0800, Andrew Morton wrote: > On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: > > > Hi, > > > > > > This patch seems to have been lost in the corner. Recently I've meet this problem again > > > > on v6.1, so I would like to propose this patch again. > > > > > > Thanks, > > > > > > On 2022/12/27 17:26, Liu Shixin wrote: > > > After I add a 10GB pmem device, I got the following error message when > > > insert module: > > > > > > insmod: vmalloc error: size 16384, vm_struct allocation failed, > > > mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 > > > > > > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the > > > vmalloc region entirely. Although module_alloc() can fall back to a 2GB > > > window if ARM64_MODULE_PLTS is set, the module region is still easily > > > exhausted because the module region is located at bottom of vmalloc region > > > and the vmalloc region is allocated from bottom to top. > > > > > > Skip module region if not calling from module_alloc(). > > > > > I'll assume this is for the arm tree. > > Acked-by: Andrew Morton This looks like the same issue previously reported at: https://lore.kernel.org/all/e6a804de-a5f7-c551-ffba-e09d04e438fc@hisilicon.com/ where Ard had a few suggestions but, afaict, they didn't help. Will