From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 348A7C636CC for ; Tue, 31 Jan 2023 13:45:34 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 889C06B0074; Tue, 31 Jan 2023 08:45:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 839526B0075; Tue, 31 Jan 2023 08:45:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7280F6B0078; Tue, 31 Jan 2023 08:45:33 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 6314F6B0074 for ; Tue, 31 Jan 2023 08:45:33 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 21D68160B63 for ; Tue, 31 Jan 2023 13:45:33 +0000 (UTC) X-FDA: 80415216546.17.BBC0974 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf02.hostedemail.com (Postfix) with ESMTP id 4FB0F80008 for ; Tue, 31 Jan 2023 13:45:30 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675172730; a=rsa-sha256; cv=none; b=bawkjhBYySiwuI/Pw9sA2XcpnQfGrfwjan1tEViZdYPS85XlP2tnEKfO1Gsy9NWT3mSXFY UPNNc1UBnTphiPm9t01XlJiqsTLhhLw6NfFmPQmtADGtFhvM1k0VmlfNVYoRFjhWMeiE9d bEsCPjb1HxyEg5UZccFCGgwWJJas24I= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=none; spf=none (imf02.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675172730; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vy++B9D2CSRhmYf/Pm24UD9zU5zS7MXfM4rqPs/UvOc=; b=56RUEDTwNBHsLu9VpKFIKIN93R67jKzHzeZxe+KRdJJ5m9CR0VVoZv4dAEa4JqoLbrPNFh lkO//KOdNuZrRo7IFpKvl3gWIPpwR/j1rpSaRtq4rw4BBpdIAYtdB2GImDTlpBALNBBnZo POmj8RGlddc9DD1TS+r6cjFlfPDXjpo= Received: by verein.lst.de (Postfix, from userid 2407) id A7B4968B05; Tue, 31 Jan 2023 14:45:22 +0100 (CET) Date: Tue, 31 Jan 2023 14:45:21 +0100 From: Christoph Hellwig To: Bart Van Assche Cc: Christoph Hellwig , Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Message-ID: <20230131134521.GA24165@lst.de> References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> <2bab7050-dec7-3af8-b643-31b414b8c4b4@acm.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <2bab7050-dec7-3af8-b643-31b414b8c4b4@acm.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: 4FB0F80008 X-Rspamd-Server: rspam01 X-Stat-Signature: ziiwcuwipzywwbuuppgiqp9kg3jr1ph5 X-HE-Tag: 1675172730-936567 X-HE-Meta: U2FsdGVkX19hLWHC8ljDs3ZHIdsHDLgM5WE2FZW25EgmouUUhYD5yhhO7Co9sCUb3n16g1pQFMtC8Ao7SzKxb8VFiYDtc4h7l8PYVzlxZXr4OZZfBHEs9Z43lpzJ8XN6CCX4PLbDYLPxH6MYU3wHOLuB6EhZ2YVn8xzkKJ9qSZ6M58XHHqsCfGNhgoUZcNflgx/oiBnZaXXXTNaEjZr9ILLoAiVDXYgin8aHTpUJLKdKa+KHZaWRPAPCd1fMbNGxVUyVKkefB4EkH3mNu191oTdUe5DclDqLrmiXcgP602WtAij+CRkKj0jXCeEH48zECY0RtsfV/14cjBCIk2LrCSf2jt6wuRuNrTyXBpqHTr2ZT5PK1olhsDNKI/xR+jxp+B6yU2UbHIRK/y6yBrVn1Z6v1OmcZkV2dvmlyffFD9P0froFUKdtm692/5jkgNP4iAjaFesjTqPu7fUmAKZ6C0shwEYy3vU1tVgvHXhUikxOdxOSUhlpZVXlJFzvzDTCQuEh4IheMGjDZV1PX/Tig+HLRhAnu2XYS4Dg7fNRulSDm40yrhbfNdgFQotM3u+0+QKjeFnGtPHMNDUfUNCJ3yzmB4XT9BECZcBLgKivW2mkMRWIzh+SIIWZbTx/9jZs3b7DHawku0a2dVkC4OmRV646wievTKj/t+j6VITAtIL8a+oTg0/fPiEaQFcj6PDn9z3Jpcnpsc3gjsH+bvNkxLb5pFsp3YpDXA/Hbb4ICTH8/Ym/SuvDFI9cHgvjzfQWy+hWwynwwVZ2Cwo7MEEBHsDeE5MVxpahN+A43JUkdLft3OayU3YgVB0+sZ9c7gs4Bm73u7/8zDEP6eQ3q0lyfBWWoX9mnanQQ18Rm+xQRvZu5rKl/RS+L0ESvDbIq1XIKwAyvXOJNLwlr0a8YqJCL3EBpCMZwTqyXYTnUYVhztg4B1hZZNq8k2DgIpP8+1EuK5WlsA5OebfV9hrGR2K KAF24oYh VjmYOe4jYTjHEoIC62AGqEVPyFes/2gVYFVTQmvyl9kHOG0KHSnWdHKPHRYIPJUAJ9as7BAxsMyJ21/lnfOJi4GNRrIM9ZkGb3PKWFnWCPkq3i8psa4z34K5i5w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, Jan 30, 2023 at 09:09:23AM -0800, Bart Van Assche wrote: > Has it been considered to use structure assignment instead of introducing > bvec_set_page(), e.g. as follows? > > bip->bip_vec[bip->bip_vcnt] = (struct bio_vec) { > .bv_page = page, .bv_len = len, .bv_offset = offset }; Unless it's hidden behind a macro it doesn't solve the problem of abstraction away the layout. I'm also find it less readable.