From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9D6AAC636CC for ; Tue, 31 Jan 2023 21:09:46 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1E1E66B0071; Tue, 31 Jan 2023 16:09:46 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 192916B0072; Tue, 31 Jan 2023 16:09:46 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0833C6B0074; Tue, 31 Jan 2023 16:09:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id EF5276B0071 for ; Tue, 31 Jan 2023 16:09:45 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id BCA661202DB for ; Tue, 31 Jan 2023 21:09:45 +0000 (UTC) X-FDA: 80416335930.20.BBCF58C Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id 0F5F9180016 for ; Tue, 31 Jan 2023 21:09:42 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tbik8kpb; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675199383; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=AfD7S9CUOE5+GS/wbdCgPfdB09IRdq5h6mc30CJylQc=; b=Mwfj1l5AQ/AAEcpWbeFpczZAivWmmzr+44U8gE92xF5qD9MwW7W6KZJTlzp95wksocTEbI x5WYoDLJs9OJHr4mvczFoJJ11N73zkCqOcrN2qgZ4E/oK578ahy2Dx7w6mqQQm00RfMPZt MJb9ccervyK3HgCrg0cRc6qJ4LioZe8= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tbik8kpb; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675199383; a=rsa-sha256; cv=none; b=NI2AOp9W858j6hPDJlLYdMnx1b65iCh11Kaz8t15cZytPy6yeWb/mbht1vGg4g0m5626RR RUhQkY1aM0klTHPJf5qZptrnMc6EbALH/bz+JeRqeIjZI3BDeE50Q3Vms5eFpymOnM77vO /Cng3Hn/oWgHPtG1ARyHB2iU0k5NaLs= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 25DD261729; Tue, 31 Jan 2023 21:09:42 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3FD57C433D2; Tue, 31 Jan 2023 21:09:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675199381; bh=Tm1IkHgEuHwmAFiQVyifjp2n8Pl5xNEUo9KiuSOrqUc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tbik8kpbarV1KV7UJ2qY/rFT6JWvSF4fTPKjQOZDQ5YwJSJqII27B4Du3yKbUbjtB GaqKtxSKOtH36tgYcaK4FpuOFBO0CR3qU9Mv5ftUYly94yxlRf8BNDsRDcBLr1ekSN oYa6MIII5NMElrZF0VMR0mZX/aykVy4QOlEGSIsw= Date: Tue, 31 Jan 2023 13:09:40 -0800 From: Andrew Morton To: Hyeonggon Yoo <42.hyeyoo@gmail.com> Cc: Andy Shevchenko , Joe Perches , Petr Mladek , Steven Rostedt , Vlastimil Babka , Matthew WilCox , David Hildenbrand , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH mm-unstable v4 1/3] mmflags.h: use less error prone method to define pageflag_names Message-Id: <20230131130940.94a7d42220857b4c75761b01@linux-foundation.org> In-Reply-To: References: <20230130042514.2418-1-42.hyeyoo@gmail.com> <20230130042514.2418-2-42.hyeyoo@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0F5F9180016 X-Stat-Signature: muifzx6hif5dqx1z5tyhuu13dkp8p1ds X-HE-Tag: 1675199382-836569 X-HE-Meta: U2FsdGVkX1/B3gRtVKTzudLWG/77eGzdsTIggaHoPaNDatGrRLOvjju5soDXUndnnvN+iXcxpYQSf+BvMlVgQrdb/z8gtKJ0oguJcjscrAQug0AEookAwn7srEkUN1PcQUs7Cvq6T8cOExXnpZ/P5fDrl63GdLjYdR8Wb419bUdX6PGQGo09aFAGg0Zi1Tlgjk3kPTkJXQG8YP1HANNbC6078ELgBkDT8V0jb4pQEPtPeL4wr7bvfp/vW0nMPKysWCI6HBShMlIQmeW3Ther9/43QLbdv1J8Bjbwuvd+I46acIdces/IZ8v4AwPcEOFdEJeM7TFpb5poCstzHjXTYREsfj4JuJf8PhOpQS8n0Dssthm8DxT6FCve41EA2S30yKA9CW7q/LzdEZSX5gO9AGf7ZduibTdsgYreWNMWOn4K7B5UytLXq9nah72YOWeFtUf9foy/KdBNK3UCs/2YZbu83Q1yEOMFXfAMt1VigIXndmbEbjdYEMkqtRmNKqu4ux1B4PRb2rzzs9lz7JgcXdLFfJ4lCZQ+YsjWyI4OQJY5tXwx+XV8M8yofQiZlPmN4N3xHi3f07UiriVJ/HbxPH1YT1emwpHmNGHlMPSvjAKPXrA4VGFu1rUOIadVr7JBBe0SxIPD8GsqPp6zgYjJQOzJBs7T+DIGULK8cg1lSHPr27bLN/he+2qSRdujw2jUhvFZum/u4ytzM04F+dSkzYvIT8istfT9yN1d/5gRvtIATAXie7laMNrVAO/eSZ/h9j7zYRoweQ1N9pQ6PpiGuEPERzv/3sMhuVSJ6KXjSnQuQ4f8ZzOpu8hPYhCbtAgIv3pUH/cUgGZpSHMI1474+RtQbZWhp+r5LpPr9iNAMgHv13Bs579qJVnF2uYg2zZD9rOaOFHgYKkqIlt6U6jFbtfxZJpIsd0Ma9qIKxOx962JM76cgjjGbMtGLGpXpnwDhmA2BlXgMxMAnIJGeQB BYwDFBPw rYgyQPkEXgArqaj4y/mWkX19eWnLbSuMiohkG9H0zxQz2+ADg2A96KK5KVZVnZqPH/7JPk0Ngemn5jHWLyWndt+zxXROzfYRi02t6oZa7o8pUzgEZaCJdL1Ff9yG6aJX5xeLeg6q8QOcNsMP0DgvuxA7WUjaEBZZOlhM4cKC7mTO5C0EkAkQcNETE5xwoFSE7ZDR9Q+ToaP/FDMQwsqpxzBQwxBMq3i0eaSnhIYLSqjidfsqkeBQyg7Ou46NziYOYx2+NYsfAI2kzSEZnXsNSj6x6nQu2HmGAnmxKnp10J9ksAK2hVMeWHPT0pc3RFyr/fGgnmTSrEnjJ5HD2CifxawfesX+sG8wxKuoZTZNuv+qKIia8+UYkdzZ1NahQYlp3x5bi9HNRiIl+/HHY95956BSEkEjABNHUHd3lt14xnU93Gem9ZkgKIaqLMxFMcGRfXHtdiQ2GIvkiC8Cabe4hhvkvlhTEP9aT8kEXB/omjhHgXiI= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 Jan 2023 17:38:02 +0900 Hyeonggon Yoo <42.hyeyoo@gmail.com> wrote: > On Mon, Jan 30, 2023 at 02:35:52PM +0200, Andy Shevchenko wrote: > > On Mon, Jan 30, 2023 at 01:25:12PM +0900, Hyeonggon Yoo wrote: > > > As suggested by Andy Shevchenko, use helper macro to decrease chances > > > of typo when defining pageflag_names. > > > > Suggested-by: ? :-) > > oh, yeah I only wrote in changelog forgot to add the tag. > I think Andrew will kindly add that when picking this series up? Sure. We're at -rc6 so I'm slowing down on the features and cleanups. I'll probably park this series for the next -rc cycle.