From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58FE5C636D7 for ; Tue, 31 Jan 2023 21:07:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D7CCC6B0071; Tue, 31 Jan 2023 16:07:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D2D1F6B0072; Tue, 31 Jan 2023 16:07:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BF5C86B0074; Tue, 31 Jan 2023 16:07:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B083A6B0071 for ; Tue, 31 Jan 2023 16:07:20 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 5F856140CE5 for ; Tue, 31 Jan 2023 21:07:20 +0000 (UTC) X-FDA: 80416329840.19.28ED929 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf24.hostedemail.com (Postfix) with ESMTP id 80438180018 for ; Tue, 31 Jan 2023 21:07:17 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oy9jqjN3; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675199237; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=UEPYjdwjev9aqG1xb15sOmni+74hjVITe1nFoL5wO4k=; b=oyLrJBSA4SqqFlMYJissCj+0vy1ZkntuULnUj9VCROauWtwlllwm6gdSrPn43UgpKcnSkd /selE/uxlTccH17XFde53hV+B6tvy65FbRjtrEie8Wpwmc8IPk4c9ne3KK719KxdJn6r1f cji9jjMsgdkds1swGvibrwdtAdREO3w= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=oy9jqjN3; dmarc=none; spf=pass (imf24.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675199237; a=rsa-sha256; cv=none; b=lyadWOXmFgvXoIdvzMqGwLgTXcqWC7jU5Tiv3LYAGkZfF8dci/DAdjsvK+YJ+N0iGcaY6Q +2A5XqsgRg56IKeZgTiYh9LJYVMIcpcgFBxrya4Lq1sIkVmVNmw7Jc88DZKtYBKexTcLfJ Mis00jaNP1b/cMFY2gGszsvI1jltfvE= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D9338B81EB5; Tue, 31 Jan 2023 21:07:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4D89DC433D2; Tue, 31 Jan 2023 21:07:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675199234; bh=4H4iBjRwVxioiqKFCxXizJYSV6KoeP6hWEgfnJdkrEs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=oy9jqjN3LqiTDGhC2GGlKK4sF1VMrdmttEVIY6Lx0hops8uEGrRqAZGqXAn4rP+vy pHPSBcpJC7x4yU5vNGkGICeLVcihx07bHo5W+mmmIPt6AIlQOb7FScmO9rxUGcaiRK ozrQLvmGaUnhG2Cp5cPM/HRlhqsCgWzd4cWGXEng= Date: Tue, 31 Jan 2023 13:07:13 -0800 From: Andrew Morton To: David Hildenbrand Cc: "Liam R. Howlett" , maple-tree@lists.infradead.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-next@vger.kernel.org, Sanan Hasanov , Matthew Wilcox , Hugh Dickins Subject: Re: [PATCH] mm/mmap: Fix vma_merge() offset when expanding the next vma Message-Id: <20230131130713.5d6a5bc9eb0ec957c5d1ba26@linux-foundation.org> In-Reply-To: <72dfedd2-a26a-17f4-87c2-3d71ab3f55b4@redhat.com> References: <20230130195713.2881766-1-Liam.Howlett@oracle.com> <97ea66a4-54a0-68a3-c42b-f3c36c69768e@redhat.com> <20230131142452.sfrmubta4ojejct2@revolver> <72dfedd2-a26a-17f4-87c2-3d71ab3f55b4@redhat.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 80438180018 X-Stat-Signature: j7imefccq68jsqwcaphbxsoue6bniaaq X-HE-Tag: 1675199237-448073 X-HE-Meta: U2FsdGVkX1+g52DJXSBPYHVU3/8uLuFH+QBD13PdKYYdSgOE0y/FnZgwx2vTvqQnA9rZBeWniijUdvTETtb91aB5Ze/P3Wyv5yFPEDp1TW6aq33YXFbt+wLTjBCTCNQpoyyHyYJkQ5DFyzgu26Ntpn0ms5Ww2e7pBeXxS2QTBdeEsSgTnbV3Aq6E2sBe6MEOYu1jBNPL2cCgrR9N7tAk2WzYRwcd6AeItCq54io4vHdZBJH5Xw/ns6Aa0h1uKXyw6O84upHMeiGey0HKvTsG3GLOyBBUQqpZlABCS3RO9c59O1i0BXqDHEoIy26wScl7U7uNxWDc2jxaNh8Z7XnDK8MRd/O9B7g4pOdKcNWdalGMoiqdpVCw8t8XPbsvbUSxkmTDb8ItEf+ZDA+tZYpFUirdae4nqJSZpelysCIjkKv1MhkPrcK5birKxd+wEJ+MNHCDztZeb4vhZRdd54EXtyERE+Khy6NLlW1pLhfwJ0vQaHfrH32QvDSiP9sebHgOqEa34UFPH4qkbYdMA/0u4nFO1pO7+AzbPSe8+hwlOuYSl8PtyBCYo94Y2LUBCLc6uJGnB6xIgO2vPCsSjLDKuHESXyqcHVk1ESw6e+pF0KpLghuxLI9GoslhW+AhprHZ1GNnYApVZWdCtlfU/y6M2C7SE3hX1xTpckXv9B5VzZSe/DFxpD9jIb4c54PhH5f4hxT+fqvAEmTcdmiOAUadrwhoqNCt7vwckwSHfmPED7u3A1varg5xozkzAQFRv1GXvfaE1dek6JvkOTCMpSOHXkazT2kpECd/KTYhbDmc3TC9aa2RiLVl71b0XIesDIEaaqjLAP/Ho2pqyKhzbgfX8ZRiim2bK/IxvvugrGRKd8eTETzUP3ajzZnFw3LNHGQ/TYT3I6XNhWK9Hh5nP0REtVt+SNaQmkkhk8Z1rCRRFH2bqVeHkPupnGbGHdfF5/IZRlf4jZsvUqEochDUivh jyjO9sAw 9KM3mmbQgZH5ImT20msFwtpcVCEXXX77RnIIGbobSVph57H/XVMgtU3vfa99nt358EuACN3KEtBt2PmEWh2sLUCWb7rlNvh/+cywttTt5Fo6WWQcYpfTlq38TdhrcXScHyDonessTVNWL4AsFdXdir5SjB2/xhpERGWe7RmNEzAFyFAsOFDtWpVdqC5kWj9ESqx38VA+lFoRN+uieB4mc+cFNs3Z7iaf7idvGaK/Bygj5yvRc1MjBYACuOsmOr6gP7lGTk7z5GhF95O+RFqacKhYvUI8JpMeas28mvli6Tz5uS6+samWBY0kZg4lzmzBYPs1iWyHQmrPxIImDalgAi3WykmqMwmggPLvZJoobRRtq5OEEqWp2zHjuqWfj+oUaCG39iqx+toGXnum0P3L/mkPUshkRbVpIOeM8Vk5ER9/fKGD4zP22WLszy+bSviErY0V1CtnNOsZK5rxJ3roGXKjY78CFfYTxqgbhC+dw9GbSX1W6lHGc7a0e++ocAcU0cWgEZyhqb71ukq6xy6IQh/twuZAKBDwgVVhmaWxtIOkkxV3/L18f2ComL0Ce5lVib5FB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 Jan 2023 15:29:59 +0100 David Hildenbrand wrote: > On 31.01.23 15:24, Liam R. Howlett wrote: > > * David Hildenbrand [230131 03:35]: > >> On 30.01.23 20:57, Liam R. Howlett wrote: > >>> The vm_pgoff was being set incorrectly when expanding the next VMA to a > >>> lower address. Fix the issue by using the mid->vm_pgoff value for this > >>> merge case (aka case 8). Note that this does not change case 3's > >>> vm_pgoff as next and mid are the same VMA. > >>> > >>> Reported-by: Sanan Hasanov > >>> Link: https://lore.kernel.org/linux-mm/IA1PR07MB983017D2FBA174D2FF78CEB6ABCE9@IA1PR07MB9830.namprd07.prod.outlook.com/ > >>> Cc: Matthew Wilcox > >>> Cc: David Hildenbrand > >>> Cc: Hugh Dickins > >> > >> Fixes: ? > > > > Fixes: (soon to be invalid git id :) ("mm/mmap: remove __vma_adjust()") > > Ah, right, upstream was not affected ... :) > > ... so this should be squashed into that commit instead as long as it > doesn't have a stable ID. Yup, I queued this as mm-mmap-remove-__vma_adjust-fix.patch so it's to-be-squished. Generally, please let's tell people when a patch fixes something which is staged in mm-unstable - to save a few brain cycles and to hopefully improve review. A Fixes: with no SHA works, or simply "this fixes X".