From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6FB8AC636CC for ; Tue, 31 Jan 2023 20:54:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 104576B0071; Tue, 31 Jan 2023 15:54:01 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0DC696B0072; Tue, 31 Jan 2023 15:54:01 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EE7366B0078; Tue, 31 Jan 2023 15:54:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id E17346B0071 for ; Tue, 31 Jan 2023 15:54:00 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id C11BF140CB6 for ; Tue, 31 Jan 2023 20:54:00 +0000 (UTC) X-FDA: 80416296240.07.E91B9EC Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf09.hostedemail.com (Postfix) with ESMTP id 0C5FA140002 for ; Tue, 31 Jan 2023 20:53:58 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hHngKerx; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675198439; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=DlWa/X9Xqg4rn1kbZaLGpEIeCf72z0xPJ7E0FXlOLtQ=; b=N/s4BGstE+0fpBhz9W63x92dLc2ygozDMs804YvfIEHzR4+jHcMpfIg2C4xpyTBxKOr5UK DaBrQRxstQvt/SdqvNQe3QPCzjct1swMswui0wIogcdIaGJWOsSaQCmFsB2PWho0kUYaA+ 6fcaJ69zGAUYElREYkEU+w0DStVtmkY= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=hHngKerx; dmarc=none; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675198439; a=rsa-sha256; cv=none; b=KL/c5ZheP0hcKb/8LP1vWnv2gHNAssWYv5nhU3FoPaw/MBspndmGdDEjOjSOZZ+B9VOczD sRgbDY65e3Rvc/bp+6Xo2mekEebWViQIZNPZMv1Kdr9wQT/lOa3tdOPQuzWPzkhofWB9P8 hCXnxyte1IE9RMtGznp+/sxtDMPux14= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 030BF61708; Tue, 31 Jan 2023 20:53:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EB5F4C433EF; Tue, 31 Jan 2023 20:53:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675198437; bh=jHy4qpmBfs5JB+49uMUbT6ZlxxySVk0qKxcOzh21LsU=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=hHngKerx0MW9zufZtMuQZEzHh3CP4ijBQc0AQ3au4woHogCVYIXIgmCDTB3X1PFRX FoL9w9mszj2lnuZGJN/zx9flw95uDHtCKgSsx9iQE3VP9KxUjOpK8pO+iR/Iaaw1/A H0saKzFa8Zb51o2dQFJzCGUfalgCpK/aouzY88j4= Date: Tue, 31 Jan 2023 12:53:55 -0800 From: Andrew Morton To: Suren Baghdasaryan Cc: Hyeonggon Yoo <42.hyeyoo@gmail.com>, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, mgorman@techsingularity.net, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, rppt@kernel.org, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com, Sebastian Reichel Subject: Re: [PATCH v4 4/7] mm: replace vma->vm_flags direct modifications with modifier calls Message-Id: <20230131125355.f07f42af56b23bfa28b2a58c@linux-foundation.org> In-Reply-To: References: <20230126193752.297968-1-surenb@google.com> <20230126193752.297968-5-surenb@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 0C5FA140002 X-Stat-Signature: mxynt7wcsktoy19mkhbpaxmdwigmm5w4 X-HE-Tag: 1675198438-454869 X-HE-Meta: U2FsdGVkX19LNIx3RhfFOZ9vMonEGuPtJEfjZFK+w+tJHLAFdAPZq4B4vIKdziXrk0F3kC8dRseqfjjVayAPmu0vJ7TdoGlLXPmU4W/h9R9z7s6aZTISQvpzsCNUrKduqHwfR3JxKRxwRY8v4F6eUU7qaDTovQIC3CciPLjodCWEHdVF+Rod6mzkmzRRRysvjDMsU2476h6wSK8BR8J5frSsLleFjzdrOd+6bgrKC8s03YskbrsIwmxH5l/mKDjeayyTibeKNWQXPmNXkz+T3UYNI+HNFcUcw35VUGBodH/iC7DJsxQ7DLdKz55B9mALOw9O8jzDWgIGHTQseMIFiAof3ywDpa6D1pwPTNPFonwKZIXLr6MzyMfwGaNlQLFs+/NT5GF8gurMsC0tDsGM86UdED5iv0VQUgZuNE368ECWIyVXquaRBeEndeO3VCCgTTmulyNNsOLpJrxuHgw5rNps5J0DN4W9dELxhPd0vkrPm2/1L4ih+oaXoyevCzCOpoc0+dSWmu+jLYkdyPwjS0+gwUpW5cgRDEDNI3dsOzDBc9jCHf0crJoSAN9GnqygCv9t+JHWMRh8DNz8z0+fwJz0jqWJvKy4QlbgDeAIzbH5ly3hS6bugnl61M6wdAi7O0/+rex5iM5ZHsvQxWY/zGIIHvjGGs0mC64dAGD71TJmlvdaScYCPVpb3eVBsCL/WNc9J7BPt3bipEoOdwlNn2bpWi0s9k1sXFqzVBQh5aWD1QpH9DGJwOeaeEmhmgLPat5Y6HisvCxxMbOyPsz5BELRU+OEafEy5LtiCC7dSddjka/NttcPtGBBAdectVKouNTBURyiE0mkTTVdn9yAji4IPMcykjLT3ZWnNkTsFZDKaP+k50nH+AnFRx4WDDUMAzS2hAvpafnOhyBcWp+QJ/JW6q1p1P6chV1gsE/VH40Jt+pTiA4csdtXKVkRu9h4EFYCyXBCR7KC0GpHOu0 oe33bl63 nRLnmZcmDBzx0kXUkzAZMNyw+ybpLKALyd5VfkqFc44tazTsAzSrvr0sCE+UYDC4NSC3z4PtCCiVLENEtgQubvoE50Mze1Wgez+2qcyphG4a/RBh4EKl86EZE2NMuH0082HC5FxQVy3B2DsibosjMlRjNVq0sMvsFKfJ9lhR9FhSNIRsQxJYd7uCNO6sC1e/8c6va9xuymaJEoWNswDx4sLAkVUofupd+nZhZ9BU2fhgbMKjqsxd1ZQXXFfz+8b2Hrk0CXUMmcfbbIZvWO1SdSqHKIJ5XxyJ4SagBwkutUqgbXbMItFg/vPE2v1DUMiwHjla7wDkZzw0WYwW0/USDgXPmXoiUDPTshtskFMnHKwMguPPc5EQvCAd2fUNYpgRuGu/DpUQCwAVjJhOfZN93Lhl7R3PrY7r5ZuBcvYU4jqSA5q6VwdxcjeMO/rDaTl4+ABb7NEVeU3vL7n0GYJKz+++M/j0gaVFdQ1+thXqxZM0cjK0= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Tue, 31 Jan 2023 10:54:22 -0800 Suren Baghdasaryan wrote: > > > - vma->vm_flags &= ~VM_MAYWRITE; > > > + vm_flags_clear(vma, VM_MAYSHARE); > > > } > > > > I think it should be: > > s/VM_MAYSHARE/VM_MAYWRITE/ > I added the fixup. Much better than resending a seven patch series for a single line change. Unless you have substantial other changes pending.