From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id B063CC38142 for ; Tue, 31 Jan 2023 04:48:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3B09C6B0074; Mon, 30 Jan 2023 23:48:08 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 33B866B0075; Mon, 30 Jan 2023 23:48:08 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 1DA846B0078; Mon, 30 Jan 2023 23:48:08 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 0A5626B0074 for ; Mon, 30 Jan 2023 23:48:08 -0500 (EST) Received: from smtpin17.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id CD9D7A5EF9 for ; Tue, 31 Jan 2023 04:48:07 +0000 (UTC) X-FDA: 80413862214.17.33A0F0C Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf07.hostedemail.com (Postfix) with ESMTP id 09EBA4000F for ; Tue, 31 Jan 2023 04:48:05 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dARP7ELm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of kuba@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675140486; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=SMy4AhdFGD9NV+ZMw++exFusPY18E/iROcgJAJj2buw=; b=S3ALwiUVTLHfq3ckbW44uUXyoz4dGro2dBsyd3dq0Wqx1WP+h9sSW0EBpKpp8nmNnzFw1F 4WsKfGgueVNQqI+voTtM+cgAnObQBLcTaYBdTqitIqNGfDUXPDIMAziCiZk2/XYvzdW2QL exCHRFGQi6KIxtecAfRYWvLBEgxBIhE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=dARP7ELm; dmarc=pass (policy=none) header.from=kernel.org; spf=pass (imf07.hostedemail.com: domain of kuba@kernel.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=kuba@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675140486; a=rsa-sha256; cv=none; b=j8PKvZ1Y6KRIsK22z4Wl4eS5fgWWcZyvgAN3QqwO/a4WmV35HdGwo9plo0VJ4mQfxCdzi3 e1MfQ3XNv4MxB0xeULLjrU4tfNhiRQZ5KaWY1yiNUUMNG0YHLe+/mqyQFQlU4Tv0sR8zbj 3L9fNorO1OHB1vKECT3cPXCT3v4prAg= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D2A26B81914; Tue, 31 Jan 2023 04:48:02 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D0504C433D2; Tue, 31 Jan 2023 04:47:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1675140481; bh=CWgleLhFsY7fdAWz2/GYSNCWb5dkQP977u3wpy/hMGw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dARP7ELm0JDZUtfdf/aZ8jH1JD0CLl7hoXoH78TsDhjc1mmn8JFRG1IigOhyzOTIR 8LpgawDRtBw86IFXj6i1YkeRts+SWuJNykJYmlH/aIgncIrOZjAf+V+/CmtP/KRDAr VQCKDZAbOX7gqYp11J79NeVN8tSKvri14UKFB/PyE8wFl5jc+kE8t46/tFsmTWzcUR 7y905w/ePF+771Ea1UzytT2Miv5ypO2Q07DAhG9UQz+0Eikry/PkH6GHvO2153a1Tl gFsQ/iFj+f+SWMdPgkH2tVoOS0Nrv5jbsqd1Sdse8+GqnLYQ5xf/0l8xGGH0jIGlb6 ELagiuszQyNWQ== Date: Mon, 30 Jan 2023 20:47:58 -0800 From: Jakub Kicinski To: Christoph Hellwig Cc: Jens Axboe , Ilya Dryomov , "Michael S. Tsirkin" , Jason Wang , Minchan Kim , Sergey Senozhatsky , Keith Busch , Sagi Grimberg , Chaitanya Kulkarni , "Martin K. Petersen" , David Howells , Marc Dionne , Xiubo Li , Steve French , Trond Myklebust , Anna Schumaker , Mike Marshall , Andrew Morton , "David S. Miller" , Eric Dumazet , Paolo Abeni , Chuck Lever , linux-block@vger.kernel.org, ceph-devel@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-nvme@lists.infradead.org, linux-scsi@vger.kernel.org, target-devel@vger.kernel.org, kvm@vger.kernel.org, netdev@vger.kernel.org, linux-afs@lists.infradead.org, linux-cifs@vger.kernel.org, samba-technical@lists.samba.org, linux-fsdevel@vger.kernel.org, linux-nfs@vger.kernel.org, devel@lists.orangefs.org, io-uring@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 01/23] block: factor out a bvec_set_page helper Message-ID: <20230130204758.38f4c6b9@kernel.org> In-Reply-To: <20230130092157.1759539-2-hch@lst.de> References: <20230130092157.1759539-1-hch@lst.de> <20230130092157.1759539-2-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 09EBA4000F X-Stat-Signature: r96tnt58rcpcihb5kaug433wektt49je X-HE-Tag: 1675140485-304210 X-HE-Meta: U2FsdGVkX197NubGTa9UcVDsjBIJZY0vzQjr3Mj0EpIwxodzE78yfzIrfN9oHUq/IuVYdfcOShROhLxdRtvClVLnja2yfpR8ArStFXE9YNzNbk754keN31Cq4eudONdAuyptAejHxBlcImu/G3UqG9pqmSaPTb0Ab2ii03mx4X31/UqcTlwfV/cT3czpceFg/IntHS+Wbs1w7zZyZZFCrZhSJE4+rYd4wFYx9Wi7DgpVxGgqxfU7KG5qSpFqofMPrBaB2OJQVlgpnZQa2Pn6v3jOBzxzBVBrqLgEMt/Ex0WDG8DwuztaNWa/flsADePLGuJeadUAtp4C5KkMPT/LoYt0HnjQyAZmqIJut0IBl0B3wo+3lZVcuBPaBTi1e0C9z9JQaGMIvLTplUBicJdU3E46omKCOb3x8aHqKG4T1Rhqx/eAU4UJDDLoyuQn88ESDZjIYXeL7zdsEBKaRSwCxEOmHwrWodnDX6JTeGvLq/7GO69XPTLsmcFD9oC37zOR/b+y0Z5P6kgilAlxtOV1op4+Ap6voWfU6YLmhAERTM7vfg6Sfi0CKlN78NVaTvYuMEAWutDtuk0RBqY42dJGsxoAEV7bPLLP/zMI6tRbfk/Zz28I0O8q3I3JdVYL5fp1fmCNp24MsNGqW5YtKO3ZETnYy3fVRxZ/+0kMF03ZnZhNVP5p+2wmdEbrsd1mLPwF3oDyq9ZDpPW8Dq0LNbykfI+citnvHv0jebNpYKDJHF+yfwyf89DY/0PiPqQIwwC4cft1seVe2fXE8fshsOVMJy5erwZJ4HHuBPUr418J5MPhrrG9hNReM9RnF1ofliLYH6ioJ/GNa5Et4t6VrzQFQ/axX7qW8z1GgdiluCY60JqsDZecC8YuUI1GaBRp5g0zNQlfPq9LiTXxAiF5Z/V3bsJmDTjRrLUxZDo2lW0P0NQnMl54x2OZTbwab0TSVD9XzAVXUUq5ZREW2CgVLEJ iNzy+hsC ihTUzHBcNgpqImEVHkw4zQZA1EsjJGkMV9iOtU8RWLBLq6J2OrqYUA/kqcC3hLk6glREKqMEpoBTnDl1w1Jmxk623aq4wex85DoyBKWJx/2ByIM3vWAtrLCkI1M8hmy2KFqijQqGTNgYg3d+Jac5A94jGX2nlzKRu4kMTxOdu0d3/zd/fsk2+/Pe8WXgdUOS/haABpL+N9+iA4raBknziuzR5dhK3msLkFus4cFX8Ut3Wb6UI+GcCOjWyA4CbNFtVNPNU7S0/3Ek98ixMG5k5ds/5g+Irkr3jq2DuCYEsJq9rz68NHLH0NRX4ac3DOAciygOOvv5mJaywBFmZA5exnjjO8SJFiJatfA2PfbaHhXviPbc= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 30 Jan 2023 10:21:35 +0100 Christoph Hellwig wrote: > diff --git a/include/linux/bvec.h b/include/linux/bvec.h > index 35c25dff651a5e..9e3dac51eb26b6 100644 > --- a/include/linux/bvec.h > +++ b/include/linux/bvec.h > @@ -35,6 +35,21 @@ struct bio_vec { > unsigned int bv_offset; > }; > > +/** > + * bvec_set_page - initialize a bvec based off a struct page > + * @bv: bvec to initialize > + * @page: page the bvec should point to > + * @len: length of the bvec > + * @offset: offset into the page > + */ > +static inline void bvec_set_page(struct bio_vec *bv, struct page *page, > + unsigned int len, unsigned int offset) > +{ > + bv->bv_page = page; > + bv->bv_len = len; > + bv->bv_offset = offset; > +} kinda random thought but since we're touching this area - could we perhaps move the definition of struct bio_vec and trivial helpers like this into a new header? bvec.h pulls in mm.h which is a right behemoth :S