From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18CEFC61DA4 for ; Tue, 31 Jan 2023 00:18:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F3876B0072; Mon, 30 Jan 2023 19:18:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 27B6D6B0073; Mon, 30 Jan 2023 19:18:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 11C166B0074; Mon, 30 Jan 2023 19:18:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 9C3E46B0072 for ; Mon, 30 Jan 2023 19:18:24 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 541201C60D3 for ; Tue, 31 Jan 2023 00:18:24 +0000 (UTC) X-FDA: 80413182528.18.FCC54C2 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf27.hostedemail.com (Postfix) with ESMTP id 8196940016 for ; Tue, 31 Jan 2023 00:18:21 +0000 (UTC) Authentication-Results: imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KKWH2oaf; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675124301; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=ldMPaa+Sh8bkY27kP/AAnSF8lbeVmvSDT6aZJNThBkc=; b=OVyTah5MIQDJpcQu5beQjwlz8b7TU3n0tXh9WqW1+uSArowV5b++ImAZ+gQj9o3RhWY1eY AZkSveEVFF1oybOk1u2TtQTysyZQVINMRvQZUKEvP3Cbl4dx+6tXq8Yblzr67VxzUON6jo mWQHKeBxTPHmU5kPY7eRKhMSu7UA3aE= ARC-Authentication-Results: i=1; imf27.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=KKWH2oaf; dmarc=none; spf=pass (imf27.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675124301; a=rsa-sha256; cv=none; b=qKl3V88lgpvKrXAfqhnykB47OYzmaUJprUl1LykHNa4JaVlR4QCDO9NPU8g1WIZ/m6Q53n 3/12Xa/NGsmG53Atb9p0/eBS1fI2fpS42uXFhH6RoUy2VIBAnc027AUrw7YMwUSJYW1plQ NBQsoKc7JdaXSMxNgxin4SIT4OcQaLU= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 876C5B818BD; Tue, 31 Jan 2023 00:18:19 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD241C433D2; Tue, 31 Jan 2023 00:18:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675124298; bh=D6HuYaK6uFnV+17yJgYm6A0P1hNUhkEhRQI956sTQig=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=KKWH2oafy4OGC2F1B+a5QAZv1h157wMz1o9xpDNbQex3QUGmmkgkuSZnnqB1OYSCU tx0ssl1nlNZsjAgeike36lhd5q+3fr2gPqHsnTCDwghWY+Fa5fvMrWmHLGUEc6YJJT Dqy7GUFTPvN7SkaLrs5pMPEsvl8rwv/UQ6FVZPk4= Date: Mon, 30 Jan 2023 16:18:17 -0800 From: Andrew Morton To: andrey.konovalov@linux.dev Cc: Marco Elver , Alexander Potapenko , Andrey Konovalov , Vlastimil Babka , kasan-dev@googlegroups.com, Evgenii Stepanov , linux-mm@kvack.org, linux-kernel@vger.kernel.org, Andrey Konovalov Subject: Re: [PATCH 01/18] lib/stackdepot: fix setting next_slab_inited in init_stack_slab Message-Id: <20230130161817.a13365bca60543e34da27f48@linux-foundation.org> In-Reply-To: <9fbb4d2bf9b2676a29b120980b5ffbda8e2304ee.1675111415.git.andreyknvl@google.com> References: <9fbb4d2bf9b2676a29b120980b5ffbda8e2304ee.1675111415.git.andreyknvl@google.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Queue-Id: 8196940016 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: eg4kfexxqknosffzprp3i53jwx6a9zfr X-HE-Tag: 1675124301-760999 X-HE-Meta: U2FsdGVkX1+SpghRnswuAgMiURX9Q7u+VQ5z81lqpO1Zg116cw0wG8Vv/z3zVYq8G0b+TjA7oViLgrSzOFpQXDmlAva+ioblSn+EEGqIFdmN+qjMTr3tY9N9vrXBtaQbAZcXJuqVDDpkUSTUjVhPQJToV0UOw5Q7CCnbQpM08ynb17MiSU54IM2321c3bFAPQ/LSys7CvU3Go/XoLR+ULngIW5/fgBBAcXtN+TxuO+6SuIU/lysBJ8tOKtN9EzQEMfpOL54m1y/c8rrNlWEtp+Hc8pqGqAev9e5M7goFLW4j3MXUiB6Lc6yAlOPXh3uglEHK5kNQilSV65rzCBq77lbN8Gv0m9cQJj86Io9SAgsuUJS6BoDKq1Kim8OxJ9OYg9yN4iDZNpHd4kmZdqsoJBgOTv6im7ap/AGbBx3cx0ei5fqOWmtFtyZxOPJ28oIZeVw+u2udBmSfovGSgF6282JZcFMBqIXzhJrW/p24nx0lteGqIy2n4lhlqVgCv5AhGqnBMUmLdM7llD8QCAJoWc3L4rfoPU4cFeFZUCDdXOw0olfr3U2vbm2rpm+Cq5jtdLOfCR4vDNS52DA4Bh742HO8WRLZL/fsIFWN6TtlFuJox0Bwa8P5zTOAQkXj2l9NKGEC8PowxF1duwykYxN3poOkJQCUv84y9xB44FNU/t16BrJ4a2PGDb1N4hMG7J+ZnN5shfzpwaytOS41Z3eYQwa3+BlIS/cg+QK1ZMdthRL+RgoYsMRG0J0SbBCRCzlW4IdrErWivMgBUVETAvQDzxV+/Syx6caARiiLoW6BPyHTJzC/TyZWO8Jg+uUUy94IbvbyzgrSx9pk0aA2P0ShZG8idVM5QJjMK5jkT71Be45XZ9Mf3OVxM0nLt61jjzRIcnyMGqx53sO91TWC7z/4CeJDxrEBuehZOKQfLn0dgyde71K1ZWoWI6HT7MJqasEvdDh/XXXPc7iFcVxb9Am 52b1haQr 6C+6JlZL4+ia0T3GXUo223IVPoCFAYPKnRKAzgLSkjaSTSZnPQLBIANk6MrpqU0DhlPqkPu/4CfF/+jaw4h23UP6tE13XZGK1kydKK+w/rOlcugLK3wfPZhNDXbAIJgsFq7Gi45J6jmI2z5+OtFdkKX0cO3AT2M+vqTh5PirNgrI+q3kLgF9nbGMD6rDjTAz+w5WgWdobALiQsgD6+j09WXqSyG4Q4jVfEruWoyh26kInFWFZyAj7j/lzs3Dmk3ciXBeCfg2Thuff57CnFPyOjvl+mxf0igI+KDINayei8J4ALxXEilSzOulTvz7pz5lN4w+TYGHTCtdm61r4B17mcIXxkWeKOcnXhGQ9MzAdKH01jxOP6kR0nlKfU8o3nhDylh77XJUnnNRQ8v4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Mon, 30 Jan 2023 21:49:25 +0100 andrey.konovalov@linux.dev wrote: > In commit 305e519ce48e ("lib/stackdepot.c: fix global out-of-bounds in > stack_slabs"), init_stack_slab was changed to only use preallocated > memory for the next slab if the slab number limit is not reached. > However, setting next_slab_inited was not moved together with updating > stack_slabs. > > Set next_slab_inited only if the preallocated memory was used for the > next slab. Please provide a full description of the user-visible runtime effects of the bug (always always). I'll add the cc:stable (per your comments in the [0/N] cover letter), but it's more reliable to add it to the changelog yourself. As to when I upstream this: don't know - that depends on the user-visible-effects thing.