From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3998BC54EAA for ; Mon, 30 Jan 2023 07:31:58 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1F1966B0072; Mon, 30 Jan 2023 02:31:58 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1A2656B0073; Mon, 30 Jan 2023 02:31:58 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 069738E0001; Mon, 30 Jan 2023 02:31:58 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id EC2E96B0072 for ; Mon, 30 Jan 2023 02:31:57 -0500 (EST) Received: from smtpin02.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id B2945C03CD for ; Mon, 30 Jan 2023 07:31:57 +0000 (UTC) X-FDA: 80410646274.02.7F40DF3 Received: from r3-22.sinamail.sina.com.cn (r3-22.sinamail.sina.com.cn [202.108.3.22]) by imf17.hostedemail.com (Postfix) with ESMTP id 4460C40007 for ; Mon, 30 Jan 2023 07:31:52 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.22 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675063916; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=BvtFbcYVCn5FXPK7Wd6qZLYtvkST2WzhoM8MeneM2R8=; b=D8jg6XTzyT6vDDnn3m3jmNZ4FfZdWBIiki7PZDaEMBbnACvGga2H7qPTjBK6ahdV2ZNIgH XZVv/rcGaImBpKJXUHvG6MgkpZ/9wAa0fBH4rco0fxPdHycoSUPvKXn8aDANDraU+lEYCq OrYtrrEtRoJw93bYlgpVoAejhAfCxKc= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf17.hostedemail.com: domain of hdanton@sina.com designates 202.108.3.22 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675063916; a=rsa-sha256; cv=none; b=lEewDlW5kcLTLKouZacPaKSq95457U3S/SnxbX8fz/TgegFfrvjaO4L8GWgMI43qcFRMlC ut3/nXEN62r4PA5KXL4maUmE1WQhvp8BydAfJAYcgbnDUknyictjHM7CzL5cch9On89KfP +u2GRo21L+RV0K0xSYLyChNfLCi2eE0= Received: from unknown (HELO localhost.localdomain)([114.249.61.130]) by sina.com (172.16.97.32) with ESMTP id 63D7717100019E43; Mon, 30 Jan 2023 15:27:47 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 84156629389 From: Hillf Danton To: syzbot Cc: edumazet@google.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, netdev@vger.kernel.org, Boqun Feng , peterz@infradead.org, Tetsuo Handa , Linus Torvalds , syzkaller-bugs@googlegroups.com Subject: Re: [syzbot] possible deadlock in team_del_slave (2) Date: Mon, 30 Jan 2023 15:31:36 +0800 Message-Id: <20230130073136.59-1-hdanton@sina.com> In-Reply-To: <00000000000008229305f374404a@google.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Queue-Id: 4460C40007 X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: x77kkpm5yoqbxzsnedeogpoqt1sx3731 X-HE-Tag: 1675063912-800117 X-HE-Meta: U2FsdGVkX18TeLwZ5rbkZ9jBqYOBITh0IHoutLI0li+2Jo4XoQGd+r441WT3jx0/JjRWWfDz1EkqVrLql10uw+hCrD/qdRgmh+jjrCT1tCvTxWcTRNhD4RY4i/tkFEGJRNHQUkXm9XZduJCHjGPTHptle4pV5uNuTreLFZI7vqMtAOTC8E8qnE6lXGo7EBXK6t6LOz9GkTf2tBlXX3ELWm6VKUVq0FCd0fQS54KSxzzSSUJaDEuSG2RRHLbKhqDylnsvyGYKDoVNbYuN3eypWl2HAZ3NoF8osiPEo0FPeHnxHvmqfsNL4CQAmKSYLOOM6nHYivDKsJW74iTFEiDT09e2IrVIPteNLM6hcIV8D3IKGhdyfcHWwxpf27kuiaSWEM9G4unw7Xk3DOvbt3l1qkxPcUVOrq8SlhHwr4dEum7ruOEEzsBoXGnqohNgFYra9T34yVbVGusfN9s1dCyNHXOdhSdwdJC/TTp4bshhYCtnySwau8BtTV7xrCh6N104+u8Fmat6WhJ/GAdBCOjHl/Lb7vUqXo6p+vZbLMRaL1+cJdpDXeODXCgYq0j5Bb+gyj+VcSBu3kyOXavjzvh8hrNJ0vJl9G1OBeRQ/96iNYyuk3/qf8WLcL1fZKgXQb810S8yq0MGPywF8C/VQ7YppW3w4Lds/RJOmLHkQS/OCori2xWc/fK+tm1CgWLvbWA4+5IVGCFw4u0zmTU80rkawFiuExKpxuf22W4KkQyKs7pZ5BUiRttqQisiUk8tSFAEvV95vsUoXB6g5aDvmX/CcnmjBaFaOL3QWWqUNLxqxbR3G9348MSiu5vxGJwGZ15SA8kfJKwKchOD45U9ZlU0qtSIDYV69QPXzmzzP/IqZZ4EmQgXUMAD8zOUWegB+Mz6ghtGTLzV2RT4MDUk+oy/+UFcKLbXzEgfi71Sgf7FvvSnDTA8bo9RyHpiRrtYs/Qgd8uXxyW1cX8Rp87Ic4y p3k2AMz0 j4V58H1+oG/Q+7qX6CcxI0HvCE4h3x5Txz7BVYvpABKcI4d89Md361Y8rKUEwN3375wsvXajlgBlRQRyT4g/o0yPhjPd7bhF/q+suF8WDO20rwwWF/9grHst/Iu+e6+KIYIlJKEMC7eC8ZVh50E5WO+wb44/OHYkYjhNZ55UeH6QOzcFAn+29/tUWQJy3WJcnb84mZQiSOtZ3spxn1aZQ3uBMWMmJxUoPsAI1EnNeKwMMq0Aptu8l9IOZtCJKbYxPKCAAPomglA+K6SzCyNLoqfD1eOnQkeQYxHaegn65IiE9HmjmxTUEpX39lQ9Vq6msG6+1K1gtH4RWNtuOWJuJdLkdoYnis1YL0LkAvhZhnNqfSe56dCer/9K2dDvsDJTgtVxIIGQoTS1DBppB8lr/qT6KmKbkmCs7jUflawLNYkd6Hp3jo8/9yEYMPnHHQ6jsOCfXTdl+GNVUecfIXk1H3lFWylfUPI+74Q+iv0eCsPm8Ff7WMb6PKzchU8SsFFqr5w7Dss1Ufw+qONEnboagQ0SperQlsiez7vcUIlHcjs5hXQWbSTi1jLju2+IHbJBtMTiFL2leEuf+TZFmSQehchJNDQyx0Thu7wnVErqlgusI3UI59nLpVvCAoAB3f2n9ZiSzMgAK+VZUSKjv39zNXNozlCmW3rVdK1k27M/WG2rbM+dLyKU+HeW1I6/k6Hivn541GkYsaQJe+8FlhKnSr5kwINh/x4Uw6NviipG6C2X9924MIg7PWspwyMAySVX74T0xF8s7YeIbwdyroOiN3cCh281epXAljZVVhjm4b05Tc12WDrMAWYwSLKRQMNlmZse68FFxjEoI7M7dI9HDiBSq1KxMHKzl+1l7cSWYY1VZclv/ysDcJVny92rwbjYX1ahewGbd+2DSTIoIDtpC0KgwHQ57W3u+PCGZj6qC204j71c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 29 Jan 2023 21:11:39 -0800 > syzbot found the following issue on: > > HEAD commit: 83abd4d4c4be Merge tag 'platform-drivers-x86-v6.2-3' of gi.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=1169c315480000 > kernel config: https://syzkaller.appspot.com/x/.config?x=1adb0905dddc79ba > dashboard link: https://syzkaller.appspot.com/bug?extid=1c71587a1a09de7fbde3 > compiler: gcc (Debian 10.2.1-6) 10.2.1 20210110, GNU ld (GNU Binutils for Debian) 2.35.2 > > Unfortunately, I don't have any reproducer for this issue yet. > > Downloadable assets: > disk image: https://storage.googleapis.com/syzbot-assets/27a2378a1d32/disk-83abd4d4.raw.xz > vmlinux: https://storage.googleapis.com/syzbot-assets/311b7677d1f2/vmlinux-83abd4d4.xz > kernel image: https://storage.googleapis.com/syzbot-assets/eac6c271be29/bzImage-83abd4d4.xz > > IMPORTANT: if you fix the issue, please add the following tag to the commit: > Reported-by: syzbot+1c71587a1a09de7fbde3@syzkaller.appspotmail.com > > ====================================================== > WARNING: possible circular locking dependency detected > 6.2.0-rc5-syzkaller-00108-g83abd4d4c4be #0 Not tainted > ------------------------------------------------------ > syz-executor.5/19937 is trying to acquire lock: > ffff88801ed2ecf8 (team->team_lock_key#2){+.+.}-{3:3}, at: team_del_slave+0x31/0x1c0 drivers/net/team/team.c:1998 > > but task is already holding lock: > ffff888036730728 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0xfb/0x190 net/wireless/nl80211.c:4328 > > which lock already depends on the new lock. > > > the existing dependency chain (in reverse order) is: > > -> #1 (&rdev->wiphy.mtx){+.+.}-{3:3}: > __mutex_lock_common kernel/locking/mutex.c:603 [inline] > __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 > wiphy_lock include/net/cfg80211.h:5633 [inline] > ieee80211_open net/mac80211/iface.c:437 [inline] > ieee80211_open+0x193/0x250 net/mac80211/iface.c:424 > __dev_open+0x297/0x4d0 net/core/dev.c:1417 > dev_open net/core/dev.c:1453 [inline] > dev_open+0xec/0x150 net/core/dev.c:1446 > team_port_add drivers/net/team/team.c:1215 [inline] > team_add_slave+0xa03/0x1c70 drivers/net/team/team.c:1984 > do_set_master+0x1c8/0x220 net/core/rtnetlink.c:2617 > do_setlink+0x89b/0x3bb0 net/core/rtnetlink.c:2820 > __rtnl_newlink+0xd69/0x1840 net/core/rtnetlink.c:3590 > rtnl_newlink+0x68/0xa0 net/core/rtnetlink.c:3637 > rtnetlink_rcv_msg+0x43e/0xca0 net/core/rtnetlink.c:6141 The BKL is acquired in rtnetlink_rcv_msg() [1] 6138 rtnl_lock(); link = rtnl_get_link(family, type); if (link && link->doit) err = link->doit(skb, nlh, extack); rtnl_unlock(); [1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/net/core/rtnetlink.c?id=83abd4d4c4be#n6141 > netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 > netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] > netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 > netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1942 > sock_sendmsg_nosec net/socket.c:714 [inline] > sock_sendmsg+0xd3/0x120 net/socket.c:734 > ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 > ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 > __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > -> #0 (team->team_lock_key#2){+.+.}-{3:3}: > check_prev_add kernel/locking/lockdep.c:3097 [inline] > check_prevs_add kernel/locking/lockdep.c:3216 [inline] > validate_chain kernel/locking/lockdep.c:3831 [inline] > __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 > lock_acquire kernel/locking/lockdep.c:5668 [inline] > lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 > __mutex_lock_common kernel/locking/mutex.c:603 [inline] > __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 > team_del_slave+0x31/0x1c0 drivers/net/team/team.c:1998 > team_device_event+0xd7/0xad0 drivers/net/team/team.c:3022 > notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 > call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1944 > call_netdevice_notifiers_extack net/core/dev.c:1982 [inline] > call_netdevice_notifiers net/core/dev.c:1996 [inline] > unregister_netdevice_many_notify+0xa2b/0x19e0 net/core/dev.c:10839 > unregister_netdevice_many net/core/dev.c:10895 [inline] > unregister_netdevice_queue+0x2e5/0x3c0 net/core/dev.c:10776 > unregister_netdevice include/linux/netdevice.h:3059 [inline] > _cfg80211_unregister_wdev+0x64a/0x830 net/wireless/core.c:1157 > ieee80211_if_remove+0x1e3/0x390 net/mac80211/iface.c:2228 > ieee80211_del_iface+0x16/0x20 net/mac80211/cfg.c:202 > rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline] > cfg80211_remove_virtual_intf+0x10a/0x3b0 net/wireless/util.c:2497 > nl80211_del_interface+0x106/0x190 net/wireless/nl80211.c:4330 > genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968 > genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline] > genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065 > netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 > genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076 > netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] > netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 > netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1942 > sock_sendmsg_nosec net/socket.c:714 [inline] > sock_sendmsg+0xd3/0x120 net/socket.c:734 > ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 > ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 > __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > > other info that might help us debug this: > > Possible unsafe locking scenario: > > CPU0 CPU1 > ---- ---- > lock(&rdev->wiphy.mtx); > lock(team->team_lock_key#2); > lock(&rdev->wiphy.mtx); > lock(team->team_lock_key#2); > > *** DEADLOCK *** > > 3 locks held by syz-executor.5/19937: > #0: ffffffff8e14f8d0 (cb_lock){++++}-{3:3}, at: genl_rcv+0x19/0x40 net/netlink/genetlink.c:1075 > #1: ffffffff8e0b4328 (rtnl_mutex){+.+.}-{3:3}, at: nl80211_pre_doit+0xb4/0xab0 net/wireless/nl80211.c:16161 > #2: ffff888036730728 (&rdev->wiphy.mtx){+.+.}-{3:3}, at: nl80211_del_interface+0xfb/0x190 net/wireless/nl80211.c:4328 This is a false positive lockdep detection given rtnl_mutex ignored on both sides. Hillf CPU0 CPU1 ---- ---- rtnl_mutex rtnl_mutex lock(&rdev->wiphy.mtx); lock(team->team_lock_key#2); lock(&rdev->wiphy.mtx); lock(team->team_lock_key#2); > > stack backtrace: > CPU: 0 PID: 19937 Comm: syz-executor.5 Not tainted 6.2.0-rc5-syzkaller-00108-g83abd4d4c4be #0 > Hardware name: Google Google Compute Engine/Google Compute Engine, BIOS Google 01/12/2023 > Call Trace: > > __dump_stack lib/dump_stack.c:88 [inline] > dump_stack_lvl+0xd1/0x138 lib/dump_stack.c:106 > check_noncircular+0x25f/0x2e0 kernel/locking/lockdep.c:2177 > check_prev_add kernel/locking/lockdep.c:3097 [inline] > check_prevs_add kernel/locking/lockdep.c:3216 [inline] > validate_chain kernel/locking/lockdep.c:3831 [inline] > __lock_acquire+0x2a43/0x56d0 kernel/locking/lockdep.c:5055 > lock_acquire kernel/locking/lockdep.c:5668 [inline] > lock_acquire+0x1e3/0x630 kernel/locking/lockdep.c:5633 > __mutex_lock_common kernel/locking/mutex.c:603 [inline] > __mutex_lock+0x12f/0x1360 kernel/locking/mutex.c:747 > team_del_slave+0x31/0x1c0 drivers/net/team/team.c:1998 > team_device_event+0xd7/0xad0 drivers/net/team/team.c:3022 > notifier_call_chain+0xb5/0x200 kernel/notifier.c:87 > call_netdevice_notifiers_info+0xb5/0x130 net/core/dev.c:1944 > call_netdevice_notifiers_extack net/core/dev.c:1982 [inline] > call_netdevice_notifiers net/core/dev.c:1996 [inline] > unregister_netdevice_many_notify+0xa2b/0x19e0 net/core/dev.c:10839 > unregister_netdevice_many net/core/dev.c:10895 [inline] > unregister_netdevice_queue+0x2e5/0x3c0 net/core/dev.c:10776 > unregister_netdevice include/linux/netdevice.h:3059 [inline] > _cfg80211_unregister_wdev+0x64a/0x830 net/wireless/core.c:1157 > ieee80211_if_remove+0x1e3/0x390 net/mac80211/iface.c:2228 > ieee80211_del_iface+0x16/0x20 net/mac80211/cfg.c:202 > rdev_del_virtual_intf net/wireless/rdev-ops.h:62 [inline] > cfg80211_remove_virtual_intf+0x10a/0x3b0 net/wireless/util.c:2497 > nl80211_del_interface+0x106/0x190 net/wireless/nl80211.c:4330 > genl_family_rcv_msg_doit.isra.0+0x1e6/0x2d0 net/netlink/genetlink.c:968 > genl_family_rcv_msg net/netlink/genetlink.c:1048 [inline] > genl_rcv_msg+0x4ff/0x7e0 net/netlink/genetlink.c:1065 > netlink_rcv_skb+0x165/0x440 net/netlink/af_netlink.c:2574 > genl_rcv+0x28/0x40 net/netlink/genetlink.c:1076 > netlink_unicast_kernel net/netlink/af_netlink.c:1339 [inline] > netlink_unicast+0x547/0x7f0 net/netlink/af_netlink.c:1365 > netlink_sendmsg+0x91b/0xe10 net/netlink/af_netlink.c:1942 > sock_sendmsg_nosec net/socket.c:714 [inline] > sock_sendmsg+0xd3/0x120 net/socket.c:734 > ____sys_sendmsg+0x712/0x8c0 net/socket.c:2476 > ___sys_sendmsg+0x110/0x1b0 net/socket.c:2530 > __sys_sendmsg+0xf7/0x1c0 net/socket.c:2559 > do_syscall_x64 arch/x86/entry/common.c:50 [inline] > do_syscall_64+0x39/0xb0 arch/x86/entry/common.c:80 > entry_SYSCALL_64_after_hwframe+0x63/0xcd > RIP: 0033:0x7fbab9c8c0c9 > Code: 28 00 00 00 75 05 48 83 c4 28 c3 e8 f1 19 00 00 90 48 89 f8 48 89 f7 48 89 d6 48 89 ca 4d 89 c2 4d 89 c8 4c 8b 4c 24 08 0f 05 <48> 3d 01 f0 ff ff 73 01 c3 48 c7 c1 b8 ff ff ff f7 d8 64 89 01 48 > RSP: 002b:00007fbaba92a168 EFLAGS: 00000246 ORIG_RAX: 000000000000002e > RAX: ffffffffffffffda RBX: 00007fbab9dabf80 RCX: 00007fbab9c8c0c9 > RDX: 0000000000000000 RSI: 0000000020001000 RDI: 0000000000000004 > RBP: 00007fbab9ce7ae9 R08: 0000000000000000 R09: 0000000000000000 > R10: 0000000000000000 R11: 0000000000000246 R12: 0000000000000000 > R13: 00007ffff9cf40df R14: 00007fbaba92a300 R15: 0000000000022000 > > team0: Port device wlan0 removed > > > --- > This report is generated by a bot. It may contain errors. > See https://goo.gl/tpsmEJ for more information about syzbot. > syzbot engineers can be reached at syzkaller@googlegroups.com. > > syzbot will keep track of this issue. See: > https://goo.gl/tpsmEJ#status for how to communicate with syzbot.