From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AF75C61D97 for ; Sun, 29 Jan 2023 21:00:20 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E76456B0072; Sun, 29 Jan 2023 16:00:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E26D16B0073; Sun, 29 Jan 2023 16:00:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D15046B0074; Sun, 29 Jan 2023 16:00:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id C2FB66B0072 for ; Sun, 29 Jan 2023 16:00:19 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 9868840915 for ; Sun, 29 Jan 2023 21:00:19 +0000 (UTC) X-FDA: 80409054558.26.AA9A057 Received: from outbound-smtp03.blacknight.com (outbound-smtp03.blacknight.com [81.17.249.16]) by imf07.hostedemail.com (Postfix) with ESMTP id B56EC40009 for ; Sun, 29 Jan 2023 21:00:16 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.16 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675026017; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=JFjtoq2RgpOdmIskpS003I0oI7C8dP1XqO+3fCduI94=; b=pszKci1aFmUuAjxGJNiJ6VeVEKvrgvRlu1MGpEYks8uwX9389DpKG39QJWFt4OFPOdpY0A U0/3W43AUMcu+2Tntt8VQYkOo07wiLWIfMta2ark1PcgV1SXrtQ+7OGgePPP99Zl/SEEi4 qU5mqGQxLsSdmZfDlpttz1FNGIC7ktk= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=none; spf=pass (imf07.hostedemail.com: domain of mgorman@techsingularity.net designates 81.17.249.16 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675026017; a=rsa-sha256; cv=none; b=vuznvaSlZtMvwdh14WrcWW1UI97MpRIz/1JIEOpQ3J9JSASKvWpiyhdGsY67Rj0fwoCYY8 1qKbzmk3waClMZBeAQWTlSNQ5DCLwpsWDi2Ee+kXHaixZ0dcrWmroZIMhcdgUBO/uG+Msi 37e/SBwyTwzByr4uTU1fBmx0W4LPT2Y= Received: from mail.blacknight.com (pemlinmail01.blacknight.ie [81.17.254.10]) by outbound-smtp03.blacknight.com (Postfix) with ESMTPS id EB770C0C23 for ; Sun, 29 Jan 2023 21:00:14 +0000 (GMT) Received: (qmail 9970 invoked from network); 29 Jan 2023 21:00:14 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 29 Jan 2023 21:00:14 -0000 Date: Sun, 29 Jan 2023 21:00:12 +0000 From: Mel Gorman To: Vlastimil Babka Cc: Andrew Morton , Jiri Slaby , Maxim Levitsky , Michal Hocko , Pedro Falcato , Paolo Bonzini , Chuyi Zhou , Linux-MM , LKML Subject: Re: [RFC PATCH 0/4] Fix excessive CPU usage during compaction Message-ID: <20230129210012.ghvweg5kqlqeu3xu@techsingularity.net> References: <20230125134434.18017-1-mgorman@techsingularity.net> <20230125171159.355a770a2e34f78d7664e1f0@linux-foundation.org> <7ad2cbdc-8589-3aa2-b16a-41336f849f65@suse.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <7ad2cbdc-8589-3aa2-b16a-41336f849f65@suse.cz> X-Stat-Signature: e3gc8m1fzg1jwwnrhp84qh4iy3agrgch X-Rspam-User: X-Rspamd-Queue-Id: B56EC40009 X-Rspamd-Server: rspam06 X-HE-Tag: 1675026016-268960 X-HE-Meta: U2FsdGVkX19ghR26Xw7sSvG1WG43xkYT8QTWqXd3lMigPcpe/5KMit3qjY8C2+IJgLAS5miL/00U3Igy3NrCtvooKHaTlRLPn8xzivwnVh4HO0CGtJixz2at1Vxl2LrqMNUlJOFi1C2YSTSmk8WT8cS26n6avL30Njt7VmNA5BcxiY5xg4Y5DoZhKFOmQBy9foJqF8B3ByzdvXB0iIdrDk56I/BchDl9JvkXlfS6h0qDfl8YUBag6H5gFBj9EmYoi7xgqa0wspT6Dj+wkZxRmFlkJ34iuK1pVqyzUP9nZCuJnzwlZh3tTMkULSeJchaNi3Jc6YhPilxWuku9lC2+00/mRZNhLLUTkjkH4wbjY2SGwyLXosNXYhnKa4+zq8STApNbvelCzrsQpacWEn0OZsJOr5ADq4gUlILU6e7f9VXBmoOWCJkeltLxQAvKG6654BVYLg1AWAU4TUtQR2nAdmQBZThdAWcvlw44YlcW/VtY6uj2NmTN58w3UKxLvJn6RhiZppsWU7m9SC4HFtRQqAmTFp0NU4P5nshO8sjIeostnr2nnQf4wnetXuEh3ymuOl1r5EKe5uMVjxRR4Gw1nnfH70+r1gZgoLLSTeQeLyQVdgTCSNtxagh/JxeRlxjJaedaobng745OVdiQuZwLs1q6IvhR2CnbpAvFv9P2Rpo1Mg7ONXeHLfrgZxxQMpTiuoa9Ic+RQYWrIeT8J33gSlCb/I0B2X21bLE26SikAhcTz4sLhCgopuVif/w5rAfzRzD4D4LMV2yGX0jtS4WjaNTRRS5y6zqU7QKX3t3nnk7Fq6D/DbcQeW3zxp67UdeMPJ++aIHqmCS8PedTwbz3t40S6sQRb5DmQ6Wc0EFqIC/3z/nEne+5wJSItfeYNayWeC6FJtB2eM7ySMEt2nSdPAyThQoZGUr72R9Yol4wh/5VMBvh3DJilg47DRnM1wERfPT7Qinft9cBlupjkzY XTyGnwH8 zUjG6Jir+Q30BiXPf/+pb3pBIjRNRiY9cJ+suubpXsV9T3GI9PMP8lbxPQDA+7xzXL0xJtfUL7iNNTcPOh94uftpyFu53Uj/zkGBwJA2L0EX3GGl1Zb1MkycKykUmd7WeH7JdW00svIsM+64YRpqiMW/xZQEvBTsmnxU4Zy5XYhT3iUfltf7WSG4a68REBTszd48rmnJkTXw62qOC1MOeNWjYBtv4uhU5UhMGca1tfHxYl0C+6fH0O3s3UyVk3jUOiBbjaMCZa/THgiolzxXSoDKk3CKMgWQsTv2g5Gn/BMy0Xjg5s2Se8db3QQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, Jan 29, 2023 at 07:03:54PM +0100, Vlastimil Babka wrote: > On 1/26/23 02:11, Andrew Morton wrote: > > On Wed, 25 Jan 2023 13:44:30 +0000 Mel Gorman wrote: > > > > If we drop Vlastimil's reversion and apply this, the whole series > > should be cc:stable and it isn't really designed for that. > > > > So I think either > > > > a) drop Vlastimil's reversion and persuade Mel to send us a minimal > > version of patch #4 for -stable consumption. Patches 1-3 of this > > series come later. > > > > b) go ahead with Vlastimil's revert for -stable, queue up this > > series for 6.3-rc1 and redo the original "fix set skip in > > fast_find_migrateblock" some time in the future. > > > > If we go with b) then the Fixes: tag in "[PATCH 4/4] mm, compaction: > > Finish pageblocks on complete migration failure" is inappropriate - > > fixing a reverted commit which Vlastimil's revert already fixed. > > > > I'll plan on b) for now. > > Agreed with the plan b). I couldn't review this yet due to being sick, > but I doubt I would have enough confidence to fast-track the series to > 6.2 and 6.1-stable. It's subtle enough area and extra time in -next and > full -rc cycle will help. I hope you feel better soon but for what it's worth, I think it also deserves a full -rc cycle. I've been running it on my own machine for the last few days using an openSUSE stable kernel with this series applied and I haven't had problems with kcompactd or khugepaged getting out of control (monitored via top -b -i). However, I have noticed at least one audio glitch and I'm not sure if that is related to the series or not. Compaction is more active than I would have expected from intuition but I've also never had reason to monitor compaction on my desktop so that's not very useful in itself. My desktop is a very basic environment (awesome WM, no fancy animations) and the times when my machine starts thrashing, I also expect it to because it's the weekly "run git gc on every git tree Friday evening if X is idle more than an hour". -- Mel Gorman SUSE Labs