From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2328BC05027 for ; Sun, 29 Jan 2023 21:41:54 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 559066B0072; Sun, 29 Jan 2023 16:41:54 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 508F16B0073; Sun, 29 Jan 2023 16:41:54 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3D0946B0074; Sun, 29 Jan 2023 16:41:54 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 216BD6B0072 for ; Sun, 29 Jan 2023 16:41:54 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id ECE5C1C4CCE for ; Sun, 29 Jan 2023 21:41:53 +0000 (UTC) X-FDA: 80409159306.14.1DAD4A0 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf09.hostedemail.com (Postfix) with ESMTP id F2A1B140002 for ; Sun, 29 Jan 2023 21:41:51 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XIojVudB; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1675028512; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bV2ktWxFWdBtNLehZwmUWlu8hY/K9vbmKxg35LYKlpU=; b=ITNRJJ0+XnBuKo/z11lU6MiUsxARUF8H4aRgJAyAIEnPhlhfXH0X60gA/q7s/bWqs13jdW 1bzBt2Y7stuiy9tveJDm0tzG7jWUWOyh87s99DVM5YKMrkgrJ8YWzoIRdWArT9pry0+fKC 3IsrOk0ozDEePgUjxmyui5nqKZKOoVk= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=XIojVudB; spf=pass (imf09.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1675028512; a=rsa-sha256; cv=none; b=pMZg9of+ogFWrJ4RBWYnYLRWnLIv3zBmbTiYgkOjt4NcOLRSsvfmwlpWZiNGAFM+edyOwC 2/iHpXjZGUPyWvQVLFoRycuMtmsNpPKm3n4SOoOvZpPse0SUZikhGRvicXUvAB3+H21LgQ iWi/732NpAacuNgmSuLHdCjqHLGRBf8= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 6513DB808CD; Sun, 29 Jan 2023 21:41:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 93234C433D2; Sun, 29 Jan 2023 21:41:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1675028508; bh=hqXHTO4VkNQRccP0ht1WlUlKvTkgK5Dy4nZapxrAJPw=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=XIojVudBxrOJhjBRRvRiy+4k16/u4kp1zbQwV9TS/l210sipQl1kb+pKGFKMiqcwl nn6Uzusfp1gjNyW518MN8oXHnXMQWooV3x57CK0cSuaZLDD7RzynjNZ/iPqbaLHUcs MQnptE2bVS1qXGchZq62tR8LUM+dkbUTAybnrL8o= Date: Sun, 29 Jan 2023 13:41:47 -0800 From: Andrew Morton To: Liu Shixin Cc: Catalin Marinas , Will Deacon , Uladzislau Rezki , Christoph Hellwig , , , Subject: Re: [PATCH RFC] arm64/vmalloc: use module region only for module_alloc() if CONFIG_RANDOMIZE_BASE is set Message-Id: <20230129134147.f19ca0641f1133f3e3bc185b@linux-foundation.org> In-Reply-To: References: <20221227092634.445212-1-liushixin2@huawei.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: gjk7niyf3a9xdturmzwo8d54w8hzex4q X-Rspamd-Queue-Id: F2A1B140002 X-HE-Tag: 1675028511-355346 X-HE-Meta: U2FsdGVkX1+vEUVvl6Oganu61twPRR6zIY144eN8rSYp7CUO9Dpy6CIFO29Fu8nf3QeQ1L5Biej4f8XrA4/kAlOOTWa3kgDoxMfpXhefnH6YoiVk0ZlG00qb5dIpjpVYGZRi91B/ua4TBV68NOemDllKOXfpnE1ut4HZpTwSIQ9DpE1G2DH4+szyujqMvY0d2p2+JdlLEO1W302/B5O5fAF0fCVvwcRWSx5N3OCygdCcGoYyahrFxmsGpAyUWGwqhdSFO5ugHaDlkl16rbPlFg/IvAhT6xUvqN2cVclW/VXu4kpOFlHW4PhGzC08PNnn9e7vK62yhW/cIh62794VtRHdDRabaBZiGtjQPF2dkHVVBrZmRl3pJKn5G1LvGyd1et6IcxY+S7xyOq8jjucEbhyzYFu92HH/ulWNvLu02eSUa0X4UDKSJ+O/THQZ5TnK57FJhBWRF9K6Nw+YlQXo17WvESQSrPwJH48YejfijBZuT8UDtfWSjcwwv053soNXF+gcPfavpKBaTC0XfYWZKwPG9xRsJ4Lr+LLBTO0DXGIw14DlbvegQlIq3XEFPn2RSmKvtspWnkbnIU1zS7nCfFPKVVmUIKb7pgUdc/LFuEOJQEREwgvTTaU6Ii2RT0S++13/r342pGmnlE0dS4l0HHUwOnWQjoSFo/emFXmbyzHEsLqLZb/kERq6LP73IMzPgOMaDvmp6XazwG/Z7ZHF9mkZpUsCjKpl2ecR3ibefdkfJkxPQZj2D4+AEUN8gqwsfd7PAJ44y114ayMJbftEKcDY0bpWiU4KUMxdWxy7EOiLG1rqb8eFllu7bWbhPLzoE0FC0ZmPZJ0kHXYphZ0TQEM6tLdiZUnByyPxdPCs8xixIGglfB82WLVkTKO0MC42wgg0wO6QYlRTJIQR5pVsoSVLUJRnzJgDPSb+SEp38q7xcQzyDWB/2ce5qDSs+aGw8/qz/6TWwxSpRAk931S SniazaTP vBLFxJZGQUVceasf9b/mvCLhqfQTILug9DqgxDcZDbDUhmcHYJSo/Q5PzimWhss8KRi34OK8mYEvBRAwMr/PGpUJg6t1YV5WaOWjuqtNxOgIoCoZgc8AWIyWs9UeWRu/mfT3VrZbxU/atgF9jhOFYToXZpse84X1sOeDfILNJhe6NDzojhn+yVUZR3mRqXktElR5GGmxplEfXIwGO73eNDZI02JEVsCytP7NGEtKHID9FKfz28hjtws8w+kPFmbOOSsB2RmdlITGlL9Ng9YUiJMYkRb1nmqgaapz1QOOy/4ZcolEQMOPwiTGtIvyu/5Z/BMoU5auQ4/xCGkWiXRZua4Cw6Gqk/55nZ3BCM0oMu12+dbqd3iCQWLu5rxdCs5TDIoUFldHkBhnV/q6PfxJkw1mqkmWg9i8WwMOg9ms9M6YW2AjYlhxOWeB+RG/zvCN81N7A3bn2ZKNlgUx6gBzUxLphLA== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Sun, 29 Jan 2023 10:44:31 +0800 Liu Shixin wrote: > Hi, > > > This patch seems to have been lost in the corner. Recently I've meet this problem again > > on v6.1, so I would like to propose this patch again. > > > Thanks, > > > On 2022/12/27 17:26, Liu Shixin wrote: > > After I add a 10GB pmem device, I got the following error message when > > insert module: > > > > insmod: vmalloc error: size 16384, vm_struct allocation failed, > > mode:0xcc0(GFP_KERNEL), nodemask=(null),cpuset=/,mems_allowed=0 > > > > If CONFIG_RANDOMIZE_BASE is set, the module region can be located in the > > vmalloc region entirely. Although module_alloc() can fall back to a 2GB > > window if ARM64_MODULE_PLTS is set, the module region is still easily > > exhausted because the module region is located at bottom of vmalloc region > > and the vmalloc region is allocated from bottom to top. > > > > Skip module region if not calling from module_alloc(). > > I'll assume this is for the arm tree. Acked-by: Andrew Morton