* [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier()
@ 2023-01-29 4:06 Tong Tiangen
2023-01-30 8:17 ` Huang, Ying
0 siblings, 1 reply; 2+ messages in thread
From: Tong Tiangen @ 2023-01-29 4:06 UTC (permalink / raw)
To: Andrew Morton, Aneesh Kumar K . V
Cc: linux-mm, linux-kernel, Tong Tiangen, wangkefeng.wang, Guohanjun
In find_create_memory_tier(), if failed to register device, then we should
release new_memtier from the tier list and put device instead of memtier.
Fixes: 9832fb87834e ("mm/demotion: expose memory tier details via sysfs")
Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
---
mm/memory-tiers.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
index c734658c6242..e593e56e530b 100644
--- a/mm/memory-tiers.c
+++ b/mm/memory-tiers.c
@@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty
ret = device_register(&new_memtier->dev);
if (ret) {
- list_del(&memtier->list);
- put_device(&memtier->dev);
+ list_del(&new_memtier->list);
+ put_device(&new_memtier->dev);
return ERR_PTR(ret);
}
memtier = new_memtier;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier()
2023-01-29 4:06 [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier() Tong Tiangen
@ 2023-01-30 8:17 ` Huang, Ying
0 siblings, 0 replies; 2+ messages in thread
From: Huang, Ying @ 2023-01-30 8:17 UTC (permalink / raw)
To: Tong Tiangen
Cc: Andrew Morton, Aneesh Kumar K . V, linux-mm, linux-kernel,
wangkefeng.wang, Guohanjun
Tong Tiangen <tongtiangen@huawei.com> writes:
> In find_create_memory_tier(), if failed to register device, then we should
> release new_memtier from the tier list and put device instead of memtier.
>
> Fixes: 9832fb87834e ("mm/demotion: expose memory tier details via sysfs")
> Signed-off-by: Tong Tiangen <tongtiangen@huawei.com>
> ---
> mm/memory-tiers.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/mm/memory-tiers.c b/mm/memory-tiers.c
> index c734658c6242..e593e56e530b 100644
> --- a/mm/memory-tiers.c
> +++ b/mm/memory-tiers.c
> @@ -211,8 +211,8 @@ static struct memory_tier *find_create_memory_tier(struct memory_dev_type *memty
>
> ret = device_register(&new_memtier->dev);
> if (ret) {
> - list_del(&memtier->list);
> - put_device(&memtier->dev);
> + list_del(&new_memtier->list);
> + put_device(&new_memtier->dev);
> return ERR_PTR(ret);
> }
> memtier = new_memtier;
Good catch! Thanks!
I think that this should be in stable since v6.1.
Best Regards,
Huang, Ying
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-30 8:18 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 4:06 [PATCH -next] memory tier: release the new_memtier in find_create_memory_tier() Tong Tiangen
2023-01-30 8:17 ` Huang, Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox