* [PATCH v2] mm/migrate: Continue to migrate for non-hugetlb folios
@ 2023-01-29 3:39 Chen Wandun
2023-01-29 5:23 ` Huang, Ying
0 siblings, 1 reply; 2+ messages in thread
From: Chen Wandun @ 2023-01-29 3:39 UTC (permalink / raw)
To: akpm, linux-mm, linux-kernel, ying.huang; +Cc: chenwandun
migrate_hugetlbs returns -ENOMEM when no enough hugetlb,
however there may be free non-hugetlb folios available,
so continue to migrate for non-hugetlb folios.
Nowdays the only negtive return value of migrate_hugetlbs
is -ENOMEM, keep compatible for coming negtive return value
instead of ignore return value.
Signed-off-by: Chen Wandun <chenwandun@huawei.com>
---
v1 --> v2: modify changelog and comment. thanks Huang Ying.
---
mm/migrate.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/mm/migrate.c b/mm/migrate.c
index b971edbf32fc..68927aa06f9b 100644
--- a/mm/migrate.c
+++ b/mm/migrate.c
@@ -1939,7 +1939,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
rc_gather = migrate_hugetlbs(from, get_new_page, put_new_page, private,
mode, reason, &stats, &ret_folios);
- if (rc_gather < 0)
+ /* There may be free non-hugetlb folios available, continue to migrate. */
+ if (rc_gather < 0 && rc_gather != -ENOMEM)
goto out;
again:
nr_pages = 0;
--
2.25.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v2] mm/migrate: Continue to migrate for non-hugetlb folios
2023-01-29 3:39 [PATCH v2] mm/migrate: Continue to migrate for non-hugetlb folios Chen Wandun
@ 2023-01-29 5:23 ` Huang, Ying
0 siblings, 0 replies; 2+ messages in thread
From: Huang, Ying @ 2023-01-29 5:23 UTC (permalink / raw)
To: Chen Wandun; +Cc: akpm, linux-mm, linux-kernel
Chen Wandun <chenwandun@huawei.com> writes:
> migrate_hugetlbs returns -ENOMEM when no enough hugetlb,
> however there may be free non-hugetlb folios available,
> so continue to migrate for non-hugetlb folios.
>
> Nowdays the only negtive return value of migrate_hugetlbs
> is -ENOMEM, keep compatible for coming negtive return value
> instead of ignore return value.
>
> Signed-off-by: Chen Wandun <chenwandun@huawei.com>
LGTM, Thanks!
Reviewed-by: "Huang, Ying" <ying.huang@intel.com>
>
> ---
> v1 --> v2: modify changelog and comment. thanks Huang Ying.
> ---
> mm/migrate.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/mm/migrate.c b/mm/migrate.c
> index b971edbf32fc..68927aa06f9b 100644
> --- a/mm/migrate.c
> +++ b/mm/migrate.c
> @@ -1939,7 +1939,8 @@ int migrate_pages(struct list_head *from, new_page_t get_new_page,
>
> rc_gather = migrate_hugetlbs(from, get_new_page, put_new_page, private,
> mode, reason, &stats, &ret_folios);
> - if (rc_gather < 0)
> + /* There may be free non-hugetlb folios available, continue to migrate. */
> + if (rc_gather < 0 && rc_gather != -ENOMEM)
> goto out;
> again:
> nr_pages = 0;
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-01-29 5:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-01-29 3:39 [PATCH v2] mm/migrate: Continue to migrate for non-hugetlb folios Chen Wandun
2023-01-29 5:23 ` Huang, Ying
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox