From: Wupeng Ma <mawupeng1@huawei.com>
To: <akpm@linux-foundation.org>
Cc: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
<mawupeng1@huawei.com>, <kuleshovmail@gmail.com>,
<aneesh.kumar@linux.ibm.com>
Subject: [PATCH v3 4/4] mm/msync: return ENOMEM if len overflows for msync
Date: Sat, 28 Jan 2023 14:32:29 +0800 [thread overview]
Message-ID: <20230128063229.989058-5-mawupeng1@huawei.com> (raw)
In-Reply-To: <20230128063229.989058-1-mawupeng1@huawei.com>
From: Ma Wupeng <mawupeng1@huawei.com>
Check and return 0 if len == 0 at the beginning of the function.
Return -ENOMEM if len overflows for msync.
Signed-off-by: Ma Wupeng <mawupeng1@huawei.com>
---
mm/msync.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/mm/msync.c b/mm/msync.c
index ac4c9bfea2e7..3104c97d70d3 100644
--- a/mm/msync.c
+++ b/mm/msync.c
@@ -46,13 +46,16 @@ SYSCALL_DEFINE3(msync, unsigned long, start, size_t, len, int, flags)
if ((flags & MS_ASYNC) && (flags & MS_SYNC))
goto out;
error = -ENOMEM;
+ if (!len)
+ return 0;
+
len = (len + ~PAGE_MASK) & PAGE_MASK;
+ if (!len)
+ goto out;
+
end = start + len;
if (end < start)
goto out;
- error = 0;
- if (end == start)
- goto out;
/*
* If the interval [start,end) covers some unmapped address ranges,
* just ignore them, but return -ENOMEM at the end. Besides, if the
--
2.25.1
next prev parent reply other threads:[~2023-01-28 6:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-28 6:32 [PATCH v3 0/4] Add overflow checks for several syscalls Wupeng Ma
2023-01-28 6:32 ` [PATCH v3 1/4] mm/mlock: return EINVAL if len overflows for mlock/munlock Wupeng Ma
2023-02-03 17:14 ` David Hildenbrand
2023-02-06 0:48 ` mawupeng
2023-02-06 17:05 ` David Hildenbrand
2023-02-07 1:24 ` mawupeng
2023-02-08 13:51 ` David Hildenbrand
2023-02-09 11:35 ` mawupeng
2023-01-28 6:32 ` [PATCH v3 2/4] mm/mempolicy: return EINVAL for if len overflows for set_mempolicy_home_node Wupeng Ma
2023-01-28 6:32 ` [PATCH v3 3/4] mm/mempolicy: return EINVAL if len overflows for mbind Wupeng Ma
2023-01-28 6:32 ` Wupeng Ma [this message]
2023-02-03 17:10 ` [PATCH v3 0/4] Add overflow checks for several syscalls David Hildenbrand
2023-02-06 0:52 ` mawupeng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230128063229.989058-5-mawupeng1@huawei.com \
--to=mawupeng1@huawei.com \
--cc=akpm@linux-foundation.org \
--cc=aneesh.kumar@linux.ibm.com \
--cc=kuleshovmail@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox