From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E062BC38142 for ; Fri, 27 Jan 2023 10:17:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4A6F46B0078; Fri, 27 Jan 2023 05:17:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 457806B007B; Fri, 27 Jan 2023 05:17:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 347736B007D; Fri, 27 Jan 2023 05:17:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 2501C6B0078 for ; Fri, 27 Jan 2023 05:17:28 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E9776141064 for ; Fri, 27 Jan 2023 10:17:27 +0000 (UTC) X-FDA: 80400176934.19.36E4358 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by imf03.hostedemail.com (Postfix) with ESMTP id EC83A2000D for ; Fri, 27 Jan 2023 10:17:24 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KW2hxf9s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=E8zZEMSn; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf03.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=mgorman@suse.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674814645; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=BvSAvLPB3FHEPhqZN7UODvQNd2e9U7VcApyqDZZQ1ck=; b=d8+7DbVSk4cD2Gb9SBSECF8faZuEO+xwyr+ooROc8F5pk6IyUXP1xuAL/WHDzlAFW03R8w djj3jkHuCNJfoFJRpJ8Ate7q7zcOvXrWaCwjc0f33RrQdMFycsKQMgskGjtEndiyK681ZX qv16agY1z/xqq39kvLcgTPm2jSGM0TE= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=suse.de header.s=susede2_rsa header.b=KW2hxf9s; dkim=pass header.d=suse.de header.s=susede2_ed25519 header.b=E8zZEMSn; dmarc=pass (policy=none) header.from=suse.de; spf=pass (imf03.hostedemail.com: domain of mgorman@suse.de designates 195.135.220.29 as permitted sender) smtp.mailfrom=mgorman@suse.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674814645; a=rsa-sha256; cv=none; b=AnNRDKyMYFNVNqz+5PA0ZGl/YYJ0XHrG9+OMdL5e3jh5rzhvIXTe8JPE2I2w3UEuemLcGL pkMMpyRMr/hpKjsxfB+C2KQgCN1gGMHno1FtkHJbcCI9RCR4Y4FqLqXTUsgg1TW//TQtHw oKFCiuCZzbXNWlRecJ9JuCVd3BTt0s4= Received: from relay2.suse.de (relay2.suse.de [149.44.160.134]) by smtp-out2.suse.de (Postfix) with ESMTP id A6EC5201D6; Fri, 27 Jan 2023 10:17:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1674814643; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BvSAvLPB3FHEPhqZN7UODvQNd2e9U7VcApyqDZZQ1ck=; b=KW2hxf9sVZKKqI9WrbdoibHXiEUpC0RDrtyzeo/AOG7AocgFe9+i9+yogOZOtWu+jofMCR ZwgMhgzaJ/jA4NGWzHSEcJmZ2/udsO2jkr4uWWgom0JM3t7XzP1OCksJBtqcU7hWM0VEUh uRPaS8J2g+In/F9qvsWiGzSPSjTPT3s= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1674814643; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=BvSAvLPB3FHEPhqZN7UODvQNd2e9U7VcApyqDZZQ1ck=; b=E8zZEMSnSEVlY5ZdXZLAzR8c35trocWed4TMrKvvS0NZnjS8ke6gtxLlCIL0Z62xzDYGOy Gqu7jEZYQ/4R0zAw== Received: from suse.de (unknown [10.163.43.106]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by relay2.suse.de (Postfix) with ESMTPS id 51CAD2C141; Fri, 27 Jan 2023 10:17:22 +0000 (UTC) Date: Fri, 27 Jan 2023 10:17:20 +0000 From: Mel Gorman To: Raghavendra K T Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Ingo Molnar , Peter Zijlstra , Andrew Morton , David Hildenbrand , Bharata B Rao , Disha Talreja , Mike Rapoport Subject: Re: [RFC PATCH V1 1/1] sched/numa: Enhance vma scanning logic Message-ID: <20230127101720.qh2wramyfyyucxhx@suse.de> References: <67bf778d592c39d02444825c416c2ed11d2ef4b2.1673610485.git.raghavendra.kt@amd.com> <20230117145951.s2jmva4v54lfrhds@suse.de> <10a06a2f-0dfc-6f36-3b7b-f4fd03153f66@amd.com> <118c2f4a-58d7-de42-1f77-31ac8a4d4701@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <118c2f4a-58d7-de42-1f77-31ac8a4d4701@amd.com> X-Rspamd-Queue-Id: EC83A2000D X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: kkxc6kksdtxguaxc35itwp3koqnm6r1c X-HE-Tag: 1674814644-338964 X-HE-Meta: U2FsdGVkX19lfPVltyB05Ndf66lDpMnNH0l8eW6M+3zjxnkk6F6hCGe017TqJ7tL6oRAT3t01lyUZxb8ziUui0GJfIrZF7TDRzZgcozsQfBaUeL2DoBAp+hjFPxkJ7hXGewhUaMBKYrbkANYlygIbGcOkZzqIONWR3f5wEC5iuunC9ZZCif6JRyoB2ua56ro2sz4jGQx3cED/KxAG+pCmaAc5JUNH2ay1RsDHDPp0LRWD7SWa53UJTVhXBRVyFp3MfqFIMjAWrbL6p5Ki5B9un0tNvMZZUougoTya1hQVYHq2iIDkKSHhLZP4wf28oZiWF2ScKprb5W6c6RvdHGCy9ooVfq/iPxQhZ9ujr9swxdod5GWW746vC9Gy3QjU0iMSo05xcAbiih3eVGt/T3cTxQ+EHSEfP7y/XumcFyeUr7IjwEbFkP+di9jRc6F0GEXROZW+8G/maImYknzYPF+ddZk4cBpZLU/HO7+HHrs8ThIUULuyQB3vlakz+3p4KaTs8fTgSkN1W2gyNlukD/lLC6GSqhVIQnKwfN6/gcI3WAaaNZ/yqncvhHqDDbtsC3+/GvZHXhBbwZdQiHmxZ0a3hQiLmQ/EVZ9agLDz++xHX0mVAvEj2saX9iHOXjPGzGO27e+BbnVvk1h4p/utI6Ui5w2WYCCcxFYc4NVWBPoqyR6i8EqaYazDNdoB89YjyC9KEH5r+mGOtlt4aYlyX+Lr3zYm3u53rk4+0hAZT64QtZ2QKEdpkITElWt48C7P6EBS5qOonGs2rrneLxHH2NQYeKDPRCypq8/3CiMVQzbTzLPKQ5YPyA7aHRiQyXjJSiXPuZ6bGvLzVcvpUdhvL+MTbM938FxGt40oX9P6xPZ/XzQN0uGOLGNavzEBA+42wy1zPbHxO9tazPQkJW2DfdFjgn2FwB+GLZZ9ZhRy34BhnJRIsNOl2q9djmjd0vUeHUFXNTC0hYRrStaYSKJn6p i7shspgm hWcw/UDl50fGHvnVc7WBXpkyJkxQiqgzL3wiYDQUHopA8/gRXrKT/4t2ETTbjR0fxNmIfiX00rG0WtX/THib1UT8Ez3KBWviBYyFz2OOAZpK0eXysIy8+v3kc7hdQ7Sv6lsUeYeIMCOkFkTrQsL/nnADsKL84sN52uhm8y1C3+7TTnCYd0e1/61TMJUY1ykpjqWe6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 12:48:16AM +0530, Raghavendra K T wrote: > looks like we have to additionally handle numab initialization in > vm_area_dup() code path. something like below fixed it (copied pasted > from tty): > Yep, it wasn't even boot tested. Better approach is something like this, still not actually tested include/linux/mm.h | 9 +++++++++ include/linux/mm_types.h | 7 +++++++ kernel/fork.c | 2 ++ kernel/sched/fair.c | 17 +++++++++++++++++ 4 files changed, 35 insertions(+) diff --git a/include/linux/mm.h b/include/linux/mm.h index 8f857163ac89..481f90dc1983 100644 --- a/include/linux/mm.h +++ b/include/linux/mm.h @@ -612,6 +612,14 @@ struct vm_operations_struct { unsigned long addr); }; +#ifdef CONFIG_NUMA_BALANCING +#define vma_numab_init(vma) do { (vma)->numab = NULL; } while (0) +#define vma_numab_free(vma) do { kfree((vma)->numab); } while (0) +#else +static inline void vma_numab_init(struct vm_area_struct *vma) {} +static inline void vma_numab_free(struct vm_area_struct *vma) {} +#endif /* CONFIG_NUMA_BALANCING */ + static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm) { static const struct vm_operations_struct dummy_vm_ops = {}; @@ -620,6 +628,7 @@ static inline void vma_init(struct vm_area_struct *vma, struct mm_struct *mm) vma->vm_mm = mm; vma->vm_ops = &dummy_vm_ops; INIT_LIST_HEAD(&vma->anon_vma_chain); + vma_numab_init(vma); } static inline void vma_set_anonymous(struct vm_area_struct *vma) diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h index 9757067c3053..43ce363d5124 100644 --- a/include/linux/mm_types.h +++ b/include/linux/mm_types.h @@ -526,6 +526,10 @@ struct anon_vma_name { char name[]; }; +struct vma_numab { + unsigned long next_scan; +}; + /* * This struct describes a virtual memory area. There is one of these * per VM-area/task. A VM area is any part of the process virtual memory @@ -593,6 +597,9 @@ struct vm_area_struct { #endif #ifdef CONFIG_NUMA struct mempolicy *vm_policy; /* NUMA policy for the VMA */ +#endif +#ifdef CONFIG_NUMA_BALANCING + struct vma_numab *numab; /* NUMA Balancing state */ #endif struct vm_userfaultfd_ctx vm_userfaultfd_ctx; } __randomize_layout; diff --git a/kernel/fork.c b/kernel/fork.c index 9f7fe3541897..5a2e8c3cc410 100644 --- a/kernel/fork.c +++ b/kernel/fork.c @@ -474,6 +474,7 @@ struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) */ *new = data_race(*orig); INIT_LIST_HEAD(&new->anon_vma_chain); + vma_numab_init(new); dup_anon_vma_name(orig, new); } return new; @@ -481,6 +482,7 @@ struct vm_area_struct *vm_area_dup(struct vm_area_struct *orig) void vm_area_free(struct vm_area_struct *vma) { + vma_numab_free(vma); free_anon_vma_name(vma); kmem_cache_free(vm_area_cachep, vma); } diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index c36aa54ae071..6a1cffdfc76b 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -3027,6 +3027,23 @@ static void task_numa_work(struct callback_head *work) if (!vma_is_accessible(vma)) continue; + /* Initialise new per-VMA NUMAB state. */ + if (!vma->numab) { + vma->numab = kzalloc(sizeof(struct vma_numab), GFP_KERNEL); + if (!vma->numab) + continue; + + vma->numab->next_scan = now + + msecs_to_jiffies(sysctl_numa_balancing_scan_delay); + } + + /* + * After the first scan is complete, delay the balancing scan + * for new VMAs. + */ + if (mm->numa_scan_seq && time_before(jiffies, vma->numab->next_scan)) + continue; + do { start = max(start, vma->vm_start); end = ALIGN(start + (pages << PAGE_SHIFT), HPAGE_SIZE);