From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1C7BC61DA7 for ; Thu, 26 Jan 2023 21:51:43 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A32176B0075; Thu, 26 Jan 2023 16:51:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9BC166B0078; Thu, 26 Jan 2023 16:51:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 835BC6B007B; Thu, 26 Jan 2023 16:51:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 6E1006B0075 for ; Thu, 26 Jan 2023 16:51:41 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id 4539980E8B for ; Thu, 26 Jan 2023 21:51:41 +0000 (UTC) X-FDA: 80398297602.18.A8C085D Received: from mx0a-00082601.pphosted.com (mx0a-00082601.pphosted.com [67.231.145.42]) by imf15.hostedemail.com (Postfix) with ESMTP id 04C1DA0006 for ; Thu, 26 Jan 2023 21:51:38 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=fMCMSJns; spf=pass (imf15.hostedemail.com: domain of "prvs=4390123481=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=4390123481=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674769899; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bKgaIgCzl+sBGwA7v3YqE5kXwxl/qwPaI+k5PR78ySk=; b=oD6g6ItYGOKfR2ACpEbr0gu1WMSwGmw/SFSFPoyhEFvWfskv50hyedIhujP8Cfd4OqWp+S Osim4+iWtPitwtVxaKmwFAzbjUGzMD68vWnuAsUjxWj/5ZOOQw30lnHf1VJ2aEtc5f5UxQ 2YEi5VwaEMChWX1MxwfcGjCNRYGn6z4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=fMCMSJns; spf=pass (imf15.hostedemail.com: domain of "prvs=4390123481=kbusch@meta.com" designates 67.231.145.42 as permitted sender) smtp.mailfrom="prvs=4390123481=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674769899; a=rsa-sha256; cv=none; b=cEBxIUwkfRr+Hvhw8PiY+9y7ot36eZXQ8nkrNwO8dY/KxsxFDKaKFBIHJCunUg7VSEMA6l sHp2TKNzRVoKnyGKfYcg8LWATGBkp0jy6qNinkXXSPi3byh4/uXfKwAjzkBOidV31zS1H6 IbKlW48iwcLTQpbhwtjWeGZHYXsQOgg= Received: from pps.filterd (m0109333.ppops.net [127.0.0.1]) by mx0a-00082601.pphosted.com (8.17.1.19/8.17.1.19) with ESMTP id 30QKqvbC000849 for ; Thu, 26 Jan 2023 13:51:37 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=bKgaIgCzl+sBGwA7v3YqE5kXwxl/qwPaI+k5PR78ySk=; b=fMCMSJnsInPjYMhsW+pbka/x8V+e6/LX+0UItt0S9df8MkqWdeQREl3xVMtuF1WAePTK UME9C3Uexi1D7J1HOb6QyNqWYacL3gF7/nyG/smx08AUUmIU/aYXwd/rE7haPzKYOgpn IFkrJNUMDxfPwc0w5nPYQmixyfP8ICmosVwtODZgpkn1YN4g7itlMpAy2lfAGC61G3eu 3ycTb3N8f5wDGZBMxsogKKMojt6srWVK5nMN2i6ZTUUomsO97u3ZtPvNuwcI8QJxfvi1 eWe1Uww60gIuB+k3LIBBTzRmKH293wn5EwiRh6hmVOxmD+uPKCxk0u0JmTtZpRUdPdbz Xw== Received: from mail.thefacebook.com ([163.114.132.120]) by mx0a-00082601.pphosted.com (PPS) with ESMTPS id 3nb7mbshbn-6 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Jan 2023 13:51:37 -0800 Received: from twshared24547.08.ash9.facebook.com (2620:10d:c085:208::11) by mail.thefacebook.com (2620:10d:c085:21d::4) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 26 Jan 2023 13:51:35 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 0ABA5FE80A93; Thu, 26 Jan 2023 13:51:26 -0800 (PST) From: Keith Busch To: , , , , , CC: , Keith Busch Subject: [PATCHv4 03/12] dmapool: use sysfs_emit() instead of scnprintf() Date: Thu, 26 Jan 2023 13:51:16 -0800 Message-ID: <20230126215125.4069751-4-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230126215125.4069751-1-kbusch@meta.com> References: <20230126215125.4069751-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-GUID: _1GZjSQC4WEYp4yc-P7r7bLVWHvhT0T- X-Proofpoint-ORIG-GUID: _1GZjSQC4WEYp4yc-P7r7bLVWHvhT0T- X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_09,2023-01-26_01,2022-06-22_01 X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 04C1DA0006 X-Stat-Signature: k9x75sf5zp9qe4cwp384xpjpu9czo8tx X-Rspam-User: X-HE-Tag: 1674769898-897657 X-HE-Meta: U2FsdGVkX1+wBjK8lHPQsYKQWERhQOOjzA/jvVxR6jI+lMuKl5k34AOghSQndJ8NajCqHoah+VueUnaE/+yTHqxs3YGbSRDA6AX1u3mqaMZ+DrE3of4U9MAQxUAwOZY0/KnyeEhJs5+jbgaetSHI9LLqg2wgZBjEGK5NoBHbtWYMdrPIL/xzS6PUBhbRO94xMkkzcYvQdC91TCfFMgp9lpZWYsqGt08lUddU5a0lzYyMN105OOawEIAZaU6QRepCYXgMCJwuwY14j9Qr7MpYAli3cs9s5E6qgci6oOp82kfnWXqeCRHkAHsGO+J93NcgwILp3X+Teo4paVVU+aQIb5c4UvQy5o5awUc6hoz+66uTmbFh0/MY7FJzG+zWLF/tPVoyZlXC2zi9oas6AHt754dCAxeIMbpEvSY92dudz7U1HP0nP7/fD7g8EMfjFctJmCYZDdBhONJikCV3qJJtsRMBuhtiy8ST9HOX9qvfAPLa3m3sv86ElnH/l5hn726JrwUcc2102YeFUMq+nt8lu3kTA2EXCVIAVW/QBxfzv7CsQYBqK6SP0ca5NibO8ozNkFeNSEyXy7jooHB3iu4RIIM41SN5951+LT5Kess9djPDAvD/CqdbH18AZG6Jt2YSO9CYLUZV0F6qfHnND1m+ctoamyH0AvrhgGlbAMH9ZR7w4oOF3K75d9CEeekjVoK6DQPwVYGQdznKZf0kOm+Mh2kb/SBv+jn3ITykonYVb78lLScZ6ELB5VU2SOIMagnTM1w9UHvciOoS3J/FLDCiGiJCEZmlQAReOuIN/TFirRp3Kl/3JrS9XvAN0GvOo9ho15lK8E9RBIGUdbeGs0H3VYSSpjT/ygweGhSC/9KKw8gt6rXxGzeClk+mY7maaqOwKFYKqLDnNS51ao3uuKZKLisFxIoUwcYTCwM2RHrHzJLqhfobKxlLXoayngI5TnqeKHOFNx3MsDVFyVD838i 0KBif34U nyK0ml6rH2JdAMynU5mhwtETE+akfnRRs/qnvEGO3OsimaoW6pjjSeEEzouoAw/N/XfLY4fxRbFJyyOJ43nbPMWoeQUjpB45Pl700oVkfUkCP/BPLcC/oaXchTp1glKtfNMKVqv4Ssms6EkMULmN28zE9VfWhkOgfpR3VOO9A/6hr6Fuki0XxhG2ShOhxA/8ImV1eyaPu3OSuwOeUPVwyQMy7wBm2mpgdSeOnr7YZsG3kaIkb30wlrnTDuZF1NOvqX5ARRmNTH7pINdEkaPQGudOHSdLxUMK32eqIUcyoRf+lbfugk8iJkV3uEXL1OWsTaTV5Ps5k902iHG/GDRlwfsGcgo0DbVSw9C+OOUpGroz7/NfJVoK/zetegJFPQybozRpVwTnGM/gNDUP9v8PJpaX+vVAbBm81u1pGn8hSlEKBwlGo0Fy1sslXp/k8ArgOqpbHJbIPe4GdZGAjLYA+l8bSyX6oefhARMhJ/KTMveJ6cgJFCK/fxEs8eg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Tony Battersby Use sysfs_emit instead of scnprintf, snprintf or sprintf. Signed-off-by: Tony Battersby Signed-off-by: Keith Busch Reviewed-by: Christoph Hellwig --- mm/dmapool.c | 23 +++++++---------------- 1 file changed, 7 insertions(+), 16 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index 559207e1c3339..20616b760bb9c 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -64,18 +64,11 @@ static DEFINE_MUTEX(pools_reg_lock); =20 static ssize_t pools_show(struct device *dev, struct device_attribute *a= ttr, char *buf) { - unsigned temp; - unsigned size; - char *next; + int size; struct dma_page *page; struct dma_pool *pool; =20 - next =3D buf; - size =3D PAGE_SIZE; - - temp =3D scnprintf(next, size, "poolinfo - 0.1\n"); - size -=3D temp; - next +=3D temp; + size =3D sysfs_emit(buf, "poolinfo - 0.1\n"); =20 mutex_lock(&pools_lock); list_for_each_entry(pool, &dev->dma_pools, pools) { @@ -90,16 +83,14 @@ static ssize_t pools_show(struct device *dev, struct = device_attribute *attr, cha spin_unlock_irq(&pool->lock); =20 /* per-pool info, no real statistics yet */ - temp =3D scnprintf(next, size, "%-16s %4u %4zu %4zu %2u\n", - pool->name, blocks, - pages * (pool->allocation / pool->size), - pool->size, pages); - size -=3D temp; - next +=3D temp; + size +=3D sysfs_emit_at(buf, size, "%-16s %4u %4zu %4zu %2u\n", + pool->name, blocks, + pages * (pool->allocation / pool->size), + pool->size, pages); } mutex_unlock(&pools_lock); =20 - return PAGE_SIZE - size; + return size; } =20 static DEVICE_ATTR_RO(pools); --=20 2.30.2