From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id F1F81C05027 for ; Thu, 26 Jan 2023 21:54:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8F67A900008; Thu, 26 Jan 2023 16:54:45 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A6EF900002; Thu, 26 Jan 2023 16:54:45 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 76EBA900008; Thu, 26 Jan 2023 16:54:45 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 66269900002 for ; Thu, 26 Jan 2023 16:54:45 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4BAA5A0EF2 for ; Thu, 26 Jan 2023 21:54:45 +0000 (UTC) X-FDA: 80398305330.07.A5B80A2 Received: from mx0a-00082601.pphosted.com (mx0b-00082601.pphosted.com [67.231.153.30]) by imf28.hostedemail.com (Postfix) with ESMTP id 5655DC0010 for ; Thu, 26 Jan 2023 21:54:43 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=lVrUtV7e; spf=pass (imf28.hostedemail.com: domain of "prvs=4390123481=kbusch@meta.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=4390123481=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674770083; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=3bZHL2Z78cKAF6RylfMcYGJJt43dfPQsNy0PbvPE3is=; b=zt2bN+AE5nYEGbMGkF9GEIVn+w4SNXzbzLAwl1RDPvMknbQAQN7m++qWsMiDhzUlCEddcP EOfQzL1rmBVbo7Q95J1y1E44HCIyz3q69SWeZqz89pknxUA4ASs0elKQYp3tMhcXPUfEmm LIjeovezO6FEZs+ZoDxup/J8rHaIrE0= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=meta.com header.s=s2048-2021-q4 header.b=lVrUtV7e; spf=pass (imf28.hostedemail.com: domain of "prvs=4390123481=kbusch@meta.com" designates 67.231.153.30 as permitted sender) smtp.mailfrom="prvs=4390123481=kbusch@meta.com"; dmarc=pass (policy=reject) header.from=meta.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674770083; a=rsa-sha256; cv=none; b=ZaRp1XJcSryG3C4zaqKfgbg+UdV9WFNeU8VV4Ursjjdnnij3TN4mdM/Ikti/qMaXdqh9KN UI2zM22DsTXOYVW+/TB4Lgb2rlvFbBfUosNrDPi+Wc9RPjc9WClPrMeJ1l/ueStL8V8pu9 Vcp8C6NUD1qvGgW2LeK3pnjt8jK5L58= Received: from pps.filterd (m0001303.ppops.net [127.0.0.1]) by m0001303.ppops.net (8.17.1.19/8.17.1.19) with ESMTP id 30QJ9NFU028224 for ; Thu, 26 Jan 2023 13:54:42 -0800 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=meta.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding : content-type; s=s2048-2021-q4; bh=3bZHL2Z78cKAF6RylfMcYGJJt43dfPQsNy0PbvPE3is=; b=lVrUtV7eIfA+pTjKwQ4ayJK+j8lGNrnWZANTogfISnYDcFY9OF80Vn5S04uuKHS/jvMb EeIGIEZdjrEWbgNpuS8LBQAaHrWV0XYxLUVb/6Ed1igPwjGL2oDsIWOAwyfA9vMPoAg/ FSab2TSFYmid8os9V6E+9I8CkMTsyXS9OMoypXZdyoOYM+Eh4FSii6xiMosOSPIu8Ugm Fe4yICWSigw/3zCpzzISOciiyvIN1f0JvD8MxwEtigJPCeUM4eEqHqzxGcg0HvCEt4Qy y3+QrA+qmX6r+kanWgp4UYVU9/3jM5IO4hErIm4/A4RrjzXCeXZNVhz5SakVnWoRMigx Sw== Received: from maileast.thefacebook.com ([163.114.130.16]) by m0001303.ppops.net (PPS) with ESMTPS id 3nbe8yye5b-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128 verify=NOT) for ; Thu, 26 Jan 2023 13:54:42 -0800 Received: from twshared1408.04.ash8.facebook.com (2620:10d:c0a8:1b::d) by mail.thefacebook.com (2620:10d:c0a8:82::f) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2507.17; Thu, 26 Jan 2023 13:54:41 -0800 Received: by devbig007.nao1.facebook.com (Postfix, from userid 544533) id 72918FE80AA6; Thu, 26 Jan 2023 13:51:26 -0800 (PST) From: Keith Busch To: , , , , , CC: , Keith Busch Subject: [PATCHv4 12/12] dmapool: create/destroy cleanup Date: Thu, 26 Jan 2023 13:51:25 -0800 Message-ID: <20230126215125.4069751-13-kbusch@meta.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20230126215125.4069751-1-kbusch@meta.com> References: <20230126215125.4069751-1-kbusch@meta.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-FB-Internal: Safe Content-Type: text/plain X-Proofpoint-ORIG-GUID: GSrII1cJIgj5cG6Z78bsXS52FzT54NHW X-Proofpoint-GUID: GSrII1cJIgj5cG6Z78bsXS52FzT54NHW X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.219,Aquarius:18.0.930,Hydra:6.0.562,FMLib:17.11.122.1 definitions=2023-01-26_09,2023-01-26_01,2022-06-22_01 X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 5655DC0010 X-Rspam-User: X-Stat-Signature: 6x4qcxfutizf5uk7pdm9rsogwsqoxnb8 X-HE-Tag: 1674770083-14214 X-HE-Meta: U2FsdGVkX1+JGRRUAwcSk/cWId+Sn6DlBuuubMQQHh8IH95APyRB7kmdyeyeV7hzryz4FBUpfx26BdzVbvd7gDRp/5DgxerAWfQ+5QxZX2pzD8heJ+TVnt+jfKrtjUDad5aCIvmXjE5MLiWCLcPjvurx2kEiVB+DFdTEIQVcCtQrNqlZCe7hu1uhNMahwuejIHReN09eHFfrxT6aU5GCyP2RLUux2SQrE29ZqC+MhpitxjuS17eOlsgmYuMpWB2gK6PFzOG24G6RJ36pUBhM1+K67FQX5MZ9pyzb1py9QV0FdacFiEIkpHiXBDRWWCgLbcXGx8SEmmtwQBtO1Lb/6uL28vddAolFDVqO58RhidM1POuByNXIhFr4gcQDrSTCL7Z8fLvcQxAccxVRmd1PylG6nL0jO0BZrJmIKhnMGrp8AtixDYJTdjWu7LpKeQnC5N8D3f8vdoyk6UbZmANEqxYZzt+dxoEpdmARSPy7jUrL4M9VNRh3bx/bXHNjcjZlLeo12G3dMPc31h6hRrlbduRI1+ker11VJY1ZvuA68gNFJtZGmyfXGiOqH1WF3G890TvwltMW3jwh6GUelb6sn3HRjapM40xo3sNBoKGB4XeD7eDWabO5jI86zI+Fz3/pDxLDFl9ZRDwQGJaJdb7SVULFyUu/WjWnsFcuK57Yz+skP6d8tFuPn3GRbntpB2DqIPf29vPK1q4Olq4FJTOFHzlvHE8xDoLFVvK9HiwjFQ2IzriFGQZPjr4cuMEJqhvZGPgp98VGLK45YnFq67XmhnKgF2cyPbEegmPudMrkYuX0W8NWQnK+DxXy56cO35+lVOND8bh4biTl8oLNomv+4rx9SJusjVbphSWDPC4u38FGYhro9mYOvY69AKvNRl7X1Xj9G3hHfcVal/eoRb7Ns76IGzydell097piKG9xCaa+EzbIgpSpMl3epuDAkJypyJOvHgXmhp4tULclNU8 pJBS4CnC +v7r91Fqu8V4b0zz3MFlEWjPeEA6trxy49aBzwlSZyUYWZBUArzHc1B44y2QnM7RNx8LhjBIFjVi2++jspIUXTFpMAb+MbZfeQJ3P0CzKNLsugHOT+K3TlW7MofUz2uX2avj27PfERo+t87WWTvdZnhKCsMmJE6iqaqoCelMZjcF3m64d7rVEw4PrMaJBAJO7jEWRjera1ghJCV7KU4ymFg8urPdz6GfjUaGUO+Gga3gO6REzt6o1T+LS3/4ST7FPrrFcSReWA/bDGgTXtkoODOGav3uVxIdZGrJqohDxwOD2J96Or6PKXzCejtY795Sk5sotIIdEQ1o+1ubTf8vn2VDBD8a1SOyzmMkDchk9mTR0U9pjApsO/q3dqYMC+qOdv3vkYKsFdC1VUMg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Keith Busch Set the 'empty' bool directly from the result of the function that determines its value instead of adding additional logic. Reviewed-by: Christoph Hellwig Signed-off-by: Keith Busch --- mm/dmapool.c | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/mm/dmapool.c b/mm/dmapool.c index bb8893b4f4b96..1920890ff8d3d 100644 --- a/mm/dmapool.c +++ b/mm/dmapool.c @@ -226,7 +226,7 @@ struct dma_pool *dma_pool_create(const char *name, st= ruct device *dev, { struct dma_pool *retval; size_t allocation; - bool empty =3D false; + bool empty; =20 if (!dev) return NULL; @@ -276,8 +276,7 @@ struct dma_pool *dma_pool_create(const char *name, st= ruct device *dev, */ mutex_lock(&pools_reg_lock); mutex_lock(&pools_lock); - if (list_empty(&dev->dma_pools)) - empty =3D true; + empty =3D list_empty(&dev->dma_pools); list_add(&retval->pools, &dev->dma_pools); mutex_unlock(&pools_lock); if (empty) { @@ -350,7 +349,7 @@ static struct dma_page *pool_alloc_page(struct dma_po= ol *pool, gfp_t mem_flags) void dma_pool_destroy(struct dma_pool *pool) { struct dma_page *page, *tmp; - bool empty =3D false, busy =3D false; + bool empty, busy =3D false; =20 if (unlikely(!pool)) return; @@ -358,8 +357,7 @@ void dma_pool_destroy(struct dma_pool *pool) mutex_lock(&pools_reg_lock); mutex_lock(&pools_lock); list_del(&pool->pools); - if (list_empty(&pool->dev->dma_pools)) - empty =3D true; + empty =3D list_empty(&pool->dev->dma_pools); mutex_unlock(&pools_lock); if (empty) device_remove_file(pool->dev, &dev_attr_pools); --=20 2.30.2