From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 47E62C05027 for ; Thu, 26 Jan 2023 16:10:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id D537A8E0003; Thu, 26 Jan 2023 11:10:44 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D03E28E0002; Thu, 26 Jan 2023 11:10:44 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B56008E0003; Thu, 26 Jan 2023 11:10:44 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id A3A3B8E0002 for ; Thu, 26 Jan 2023 11:10:44 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id 6E096C0E41 for ; Thu, 26 Jan 2023 16:10:44 +0000 (UTC) X-FDA: 80397438408.10.F587BFD Received: from fx305.security-mail.net (smtpout30.security-mail.net [85.31.212.35]) by imf28.hostedemail.com (Postfix) with ESMTP id BDF26C0021 for ; Thu, 26 Jan 2023 16:10:40 +0000 (UTC) Authentication-Results: imf28.hostedemail.com; dkim=pass header.d=kalray.eu header.s=sec-sig-email header.b=5vw5axJy; dkim=pass header.d=kalray.eu header.s=32AE1B44-9502-11E5-BA35-3734643DEF29 header.b="gjg/x2Tl"; spf=pass (imf28.hostedemail.com: domain of jmaselbas@kalray.eu designates 85.31.212.35 as permitted sender) smtp.mailfrom=jmaselbas@kalray.eu; dmarc=pass (policy=quarantine) header.from=kalray.eu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674749441; a=rsa-sha256; cv=none; b=FGcWiLQy9KxRa//mTN+n6QwnkdtM15sM+rqGJiJNppRtuyvqKsuMIZEka+UkUAi8eBaSIU BiP5nJDJH2go1haGewomGgwNvHYv3kOs0uz8Xea/V88XLVSHQMATwdJhCeI8vLiRfLyhVd EIKK3epFCdq4a+83pWA+CRkD0j1H+Zc= ARC-Authentication-Results: i=1; imf28.hostedemail.com; dkim=pass header.d=kalray.eu header.s=sec-sig-email header.b=5vw5axJy; dkim=pass header.d=kalray.eu header.s=32AE1B44-9502-11E5-BA35-3734643DEF29 header.b="gjg/x2Tl"; spf=pass (imf28.hostedemail.com: domain of jmaselbas@kalray.eu designates 85.31.212.35 as permitted sender) smtp.mailfrom=jmaselbas@kalray.eu; dmarc=pass (policy=quarantine) header.from=kalray.eu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674749441; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=9giavlvQOACZW0fqif+Jno6XkcerIxtPM3AoszI6iXA=; b=UJ9KvrvIrPEi4vQZinLrcl948cSNWcqmKhPjcURv11Kfz4qc9bZ3Jv1QP6kskO8Ht0c0ms 63PCdOcpLvvsC0uiEeN3UoqdAh/khQp4/z2QqqnzoTGv4Gr/tVSipXuYlGTgmCU59hRECq e6xS8KSTN1MP1VAAhsZlY8lhYHm/ShQ= Received: from localhost (fx305.security-mail.net [127.0.0.1]) by fx305.security-mail.net (Postfix) with ESMTP id 3C1EA30FE70 for ; Thu, 26 Jan 2023 17:10:38 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kalray.eu; s=sec-sig-email; t=1674749438; bh=18h0PvVkWw5cOD2tUF5rJDodhNIHFoyGd3swtBhEV9s=; h=Date:From:To:Cc:Subject:References:In-Reply-To; b=5vw5axJyF9LieKbQoJGxZArRGN69LCOIdRjMzwH3t6+nxH+vLwTkOG09Vp3KdRfMv ouyIKTDSpHaCKiX0Kt8ISHUYWNsi3G+unW7AOZpjPagkpGGmVRVmDayrctlEFac0i9 DqUoX1gQPAUU+EvHyIEXLgEGNiJnWX0QmlIZT5uI= Received: from fx305 (fx305.security-mail.net [127.0.0.1]) by fx305.security-mail.net (Postfix) with ESMTP id 9D10E30F96B; Thu, 26 Jan 2023 17:10:36 +0100 (CET) Received: from zimbra2.kalray.eu (unknown [217.181.231.53]) by fx305.security-mail.net (Postfix) with ESMTPS id 6F4FF30F6F9; Thu, 26 Jan 2023 17:10:35 +0100 (CET) Received: from zimbra2.kalray.eu (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTPS id 2AA7527E0431; Thu, 26 Jan 2023 17:10:35 +0100 (CET) Received: from localhost (localhost [127.0.0.1]) by zimbra2.kalray.eu (Postfix) with ESMTP id F335127E0461; Thu, 26 Jan 2023 17:10:34 +0100 (CET) Received: from zimbra2.kalray.eu ([127.0.0.1]) by localhost (zimbra2.kalray.eu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id ckvuBGSN-_53; Thu, 26 Jan 2023 17:10:34 +0100 (CET) Received: from tellis.lin.mbt.kalray.eu (unknown [192.168.36.206]) by zimbra2.kalray.eu (Postfix) with ESMTPSA id 8E3C527E0374; Thu, 26 Jan 2023 17:10:34 +0100 (CET) X-Virus-Scanned: E-securemail Secumail-id: <3ac4.63d2a5fb.6cc14.0> DKIM-Filter: OpenDKIM Filter v2.10.3 zimbra2.kalray.eu F335127E0461 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kalray.eu; s=32AE1B44-9502-11E5-BA35-3734643DEF29; t=1674749435; bh=9giavlvQOACZW0fqif+Jno6XkcerIxtPM3AoszI6iXA=; h=Date:From:To:Message-ID:MIME-Version; b=gjg/x2TlOcjiKN3NypFbIHFe/byI2jjV8o3VpLfw+6A29RvT0tO7rhyOLP4RSQBmB x4Tx+6M47/jYTq+5ZLA2uCIUhHGzwDXxt8eUceRV5P9eFpkBGwoYQYAzaEc236wUu9 1kIkSP3K+m+aYLf/4oc9MR/KzKUTElR11/fHsdhg= Date: Thu, 26 Jan 2023 17:10:33 +0100 From: Jules Maselbas To: Krzysztof Kozlowski Cc: Yann Sionneau , Arnd Bergmann , Jonathan Corbet , Thomas Gleixner , Marc Zyngier , Rob Herring , Krzysztof Kozlowski , Will Deacon , Peter Zijlstra , Boqun Feng , Mark Rutland , Eric Biederman , Kees Cook , Oleg Nesterov , Ingo Molnar , Waiman Long , "Aneesh Kumar K.V" , Andrew Morton , Nick Piggin , Paul Moore , Eric Paris , Christian Brauner , Paul Walmsley , Palmer Dabbelt , Albert Ou , Guillaume Thouvenin , Clement Leger , Vincent Chardon , Marc =?utf-8?b?UG91bGhpw6hz?= , Julian Vetter , Samuel Jones , Ashley Lesdalons , Thomas Costis , Marius Gligor , Jonathan Borne , Julien Villette , Luc Michel , Louis Morhet , Julien Hascoet , Jean-Christophe Pince , Guillaume Missonnier , Alex Michon , Huacai Chen , WANG Xuerui , Shaokun Zhang , John Garry , Guangbin Huang , Bharat Bhushan , Bibo Mao , Atish Patra , "Jason A. Donenfeld" , Qi Liu , Jiaxun Yang , Catalin Marinas , Mark Brown , Janosch Frank , Alexey Dobriyan , Benjamin Mugnier , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-mm@kvack.org, linux-arch@vger.kernel.org, linux-audit@redhat.com, linux-riscv@lists.infradead.org, bpf@vger.kernel.org Subject: Re: [RFC PATCH v2 02/31] Documentation: Add binding for kalray,kv3-1-core-intc Message-ID: <20230126161032.GH5952@tellis.lin.mbt.kalray.eu> References: <20230120141002.2442-1-ysionneau@kalray.eu> <20230120141002.2442-3-ysionneau@kalray.eu> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.9.4 (2018-02-28) Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-ALTERMIMEV2_out: done X-Rspam-User: X-Rspamd-Queue-Id: BDF26C0021 X-Rspamd-Server: rspam01 X-Stat-Signature: 8kak955ohzmrnd4gixeiwgfm1zeumjga X-HE-Tag: 1674749440-265760 X-HE-Meta: U2FsdGVkX1/QrpNZrFsUHCIiXT/zkqbyFrsGOO3XZjy5rON6zNcb6xM/4UBKhhgotv+VaUb/l6zKxxsIsKJl90K8NYYekSw2C/y8sy9kglAfpXz+kgOx4uzvD4mddYYTdZ0avxqgP9TM0uEFeoZbMcOWdDjFEV+3b9otpBKfzCneyHj+BmHKzLvRMRUbjVLIaxXvxteX4dxZaMNhA+bIs5F+eYCSYmRt5gJNd429m5UG8bEXsh2SJ47C/wlbeFPCRJtYmFsm7/eO961LjCcqHXx1xbuAhD4COaJjdqvyvl57EXNb+LHBtaz6PIE9t0RGOibh5jj7jHms7dROHJaMwlUE6JYL0NVgDS/zu13K2M4CeX2TbYZ7P48MsrlVD8FugMMwDOrUoOvrJTlqfaTNNC6jvroG7Yr2S3smgt9IivBnUjrUkDaEapufDv6LT4/g8SGVm1mKY2c4pYB5aFpZzD7HwIvIJsKGz/U5gauVFA60fHuF5OPZUXVTOpGXwQr4GgMis9MC6Wxy6T2n1FvintoxQlG5UwPbopRlKol/sNceG73mXMQJG07L2+WlLBJYvuzmDIBxXr247ziEfsnCT9O8B9/GX48Qpo6KT3A4m/HFaY4tXH6/WC+r+Yun7rW3N/6PRcMsTjumWH3z81HB+wbNAW/HzknlbXARn3KEz7brMZPjWU+zNa6ZPP8z2ueDsQAz79LtXmQ+Aosa8Y6w7yb/6BQcrjylkJmbjYc/hBSQIScl+No0Cr9dX9iuztw4XLkf8a8QbvDZbFFvrqhTe0i0Yr/JHGNv2jedchwQb1Dwr08l/SBz3ZuTPTR8RjIdwnPzrnuUDHAYm82DrMKpSzTR3dLt+BODWlLOYEzQ3hQC/j7793zUOewgCvBX6hlS3IbLp4sGRN3IGxAT5l0KERte7eixWKKM6ukdFD/N0p0vEIgbF9a7hpasAEcJr0zkB3WzeugOqEZ42Tc0DWv ynGAnX+h UFeTwG32/MuXx9a8lyUON4HNsbm6cM7GfF6gYWQV6lp3lWtJ0qavBYFgs7n+VduBA1WD2aIlI1ryR0XRuWejZcNJ0NPpyROU0NtRcTNd7E5waWZ04VcGs+gmLtffyh3WKDqrvCtfyCFb271WS68DmoXfwt/IdNxBrAUCUSzP697L6C3bRl/EHULD7VD4SR2jYPPh6gzaVdj1fpUFefj7vE/YLkmI+U2gfMmor+TCGgFpGAInMQNh8o9PqifIjTy1kvfuaYp/LWIJABY8NrUztkSfiWeAKQqa/uGK123U7flgeKDW4sUUrKSzXK6UATTHdU2lg9Qt76BWKyq0+RhZIt7oabmz4VgziXr2z+s46w321ldWCclwoLi9eK2sZu1FAkK+YeiA6c/zAzuIt4yA2yVBL541BR+7xAGgf7O6La0ISY9ESBm1dL/ZvFDDhfhPR3dw7J2YrfBGdXYSM65L+Krv4EkLWBGoLWUTnDWlsz2WlCeemHjZqAecXZQ9fXous0Acwmf5rrVQUl+grGMmUWENcVVEZ0c53EayM3cQoSnMDFun24mc8tqHArFiroy5xq2ePc3IQO/hgRYJUWWEWPjPmtkIdY6V27r4U/jlhmxID5glV7lVrLGusUw== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Krzysztof, On Sun, Jan 22, 2023 at 12:44:46PM +0100, Krzysztof Kozlowski wrote: > On 20/01/2023 15:09, Yann Sionneau wrote: > > From: Jules Maselbas > > Use subject prefixes matching the subsystem (which you can get for > example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory > your patch is touching). This will be fixed, sorry for the inconvenience. > > > > > Add documentation for `kalray,kv3-1-core-intc` binding. > > > > Co-developed-by: Jules Maselbas > > Signed-off-by: Jules Maselbas > > Signed-off-by: Yann Sionneau > > --- > > > > Notes: > > V1 -> V2: new patch > > > > .../kalray,kv3-1-core-intc.yaml | 46 +++++++++++++++++++ > > 1 file changed, 46 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > > new file mode 100644 > > index 000000000000..1e3d0593173a > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/kalray,kv3-1-core-intc.yaml > > @@ -0,0 +1,46 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/interrupt-controller/kalray,kv3-1-core-intc# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Kalray kv3-1 Core Interrupt Controller > > + > > +description: | > > + The Kalray Core Interrupt Controller is tightly integrated in each kv3 core > > + present in the Coolidge SoC. > > + > > + It provides the following features: > > + - 32 independent interrupt sources > > + - 2-bit configurable priority level > > + - 2-bit configurable ownership level > > + > > +allOf: > > + - $ref: /schemas/interrupt-controller.yaml# > > + > > +properties: > > + compatible: > > + const: kalray,kv3-1-core-intc > > Blank line between each of these, Ack > > + "#interrupt-cells": > > + const: 1 > > + description: > > + The IRQ number. > > + reg: > > + maxItems: 0 > > ??? No way... What's this? This (per CPU) interrupt controller is not memory mapped at all, it is controlled and configured through system registers. I do not have found existing .yaml bindings for such devices, only the file snps,archs-intc.txt has something similar. I do not know what is the best way to represent such devices in the device-tree. Any suggestions are welcome. > > > + "kalray,intc-nr-irqs": > > Drop quotes. > > > + description: Number of irqs handled by the controller. > > Why this is variable per board? Why do you need it ? This property is not even used in our device-tree, this will be removed from the documentation and from the driver as well. > > + > > +required: > > + - compatible > > + - "#interrupt-cells" > > + - interrupt-controller > > missing additionalProperties: false > > This binding looks poor, like you started from something odd. Please > don't. Take the newest reviewed binding or better example-schema and use > it to build yours. This would solve several trivial mistakes and style > issues. I am starting over from the example-schema. > > + > > +examples: > > + - | > > + intc: interrupt-controller { > > What's the IO address space? As said above, this is not a memory mapped device, but is accessed through system registers. Thanks, -- Jules