From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CB85C54EAA for ; Thu, 26 Jan 2023 22:59:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B5E3B8E0001; Thu, 26 Jan 2023 17:59:48 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0DD66B0072; Thu, 26 Jan 2023 17:59:48 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9FCB18E0001; Thu, 26 Jan 2023 17:59:48 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 8CA736B0071 for ; Thu, 26 Jan 2023 17:59:48 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 649C21C5BFE for ; Thu, 26 Jan 2023 22:59:48 +0000 (UTC) X-FDA: 80398469256.09.8BEE5B7 Received: from ams.source.kernel.org (ams.source.kernel.org [145.40.68.75]) by imf18.hostedemail.com (Postfix) with ESMTP id 85BD01C0009 for ; Thu, 26 Jan 2023 22:59:46 +0000 (UTC) Authentication-Results: imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OdcGjNzE; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674773986; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/mi0SkG2XsiQXNAO9Nm5bkGl60+gCaVsYLHNU+R1XdQ=; b=jBnQKjTUVjg5BMWD+JKLgUSUtlhO2tV/rrnEdD0ibRhGLjL1yRarxfMzDrAsWnBUOcHsxl AFos0o+lprhsru8SdsVp1jujsSGUWuOOl777fasGOBdRw9XBNdQdWN73EXrwbWKg9F7+hv GFMW+q5kIX0oHtYhpf0Qhsj7m6A8mNI= ARC-Authentication-Results: i=1; imf18.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=OdcGjNzE; spf=pass (imf18.hostedemail.com: domain of akpm@linux-foundation.org designates 145.40.68.75 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674773986; a=rsa-sha256; cv=none; b=pjXzxG++awAsbWRbWaO3jL4LrESwtxFG7zHX2n+ZAGfiEQtckxpJLU7MuXwe8IPlsahcg1 YVljQShfJL9yah2HtxbzXgKsC0OI12nUA34YibzCrSYEM1BBRZQeIyIqV3WZXhHyk/aLBU cbGiFs5MtTh7EenvqbgWziG7UBZDLvc= Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 06B64B81ED5; Thu, 26 Jan 2023 22:59:45 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 963CFC433D2; Thu, 26 Jan 2023 22:59:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1674773983; bh=42eO7WF7X2qZyvDDgC5i2e07FCwsOErXAENkqUpi05I=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=OdcGjNzEs8yKW4vzBruzNVss6i+MPR28YarJ5KQjzOxGRcwgm0dEyg1mA5dam+9VV IbrtyKMqDXZQZXg4ScK2RFGZjC4Kvc8yG4HDR3MlkT57WIagMPp0L41sHHIxkjgvKU HT3p3sOvK/gWaa41TRs41l2ufvWEAUR9S3OL7JGQ= Date: Thu, 26 Jan 2023 14:59:42 -0800 From: Andrew Morton To: "Matthew Wilcox (Oracle)" Cc: Christoph Hellwig , linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/2] mpage: Convert __mpage_writepage() to use a folio more fully Message-Id: <20230126145942.de051666a47ada8f56cb34a4@linux-foundation.org> In-Reply-To: <20230126201255.1681189-3-willy@infradead.org> References: <20230126201255.1681189-1-willy@infradead.org> <20230126201255.1681189-3-willy@infradead.org> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspamd-Server: rspam05 X-Rspamd-Queue-Id: 85BD01C0009 X-Stat-Signature: xpmqmk4yxepoo6witb6se8zwftc8qn31 X-Rspam-User: X-HE-Tag: 1674773986-790700 X-HE-Meta: U2FsdGVkX1+bLZ/UYdC+KUO2RxtMFTXCsuSlX89itt6QdeMIOWQ55x3PnMMGiAqEdr28yamqx1STThGbotE6mTF3uBXNL+sMaLpM4L84NpJGTL1agTSGmG9fyD9hQz3ql3dy3o7HmXYYT1sSDdgFEsuQNOsALMTxWexMT1uazg2eQBqIgSdGEmfZHKmzCu4gWwo1Sj6TeaQveiQUPYt6iLrcHM99nrpfOI9qp0xS+EFjVJ/bX9iN8X3CJvQ2q6EMMa6YtjoUT1UtbRBsYLeua4TuL8u44zcDYxxk327yZOX46uXHE3YDd307kmVBavkJb2acBpDRfijPDE8L0bSIVFAPh3MfYYgxgCPq7ghDPrUuMlO1nMUdfarZsUN7+zub9ztbh3xWaVe9WzMsomgTfxglW/OoCEMIOC8AHsk+pHpT77Ww6SDAz6oH3WaioyyfIBDs78xEI+ZBzRFWlSvzFrq2osDGihCotEwC3enKawxSzcaE4tQcFtXt5EeN1ChZ9rByR9XJyg6uWXVN9oCB5P9bV7MdmcsuW5ZtaYENBl7K2fHStc5X9owZlozTFzuel12OJipihJwdwc247PlLEDKFsbroO4YAfA5XFA8Jn+3LO7l6UmzqBdEmAInd4zfqyku23b3tlseH6wiuk8i2P1hoZi3NUDVq44FfeNsz6UmosCwk/BpHrbHtIlHlmLS3C6OHkXv7VTajbsK5ThKRuX7wZ+Qh6uG9RmLaxsJhInm+YpbIsanZkLTuw1jBjMv+osR0Je55fyyC8WjkN5Mt/X/EDm853QPEnnIldw/T9oWQfG23ePd9HtKkPwNLSpsSq/Qm21Y7DphevT1ggmyRVOw4RWSykn++0Ztkp9ebK9QX7Yp1uJ1XGxLna69FljbPJi2XWMmTA7CS1l/aazIowWFxr9YmN1dyum7TrXcUUAZxpYyJsKYdnB7a5GmdA7TDeuleB81hzahkCEvlbUX vjRMux+6 imdk6i1KRUPty3q5MrxDeHQu6AHvsoST2bHbWmgIUTu2EGZCNETsW5WjIjKDdEeLEWuky2ODhQj83s8OaeSD/1f5eJkfqqR9ptlRLHpA3WrBYKETf7gzccTa8WQtCHMqTikfgH9rMQBoNpI800/kXX0z1fyzhgxXl2u0SWtoT+oBQyNnikEKKx7S6ML84DhGZwV53rLIgKHONuNiw4N1jHU2Th1G+ETdl6hbIlwzS6+KrAcZH1fqdy29Vyw/axB5NJZB3q0AomSmuFZDOjAnmXQ/GL84dWvBdNmBT6GTmK97cofaYNaGkOs9pVEl/8/P0Ne+gk/hHE0zwkDAw+k71COVb7dg0Jbgny3VmunuRGNIdQrHqhqN/e37Hx5bn23+QVERitZqMtzssiUwBKz3Lb4HgecYVQDoyTggOjW1Ihj+inT0ys9oXHXv8ETvdesBHtRy4q02TgDEbMXc35HoistXwFYjo0wKY9DW+bCnAO0vWsXtV/yZQqsDhP8ixRWmNKQx6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Thu, 26 Jan 2023 20:12:55 +0000 "Matthew Wilcox (Oracle)" wrote: > This is just a conversion to the folio API. While there are some nods > towards supporting multi-page folios in here, the blocks array is > still sized for one page's worth of blocks, and there are other > assumptions such as the blocks_per_page variable. > > ... > > @@ -588,7 +585,7 @@ static int __mpage_writepage(struct folio *folio, struct writeback_control *wbc, > if (bio == NULL) { > if (first_unmapped == blocks_per_page) { > if (!bdev_write_page(bdev, blocks[0] << (blkbits - 9), > - page, wbc)) > + &folio->page, wbc)) > goto out; > } > bio = bio_alloc(bdev, BIO_MAX_VECS, > hch removed this code in https://lkml.kernel.org/r/20230125133436.447864-2-hch@lst.de, so I'll drop this hunk.