From: Andrew Morton <akpm@linux-foundation.org>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: Christoph Hellwig <hch@infradead.org>,
linux-fsdevel@vger.kernel.org, linux-mm@kvack.org
Subject: Re: [PATCH 2/2] mpage: Convert __mpage_writepage() to use a folio more fully
Date: Thu, 26 Jan 2023 14:59:42 -0800 [thread overview]
Message-ID: <20230126145942.de051666a47ada8f56cb34a4@linux-foundation.org> (raw)
In-Reply-To: <20230126201255.1681189-3-willy@infradead.org>
On Thu, 26 Jan 2023 20:12:55 +0000 "Matthew Wilcox (Oracle)" <willy@infradead.org> wrote:
> This is just a conversion to the folio API. While there are some nods
> towards supporting multi-page folios in here, the blocks array is
> still sized for one page's worth of blocks, and there are other
> assumptions such as the blocks_per_page variable.
>
> ...
>
> @@ -588,7 +585,7 @@ static int __mpage_writepage(struct folio *folio, struct writeback_control *wbc,
> if (bio == NULL) {
> if (first_unmapped == blocks_per_page) {
> if (!bdev_write_page(bdev, blocks[0] << (blkbits - 9),
> - page, wbc))
> + &folio->page, wbc))
> goto out;
> }
> bio = bio_alloc(bdev, BIO_MAX_VECS,
>
hch removed this code in
https://lkml.kernel.org/r/20230125133436.447864-2-hch@lst.de, so I'll
drop this hunk.
next prev parent reply other threads:[~2023-01-26 22:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-26 20:12 [PATCH 0/2] Convert writepage_t to use a folio Matthew Wilcox (Oracle)
2023-01-26 20:12 ` [PATCH 1/2] fs: Convert writepage_t callback to pass " Matthew Wilcox (Oracle)
2023-01-28 17:13 ` kernel test robot
2023-01-29 21:33 ` Andrew Morton
2023-01-26 20:12 ` [PATCH 2/2] mpage: Convert __mpage_writepage() to use a folio more fully Matthew Wilcox (Oracle)
2023-01-26 22:59 ` Andrew Morton [this message]
2023-01-30 11:04 ` Alexander Egorenkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230126145942.de051666a47ada8f56cb34a4@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=hch@infradead.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox