From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F02DC05027 for ; Thu, 26 Jan 2023 13:58:23 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5EF438E0001; Thu, 26 Jan 2023 08:58:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5784B6B0072; Thu, 26 Jan 2023 08:58:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 418C18E0001; Thu, 26 Jan 2023 08:58:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 2F0EC6B0071 for ; Thu, 26 Jan 2023 08:58:22 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id E0FF1C048E for ; Thu, 26 Jan 2023 13:58:21 +0000 (UTC) X-FDA: 80397104802.25.3250AAB Received: from outbound-smtp63.blacknight.com (outbound-smtp63.blacknight.com [46.22.136.252]) by imf20.hostedemail.com (Postfix) with ESMTP id E2D421C000B for ; Thu, 26 Jan 2023 13:58:19 +0000 (UTC) Authentication-Results: imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.252 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674741500; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9UxfVGAW47gUnNRIt8puTeVBbdlvl5xsKTvxtmU4q/g=; b=NlNzVqJbQ9pj/ymecoOOaeAasCGbivOcv00FEOBeaSWlhmYkn9AvrLiZmU3sIL37gQt8or lnoibWPm5hoNi5VcIWcmzYvdcKTDO8DFgBZwKnySt72+5R0BVTrvUJ7IipSyEPQL+y3t7m KCJk50DtdrsQjIOHYZO0mAMRmE2ZkVI= ARC-Authentication-Results: i=1; imf20.hostedemail.com; dkim=none; spf=pass (imf20.hostedemail.com: domain of mgorman@techsingularity.net designates 46.22.136.252 as permitted sender) smtp.mailfrom=mgorman@techsingularity.net; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674741500; a=rsa-sha256; cv=none; b=vQs+yMddYjXBo9uD/p/iEm/9RhdwTgrjCtPxuI+8mdIakl2Jb7oJVkyxPu9nJwLLyIrUgS I6dKgrJLMdUe3aeGdKQ/2MWDiHmop1YR5dvX0wm8EgBQLNAl3vUqlhWz33b5j9e3Uru/fe 5afCpOKcUNM0Q0HCUnijeP6B40wfoXs= Received: from mail.blacknight.com (pemlinmail03.blacknight.ie [81.17.254.16]) by outbound-smtp63.blacknight.com (Postfix) with ESMTPS id 2084BFAC48 for ; Thu, 26 Jan 2023 13:58:18 +0000 (GMT) Received: (qmail 23565 invoked from network); 26 Jan 2023 13:58:17 -0000 Received: from unknown (HELO techsingularity.net) (mgorman@techsingularity.net@[84.203.198.246]) by 81.17.254.9 with ESMTPSA (AES256-SHA encrypted, authenticated); 26 Jan 2023 13:58:17 -0000 Date: Thu, 26 Jan 2023 13:58:15 +0000 From: Mel Gorman To: Suren Baghdasaryan Cc: akpm@linux-foundation.org, michel@lespinasse.org, jglisse@google.com, mhocko@suse.com, vbabka@suse.cz, hannes@cmpxchg.org, dave@stgolabs.net, willy@infradead.org, liam.howlett@oracle.com, peterz@infradead.org, ldufour@linux.ibm.com, paulmck@kernel.org, mingo@redhat.com, will@kernel.org, luto@kernel.org, songliubraving@fb.com, peterx@redhat.com, david@redhat.com, dhowells@redhat.com, hughd@google.com, bigeasy@linutronix.de, kent.overstreet@linux.dev, punit.agrawal@bytedance.com, lstoakes@gmail.com, peterjung1337@gmail.com, rientjes@google.com, axelrasmussen@google.com, joelaf@google.com, minchan@google.com, jannh@google.com, shakeelb@google.com, tatashin@google.com, edumazet@google.com, gthelen@google.com, gurua@google.com, arjunroy@google.com, soheil@google.com, hughlynch@google.com, leewalsh@google.com, posk@google.com, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linuxppc-dev@lists.ozlabs.org, x86@kernel.org, linux-kernel@vger.kernel.org, kernel-team@android.com Subject: Re: [PATCH v3 2/7] mm: introduce vma->vm_flags wrapper functions Message-ID: <20230126135815.7hjwrrv77y2en2ku@techsingularity.net> References: <20230125233554.153109-1-surenb@google.com> <20230125233554.153109-3-surenb@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-15 Content-Disposition: inline In-Reply-To: <20230125233554.153109-3-surenb@google.com> X-Rspam-User: X-Rspamd-Server: rspam03 X-Stat-Signature: w94jjdus1jzg6h5oqno8h4aq7qr55nd8 X-Rspamd-Queue-Id: E2D421C000B X-HE-Tag: 1674741499-127438 X-HE-Meta: U2FsdGVkX19SrZf2L8Ve4c/YIy7fg/uo0Krr8+wdiE0CHcD6i2Su7/1RjxKiL3s4bjzhCPwqqRWTQ8iL6qZKG/R8pWH5T0HWayPuRPdy/VWcxRfZDumY12wCx2ZTi3HgyvnjMCrarxmg7snDiAPkBmL5vjqqnJnYe+vB2cZfPDui+7yCgh0BsKKwilVbBnDLTdJ1hYCuaa9y4XMC5qT+zxduSOWXfDTtfvrpi9y3MgtLbnHzkNhbSpfjlG1OZ8w/mJyHaImtwTqkx3fbusvMI25ikXTduhlsNWyv9LltLkB2ME+9eVtwGxtEghjrJEPqPkDvN2labmXDd7ObOQOFVfVn3Qa1lq/nOUMvzPSIqhmsuH83UXdGOcMHFhRcN70cXKxysBwNbflw3TSUvfnxNmYOE7cYrVitQm3N4iEYHgY5vhoD//m3MD+g7cH7nrH+xWxyikp2B7awJvaBDYYQDmtFGP5YTpmzc03r9K4DDBCmLQOwF5SENj/7nNFHv8DdX9rbo293aT63rW11QKweZfWogLfmVoQ/PP2FskRhyo7b89edCUpIOd3HdYLMqKLcosx+AxJZ0HUPUaFmbAcra8rCNjhr92cKzcPJvxPys60m/vhd2GEr2WbIVTaNiy/m/vjzruqVm0APSq5yhXHBiSlrTQNI0ilSEzZZcwhfbbNzS2aKTCT1FL4B+FDFUnscSk8/DxAO0PNkCDZAWp7nzVbL9G/lEL5tr/XeDA2BBt/PAMM2Dw9hCB5s6S3i0lyWv1cj2EsAORaLQ3pzciRzgkhdlyIM6iKos87I/nikF2NSpxXMMbU6J2tN0GMfYJsEiTdQl+SbpE/4AjbxQHonFXVz2Y1GwwmfZR2w34X1M0EzCoPerX4W7E2WjOiJyu55z2Mq4qV9gNa3nWt9OmIR7y9EyeYnDfXdwpfS0+7ROHQNGlsRbF70N9MZxTDE+pO4zf+YgvLFESzKw+v4l4P HeMSlYbZ Ynrbrqt+MMQ6oWrrzpTv3NpyKM1vR9CVMZJqGso/+Pb6MiCRQ3ZoqfzfhYmpihVKGse2RS31BMeKU+VULe+5ZemkleKq+w0EYDqu2/2d0QDGI6KE9jRqP6jdGPifCxoSIb6x7rietpsXvMOyVUX3Iq7fndM0UtEN97h549IG2zTOs4o8UTnsui/YkottWhUip65qSVaK4oz8aSBccw+J5lYagkxyw47YpwmLPbrg6n3tXwYQMXf7XKNQLzOoZNVPmZwdg+eBYBq3+AFBsjCsMvRqKsJOQxX6oCttssty+cJHKHhVcDKHADn81qj+XTvlwdAN3 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 03:35:49PM -0800, Suren Baghdasaryan wrote: > vm_flags are among VMA attributes which affect decisions like VMA merging > and splitting. Therefore all vm_flags modifications are performed after > taking exclusive mmap_lock to prevent vm_flags updates racing with such > operations. Introduce modifier functions for vm_flags to be used whenever > flags are updated. This way we can better check and control correct > locking behavior during these updates. > > Signed-off-by: Suren Baghdasaryan With or without the suggested rename; Acked-by: Mel Gorman -- Mel Gorman SUSE Labs