From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB269C61D9D for ; Thu, 26 Jan 2023 05:30:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 154646B0072; Thu, 26 Jan 2023 00:30:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 104316B0073; Thu, 26 Jan 2023 00:30:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F36D66B0075; Thu, 26 Jan 2023 00:30:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id E25586B0072 for ; Thu, 26 Jan 2023 00:30:31 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 92D5D120F2F for ; Thu, 26 Jan 2023 05:30:31 +0000 (UTC) X-FDA: 80395825062.08.291261C Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP id DF07410000F for ; Thu, 26 Jan 2023 05:30:29 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674711030; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hxwmiuJn66GE9w05Qc4Lp8zFYSduUPNfnpoF9Ynz5Vc=; b=KO/Ur9t232rCMVNVAVPgFfYkomM+gHQEPFjCNxRVpIlVKKJQcCHia6o14ZhYIUBX3C/EpL N3jh9ohhg6JMMZHj9aAz6GWfBOwp9rNoRvsfyKTIV27TCqgeMKbRnmsnkcgk5vXXuVD4Gq yOqXvYH4aVvlSYXjT4skHHdOzKVC5aE= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=none (imf14.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674711030; a=rsa-sha256; cv=none; b=POAvaYGW+nV4cb6JGDzzKw9wGLI0TkMn8X8KPKzcoYj176LY8qNvJ8Vrs2C4RsGhuwUdFJ QCgY2+Gemk5L997ALS8KF+RlEkZI0hyjdQ0q9Kw1Yo3da9vIG6GpLH+FRucoTwHbWa9k0z BSHzcvcVdnlikSkZmewGXG2h1NH7/Yw= Received: by verein.lst.de (Postfix, from userid 2407) id 6D8C568D0A; Thu, 26 Jan 2023 06:30:26 +0100 (CET) Date: Thu, 26 Jan 2023 06:30:25 +0100 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Jens Axboe , Minchan Kim , Sergey Senozhatsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , linux-block@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 2/7] mm: remove the swap_readpage return value Message-ID: <20230126053025.GB28355@lst.de> References: <20230125133436.447864-1-hch@lst.de> <20230125133436.447864-3-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: DF07410000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: sx4oked83h7pga4g8hqrxqxtbrbkw7ae X-HE-Tag: 1674711029-954363 X-HE-Meta: U2FsdGVkX1/HUsRAd0q3pstwmaicCLCWDUbv8LujDz4c3YirY6HHlKpiABYuc92HoWrpQX8OG9Gp3muLK6nTs3+uM1f/s7f81Ho0+h9kZzv0AEKVmBmk4TAq+HC3q4qHSDKMPcpaUp7UP8zubhHF0REhHXzd2Z/BI522PXSS4+cE6wXDZ2YT+jJK0HhUERezlKj033EHBZzHzE5vPtahjLyrg/WDXM0KwvzeclIbMWS1XlnB1rSwfbL3f/veSs+zGNBmwZJTpDzFtoSWnFgdYo0CGye+YphJbINPkHbZDgsDglqoSb704cBPGzus5qnK3GgODtX/R11pYein2GCZFAkRc0GvPGBCUNHseQgTD6WDiFsKSkY+AqFGAsnA1f3ohGkuoeNzGsS3EpiwNeCPInsMKjHezgoNVIAHvYimo6sAD/UU2IYGWxE81ZXAGOx6hr/O5JD9QK7AtZzF/e6SvwNxBFoCZ70aHwSAnIEKutyIxTBMLGdLwVB07kVF4jXhURGu1sVJnbltRRVJEREXvwzePX0KcGZDhiyccKt5rs+L1QQvJFRqlJogGGedVlx4YZzIB7QOOEsO58zkUoxMNWpJgudgit+78ZOAE1w034CyAX8GBdQ1OYgb2zkNyCU05OTNzsWQH5vqYf8pXllndvOmd4WPRTwmoHHqCwwEw2voTCWnBktlh98KvWEKVGeEUJTxZfz9opAcHqBHMyLieZxDHpj3RIuTwMU3PcnDAyJvh1RMkRG6J3mlHfnMqzFh+VZnBpC+i5qSVy73aS6mVG46s1mV9+z62PIZKB4xRRxD+pt2YAKKYF73dIaFIOWDoj2qCPmV58XP5g10bL7M/X1ClTnamclJ2NUm7C9eTttTSKmUZIGYtlBAJFJeAbBSHut5wJ63aR6KDYNMEu2hzHvdeihNofRF0c0H6EwIYtTExur0fYllVk6WWrmc3CTSH4p+hQSStbs5bl226zA c5iQ0Bt9 59B9MuzvmKl/VJNekBCUrWeBrkFMhzdSKxmVaaZCyWlE/84BbnJ/8suj0reSWfa0lcjcpiM7J6/FeO3j67Ldwu6up3jGjnBcXUbP71Kde4kB7hX8c2wbEDPU8+w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 08:58:31AM -0700, Keith Busch wrote: > On Wed, Jan 25, 2023 at 02:34:31PM +0100, Christoph Hellwig wrote: > > -static inline int swap_readpage(struct page *page, bool do_poll, > > - struct swap_iocb **plug) > > +static inline void swap_readpage(struct page *page, bool do_poll, > > + struct swap_iocb **plug) > > { > > return 0; > > } > > Need to remove the 'return 0'. Yes.