From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8CFA7C05027 for ; Thu, 26 Jan 2023 05:30:29 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C9E1C6B0071; Thu, 26 Jan 2023 00:30:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C4F086B0072; Thu, 26 Jan 2023 00:30:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B3C5B6B0073; Thu, 26 Jan 2023 00:30:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id A8EB56B0071 for ; Thu, 26 Jan 2023 00:30:28 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id E2C86140F57 for ; Thu, 26 Jan 2023 05:30:26 +0000 (UTC) X-FDA: 80395824852.10.2621C8A Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf26.hostedemail.com (Postfix) with ESMTP id 2EF8614000F for ; Thu, 26 Jan 2023 05:30:23 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=none; dmarc=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1674711024; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=SdpWutz0mxNx9NbrOJbwQOTKo7gmBU98FeM2Totk6K8=; b=Jn+fMNOXvZNFtzkLT9Mhy/ZSR2dDzDl2YMOZgO4xahDDj21kXU3+S6/x9h4bzC/tIHOQZN 7UgL566yYwMOMp/jHOTFOeW22sQaDDDdUhTVMmybeFsp2MxnZlA63Kvk4LX4ED5jxUvdMP IkBIPPoLB0mO25uQbvsT8HUL2z9JLd8= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=none; dmarc=none; spf=none (imf26.hostedemail.com: domain of hch@lst.de has no SPF policy when checking 213.95.11.211) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1674711024; a=rsa-sha256; cv=none; b=EInk3sMBCI2OdKycF9mjTUEhJvXtT6NTXChU8Vs7I/uoKGR0YEn1Ar8ovPNvsVVzlnl4bf gw1ZIz+kzzmNkJ+ziHFULW1C7fu58kb8KQsY6q16X16EeMGUJH0RFdkVjpHx3opxXF4ut9 Z+md/uy3CtAj2rdfS9GmNxRcMrRScJs= Received: by verein.lst.de (Postfix, from userid 2407) id 7936068D09; Thu, 26 Jan 2023 06:30:18 +0100 (CET) Date: Thu, 26 Jan 2023 06:30:17 +0100 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Jens Axboe , Minchan Kim , Sergey Senozhatsky , Dan Williams , Vishal Verma , Dave Jiang , Ira Weiny , Andrew Morton , linux-block@vger.kernel.org, nvdimm@lists.linux.dev, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH 7/7] block: remove ->rw_page Message-ID: <20230126053017.GA28355@lst.de> References: <20230125133436.447864-1-hch@lst.de> <20230125133436.447864-8-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Queue-Id: 2EF8614000F X-Rspamd-Server: rspam09 X-Rspam-User: X-Stat-Signature: kz68y4apxe87jtbxeiisnckzbxxc6gur X-HE-Tag: 1674711023-780489 X-HE-Meta: U2FsdGVkX1/d447QSCpi2/YLNksZpIofCEtzqmWk0KSG3PxCHFqaLDqG7BWN4Nv99/NJx3O6AolFQlhXe6B7mC0g7Fb2byp+bp1mKLKi5HQcqNFw+NLZJ7Pn+/q+YxOBHuu8Y/Di26RVd+sbilwygZ7AjKTOutABdho/0y5Yt/FNH664a41oK40b021/9I28e7Jhl8sOZuCDNIi+ezIbK8nkl5HRFPj39kdLJslfAI4Y5kDREwTdriqneWJm+DHXxP9hEBKqXNUyDaOZG6nBo3w+Uft5UHjocldO4hURRf2tMTCWWgYtmVRSXU5saqFfMOasbAiY0scKTd3rbfnjhmTckrB6QH9E3vG9I5H58zG1aYRXVAowG1eZmLVRBH/Nk9j6v3wmRoLaT10cvLQBwTZlTbIqvDJBQAMyh+xonEyC6MAYQCQp9jAM50OhWN7AVpO7OLr03yVdUnB918oxARAcwlCPy0Yoz+Xw9qDs++56IzCAhmPv/cvr3UCAcCfUdoyPEG/heZY2Ce6J2b5RSZA4pAWP+eKxqeJZE8j9+22nVtLJ9wWE2KXaZmEgK8rdKV6NF4vrVEOh0UnsZ9QMfEgID9QvUEF+FarVjpt4WTAod5YVHnCOHfPLH+f57qPeK+HFld613kiYAwwOML+S/Ap+xnr+seJeBI06TwS+25JwP8bZefU5XP98l03X0jSlY1IiMP0uwPSGW/kCBbZMrynLv7P5jaLHcwh8mHdoDCilM9Wz9PudzQlO24cZpq5R+IYaBXEqRKn91YfgiLUCloUQeBiOkNsk7mTsZr5CUb8Ul0Wt+GerxhrAL1L7SmBhKalAe5yhpdprmf/O4xCdAG1JdDDKIw4MO5w9jnrTvy/QxN0dE+K2ba7iI6Af17rNXWgiCdhSWkdCKgTRgxmeKqZe3/DbKDvyC/L8yDWWOzWd+MMdi3X2eNUJ8gwiO5cU4nK+VzuL6kC4X+fbQpU gIOaUl2v 0AN5Bz3rXE8zThuzazo1YdsBtsJNIzU07ezwZxM8YuD/nWHL/aXdmPXx9c0wV9NfiqUnibfHPKia/EvEvBjMZFfQdwDzCF31OVy2R2Esv/10/dvUU5VIlFLVhfQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000064, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: On Wed, Jan 25, 2023 at 09:28:33AM -0700, Keith Busch wrote: > On Wed, Jan 25, 2023 at 02:34:36PM +0100, Christoph Hellwig wrote: > > @@ -363,8 +384,10 @@ void __swap_writepage(struct page *page, struct writeback_control *wbc) > > */ > > if (data_race(sis->flags & SWP_FS_OPS)) > > swap_writepage_fs(page, wbc); > > + else if (sis->flags & SWP_SYNCHRONOUS_IO) > > + swap_writepage_bdev_sync(page, wbc, sis); > > For an additional cleanup, it looks okay to remove the SWP_SYNCHRONOUS_IO flag > entirely and just check bdev_synchronous(sis->bdev)) directly instead. The swap code relatively consistently maps bdev flags to SWP_* flags, including SWP_STABLE_WRITES, SWAP_FLAG_DISCARD and the somewhat misnamed SWP_SOLIDSTATE. So if we want to change that it's probably a separate series.